Commit Graph

417 Commits

Author SHA1 Message Date
Caolán McNamara
6c9dfa8ab7 cppcheck: noExplicitConstructor
Change-Id: If947733a205e8ece1845079be95cbc2d6cbd5029
2015-05-26 09:57:21 +01:00
Stephan Bergmann
6ff2d84ade Various #include <sal/log.hxx> fixups
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx>
(and don't make use of it themselves), but many other files happen to depend on
it.  Cleaned up some, but something like

  grep -FwL sal/log.hxx $(git grep -Elw \
    'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx)

shows lots more files that potentially need fixing before the include can be
removed from rtl/string.hxx and rtl/ustring.hxx.

Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-22 09:57:47 +02:00
Noel Grandin
71b809959b remove unnecessary use of void in function declarations
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
Stephan Bergmann
2fc4a8c811 Add support for cppu::UnoType<void>
Change-Id: I88259ffaffc73979c240721d2db166c79d3085f1
2015-04-01 12:48:44 +02:00
Stephan Bergmann
15bdb0ae87 Replace remaining getCppuType et al with cppu::UnoType
Change-Id: I0ecb96d6f26c827640f3329c81884001f860090d
2015-04-01 08:42:56 +02:00
Caolán McNamara
d22519f62b V801: Decreased performance
Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
2015-03-09 22:04:31 +00:00
Caolán McNamara
fd1372ba8b boost::unordered_map->std::unordered_map
you can get debug stl this way

Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2015-01-02 16:14:36 +00:00
Stephan Bergmann
9c9276c9e1 ucbhelper: Use appropriate OUString functions on string constants
Change-Id: Id5832f8ca20f5ff3179a25bc3c28be7b9fde5bfb
2014-12-18 14:12:36 +01:00
Mihai Varga
4998e6a361 Authentication fallback request for the OneDrive connection
To fix build, also squashed in:

Author: Mihai Varga <mihai.mv13@gmail.com>
Date:   Fri Aug 1 12:50:23 2014 +0300

    OneDrive auth fallback dialog interaction continuation

Change-Id: Id37f502217da3fde55ae93a6e1c01409509d657c
2014-12-15 11:23:26 +01:00
Michael Stahl
15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18 18:51:49 +01:00
Michael Stahl
6a0fe37dec sal: clean up public headers with include-what-you-use
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade…
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:04:11 +00:00
Noel Grandin
fbf3aa391b spelling: instanciated -> instantiated
Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
2014-10-08 11:02:55 +02:00
Noel Grandin
5139fad429 loplugin: cstylecast
Change-Id: I84873c9f84651dc8a1337f37c63020b461314e1b
2014-09-22 12:24:23 +02:00
Daniel Sikeler
32d6415617 fdo#83512 Make use of OUStringHash and OStringHash
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-18 13:12:48 +02:00
Stephan Bergmann
6ee5be0e1d Improve exception msg
Change-Id: I4edbecd0ca3006c24fd5920a9ef9ad1fdc6016fb
2014-09-17 11:48:56 +02:00
Norbert Thiebaud
0db950ded8 bug wrong order of test cause out of bound access.
Change-Id: If9c497473bc163677175b0fda1f3a8975cceb3dd
2014-09-12 01:45:29 +02:00
Stephan Bergmann
b807a02850 InteractionSupplyName is a detail of SimpleNameClashResolveRequest
Change-Id: Iecc77b1c4749bd14ce79f1a7f3e98f45fa3abbba
2014-07-02 14:56:53 +02:00
Noel Grandin
0e507ae031 various: remove SAL_THROW macro
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-05 08:17:52 +02:00
Julien Nabet
ac76cc7e60 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-23 22:11:52 +02:00
Julien Nabet
dd33f91581 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part14
Change-Id: Ibccaa2138426c22cd63d273a1b6cdc927ebe80dc
2014-05-17 00:24:22 +02:00
Julien Nabet
036a660a86 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part11
Change-Id: Ibe0a1006aba2b6cbd87c0bd6ca3acbf9ba7b0fbe
2014-05-13 23:20:26 +02:00
Julien Nabet
bd59628620 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part10
Change-Id: I67acda35fa127547dcea0cd18c9dc16db7c00294
2014-05-11 10:16:42 +02:00
Tor Lillqvist
728ec86062 Typo: s/cant/can't/
Change-Id: Id76b4ea569246c4b96da48dbc8d5a557367e0cca
2014-04-18 00:30:35 +03:00
Caolán McNamara
abd5786847 coverity#1202901 Uncaught exception
and probably gadzillions of other uncaught exception warnings

this exception can't actually be thrown because all possible InsertOperation
conditions are already handled.

Change-Id: I176c5e253e8b1092a060fc066c2e03dae3cea343
2014-04-17 21:13:52 +01:00
Stephan Bergmann
fa0ffdbeb5 cppu::OMultiTypeInterfaceContainerHelperVar hashImpl param is unused
...since f059134fab "INTEGRATION: CWS
cppuhelpshrink: #i72766# save memory in cppuhelper, using a vector instead of a
hash_map" (but a dummy "void" default is left in place for backwards
compatibility).

Change-Id: I3bb0af8158f34737d41c344464f3cf944e2891ed
2014-04-15 07:46:43 +02:00
Michael Stahl
a7d3f57da5 warning C4101: 'e': unreferenced local variable
Change-Id: I3fb8a4f2854fb034d6b184ee46c04e8a8d03ca6a
2014-04-10 14:13:19 +02:00
Caolán McNamara
9e8d4c439f coverity#707355 Uncaught exception, help coverity out here
hopefully loads of other ones too

Change-Id: I8445602adc76205448926efe23c9770cef0eb5dc
2014-04-04 09:35:19 +01:00
Noel Grandin
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
Stephan Bergmann
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
Norbert Thiebaud
514a6de482 kill ucbhelper XTYPEPROVIDER_DECL macro
Change-Id: I1daf6661dd7b5be396bec980da84feaab6e6b80f
2014-03-20 19:33:47 -05:00
Stephan Bergmann
c7d2ed40de ucbhelper: simplify deprecated XTypeProvider.getImplementationId
Change-Id: I7797ba7fdc47a5f8d2453e839d8644bf125652bd
2014-03-10 17:40:00 +01:00
Caolán McNamara
ec4498a393 coverity#1078944 Uncaught exception
a false positive but easier to fix it by helping coverity out
for any other cases it triggers

Change-Id: I7c61298a95fa427d279599110b7aab263d039c5d
2014-03-09 21:20:13 +00:00
Norbert Thiebaud
b4ab8df0a4 de-macroize ucbhelper commandenvironment
Change-Id: I39c7ca30d483dab3eae0f39be15ef9586aef7851
2014-03-08 15:27:35 -06:00
Norbert Thiebaud
a14e1cb35b de-macroize ucbhelper activedatastreamer
Change-Id: I55bbce1f8e3c0dcd92d0e2af03d7be5c7ac910c0
2014-03-08 15:27:34 -06:00
Norbert Thiebaud
a6e19ea7a8 use WeakImplHelper for ActivaDataSink
Change-Id: Ife32157ff876a0860b3920cadc24b7888200796b
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-03-06 10:04:33 +01:00
Norbert Thiebaud
cf1878f5dc kill XINTERFACE_IMPL_3
Change-Id: I72448b67ae52e89c206f9c313b3d351ae2a56dc3
2014-03-05 09:44:20 -06:00
Norbert Thiebaud
8b40ddd9f0 kill XINTERFACE_IMPL_4
Change-Id: I88e2e62b82f40cfa3e892023d381f7611e093fd6
2014-03-05 09:44:19 -06:00
Norbert Thiebaud
a5aad2ac58 kill XINTERFACE_IMPL_9
Change-Id: I651599cf3ec82a31f3260985907b5b2d56665da3
2014-03-05 09:44:19 -06:00
Norbert Thiebaud
e090a0f580 kill XINTERFACE_IMPL_2
Change-Id: Ic735b7d6ddfaacab9af7405e4dacc62f818bed8c
2014-03-05 09:44:18 -06:00
Norbert Thiebaud
66f2c35fac de-macroize XINTERFACE_DECL
Change-Id: Iaa1cf999189f6b62547c208eadc38150400ca0fe
Reviewed-on: https://gerrit.libreoffice.org/8454
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-05 09:29:24 -06:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Alexander Wilms
c99a199488 Remove visual noise from ucbhelper
Change-Id: Id9396eca64069f2f0ba636ac9efa090f121afdd3
Reviewed-on: https://gerrit.libreoffice.org/8330
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 07:23:27 -06:00
Stephan Bergmann
faced6b5f7 ucbhelper: sal_Bool -> bool
Change-Id: Iee327c3dd75bebb35d99de01eaa7103956e08974
2014-02-17 17:55:18 +01:00
Alexandre Vicenzi
6ad41af76f fdo#54938 Convert dtrans, remoteb., reportd., ucbhelper to cppu::supportsSer..
Change-Id: I42cf7dc139b79b715f3c330f9bca7d333de8bafc
Reviewed-on: https://gerrit.libreoffice.org/7762
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-02-04 10:16:33 +00:00
Stephan Bergmann
612dac063a bool improvements
Change-Id: I0dc09b7a6ee2849bd0c2ffc31be45f81cd2c15ee
2014-01-29 11:08:32 +01:00
Stephan Bergmann
2c907d2107 bool improvements
Change-Id: Ia9f1b1d1a0fea7dbda8e2a322aaf86899bfd7fd3
2014-01-28 20:26:20 +01:00
Tor Lillqvist
17f1b0f551 Using pre-cached type_infos provided by the typeid operator seems to work now
Apparently there was no problem in this after all. The reason it
seemed not to work earlier was because of the unwinding failure due to
the missing .cfi_startproc and .cfi_endproc thingies in helper.s

The hack in ucbhelper is now not needed after all.

Change-Id: If9fec5c502d4c9d0c44709ad9c2729f812e882e2
2013-12-27 14:02:44 +02:00
Tor Lillqvist
55c6dade04 Hacky workaround for non-working C++/UNO bridge for arm64 iOS
I haven't managed to get the C++/UNO bridge to work for 64-bit iOS
code yet. I think I understand the calling convention and the
parameter marshalling etc might even be correct now. But something
goes wrong in the dynamic creation of type_infos and throwing of
exceptions. 64-bit iOS code uses a different unwinding mechanism than
32-bit iOS code, I think, which could be related.

Quite possibly there is also an unintended compiler feature (or dare I
say bug?) in Apple's Clang for arm64 that affects this: The typeinfos
are generated as private_extern symbols in arm64 code (instead of as
normal extern in armv7 code), thus the dlsym() thing to look up
typeinfos doesn't work.

Note that as we don't support any Basic, Java or Python on iOS anyway,
the C++/UNO bridge is not used for much. Actually, the only use of the
bridge at least in the TiledLibreOffice test app seems to be to throw
exceptions. Fun, huh? As the actual types of exceptions thrown seems
to be a quite small set, just hack it and throw the appropriate
exception directly... The only places where exceptions are thrown
through the bridge that is used in the test app seems to be the two
cancelCommandExecution() functions in ucbhelper.

(It would be nice to change the ucbhelper API to not use exceptions
for non-exceptional conditions, but that's another thing...)

Change-Id: Ifd1861ccbba23d3b138e82400f2b7d80baf0215a
2013-12-24 03:34:47 +02:00
Andras Timar
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00