Commit Graph

169 Commits

Author SHA1 Message Date
Andrea Gelmini
ca9de688c2 Fix typos
Change-Id: I549635318f46718042e50c8f89ce3c620cade990
Reviewed-on: https://gerrit.libreoffice.org/16281
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16 11:10:51 +00:00
Julien Nabet
16f1477a2d Remove include stdio (part7)
Change-Id: I7058ac53f4bbf96eff9a36a03279ab0753cc42ba
Reviewed-on: https://gerrit.libreoffice.org/16135
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-07 15:33:38 +00:00
Caolán McNamara
dcee23b7f8 cppcheck: noExplicitConstructor
Change-Id: Idcf5460ec59cfb6f13055652c094d460c15da5ed
2015-05-20 20:40:54 +01:00
Caolán McNamara
869e477484 cppcheck: noExplicitConstructor
Change-Id: Iea5bb0504518b380c3fe7c238d376dc26be8a7ef
2015-05-04 20:13:52 +01:00
Stephan Bergmann
1a31dd5ec4 Clean up odd sal::static_int_cast<sal_Bool> uses
Change-Id: Idbd1cdb06315b96dc9f45e34108a1af45229ed2f
Reviewed-on: https://gerrit.libreoffice.org/15484
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-04-22 20:50:54 +00:00
Caolán McNamara
68495ab364 cppcheck: add some explicits
Change-Id: I4e1fd50f1268f0820fae2bb41c69155ef5c28464
2015-03-23 09:38:04 +00:00
Caolán McNamara
556373c41f V668 no sense in testing the result of new against null
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
2015-03-11 09:58:36 +00:00
Caolán McNamara
5a308b1239 V801: Decreased performance
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
2015-03-09 12:41:09 +00:00
Caolán McNamara
309574394b callcatcher: large newly detected unused methods post de-virtualization
i.e lots now able to be detected after...

commit b44cbb26ef
Author: Noel Grandin <noel@peralex.com>
Date:   Tue Jan 20 12:38:10 2015 +0200

    new loplugin: change virtual methods to non-virtual

    Where we can prove that the virtual method is never overriden.

    In the case of pure-virtual methods, we remove the method entirely.
    Sometimes this leads to entire methods and fields being
    eliminated.

Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-29 23:42:26 +00:00
Michael Weghorn
bfe79b50bc fdo#39440 reduce scope of local variables
This addresses some cppcheck warnings.

Change-Id: If7ad3584b3124ed0b337836071af1a5bd0451d85
Reviewed-on: https://gerrit.libreoffice.org/13972
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-19 08:39:32 +00:00
Stephan Bergmann
147ff66242 Typo "mehtod" -> "method"
Change-Id: I49f3f59c76bd4dd078f7014b6a0450241214db7f
2014-12-08 11:11:43 +01:00
Tor Lillqvist
71c58fce69 Bin noise comments
Change-Id: I084040ff90ee30aa83ac5d3ad11365768272ec65
2014-12-04 16:59:19 +02:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade…
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:04:11 +00:00
Noel Grandin
fc04f76336 fdo#82577: Handle Time
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01 07:34:23 +00:00
Tor Lillqvist
595e446aff Get rid of xmlsec_trace() and use SAL_INFO("xmlsecurity.xmlsec")
Change-Id: I3e1db89de2019285ce313f9bae1375a5b82f6383
2014-08-12 17:02:15 +03:00
Thomas Arnhold
b312a38797 update_pch: add a bunch of pch files
desktop:    1m51s ->   54s
 framework:  1m55s -> 1m04s
 package:      32s ->   16s
 sdext:      1m31s ->   47s
 svgio:        32s ->   15s
 uui:          49s ->   20s
 vbahelper:  1m44s ->   27s
 xmlscript:    15s ->   10s
 xmlsecurity:  45s ->   23s

Change-Id: Ia437969c091bf877983ababc5ea2d044bbc0bee0
2014-06-04 21:18:37 +02:00
Thomas Arnhold
4671e7b8a4 fix-includes.pl: xmlsecurity
Change-Id: Ie3dd8674e1fa927d15eeb6a64a0cad24b8825262
2014-05-19 20:04:27 +02:00
Thomas Arnhold
55c70634b8 fixincludeguards.sh: xmlsecurity 2014-04-19 11:10:08 +02:00
Marcos Paulo de Souza
4d6560f506 fdo#54938: Convert some places to use cppu::supportsService
The last cases are non obvious, so it's pratically done

Change-Id: Icae1da8e238f516eaed0f7fbdf96fff778eac547
Reviewed-on: https://gerrit.libreoffice.org/8445
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-03-04 07:30:02 -06:00
Noel Grandin
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
Noel Grandin
0121f632ef remove unnecessary use of OUString constructor in XMLSECURITY module
Change-Id: I95b0eda83c60456f3db267183030fe5f6cd70bc4
2013-11-07 11:28:38 +02:00
Andras Timar
6ea6a422fb s/wiki.services.openoffice.org/wiki.openoffice.org/g
Change-Id: I059fbee385a109069c70f3869021c8e2ee48fee1
2013-09-07 14:21:22 +02:00
Tor Lillqvist
9499df9f8c Ifdef out code which had been accidentally un-commented-out
The code snippet had been commented out since its introduction in
2004. In 1452e56597 it was accidentally
un-commented-out, but it causes compilation errors. So ifdef it out
instead, with a comment. Note that I have no idea what the code does
and whether it actually is useful to keep for future reference or not.

Change-Id: Ie60ca065b2c65f86a7b382e246c1b650424daa1d
2013-08-12 09:28:57 +03:00
Jelle van der Waa
1452e56597 fdo#62475 removed pointless comments
Change-Id: I02b264a9661bcefaea96d6c5743352914154427d
Reviewed-on: https://gerrit.libreoffice.org/5345
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-08-11 19:37:59 +00:00
Noel Grandin
670e2329df fdo#46808, Convert xml::crypto services to new style
Also remove the unnecessary XInitialization implementations.

Change-Id: I81f32b2cdcf69b84fe4b15382f9294073a7f2f20
2013-06-10 10:20:44 +02:00
Jian Fang Zhang
3d8a7a435c Resolves: #i120675# the certificate store handles need to be closed
after closing the document

Found by: zhangjf
Patch by: zhangjf
(cherry picked from commit 33d9584bb6d285de1d935bf23adbb2c7666656f4)

Change-Id: I131a17276f33059eb944fc34272c50f838b6973f
2013-05-16 16:26:34 +01:00
Lionel Elie Mamane
9830fd36db date/time IDL datatypes incompatible change
- nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-18 21:34:46 +02:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Stephan Bergmann
ec52e5e5a2 Consolidate XMLSEC_NO_SIZE_T setting in xmlsecurity/xmlsec-wrapper.h
...so all xmlsec/*.h includes are bundled there now (except, for pragmatic
reasons, the xmlsec/mscrypto/*.h ones that unconditionally include windows.h and
only work on Windows).

Change-Id: I33e642f4f6a2e40edd6950af7f209c8b76c6e5fe
2013-03-25 08:52:55 +01:00
Jean-Noël Rouvignac
875c997c7d fdo#39446 - Bloat Removal. Removing uncallable code with callcatcher
Removed several unused methods.

Could not remove ScVbaFormat<ooo::vba::excel::XStyle>::getAddIndent() and ScVbaFormat<ooo::vba::excel::XStyle>::setAddIndent(com::sun::uno::Any const&) because it breaks compilation (they are implementing pure virtual methods).
Should Test::test1Table1Page() really be removed? (test class)

Conflicts:
        unusedcode.easy

Change-Id: I98a761f66f28e3a82661c10a5fa1dc7e109fff2f
2013-02-27 15:40:16 +01:00
Thomas Arnhold
f1a96446fa Remove duplicate OID
This ID is refers to digestedData and hashedData.

http://msdn.microsoft.com/en-us/library/windows/desktop/aa381133(v=vs.85).aspx

Change-Id: I2b9585332e27fad860aee458ef3183a9772e9c3f
Reviewed-on: https://gerrit.libreoffice.org/2403
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-02-26 09:10:27 +00:00
Valek Filippov
3648c3226d Add OIDs for Russian crypto algorithms.
Change-Id: Id1d6a623863d7643401dce912991e61de16695f2
2013-02-24 13:56:37 +01:00
Jean-Noël Rouvignac
97eb8a6e0e Removed several useless macros: A2OU, A2S, C2U, C2S, OUSTR, OUSTRING
Change-Id: Ie859cb2dfdc7103c379fce56be88eef8fe390afd
Reviewed-on: https://gerrit.libreoffice.org/1924
Tested-by: Luboš Luňák <l.lunak@suse.cz>
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-30 12:54:40 +00:00
Marcos Paulo de Souza
d540c322cc Remove more useless code inside "#if 0" blocks
Change-Id: Ifb9f9d2211608b848a5de66e1d19c4815a755907
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/840
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-10-08 21:27:01 +00:00
Caolán McNamara
350b031df0 callcatcher: remove some of the slightly trickier unused methods
Change-Id: Ief164c980f3a92316e1f47cb50bdf243155b6dd9
2012-08-20 12:12:21 +01:00
Arnaud Versini
9b2e6d4536 Replace usage of rtl/memory.h in xmlsecurity their equivalent from string.h
Change-Id: Id4a088864ee28163160d6ac408592952fe6c797d
2012-08-04 17:46:59 +02:00
Michael Meeks
6eeb0942c3 re-base on ALv2 code. Includes:
retain presence of MPL licensed nssrenam.h symbol renamer.
2012-07-17 11:51:17 +01:00
Thomas Arnhold
8e1bffe7ff Remove include guards
Change-Id: Ib4ba76d0083e5bd75cc589a55318089c004f591f
2012-06-29 15:59:53 +02:00
Michael Meeks
ec5fa0164b replace all but one .hdl include with equivalent .hpp includes.
Change-Id: I15e94f112144549692d0c2babeb48c77adcb93a9
2012-06-21 19:28:47 +01:00
Michael Meeks
b9042fad7c re-base on ALv2 code.
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00
Takeshi Abe
d95d58af08 nuke unused namespace
Change-Id: Ic00cdfce4172af0a2f0aa1aa33ef5e386d407976
2012-06-01 01:04:50 +09:00
Norbert Thiebaud
601500f8a8 targeted string re-work
Change-Id: I6ce76c22118586b213161a0e307a53b22b318004
2012-05-29 19:30:23 -05:00
Szabolcs Dezsi
743f22045c Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator
Pattern used:

find . -name "*.cxx" -exec sed -i 's/\( *\)\(else if\|if\) *( *\([^!()|&]*\)\.equalsAsciiL( *RTL_CONSTASCII_STRINGPARAM *( *\([^)]*\)) *) *)$/\1\2 ( \3 == \4 )/' \{\} \;
2012-04-06 15:07:41 +02:00
Szabolcs Dezsi
f770c5d6bc Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator
Pattern used:

find . -name "*.cxx" -exec sed -i 's/\( *\)return \([^()]*\)\.equalsAsciiL( *RTL_CONSTASCII_STRINGPARAM *( *\([^)]*\) ) *);/\1return \2 == \3;/' \{\} \;
2012-04-06 12:48:32 +02:00
Takeshi Abe
643a582793 removed duplicate #includes
in vbahelper / writerfilter / writerperfect / xmlhelp / xmloff / xmlscript / xmlsecurity
2012-04-04 01:39:08 +09:00
Takeshi Abe
e7e0455b02 Prefer equalsAsciiL(RTL_CONSTASCII_STRINGPARAM("...")) to equalsAscii("...") 2012-02-10 01:59:26 +09:00
Caolán McNamara
5833c182ed callcatcher: update list 2012-02-01 11:13:44 +00:00
Norbert Thiebaud
b33971cb12 remove include of pch header from xmlsecurity 2011-11-27 13:28:28 -06:00
Fridrich Štrba
4cd6e07a84 And yet another .getStr()-style fix 2011-10-06 14:55:36 +02:00
Caolán McNamara
1f5c696c37 add mode-lines to .m files and last round of merged files, etc. 2011-09-30 09:09:25 +01:00