mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
370,860 Commits 1 Branch 0 Tags
0fb66458c08b9c0ce59bca85e77d26fad8b59e4b
Commit Graph

766 Commits

Author SHA1 Message Date
Julien Nabet
b33788cb6b Typos 
Change-Id: I665a56fcad10e136e949a10497f6ab8813af9968
 2015-03-25 21:19:59 +01:00
Noel Grandin
b2d2d72a7e loplugin:constantfunction: basic 
Change-Id: I1c9a33cefb68bec978b2a922c2c3ef00f2a7a1b4
 2015-03-24 10:31:17 +02:00
Stephan Bergmann
d1c9e5ee53 tdf#43157: Fix format string violations in OSL_TRACE etc. 
...for a 32-bit build, similar to what ee11e221d2
"tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit
build

Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
 2015-03-13 18:21:36 +01:00
Caolán McNamara
556373c41f V668 no sense in testing the result of new against null 
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
 2015-03-11 09:58:36 +00:00
Julien Nabet
5f6fcb4e7c Typos 
Change-Id: Ibc378fa5f515de61bb768b4ef082638b40c94e00
 2015-03-08 16:45:30 +01:00
Noel Grandin
e9beb26470 convert SBI_ constants to enum class 
Change-Id: I65e706f4e1adfe242808293d9514c9db8d22cc12
 2015-03-02 08:59:18 +02:00
David Tardon
04814fcc3b likely intent 
Change-Id: I2372ddec8e82eb99206661469843d7837d2bf6d1
 2015-03-01 17:33:58 +01:00
Caolán McNamara
d41b8ac9e5 callcatcher: shave off a few more 
Change-Id: Ie48cf7f89c8c826e56409c2493e1e1250086f10a
 2015-02-02 21:07:54 +00:00
Michael Stahl
a4faad707c tdf#76174: basic: lock SolarMutex in BasicScriptListener_Impl 
... before calling into BASIC.

Change-Id: I51a59fe5ca9b15ff7ec509c052964523d87a9790
 2015-01-29 21:48:12 +01:00
Noel Grandin
b44cbb26ef new loplugin: change virtual methods to non-virtual 
Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
 2015-01-26 08:42:28 +02:00
Stephan Bergmann
4130c64355 Some more loplugin:cstylecast: basic 
Change-Id: Ib22bc7408d333a7080fa44c9c3ac9535ccf00752
 2015-01-20 09:06:45 +01:00
Noel Grandin
2f69f6efa0 remove unnecessary parentheses 
left over from "SVStream operator>> to Write method" conversion

Change-Id: I619eb743d7890d5c70d0a94e51ce263567fa6f3b
 2015-01-16 08:08:44 +02:00
Caolán McNamara
7f476fea47 boost::unordered_map -> c++11 std::unordered_map 
Change-Id: I28438000c2b0a8e6ce4f5640f861f572c0cb83c8
 2014-12-27 23:00:45 +00:00
Stephan Bergmann
39ddeb53c0 basic: Use appropriate OUString functions on string constants 
Change-Id: I43f99ba6759b0f8f633af784beaec583dbab0b9e
 2014-12-18 14:12:23 +01:00
Stephan Bergmann
0f5e917024 Introduce rtl::OUStringLiteral1 
...to use single ASCII character literals "more directly" in the OUString API
(instead of having to go via an intermediary OUString ctor call).  Especially
useful for character literals that are defined as const variables or via macros
("direct" uses of character literals in the OUString API can often simply be
replaced with single-character string literals, for improved readability).

(The functions overloaded for OUStringLiteral1 are those that are actually used
by the existing LO code; more could potentially be added.  The asymmetry in the
operator ==/!= parameter types is by design, though---writing code like

  'x' == s

is an abomination that shall not be abetted.)

Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f
 2014-12-17 16:39:33 +01:00
Stephan Bergmann
898c414700 basic: Use appropriate OUString functions on string constants 
Change-Id: Ied7e5eba39672363065083493bd5e60449fda371
 2014-12-12 10:21:45 +01:00
Michael Weghorn
93124f7710 reduce scope of local variables 
This eliminates some of the warnings from Cppcheck report of
2014-11-29.

Change-Id: Ic4bf3bd8f5982d2ea2f25a28c0dd61084c59af11
Reviewed-on: https://gerrit.libreoffice.org/13331
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2014-12-06 14:12:31 +00:00
Caolán McNamara
41029bcdd0 coverity#1242865 Untrusted value as argument 
Change-Id: Ie7a7a2e7894a204dd55833416b7cbc5b01826e64
 2014-11-14 12:02:48 +00:00
Brij Mohan Lal Srivastava
d32be3ace8 fdo#86023 - O[U]String needs a 'clear' method 
Added clear() method to OString and OUString class, Updated appropriate call-sites.

Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2014-11-14 09:20:38 +01:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Caolán McNamara
1409c0bd88 coverity#1242865 Untrusted loop bound 
Change-Id: I9dc9cd98d0a02a2867d4c40c7afb7bf873513143
 2014-11-05 21:03:24 +00:00
Caolán McNamara
5b0c95d81e coverity#1242794 Untrusted loop bound 
Change-Id: I902a5bf989a8f385994a2f927cce4975b18f06d2
 2014-11-05 21:03:24 +00:00
Caolán McNamara
12bcfec04f markup with event type not checker type 
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
 2014-11-05 14:58:00 +00:00
Noel Grandin
705c48d32e fdo#38835 strip out OUString globals 
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.

Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
 2014-11-05 08:44:19 +02:00
Caolán McNamara
cb0e009a9e document array_vs_singleton dismissals 
Change-Id: I8d7eb4c01197e885abca717c7814c61a7641ac9d
 2014-10-30 10:10:09 +00:00
Michael Stahl
a1fad26e04 fdo#84935: basic: DocBasicItem is a UNO service, lock SolarMutex in dtor 
Change-Id: Ia31d735ba54d18f406653debce04a07c077d09eb
 2014-10-23 15:38:20 +02:00
Caolán McNamara
0f6c6baf61 coverity#1242481 Dereference null return value 
Change-Id: I21e6bdd643d898a3515a96e4c9c17c2d6f98b0e4
 2014-10-03 16:30:32 +01:00
Noel Grandin
c625525ddc rename SvRef::AddRef to AddFirstRef 
to make it's intended purpose clearly distinguishable from AddNextRef

Change-Id: I5da780b48b19fd873667b648031bc394113f953b
Reviewed-on: https://gerrit.libreoffice.org/11763
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-03 05:25:41 +00:00
Noel Grandin
059f5a95b2 loplugin: cstylecast 
Change-Id: Ic7c9c978baf5602a508aff5976220a02ed03a680
 2014-10-02 07:37:19 +02:00
Noel Grandin
5cefde06ea remove unnecessary casts in calls to SvStream.WriteUInt32 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
 2014-09-26 15:27:17 +02:00
Noel Grandin
04fd62096f remove unnecessary casts in calls to SvStream.WriteInt32 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I0c0172519479be0535a447e41a592fbf782751bd
 2014-09-26 15:27:17 +02:00
Noel Grandin
5501c8d222 remove unnecessary casts in calls to SvStream.WriteUInt16 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
 2014-09-26 15:26:48 +02:00
Noel Grandin
dedfa972bc remove unnecessary casts in calls to SvStream.WriteInt16 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: Ie44bec6b988f3e46fe78d14b740818c9141f5df0
 2014-09-26 15:26:48 +02:00
Noel Grandin
bec72dd34f remove unnecessary casts in calls to SvStream.WriteUChar 
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
 2014-09-26 15:26:19 +02:00
Noel Grandin
5bce329040 SfxHint: convert home-grown RTTI to normal C++ RTTI 
Also note that I fixed a bug in SvxFontMenuControl::Notify
where the if statement had the check the wrong way around.

Change-Id: I611e8929c65818191e36bd80f2b985820ada4411
Reviewed-on: https://gerrit.libreoffice.org/11147
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2014-09-06 15:47:44 -05:00
Noel Grandin
37b9ea92ba convert SBX flag bits to type-safe enum 
Change-Id: I18d5d6a27f06ee60a5cb3dc393bf05b51bba4817
Reviewed-on: https://gerrit.libreoffice.org/11070
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-08-26 04:30:03 -05:00
Caolán McNamara
d21d5a7261 drop unnecessary shl.hxx includes 
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
 2014-08-18 12:59:49 +01:00
Caolán McNamara
d438c470d7 coverity#1231668 Unchecked return value 
Change-Id: Ia7e47b5d42e9a488b3952f12d607b3f17661c44d
 2014-08-17 16:39:21 +01:00
Tobias Lippert
6a873638fa Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xx 
- Remove includes from files where they are not needed.
- Update pch files

Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5
Reviewed-on: https://gerrit.libreoffice.org/10342
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-07-17 08:47:58 +00:00
Takeshi Abe
d97b5e420f Avoid possible memory leaks in case of exceptions 
Change-Id: Icecc2cce52d7f27c030270639e6b85877e3aa620
 2014-07-16 18:01:39 +09:00
Noel Grandin
dac4ca5f68 new loplugin: externalandnotdefined 
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
 2014-07-11 14:12:25 +02:00
Norbert Thiebaud
42fcd888ae coverity#735397 dead code 
Change-Id: If8d82a39af7a506f42b6c13d8408ffc479b564e7
 2014-07-01 12:44:06 +02:00
Caolán McNamara
a7fcb3ed07 clang: Returning null reference 
Change-Id: I2cfc14e73696a027283dfa5eef98f784505dc5a3
 2014-06-26 16:29:13 +01:00
Noel Grandin
3e82897353 improve the inlinesimplememberfunctions clang plugin 
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
 2014-06-17 10:55:17 +02:00
Stephan Bergmann
f8ef1fe95b loplugin:staticcall 
Change-Id: I6cd46964c523c9393e9d249fdb43aaa38679fa06
 2014-06-13 17:54:23 +02:00
Noel Grandin
184a00b962 loplugin: inlinesimplememberfunctions 
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
 2014-06-09 10:10:13 +02:00
Thomas Arnhold
dd8f095940 WaE: warning C4101: 'ex' : unreferenced local variable 
Change-Id: Ib8b71b50fe52a7cc4e261626549ac3e067851797
 2014-06-04 08:30:26 +02:00
Thomas Arnhold
3038794d2e basic: typo 
Change-Id: I10c9e480a94a966dac4f6c17fc69fa8892c56955
 2014-06-02 12:04:31 +02:00
Stephan Bergmann
6b4c596b01 Fix memory leak for BASIC sub (as well as void function) 
d88593af59 "INTEGRATION: CWS ab34: #i73457#
Prevent sub from beeing set as param 0 for return type void" to fix i#73457
"Memory Leak in all Basic type void Method calls" had made the PutDirect call
dependent on != SbxVOID only (which would cover void functions) but not also on
!= SbxEMPTY (which would apparently be required to also cover subs, as seen with
CppunitTest_basic_vba run under lsan).  Either this was an oversight with the
original fix, or subs have meanwhile changed from GetType() == SbxVOID to
SbxEMPTY?

Change-Id: I3e5dbf79bfd5eea3cfec8ed3fa984d13167aa501
 2014-06-02 11:12:11 +02:00
Kohei Yoshida
a916b6ff7f Detach all DocBasicItem objects upon process termination. 
To prevent rogue DocBasicItem objects (which are global objects) from
attempting to stop listening after the main app is dead.

Change-Id: I68a667137ca4e0eff18278f4d2d5dd67466eaf34
 2014-05-29 21:59:48 -04:00