399585 Commits

Author SHA1 Message Date
Stephan Bergmann
8251b57dec const-ness mismatch
(Why does that only cause a compilation failure now?
DataFlavorMapper::openOfficeToSystemFlavor always returned a const NSString*.
Odd.)

Change-Id: I5baa577b78d024c5e959df7ec5bf477057b91c07
2016-11-02 09:25:57 +01:00
Noel Grandin
3fea7ac94b loplugin:unusedfields
Change-Id: I96634c18ba6600f8f7d5d04a162dcd7e1e312923
Reviewed-on: https://gerrit.libreoffice.org/30474
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02 07:54:20 +00:00
Noel Grandin
2db81e7336 loplugin:expandablemethods in avmedia
Change-Id: I215230d3b7e3649146083f00e7c10c03a4d3154e
Reviewed-on: https://gerrit.libreoffice.org/30470
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02 07:13:16 +00:00
Noel Grandin
a7369d9899 loplugin:oncevar in helpcompiler..reportdesign
Change-Id: I2dc57931fb230953c285aeb18f57c0a41fedafcb
Reviewed-on: https://gerrit.libreoffice.org/30463
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02 07:12:46 +00:00
Khaled Hosny
5d39c20133 tdf#71603: Create a new DC for the font fallback
For some reason re-using the DC from SalGraphics results in
GetFontData() returning GDI_ERROR and we fail to read the font’s “cmap”
table. The wired thing is that this happens only for fonts that were
not used before, so if you open a document directly the fallback works
but if you open start center or blank Writer document you get no
fallback. GDI is “interesting”.

Change-Id: Ic23095cabbd2623717271ce5d89bea75dca76a9a
2016-11-02 01:37:21 +02:00
Stanislav Horacek
3f04f3f08b Updated core
Project: help  68f7b9d1c6ffed02a241645868e49bf80aa45b53

tdf#70998 change term "Graphics" to "Images"

Change-Id: Ic2c2877a077bd5ba67a271dd7a89c4d1391e6fbb
Reviewed-on: https://gerrit.libreoffice.org/30450
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-01 21:48:46 +00:00
Khaled Hosny
03bff1b6b9 tdf#71603: Improve font fallback on Windows a bit
Check all missing characters, not just the first one. Also the calling
sites for GlyphFallbackFontSubstitution hook expect the OUString to be
updated to have only any characters not supported by the returned font.

Change-Id: Ife56d692c05433f2f7fe02db3ef1562181dc3d53
2016-11-01 23:46:32 +02:00
Khaled Hosny
d66ec48fe8 Use the font language instead of guessing it
Similar to what we do with FontConfig.

Change-Id: Id01dabe0b52e4e3aea54073d42b719a924025920
2016-11-01 23:46:32 +02:00
andreas_k
35bfb8fb0c remove red alert color from pdf icon
Change-Id: Iebeebc26a02dfa4c9d517664fb803d371b8ac1cc
Reviewed-on: https://gerrit.libreoffice.org/30387
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-01 21:39:13 +00:00
Khaled Hosny
8d192b66e3 Misplaced #if ENABLE_GRAPHITE
Change-Id: I2af3fdf100f6aaf435d8ed33d781ea0ca4ec21ec
2016-11-01 23:37:39 +02:00
andreas_k
1476c299b6 quit icons in breeze-dark were shown in black instead of red
Change-Id: I1ae0ee355e537339e33c5e41826527ccb8dd6277
Reviewed-on: https://gerrit.libreoffice.org/30384
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-01 21:36:25 +00:00
Noel Grandin
241dca2d8a add an assert to check for ref-counts > 16 bits
after
    commit 87c518593de59dbf4c0f5f45c720b14a05aeca9e
    sc: remove antique reference counting hacks from ScDocumentPool

In theory, nothing should be trying to save items like this
anymore, but lets make the error more obvious in case something is.

Change-Id: I89b3637168c072d20e214a8f6338f6336d44d891
Reviewed-on: https://gerrit.libreoffice.org/30467
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2016-11-01 21:36:08 +00:00
andreas_k
943e82d8a4 update icon to have the right icon color in breeze-dark
Change-Id: Iaf1888357c8b9ed6aeb987341fbc69117c6e0ecb
Reviewed-on: https://gerrit.libreoffice.org/30386
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-01 21:35:38 +00:00
andreas_k
5f0d987f02 update calc icon now the calc icon is green instead of black
Change-Id: I7a11448e84ace54936b378bc178bbd4a7603b516
Reviewed-on: https://gerrit.libreoffice.org/30385
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-01 21:33:13 +00:00
Stephan Bergmann
f861c29e4c Clean up javavendors_*.xml files
...and drop unnecessary javavendors_template.xml

Change-Id: Ib7f2d595d2086c1d3bf324f19693b9032cf00cd7
2016-11-01 22:28:37 +01:00
Stephan Bergmann
f537e561c7 quickfix: Automatic selection of Oracle Java runtime on macOS
same issue as 36f637f7f21906fa3f37223e69b044db52036fb1 "tdf#103507 quickfix:
Automatic selection of Oracle Java runtime on Windows"

Change-Id: I3239bbf52263fb53bcd0ed54e8e983bda3b19182
2016-11-01 21:17:48 +01:00
Maxim Monastirsky
2c1d6e5989 tdf#103624 Avoid double init of controls in SidebarToolBox
Controls that created by the service manager are already
initialized by it. At least in the case of SaveToolbarController
such double init creates a problem, as SaveToolbarController
will add itself as a modify listener twice, but remove only
once in dispose method. Probably SaveToolbarController should
be smarter about this, for both not adding a listener twice,
and also not attempt to work after being disposed - but that
doesn't make the behavior of SidebarToolBox correct.

Change-Id: I3f0fcdff31c65198a2233c969d37a0015712fff5
2016-11-01 21:53:11 +02:00
Jochen Nitschke
8826771e83 style fixes for cppcheck noExplicitConstructor
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34
Reviewed-on: https://gerrit.libreoffice.org/30460
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-11-01 18:44:20 +00:00
Marco A.G.Pinto
33bc51a605 Added 22 pt_PT autocorrect words
Change-Id: Ida1f8f836e1c5772771fb4ca3c90982b98326778
Reviewed-on: https://gerrit.libreoffice.org/30473
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-11-01 18:07:59 +00:00
Samuel Mehrbrodt
5cddf5d763 SafeModeDialog: Close dialog before restarting
Change-Id: I714040d0892cf154e002209dbdb4831b40ec08bc
Reviewed-on: https://gerrit.libreoffice.org/30472
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-01 16:45:00 +00:00
Stephan Bergmann
d82f34a7ec Forward debug/optimization flags to external/harfbuzz
Change-Id: Ie3bc54a43e46dc28faca9356f414a700a0727cec
Reviewed-on: https://gerrit.libreoffice.org/30456
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-01 16:04:44 +00:00
Szymon Kłos
889b8102e0 tdf#103481 fixed SIGABRT in embedded presentation
Change-Id: I51402aec953d58f92d8fe768bca0d2c2d1ce4474
Reviewed-on: https://gerrit.libreoffice.org/30368
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-01 15:54:17 +00:00
Tor Lillqvist
7ec0eed345 Fix inconsistent indentation
Change-Id: I4b87541c6e64e6b2b7c912f47a80a4aa37842014
2016-11-01 17:17:35 +02:00
Samuel Mehrbrodt
e13827070c SafeModeDialog: Group options
Change-Id: Ife0903c90f17efb2a1c6681ece8dd9af257873cd
Reviewed-on: https://gerrit.libreoffice.org/30453
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-01 14:59:20 +00:00
Samuel Mehrbrodt
69de2b4772 SafeModeDialog: Add link to user profile
Change-Id: I0096b3d7db51e28eb58c7209109c30b73b382478
Reviewed-on: https://gerrit.libreoffice.org/30448
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-01 14:58:25 +00:00
Samuel Mehrbrodt
1161de521e safemode: Add option to disable H/W acceleration
Change-Id: Ic6751717c14d317b5a4bc64c4fd1cf2b2f5efabf
Reviewed-on: https://gerrit.libreoffice.org/30112
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-01 14:54:04 +00:00
Michael Stahl
6b5cbdf833 sysui: add "translate" urls to AppData files
* run "appstream-util upgrade"
* add "translate" urls

Change-Id: I3bad7d5dd90cce7703a100ac95097ad3a8f2c56d
2016-11-01 15:49:22 +01:00
Tor Lillqvist
0bbc15aa24 Use enum class for two local enums
Change-Id: I0d7e6a14ec890b8a1dbdea3685b543b63426c628
2016-11-01 16:38:32 +02:00
Giuseppe Castagno
acf531be6a Cosmetic: Namespaces, better make use of the 'using-directive'
Change-Id: If27709a2d8d8f231be9be0231d522f2a71e5fcae
Reviewed-on: https://gerrit.libreoffice.org/30457
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-11-01 13:33:41 +00:00
Caolán McNamara
9e33ac4035 Resolves: tdf#103556 the implicit convert to bare pointer hurts us here
Change-Id: I2d91cf9b11027f76dbcbb5432f4cad71c56f53f2
2016-11-01 13:30:54 +00:00
Noel Grandin
9bdec0831a loplugin:oncevar in sd..svgio
Change-Id: I58565460fcc3279c9771c6e1272d0af540b2c87c
Reviewed-on: https://gerrit.libreoffice.org/30459
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01 13:25:08 +00:00
Noel Grandin
49c7bc5af2 loplugin:expandablemethods in accessibility
Change-Id: I51d13c12274d99623b97f611e30204bea624cbfc
2016-11-01 14:54:13 +02:00
Jochen Nitschke
53949256dd simplify loop to O(n)
Change-Id: Ib14da0201730e213f15f4f46b539fc843bfbe750
Reviewed-on: https://gerrit.libreoffice.org/30454
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01 12:38:35 +00:00
Noel Grandin
3941482735 loplugin:oncevar in sal..scripting
Change-Id: Id9ab12f3a61eb83a2288b2fd4d99ab77f5833e1b
Reviewed-on: https://gerrit.libreoffice.org/30461
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01 12:34:51 +00:00
Jochen Nitschke
d5c4823555 cppcheck unreadVariable: nModified
unused since initial commit 9ae5a91f7955e44d3b24a3f7741f9bca02ac7f24

Change-Id: I2828af1fbfda993dff32abf0f9a9f73e9fb61028
Reviewed-on: https://gerrit.libreoffice.org/30455
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-11-01 11:22:56 +00:00
Noel Grandin
2f71f88cf8 add Codelite files to .gitignore
Change-Id: I464748061b9df4d781ae49f4971f73d92f825bba
2016-11-01 13:02:53 +02:00
Noel Grandin
5e997f4dba disable this chunk of loplugin code on clang < 3.8
not worth the spaghetti of making it work across version

Change-Id: I0de923b16fb6d58cbad55adc9878ab39bc0c86ae
2016-11-01 12:58:17 +02:00
Шиповський Роман
458a9fd806 Decrease SpreadsheetML import time to prevent "General input/output error"
Change-Id: I39ed8fff7ba88042c74a11ddc58eec014c0bc6bd
Reviewed-on: https://gerrit.libreoffice.org/30361
Tested-by: Jenkins <ci@libreoffice.org>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-11-01 08:19:30 +00:00
Arnaud Versini
6e0b4ffd25 BASIC : use rtl/character.hxx in sbxform.cxx
Change-Id: I88c9d26b27ff80e02a88349198813d2771522343
Reviewed-on: https://gerrit.libreoffice.org/30445
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01 06:54:11 +00:00
Takeshi Abe
cb90f0976d Omit the default comparator
Change-Id: Idea8ea8dab6a86d7be6394aef1cf7f25b75009e0
Reviewed-on: https://gerrit.libreoffice.org/30319
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-01 04:11:44 +00:00
Takeshi Abe
9fa6dadc4e Omit the default comparator for std::sort()
Change-Id: Ib865bdf911b53d809fc2979f524da3735bb39ce5
Reviewed-on: https://gerrit.libreoffice.org/30432
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-01 00:54:03 +00:00
Khaled Hosny
3950166877 Revert "Enable the new text layout engine by default"
This reverts commit d79f43d0bebbe7b1f8d68d50734737aea9fe839d.

Breaks MacOSX tinderbox, need to figure out why a totally unrelated test
is broken.
2016-11-01 02:25:10 +02:00
Khaled Hosny
e31f7f4c87 tdf#103403: Wrong glyph advances with Graphite
Always create HarfBuzz font at the UPEM size and scale HarfBuzz output
with the desired size instead. This theoretically means we loss any
size-specific adjustments in the font but in practice very few fonts do
this and in general modern APIs prefer stable glyph positioning across
font sizes.

Change-Id: Idf396eec5e241cc5fb9d0db698f2c081b7de29e3
2016-11-01 02:15:23 +02:00
Khaled Hosny
86abe3cb3d Revert "tdf#103403: Wrong glyph advances with Graphite"
This reverts commit 3d83c42008ab51202c0577f493e8ed3fde0310b7.

A simpler fix in the next commit.
2016-11-01 02:14:17 +02:00
Khaled Hosny
d79f43d0be Enable the new text layout engine by default
The handful of bugs reported so far have been fixed, and I think it had
enough basic testing to show that it is usable and can be switched on
for wider testing.

We can always revert back to the old engine if needed before or even
during 5.3 series.

The environment variable SAL_NO_COMMON_LAYOUT can be set to disable it
at runtime.

Change-Id: If319a0161897ec676d3123595944a0401c67b63f
Reviewed-on: https://gerrit.libreoffice.org/30443
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2016-10-31 23:28:59 +00:00
Eike Rathke
33090865c4 Resolves: tdf#99291 empty array element should not match empty cell
As weird as it is, but an empty cell is only to be matched by an empty string,
not another empty cell.

Affects spreadsheet functions SUMIF, AVERAGEIF, COUNTIF, SUMIFS, AVERAGEIFS and
COUNTIFS.

Change-Id: Ib33402e8c93f26cd8e2648426a5bde6b267c55ab
2016-10-31 23:54:46 +01:00
Stephan Bergmann
f25a15dc99 loplugin:vclwidgets: Adapt iterator hack to libc++
Change-Id: I1e4fbb06578b2b1d6de4b57507693b014d36cd3a
2016-10-31 21:01:18 +01:00
David Tardon
04055cd8d9 fix doc comment to match code
This has been wrong since the initial commit...

Change-Id: I271375ba10c37aa9b198476955d66af9fc019e27
2016-10-31 20:16:04 +01:00
David Tardon
7445399af8 convert angle from degrees to radians for glm
This makes simple (i.e., not implemented as a shader) OpenGL transitions
work correctly again.

Change-Id: I773f686089bce3611940743b1a7f5046093886e8
2016-10-31 20:16:04 +01:00
Eike Rathke
d7984d88e6 Resolves: tdf#64001 exclude "boolean" value cells from increment during Fill
Change-Id: Id79438cc37a63c0619c6b96ecf57b10d781afea3
2016-10-31 18:13:17 +01:00