OfficeDocumentsManager::buildDocumentsList was set up to ignore disposed
documents, but didn't ignore documents which were still uninitialized (i.e.
waiting for the macro warning dialog of the other in-construction document to
return a decision)
Change-Id: I936e29ab6fad14a33609e8d57d11d7d0178075e4
We have comphelper::WindowsErrorString(), so use it, in SAL_WARNs,
right where an error happens. Get rid of the fairly unhelpful
ImplWriteLastError() function.
Avoid duplicated error reporting.
Change-Id: I83374a65980b7c0ffa35fc493b4fb1f2e94f0dbb
If we notice early enough that OpenGL is broken or not good enough, we
can disable it and terminate with EXITHELPER_NORMAL_RESTART. Not
beautiful, but works.
The earlier added check whether shader compilation and loading of
shader program binaries from a cached file works is now just one of
the aspects that are checked.
Change-Id: I9382576cc607f1916f6002f1fa78a62e23180fe3
Relax the checks in configure.ac to allow building against recently
released Firebird 3.0. In this version, libfbclient is also used to
access local database files (embedded server mode) rather than
separate libfbembed.
Change-Id: Id498cbca22409f95ee299a6165cc765efa25eca7
Reviewed-on: https://gerrit.libreoffice.org/25845
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
For example, copying an empty column or row range, and then
pasting as unformatted text exports all the newline characters
inspite of the fact that this is an invalid data range.
The problem becomes worse when someone tries to copy an entire
column which implies exporting MAXROW times newline characters.
Change-Id: Ie0a09890e2d0cd5f44d89d520959248e65365ad7
even with only one toolchain, so test whether path exists without
version, otherwise just stick it in.
Change-Id: I58c7f9e9582efdccb446e1bcf161d2c9e913a3af
In preparation of adding some builtin format codes, actually already
NF_FRACTION_3 and NF_FRACTION_4 needed that.
Change-Id: I734a1ef5e6405aceaace7d44e8901a6183dc2a64
__LP64__ is not defined in MSVC AMD64 builds, since it doesn't have
64-bit longs. This caused the vcl_filters_test to fail because loading
the file for which that check is a work-around succeeded.
Change-Id: I4df48d4b196a1d08e9bd5ef61b64ec63501037c9
This would have been more useful if it checked one of the other types
that use inheritance. It would also be more useful if it actually did
something to report the issue instead of silently reporting success.
Change-Id: I684146244d4eec15669b499e40214b8ede70741f
This filter reads entire structs at a time from the SvStream, including
structs that are derived from other structs. This happens to work fine
with GCC by chance, but MSVC AMD64 by default aligns structs to 8 bytes,
and that means if sizeof(super-stuct) = 20 then 4 bytes of padding are
inserted and that ruins the import.
This causes vcl_filters_test to go into an infinite loop reading
SaveAsPicture.sgv.
Fix this by reading each member of the structs separately, which also
means that the filter doesn't need to byte-swap every member on
big-endian platforms since SvStream methods already do that.
Change-Id: I237725dbcde5232006728179e645776fcb79cac3
...in an attempt to reduce usage of type-unsafe
void const * css::uno::Any::getValue()
These new functions are often more convenient to use than the existing ">>=" and
Any::get<T>. Note how they are careful to provide a pointer directly into the
given Any, instead of creating temporaries.
As an example, replaced most calls of getValue across xmloff:
* Cases that first check for a specific type (via getValueType etc.) and then
call getValue can instead call tryGet. (But beware that tryGet supports some
conversions, which a check for a specific type may have missed---either
intentionally or by accident. Also beware the somewhat common idiom of
checking for TypeClass_ENUM and then using getValue to obtain a sal_Int32;
this cannot be replaced with a call to tryGet.)
* Cases that seem confident that the Any is of the correct type when calling
getValue (but apparently are confident due to some higher-layer protocol, as
the surrounding code does not do any checking via getValueType or similar) can
instead call doGet. It throws an exception if it turns out the confidence
wasn't warranted. (Many of the existing calls that directly dereferenced the
return value of getValue as sal_Bool look suspicious, in that the author might
have thought the given code would also cover a VOID Any---which technically it
even would have happened to do. If any RuntimeExceptions thrown from these
doGet calls start to crop up, these changes need to be revisited. Some may
even be rewritten as uses of ">>=". But at least "make check" did not show
any such problems. Also note that casting the value obtained from getValue to
any css::uno::Reference<X> with X being anything but the base
css::uno::XInterface was always prone to producing a bad pointer, in case the
interface actually stored in the Any derived from X via multiple inheritance.)
* Should there ever be cases where an Any is known to be of the requested type,
some additional forceGet could be introduced (which would assert instead of
throwing an exception).
Change-Id: I2d8739e86314eff73abfcafe01d806f5bc5c34db
(And not just names from the hardcoded list.) Surely we want it to be
possible to add a blacklist entry for a hitherto unhandled vendor to
the file at a user site without having to modify the parsing code and
rebuilding LO.
Change-Id: I01ca45cb91df06e1634a565b3e469fb85fe4e116
Changes:
- added invalidate call after entry selection and expand
Behaviour before patch (Linux):
1. Open Writer
2. Open AutoText Dialog: Tools > AutoText
3. Expand/select entry
Insert button is still disabled / entry is not expanded.
To force repaint you had to use mouse scroll.
Change-Id: I814db71dea02273998f675c3b140d554f2e109ba
Reviewed-on: https://gerrit.libreoffice.org/25783
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
