1200 Commits

Author SHA1 Message Date
Noel Grandin
436cd90095 svtools: sal_Bool->bool
Change-Id: Ifd3e643dbc6755839ad4af73ae141fd115ddb4f4
2014-03-25 14:32:56 +02:00
Stephan Bergmann
f9cc750985 Reduce IAccessibleTabListBox to what's actually used
...the calls to getAccessibleChild(0) and getHeaderBar(BBYTE_COLUMNHEADERBAR)
ultimately all ended up at
AccessibleBrowseBox::implGetHeaderBar(BBTYPE_COLUMNHEADERBAR).

Change-Id: Ie25659e19d0d1ce2dcde2d1440ecc69b4fa265b0
2014-03-25 09:15:40 +01:00
Stephan Bergmann
d96a2f432f Remove dead code
Change-Id: Ia9035189bd01d3a3e5e3222760fc392f3f78880f
2014-03-25 09:15:39 +01:00
Stephan Bergmann
c6b2b5f34c Remove dead code
Change-Id: Id522113f1ba0c9e7b1356acc01a79e0e90a5e752
2014-03-25 09:15:39 +01:00
Noel Grandin
9f12e4a351 svtools: sal_Bool->bool
Change-Id: Ic765d1a28960dbeca9501852b5e84cfdfe6ac47e
2014-03-24 08:12:07 +02:00
Stephan Bergmann
c2fb42afb3 Use cppu::BaseMutex and remove need for Paragraph/ParagraphImpl split
Change-Id: I790e14feb50fefe3b2efa505118b332d065970fc
2014-03-18 13:29:13 +01:00
Noel Grandin
86a32589e9 Find places where OUString and OString are passed by value.
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-18 08:32:26 +02:00
Alexandre Vicenzi
364ac5acf4 fdo#63154 Remove some solar.h references
Remove some solar.h from tools.
Replace sal_uLong by size_t, sal_uInt32 and sal_Int32.

Change-Id: I38961db046337a3ea4ef75d64afa424d81391f34
Reviewed-on: https://gerrit.libreoffice.org/8582
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-03-15 22:55:02 +00:00
Stephan Bergmann
36784563ed OAccessibleContextWrapperHelper does not implement XAccessibleContext
...but rather some (non-virtual) base functionality for use in derived classes
(that do implement XAccessibleContext)

Change-Id: Idb0023906108db22bb9696245f07b9a4c053a0d1
2014-03-14 14:29:24 +01:00
Caolán McNamara
cf561446e4 a crash sometimes seen in a11y in base
Change-Id: Id8b7c8394a4e8bc1477c34056b8014d311186d7e
2014-03-13 16:24:15 +00:00
Stephan Bergmann
d47ca30f1c No need for implGetBounds to be SAL_CALL
Change-Id: I4eb1f998de57a4ceeb7990c6e4a964ce0d07ea88
2014-03-11 15:35:52 +01:00
Stephan Bergmann
acca15f7a0 accessibility: simplify deprecated XTypeProvider.getImplementationId
Change-Id: I7f8848adf245a4fdf56bff67cc15ee0efb818c43
2014-03-10 17:39:51 +01:00
Eike Rathke
68ec95b3f8 made ListBox handle more than 64k elements, fdo#61520 related
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.

Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 07:31:19 -06:00
Noel Grandin
6f0dfc462e remove unused code in accessibility::Document
accessibility::Document::justifySelection(TextPaM&, TextPaM&)
accessibility::Document::notifySelectionChange(int, int)

Change-Id: I3a5c79ada69c1530ebbbf386bf271f3a83843815
2014-03-05 09:17:44 +02:00
Stephan Bergmann
994a359649 Revert "Let's use RADIO_BUTTON and CHECK_BUTTON roles"
This reverts commit 97d4f7e07462cbc33e8ebf0bc2bbf8a17c232d50, which appears to
be incomplete: CHECK_BUTTON is not defined anywhere.
2014-02-26 22:36:49 +01:00
Julien Nabet
97d4f7e074 Let's use RADIO_BUTTON and CHECK_BUTTON roles
Thank you Caolán and Niklas for your support!

Change-Id: Ied978b36cc309b2668889d878a309d1a1400633a
2014-02-26 22:31:14 +01:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Julien Nabet
09a1c9d31f cppcheck: duplicateIf
- replace duplicate TIB_DROPDOWN test with TIB_DROPDOWN + TIB_DROPDOWNONLY
- consider also TIB_RADIOCHECK as AccessibleRole::TOGGLE_BUTTON

Change-Id: Id159349ae1515681f47c373ba3d839ed406284ab
Reviewed-on: https://gerrit.libreoffice.org/8164
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 05:06:44 -06:00
Alexander Wilms
2e821e4741 Remove visual noise from accessibility
Change-Id: I876e5c4d1991b35c1dc2cea709d8a2ddf781b012
Reviewed-on: https://gerrit.libreoffice.org/8225
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25 16:18:25 +00:00
Stephan Bergmann
33740b7d5a Replace exisiting TriState, AutoState with more generic TriState
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24 12:27:32 +01:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
Tobias Lippert
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
Caolán McNamara
49cecd8b41 Related: fdo#74242 hook up a selection and caret change for multiline edits
a) split the textengine selection changed broadcast into a text selection changed
and text caret change event
b) handle both in existing places that handled the text selection event
c) listen for them in VclMultiLineEdit and translate to
VCLEVENT_EDIT_SELECTIONCHANGED VCLEVENT_EDIT_CARETCHANGED events
d) profit from the VCLEVENT_EDIT_SELECTIONCHANGED and
VCLEVENT_EDIT_CARETCHANGED handling in
accessibility/source/standard/vclxaccessibleedit.cxx for VCLXAccessibleEdits

Change-Id: I09187e76ae4eb189ee9469e388374154087faf80
2014-02-19 15:32:00 +00:00
Caolán McNamara
da13dd9a35 Related: fdo#74242 #i104470# we now have a seperate CARET_CHANGED event
so cursoring left and right in normal non-multiline edit widgets should
give a11y cursor-changed events

Change-Id: I91e86e43d049793912b3ffcc2802bb9aa4b3857c
2014-02-19 11:07:12 +00:00
Michael Stahl
368cff78a4 accessibility: add some missing locks in new code
Change-Id: Ic38a07c592a89973ca1df807505f87910e84a17f
2014-02-11 12:52:22 +01:00
Caolán McNamara
2b12a5b87b the return of callcatcher
Change-Id: I447ebcc61ff061bce15678c6fcfd3d0a4669908f
2014-02-10 11:21:03 +00:00
Stephan Bergmann
660c1889c9 std::less is the default here
Change-Id: I57428772187d3487668eca2f553c74e18e4f736e
2014-02-07 18:43:31 +01:00
Stephan Bergmann
2935c2999e auto_ptr -> scoped_ptr
Change-Id: I05c461deca118f1a1b75d94b4d00ce797987e8d6
2014-02-07 18:43:31 +01:00
Stephan Bergmann
2b04d0a17f Avoid unnecessary heap allocation
Change-Id: I7bc1a0960cc100c51b90c50838a5ef620f3c763f
2014-02-07 18:43:30 +01:00
Chris Sherlock
51a68b4992 Doxygen warnings corrected
* Doxygen spits out a lot of warnings about not being able to find
  match function signatures, etc. This is because in some headers we
  have a using namespace statement, in others it gets confused between
  ::Window and Window (!).

* Wrong use of tags:
  + Lots of @seealso - should be @see
  + Wrong usage of @overload - corrected with the right function
    signature
  + HTML tags that doxygen doesn't recognize removed

Change-Id: I1c2eed941619b8764dbfcfc5ab38027518cdf261
2014-02-05 09:14:53 +00:00
Caolán McNamara
0be44f7d15 fix ambiguities
Change-Id: Ice46cfbe8a21c5e641e09070128b8f412411c9d9
2014-02-04 14:57:37 +00:00
Herbert Dürr
59238ef422 Related: #i123862# use O*String's isEmpty() method...
to check for emptiness in modules starting with 'a'

Patch-by: j.nitschke@ok.de
Review-by: hdu@apache.org
(cherry picked from commit 40b2ffbb1036c2f2db50965525009213d8fd6343)

Conflicts:
	accessibility/source/extended/accessibleiconchoicectrl.cxx
	accessibility/source/extended/textwindowaccessibility.cxx
	accessibility/source/standard/vclxaccessiblebox.cxx
	accessibility/source/standard/vclxaccessibletoolboxitem.cxx
	automation/source/server/recorder.cxx
	automation/source/server/statemnt.cxx
	avmedia/source/framework/mediacontrol.cxx
	avmedia/source/framework/soundhandler.cxx
	avmedia/source/gstreamer/gstplayer.cxx
	avmedia/source/viewer/mediawindow.cxx

Change-Id: I8e6d6754282634f6931a2e7f73f08f70c23d452e
2014-02-04 12:14:11 +00:00
Stephan Bergmann
bfe5448939 bool improvements
Change-Id: I09ac60e907b7c0a78934dce05343e2ba2b6df49f
2014-01-28 20:26:30 +01:00
Steve Yin
05534b5523 Resolves: #i124008# listbox entry's are selected automatically...
on mouse over instead of mouse click

(cherry picked from commit ae97dcb5b8d2dead81b007c5c71daf608f0c7bc3)

Change-Id: Ib1ce0db60785ddc96473ef4ce88b578287956164
2014-01-28 11:37:23 +00:00
Caolán McNamara
ab4b2e0b56 coverity#983594 Uncaught exception
Change-Id: Ic49f88b44216a24df8a236b755d22b2537245c5f
2014-01-28 11:29:14 +00:00
Caolán McNamara
420ca6138c coverity#706219 Uncaught exception
Change-Id: I1c2566337347679453bee46a78a4a0ecd7fdd2fb
2014-01-28 11:29:14 +00:00
Alexandre Vicenzi
4bdf9a0247 fdo#63154 Removed unused solar.h reference
Change-Id: I6b2f9e04e2232570c8bb9f36252b23a70c5f7525
Reviewed-on: https://gerrit.libreoffice.org/7604
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-01-23 09:48:42 +00:00
Norbert Thiebaud
a1a545aa98 coverity#1132668 : missing break in switch
Change-Id: Ia759081e7ccc9105898f25025ea567d900d33b13
2014-01-19 15:29:26 -06:00
Norbert Thiebaud
2a77e7a310 coverity#1158122 : Explicit null dereferenced
Change-Id: I6ffec6e69ca5ddb01998653d2f7637ed062bdc80
2014-01-19 15:14:55 -06:00
Norbert Thiebaud
8db51361dc coverity#1132662 Dereference after null check
Change-Id: Iaccf8bb7903702d2bed3c4fc2195172e18ead6c7
2014-01-19 15:11:09 -06:00
Norbert Thiebaud
9fd10cca8e coverity#1132661 Dereference after null check
Change-Id: Ida147599810b0aff4a7ebd00b90475b1c6cd1366
2014-01-19 15:07:28 -06:00
Norbert Thiebaud
014a0e5d6f coverity#1132660 Dereference after null check
Change-Id: Ib184d73f2ced3beca8540a37bab74c4a712170ba
2014-01-19 14:59:29 -06:00
Anderson Roberto
330c6cb59a fdo#57950: Remove chained appends in accessibility
Change-Id: I4ba583a891933068ab4003307d09693180c7b61f
Reviewed-on: https://gerrit.libreoffice.org/7436
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-01-15 10:47:57 +00:00
Michael Stahl
158b4df603 svtools: rename IAccessibleTableControl::dispose()
... to not confuse it with XComponent::dispose().

Change-Id: I056fdf77f9116d1c22f8ca9313a0ea313fb1c4aa
2013-12-16 16:21:09 +01:00
Michael Stahl
449e0c9c73 accessibility: don't crash if the TableControl is dead
AccessibleGridControlAccess: clear the m_pTable member in dispose() so
it is no longer accessed later.

Change-Id: I490c84ce1bee55c9c69eb29b81ddfbe808301797
2013-12-16 16:21:09 +01:00
Michael Stahl
9eccfd86ee accessibility: Mutex cleanup in AccessibleGridControl* classes
For unknown reasons this uses both SolarMutex and a OBaseMutex::m_aMutex
to lock some but not all methods, which seems odd.

- remove a third mutex AccessibleGridControl::m_aMutex that appears
  unused
- lock OBaseMutex::m_aMutex in AccessibleGridControlBase::isAlive()
  which accesses rBHelper members, which should be sufficient
- lock SolarMutex in all UNO methods
- remove misc weird stuff like TC_SolarMethodGuard

Change-Id: I8321757fb4a5043a05c23f2dc9801f5d8c8d911e
2013-12-16 16:21:08 +01:00
Takeshi Abe
526a60086c Drop duplicate #include
Change-Id: I05569ef98293445916e8f48e7f06abd795fe9bb5
2013-12-08 17:20:40 +09:00
David Ostrovsky
130833f80e fdo#39956 Delete JAB
JAB has been discontinued in favor of the native IA2 bridge.

Change-Id: I88461f73c620507d3e97b077ea2abdd2229322e1
Reviewed-on: https://gerrit.libreoffice.org/6819
Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de>
Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2013-12-05 05:31:43 -06:00
Herbert Dürr
5585c4f2bf Related: #i123768# [ia2] remove pseudo-automatic noisy comments
Change-Id: I346518267294556ce529966fe168440de05a38c6
2013-11-28 14:33:55 +00:00
Stephan Bergmann
382421189f Improve exception message
Change-Id: I06ffe3088546d55b29d61ccfae16937d8a7ce9e8
2013-11-27 09:15:14 +01:00