2933 Commits

Author SHA1 Message Date
Caolán McNamara
fdc28850c6 coverity#735667 Unchecked dynamic_cast
Change-Id: I747b6bcfb1e57fd3f21250b274f2f179e1982d7c
2014-01-27 14:38:37 +00:00
Caolán McNamara
01c28e33bf coverity#1130421 Improper use of negative value
Change-Id: Iefdd854cb0348b187b95f4a89d52482381c73dfc
2014-01-27 14:38:37 +00:00
Tsutomu Uchino
4f03eb00fc Related: #i50481# improve Select All command in Basic IDE
see also fdo#37211 i.e. commit 4bc2724240b11ce4dfb7adafbe1f1c260fa44030

(cherry picked from commit f841659faf09fec69c962959b9da032fa0bc2b16)

Conflicts:
	basctl/source/basicide/baside2.cxx
	basctl/source/basicide/baside2b.cxx
	basctl/source/basicide/baside3.cxx

Change-Id: Id679b1e16b87ec8d81fb78039318728320b9d5bc
2014-01-22 10:31:27 +00:00
Norbert Thiebaud
2ee5758e4e coverity#735600 : Division by zero
Change-Id: I67c2af62144872c4ad0ac7e17be5bb9a5883ba69
2014-01-19 15:44:21 -06:00
Norbert Thiebaud
838d0cd4f3 coverity#1000814 coverity#1000815 : Unintended sign extension
Change-Id: Ia9e40dba5ef2beca2ebc6cc40672d6804d430af0
2014-01-19 15:42:23 -06:00
Norbert Thiebaud
b4ed680ebe coverity#735599 : Division by zero
Change-Id: I1a69224793eb39d88894e1090672bdb641c88a02
2014-01-19 15:36:06 -06:00
Norbert Thiebaud
3c2f3f4854 coverity#735598 : Division by zero
Change-Id: I288b46a933d8a301823deed8fccae9764b74e840
2014-01-19 15:22:19 -06:00
Stephan Bergmann
602c87b425 Window::PreNotify should return bool
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-18 00:37:49 +01:00
Stephan Bergmann
5c3eca5e84 bool improvements
Change-Id: Ia5ab74b8a8b367ea92f29eb6269ef0ede47f09bb
2014-01-17 18:45:13 +01:00
Stephan Bergmann
04683f1488 Window::Notify should return bool
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17 16:42:29 +01:00
Stephan Bergmann
ad1390b8c2 Remove use of deprecated css::document::XEventBroadcaster/Listener
Change-Id: I178ae590fec87f53e90db5aa6e560cd146c0676b
2014-01-17 11:38:18 +01:00
Stephan Bergmann
62951cdd17 Introduce com.sun.star.frame.theGlobalEventBroadcaster singleton
...to supersede com.sun.star.frame.GlobalEventBroadcaster single-instance
service.

Change-Id: I74ecaadadb4c600d39979aa7c13b6389bed38fd7
2014-01-16 18:40:05 +01:00
Stephan Bergmann
7c1415e06f Remove unused bForBrowsing parameter
Change-Id: I32b458390130e9ed83af0831069329ac8f672d67
2014-01-14 11:21:10 +01:00
Stephan Bergmann
0d0fd7b4fb PrepareClose should probably return bool
Change-Id: Ie62a6c1197594102bc68e246ae6059a9442ce314
2014-01-14 09:31:58 +01:00
Stephan Bergmann
01f3186c4b SvTreeListBox::ExpandingHdl should return bool
Change-Id: I39a854910299ab2e7c64beabda381bb9f0bd2891
2014-01-13 18:08:07 +01:00
Caolán McNamara
1b7a5c634a disentangle CalcSize
Change-Id: I42248ff611dbe7c109076da5d548717898341be3
2014-01-13 09:50:11 +00:00
Stephan Bergmann
d1043892df SfxPoolItem::operator ==, != should return bool
...and SfxEnumItemInterface::HasBoolValue, too.

Change-Id: Ia032e3d35a4c3b4c1efdc515ca36e466be03fc0a
2014-01-10 17:11:51 +01:00
Caolán McNamara
ea89ba42e2 convert module and dialog tabpages to .ui
Change-Id: I2954a734b44be22d4d7ffae17480dde1c0ac64e7
2014-01-06 11:46:14 +00:00
Caolán McNamara
8c51c5fa11 basctl::CheckBox all loaded from .ui now, drop resid ctor
Change-Id: Ie11fdcea9d307518cabfa519ddccc65997250519
2014-01-06 11:46:13 +00:00
Caolán McNamara
6fd47306eb convert lib page to .ui
Change-Id: Idd9e3c1ab1c63baa11f503c20d46f3d13e6f78a3
2014-01-06 10:08:40 +00:00
Caolán McNamara
75137e6e9f convert default language dialog to .ui
Change-Id: Ia4d5b983168d6645fce8e2549db2b6c3fd410690
2014-01-03 21:27:09 +00:00
Caolán McNamara
3aa3551ed7 add some borders here
Change-Id: Ica1f2872759366120b9329f168f18788a8e239b3
2014-01-03 21:27:09 +00:00
Caolán McNamara
6fd7f5b1c9 convert import library dialog to .ui
Change-Id: Iaedcbeb5618ece65692a9688ccb5c13aad1e6626
2014-01-03 14:55:42 +00:00
Caolán McNamara
f9aab8ff0e Convert break point dialog to .ui format
Change-Id: I750133b673e135399ab9c04953550bea1db3a9e8
2014-01-02 21:33:56 +00:00
Caolán McNamara
257d1f4ff3 allow simple MessageDialogs to be created from just message strings
Change-Id: I9f8324d1c61bd55ccc78e67699ebdfa946e48af6
2014-01-02 13:15:07 +00:00
Caolán McNamara
9210cde1ea const this up
Change-Id: Id4b832b04368627a7df243c881ac203d1d2a0140
2014-01-01 18:24:07 +00:00
Caolán McNamara
8c5f5aab2e convert export basic dialog to .ui (600th .ui conversion)
Change-Id: I67511e69f763761cd1631263fccd0704daf1886b
2013-12-31 21:34:07 +00:00
Caolán McNamara
79c1b86e20 MessageDialog isn't ready for this usage just yet
Change-Id: If6c886ac4115dd0a030660fd0147491815fa411a
2013-12-31 21:34:06 +00:00
Caolán McNamara
40c6f8362c convert new lib dialog to .ui
and a drive-by on some no .src InfoBox and ErrorBoxes to MessageDialog

Change-Id: Ideb58a0042ed45a49bff9b336622dfe11bb363ab
2013-12-31 21:11:46 +00:00
Caolán McNamara
978172bb00 don't access beyond end of empty string
Change-Id: Ie772d7a60fd65b93ca66c543eb2786ce7f109004
2013-12-31 20:49:12 +00:00
Caolán McNamara
ec6050497a convert goto line dialog to .ui
Change-Id: I4c4ec4f2169d001e6f09c9c7bb06a4b0b327a2f8
2013-12-31 20:28:16 +00:00
Julien Nabet
203fbb1605 cppcheck: fix var reassigned
Change-Id: I9db36a231ea846929f8860d089d77d0126242c26
2013-12-27 15:02:32 +01:00
Caolán McNamara
2544a2a810 convert organize macros dialog to .ui
Change-Id: I210ab0bb294ddfefc3f60cffe64b72e5d8fa4650
2013-12-24 09:49:40 +00:00
Andras Timar
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
Stephan Bergmann
075a0b30c8 No need for DlgEdObj::supportsService to be virtual
Change-Id: Ib324adb4bc894f16c051fe956c25e37b0502006c
2013-12-18 14:14:53 +01:00
Norbert Thiebaud
4c539fac01 vcl get rid of xub_StrLen and STRING_LEN in outdev3
a new log section (sal.rtl.xub) is used to display alert in case of
suspicious len == 0xFFFF (aka STRING_LEN)

Change-Id: I3ed2aa7896e12592be9e003580dd6c8eda4add5e
Reviewed-on: https://gerrit.libreoffice.org/7117
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-12-18 01:54:16 +00:00
Stephan Bergmann
9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..."
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
Bjoern Michaelsen
78c7eb3507 uiconfig is a l10n-relevant target
Change-Id: I8a2ca73c02fd6b04ce60e7701c51d2362ef7ec06
2013-12-16 17:36:26 +01:00
Stephan Bergmann
07ab0d43b5 Get rid of DECLARE_STL_VECTOR
Change-Id: If4588034fc09e4663b5217669c71f26c0a3b8c8a
2013-12-06 08:04:23 +01:00
Stephan Bergmann
0c55303581 Get rid of DECLARE_STL_STDKEY_SET
Change-Id: I4817694d183d525fa5a29eb9693a20d491549e5d
2013-12-05 18:36:21 +01:00
Stephan Bergmann
0ee2cddfbd Properly encapsulate svt::TextWindowPeer
Change-Id: Iffa67c345a03852ad7872031b4c5a87e223ffcad
2013-11-27 11:35:24 +01:00
Noel Grandin
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
Bjoern Michaelsen
04dead1c6b make l10n buildable separately
- this renames the 'almost' module target to non-l10n
- and adds a l10n target which is intended to only build l10n parts of
  the product
- packagers should then be able to build l10n and non-l10n parts of the
  product independently, thus:
   - enable quicker rebuilds
   - distribution of load
   - updates to l10n without a full rebuild
   - security fixes to binaries without rebuilding all l10n
- the new targets are called build-l10n-only and build-non-l10n-only
- note this is not intended to move a concept of split packages
  upstream -- while this exsists in distros, the number of test
  scenarios for this would explode upstream

Change-Id: Ib8ccc9bc52718d9b0ebbfee76ad93dc29c260863

Conflicts:
	filter/Module_filter.mk
2013-11-14 16:45:02 +01:00
Noel Grandin
d366c9b20e remove unnecessary sal_Unicode casts in various places
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-14 08:17:32 +02:00
Norbert Thiebaud
cde4fdb2d0 basctl: include <> for external includes
Change-Id: I1897c587c02c5b50e6e8a7bf70467233be871878
2013-11-11 22:37:25 -06:00
Ivan Timofeev
560b276136 fdo#71306: fix printing from basic ide
regression from e13a3d566ecc34a46e037aca1b2d70e58501e422

Change-Id: I0d734e112038746aa48df669d4b82b644a95c220
2013-11-08 13:02:21 +04:00
Noel Grandin
5285beeaa4 remove redundant calls to OUString constructor in if expression
Convert code like:
  if( aStr == OUString("xxxx") )
to this:
  if( aStr == "xxxx" )

Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04 10:11:08 +02:00
Noel Grandin
0e6a2601b3 Convert code that calls OUString::getStr()[] to use the [] operator
This also means that this code now gets bounds checked in debug builds.

Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-04 08:06:10 +02:00
Noel Grandin
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-31 08:34:21 +02:00
Stephan Bergmann
176ac1e616 Remove unnecessary SyntaxHighlighter::Tokenizer statefulness
...which reveals that SyntaxHighlighter::notifyChange does nothing, so remove it.

Change-Id: I49834af29081ee703d9e62e182e3c1f8ce7e212e
2013-10-28 13:48:14 +01:00