mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
403,714 Commits 1 Branch 0 Tags
Commit Graph

1738 Commits

Author SHA1 Message Date
Michael Stahl
d01f7db4b5 canvas: replace BOOST_CURRENT_FUNCTION with __func__ 
Change-Id: I384472894288081423ae9467cc439b10d637f6e0
 2016-01-28 10:10:27 +01:00
Noel Grandin
90d892664a loplugin: unused return values 
Change-Id: I4eb1f0c9245c04058fd5e47046f043f8840a79c7
Reviewed-on: https://gerrit.libreoffice.org/21628
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-21 07:18:38 +00:00
Chris Sherlock
28c96fc255 vcl: rename Font::GetName to Font::GetFamilyName 
Change-Id: Ie20871a3078bf875c1782b7761d60591a9c9704f
Reviewed-on: https://gerrit.libreoffice.org/21529
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-01-17 23:35:37 +00:00
Norbert Thiebaud
45654a1d4d revert vcl patch series that brok Mac and Windows 
revert:
9bc2f3de8672e812f3a67541c6d7069b434a7e42
 vcl: add comment about ImplFontMetric::{Get|Set}LineHeight()
26371f105bc44e04469ec03fc5bb12505e651c6b
 vcl: FontAttributes::GetSlantType() -> FontAttributes::GetItalic()
2dd0b4317372b8022efe3911b38b4fa02956d8b9
 vcl: font.hxx and metric.hxx cleanup, make ctors explicit and the dtor virtual
5ab13bf3ead3539e4ad847656da81e7eb6029652
 vcl: tabify font.hxx
f99550dae55e40e49bf9c9875053fe2abb4c71ca
 vcl: change Font::SetName() to Font::SetFamilyName()
2b297116cb6bb1061c43e5714e2609c8ee9f57d2
 vcl: rename Font::GetName to Font::GetFamilyName

Change-Id: I23f38921187d66b970ca815eb30dda4222a2da62
 2016-01-16 12:20:45 -06:00
Chris Sherlock
2b297116cb vcl: rename Font::GetName to Font::GetFamilyName 
Change-Id: I83927e0992dfe0a2a79d139818a9f45d3761aae5
Reviewed-on: https://gerrit.libreoffice.org/21509
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-01-16 16:11:28 +00:00
Chris Sherlock
08bbdaa2f9 vcl: Create accessor and mutator for int and ext leading in FontMetric 
Accessor and mutator created for external and internal leading space in
FontMetric.

See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor
and mutator for font scaling in FontMetric") for reasoning behind
patch.

Unit tests
- check to ensure that can set external and leading space
- check equality operator on FontMetric after setting both external
  and internal leading space
- enhanced tests to also check the inequality operator

Change-Id: I973970dd0b0631c5eca3e89039dce57ac3a3eb63
Reviewed-on: https://gerrit.libreoffice.org/21454
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-01-13 19:50:18 +00:00
Julien Nabet
4af3fd71eb Remove useless extra var for loop 
Take benefit of returned iterator from erase method

Change-Id: I77eaa5b4500cfc66ae66e5f388915e0ade79b23c
Reviewed-on: https://gerrit.libreoffice.org/21239
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2016-01-08 06:06:28 +00:00
Caolán McNamara
5ee8e22a26 cppcheck: noExplicitConstructor 
Change-Id: I94db78ca12e0f3389f00ea5c557f0b64d452f613
Reviewed-on: https://gerrit.libreoffice.org/21150
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-01-07 09:11:53 +00:00
Andrzej Hunt
9d0b06e9f7 new loplugin rangedforcopy - use reference in range based for 
Inspired by 6e6ae9803796b120e95f6e89575e03c5fd0ed3c2

Change-Id: Ia0f264d3a6bbf076aa5080e3398683e50bc6ef01
Reviewed-on: https://gerrit.libreoffice.org/20190
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-01-05 11:06:52 +00:00
Andrea Gelmini
92e60e1b80 Fix typos 
Change-Id: I1b79005d9c4e32325b8dadcc4f805975d6bf2727
Reviewed-on: https://gerrit.libreoffice.org/21103
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
 2016-01-05 07:32:28 +00:00
Caolán McNamara
f22d153a07 Resolves: tdf#93703 0 scaling is CAIRO_STATUS_INVALID_MATRIX 
so more drawing to the surface fails

prior to 4ac876084bb89b6460b31e090a666b395f66b1e8 we had
a new cairo context each time to the error was thrown away
along with the context and the new one would work

Change-Id: I90ab1a943e8908e87f391bdfb8ccd5f3818e13d5
 2015-12-21 21:24:27 +00:00
Noel Grandin
7f8c4b8445 Use comphelper::containerToSequence() 
Change-Id: I18d6ef04ff00f971a4c54ba259733c07501c6c1a
 2015-12-03 13:57:22 +02:00
Stephan Bergmann
a6aa29db42 Remove unused FMT_R8G8B8 
...since 5b4d4af3e8bc3b5fb07bceecefc2a47d8e4b8b18 "bin agg"

Change-Id: If86d294f812a670917b181f3bd140883ad2df71d
Reviewed-on: https://gerrit.libreoffice.org/20348
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2015-12-02 07:48:42 +00:00
Stephan Bergmann
8fa059fe65 C++17 nested namespace definition 
Change-Id: I49fd2093d619743d0d5aaaa4784bd5ef5bb330c6
 2015-11-28 08:44:43 +01:00
Stephan Bergmann
e54e5ee959 Unused forward decl 
Change-Id: Id332cdff634be042e026faf7cc75d8eaeb44a13e
 2015-11-28 08:44:42 +01:00
Stephan Bergmann
675fbe9e2d -Werror,-Wunused-function 
Change-Id: Ic238339b521dbff2d7fbe899127ac7954036300f
 2015-11-28 08:44:42 +01:00
Stephan Bergmann
85453425a8 -Werror,-Wunused-private-field 
Change-Id: Ie14d3b3474b7886add80bd6e223e76fbf964144e
 2015-11-28 08:44:42 +01:00
Stephan Bergmann
6694e10a23 -Werror,-Wreorder 
Change-Id: I27eb5c497985267dd00b5be2fb3c17f8d79745cf
 2015-11-28 08:44:41 +01:00
Stephan Bergmann
6adbf1322b -Werror,-Wreorder 
Change-Id: I0a3384505d8ab7fe70c0dccb93a96d9d3e991367
 2015-11-28 08:44:41 +01:00
Stephan Bergmann
df077447ee -Werror,-Wunused-function 
Change-Id: I99246a9de5f266154f9927bff322a0a1697bcdee
 2015-11-28 08:44:41 +01:00
Stephan Bergmann
1145de8660 -Werror,-Winconsistent-missing-override 
Change-Id: I41d1e0d5e6263255426efb011c7b4bb5ae6775b5
 2015-11-28 08:44:41 +01:00
Noel Grandin
3d8a01b0c8 expression result unused [-Werror,-Wunused-value] 
Change-Id: I57b44c1997ac286fcb4caf8e3027e3b5996fc377
 2015-11-26 09:17:21 +02:00
Noel Grandin
1f86864e97 loplugin:unusedfields various 
Change-Id: I59d9f7f73677358b4ae57efda965d43718bdf0d5
 2015-11-25 13:57:29 +02:00
Caolán McNamara
b639fe60ea VirtualDevices either match another device depth, or are 1 bit 
cairo can therefore always render to a svp virtual device with
need for a fallback

Change-Id: I5d03ae541820389e26f7448444444be009fb28a4
 2015-11-23 14:25:59 +00:00
Caolán McNamara
c43a3a5867 establish that Virtual Devices either match Physical Device depth or ... 
are 1 or (rarely) 8 bit and lock that down.

Change-Id: I3d946ebef34ffb71c5adea7aa420af50e9584e05
 2015-11-23 14:25:59 +00:00
Stephan Bergmann
8f7025b50f Adapt Windows-only code 
...to b8793748b0eaaa3fe405587fcb2a3021adab833b "Seems more natural to pass a
homogenous list by initializer_list"

Change-Id: I1c6816a442b57572a307251de1de5652a9d2a63a
 2015-11-20 16:28:27 +01:00
Noel Grandin
ce6170dafe loplugin:unusedfields in canvas 
Change-Id: Ic532ebf1f929044d72ee3abca29c8275cbe837ac
Reviewed-on: https://gerrit.libreoffice.org/20078
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-20 13:25:18 +00:00
Stephan Bergmann
b8793748b0 Seems more natural to pass a homogenous list by initializer_list 
...than by template parameter pack (even if that requires using ServiceDecl*, as
initializer_list cannot take reference types)

Change-Id: Ia986201b52d8daedfe925f132ebc79bc2c0ba378
 2015-11-20 13:39:52 +01:00
Stephan Bergmann
ab9add5c96 loplugin:sallogareas 
Change-Id: Ib1f06cb5f925535858bc14aab6f59ad7fd2a3a8d
 2015-11-20 10:14:49 +01:00
Noel Grandin
54d22957bc use initialiser for Sequence<OUString> 
performed using:
git grep -lP 'Sequence.*OUString.*\(1\)'
| xargs perl -0777 -pi -e
  "s/Sequence<OUString> (\w+)\(1\);
.*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g"

Change-Id: I4da56c80fa09bfc1e8f868794001e9921431e09f
Reviewed-on: https://gerrit.libreoffice.org/19968
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 11:31:23 +00:00
Noel Grandin
8e234c5b7d use initialiser syntax for Sequence<OUString> 
replaced using the script:

git grep -lP 'Sequence.*OUString.*\(1\)'
  | xargs perl -0777 -pi
    -e "s/Sequence< OUString > (\w+)\(1\);
.*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g"

Change-Id: I23688a91562051a8eed11fc2a85599545c285c34
Reviewed-on: https://gerrit.libreoffice.org/19967
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 10:13:08 +00:00
Ashod Nakashian
1a494d9a00 Windows header sanitization 
Isolation of windows headers using prewin.h
and postwin.h headers and making headers
dependent on them more self contained.

Conversion of TCHAR to WCHAR and
LPCTSTR to LPCWSTR etc. and cleanup
of unnecessary casts.

Change-Id: I7eff5c477d9223a064bfb4d962ff6d61960ee69c
Reviewed-on: https://gerrit.libreoffice.org/19901
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-11-12 10:55:41 +00:00
Tor Lillqvist
a0b9baab6d Bin mesa_headers completely 
We don't need them in a MSVC or OS X compilation either.

Change-Id: I00181fe0a047df09bbdfcce34c07eb2ebc45a2da
 2015-11-12 07:10:30 +02:00
Tor Lillqvist
b216cc1b80 Avoid mesa_headers on X11, also link with -lGL only where necesssary 
The GLEW headers are enough, and what we actually use in these
places. In addition to handling GL extension things in its dynamic
fashion, GLEW headers also have declarations for standard,
non-extension, OpenGL API, including xgl and wgl ones.

Most likely we don't need mesa_headers on Windows or OS X either, and
can drop them completely.

Change-Id: Ic0d8d6238c862f8fe4a74e99e95344dcbf540980
 2015-11-12 01:30:08 +02:00
Stephan Bergmann
c40c7a8c36 loplugin:nullptr (automatic rewrite) 
Change-Id: I9e064592c4ee18a600aadfa20b3c89ecafc818d4
 2015-11-10 10:31:18 +01:00
Stephan Bergmann
a51f37d023 loplugin:stringconstant: elide explicit ctor usage (automatic rewrite) 
Change-Id: I72cad7217bdfc2a1f3339c604ea4dc55ff661e2a
 2015-11-06 09:34:45 +01:00
Mario J. Rugiero
ae78051c22 Replaced boost::bind by std::bind in canvas/source/opengl/ogl_canvashelper.cxx 
Chose not to use lambdas instead because the number of arguments in these calls
would have made it way too verbose, hurting readability.

Change-Id: I8662a937ec10ca0fac6cd7e0d78b6268e8023ada
Reviewed-on: https://gerrit.libreoffice.org/19707
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
 2015-11-02 18:21:45 +00:00
Thorsten Behrens
368b657f4b Partial revert 'for_each -> range-based' 
There was a subtle change in semantics, the earlier loop was only
iterating until aEnd, covering only unique elements of the vector.

This partially reverts commit c04fd82433e9155ad61ebd92ca7b43a729a87890

Change-Id: I75c5f1b343c3fa8855f6d7f8f706b9259bc9f6df
 2015-11-02 13:45:45 +01:00
Mario J. Rugiero
707f416192 boost::bind -> lambdas in canvas/source/simplecanvas/simplecanvasimpl.cxx 
Change-Id: If768595d3c3ec294d5a59ad42f26aacfd6e0fda3
Reviewed-on: https://gerrit.libreoffice.org/19708
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-01 15:28:41 +00:00
Mario J. Rugiero
ce69d6e9e1 boost::bind -> lambdas in canvas/source/vcl subtree 
Change-Id: I2b2e746197b94222c73b78379d64086adfb5e693
Reviewed-on: https://gerrit.libreoffice.org/19712
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-01 11:31:21 +00:00
Mario J. Rugiero
d841b44243 std::for_each -> range based for in canvas/source/tools/verifyinput.cxx 
Change-Id: I71c714a459ea81a268f93f8ffc5286eb532794ca
Reviewed-on: https://gerrit.libreoffice.org/19711
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-01 11:30:15 +00:00
Mario J. Rugiero
c04fd82433 for_each -> range-based for in canvas/source/tools/spriteredrawmanager.cxx 
Change-Id: Ibe089e53488a9ba6baded637b17a1aeee0908f79
Reviewed-on: https://gerrit.libreoffice.org/19709
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-01 11:29:31 +00:00
Mario J. Rugiero
1bd101d91d boost::bind -> lambdas in canvas/source/tools/surface.cxx 
Change-Id: I9a9c4832cf18b10e15d2a4de8944b404b082e990
Reviewed-on: https://gerrit.libreoffice.org/19710
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-01 11:28:33 +00:00
Mario J. Rugiero
bd332c2a33 Replace boost::bind by lambdas in canvas/source/directx tree. 
Change-Id: I1622f563b921a03234b9cb02de7c8abd00444129
Reviewed-on: https://gerrit.libreoffice.org/19703
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-31 12:53:08 +00:00
Ryan McCoskrie
d77af785f9 tdf#93684 - Remove SalFrame::Sync 
Change-Id: Icae9cf0a17f9cdf9a671c7e7278019d6980602b1
Reviewed-on: https://gerrit.libreoffice.org/18453
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2015-10-30 20:07:19 +00:00
Tor Lillqvist
f96508f323 tdf#92272: We need to twiddle the bytes from BGR to RGB 
As far as I see, the surfaces created in the DX canvas are of
D3DFMT_A8R8G8B8 or D3DFMT_X8R8G8B8 format, which means that the bytes
(in memory order, on little-endian Windows) are B,G,R,A/X. So if the
desired destination wants R,G,B,A, we need to swap the blue and red
bytes.

Let's hope this doesn't break anything else...

Change-Id: I1b90d2cf95418f6557cac633ec6fce27599e8a61
 2015-10-30 19:30:20 +02:00
Noel Grandin
3bc5df7f32 UNO: no need to use OUString constructor when calling createInstance 
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526
Reviewed-on: https://gerrit.libreoffice.org/19682
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-30 08:59:59 +00:00
Noel Grandin
065c8b48a6 use uno::Reference::set method instead of assignment 
Change-Id: I58410209f32f988f258a588364e0b037c2790211
 2015-10-30 08:10:22 +02:00
Noel Grandin
c7e8f21a53 loplugin:unusedmethods 
Change-Id: Id3b5cd75d4357336ed592ef11a3f34d209f8e95f
Reviewed-on: https://gerrit.libreoffice.org/19636
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-30 05:58:41 +00:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00