6729 Commits

Author SHA1 Message Date
Caolán McNamara
a860df25dd masses of MessBoxes not being disposed promptly
since...

commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f
Date:   Thu May 28 21:35:43 2015 +0100

    tdf#91702 - fix stack-based MessBox allocation.

There is no special ScopedVclPtr<X>::Create or
ScopedVclPtrInstance<X>::Create just
VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo
doesn't call dispose on the owned X

Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-26 11:26:52 +01:00
Noel Grandin
938821fb08 new loplugin overrideparam
verify that parameters on override methods have the same set of default
values for their params as their parent/super-methods do.

Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2
Reviewed-on: https://gerrit.libreoffice.org/27437
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-25 06:09:17 +00:00
Michael Stahl
580ed47cf7 chart2: missing header <iterator> reportedly breaks MSVC2015
Change-Id: I09b5a292e38044f14cd033a05e459cc69197de57
2016-07-22 19:33:26 +02:00
Noel Grandin
36313d93ac improve unnecessaryoverride plugin
to ignore ImplicitCastExpr when calling superclass method

Change-Id: I76a3068446acfee85aa1baeb216e57f63c7099c1
Reviewed-on: https://gerrit.libreoffice.org/27279
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-19 05:39:46 +00:00
Stephan Bergmann
8babcb7e66 loplugin:staticcall
Change-Id: I4ec0585bec93c7bc79a31c699df7d68b955eef56
2016-07-17 21:58:35 +02:00
Stephan Bergmann
8569cf1d91 loplugin:passstuffbyref
Change-Id: I0114bd98b92b9810d7d829ddce8461a2844e0506
2016-07-17 21:57:33 +02:00
krishna keshav
bd9644249d tdf#100913 Remove tOID typedefs in ObjectHierarchy class
Replace use of toID with ObjectIdentifier in 'ObjectIdentifier.hxx'.

Change-Id: Ic0157974eca2992167319f7d19a0224056cc985e
Reviewed-on: https://gerrit.libreoffice.org/27243
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-17 12:20:42 +00:00
Markus Mohrhard
d2b2278aab uitest: provide wrapper for chart objects
This allows now to operate on chart objects and call commands on them.

Change-Id: I399b275c563deb507aaf4f3f49373871e733af91
2016-07-16 18:27:14 +02:00
Markus Mohrhard
a980b6c8ae no need for this temporary OString
Change-Id: I8b5d69f7e64a83e52a41c285f5ef186a666ccd55
2016-07-16 18:27:14 +02:00
Markus Mohrhard
8781dbe099 uitest: provide all the children for charts
This now also includes legend entries and data points.

Change-Id: I0e4d1f21a20035cd632a7755dbbea17baec4b083
2016-07-16 18:27:13 +02:00
Markus Mohrhard
0f03a80131 uitest: some initial work on the chart selection
Change-Id: I3317eba5383206de6f619da548ee3047861eef07
2016-07-16 18:27:13 +02:00
Markus Mohrhard
b1e1b38349 uitest: add initial support for selecting chart elements
Change-Id: I3af11d44067618b5188f3dbf4abccc171dd98d0c
2016-07-16 18:27:13 +02:00
Noel Grandin
6e72f0251b new loplugin unnecessary override
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb
Reviewed-on: https://gerrit.libreoffice.org/27135
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-15 14:05:41 +00:00
Jochen Nitschke
800a196718 chart2: avoid use of realloc
by using ctor initializer list, removing redundant realloc
and other small tweaks

Change-Id: I73775ef3677244de5c04e8743c43228d6cb3b008
Reviewed-on: https://gerrit.libreoffice.org/27174
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-14 02:00:00 +00:00
Jochen Nitschke
176d54fa5d chart2: inline local macros
make use of Sequence initializer_list constructor
and use makeAny to simplify further.
removed unused includes

Change-Id: I7d5b901a8bb375533c8ab945632dc8668806ca1a
Reviewed-on: https://gerrit.libreoffice.org/27173
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-13 13:07:49 +00:00
Jochen Nitschke
194d4a02b9 chart2: remove unused ContainerHelper.hxx includes
remove using namespace :💹:ContainerHelper;
to match other uses

Change-Id: I343086a6b7d70c84499b209680973431c7317219
Reviewed-on: https://gerrit.libreoffice.org/27184
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jenkins <ci@libreoffice.org>
2016-07-13 12:58:55 +00:00
Noel Grandin
cba5a9223a no need to create temporary OUString for comparison
Change-Id: I0a321e8ffbe379588a288084ec2e74e1a8c296b2
Reviewed-on: https://gerrit.libreoffice.org/27171
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-13 08:20:40 +00:00
Jochen Nitschke
5ce65d04fd chart2: cleanup local var assignments
and remove comments about a gcc 3.3 workaround.
some comments went obsolete with other commits
like 367105e0248c7b80b60b2554d04f5f248b4259b3

Change-Id: I15fff464e2f71a6ade29c141bb17216770f54ced
Reviewed-on: https://gerrit.libreoffice.org/27127
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-13 07:26:45 +00:00
Stephan Bergmann
cd1e2f5cc3 Avoid global data with (non-constexpr) ctors/dtors
Change-Id: I787ec685275d119dd4eea86f51b6dd85bc0260d1
2016-07-12 09:43:56 +02:00
Jochen Nitschke
43bc09d6dd chart2: make m_aEntryMap a non member constant
Change-Id: Ic45ba10808ea2ce6bc6520bb4222cd8b3ebd8ea6
Reviewed-on: https://gerrit.libreoffice.org/27098
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-12 06:31:08 +00:00
Eike Rathke
6d4f2dcc7c Resolves: tdf#100452 class Date full (BCE,CE) proleptic Gregorian calendar
... implementing signed years with year 0 gap.
Date(31,12,-1) last day BCE
Date(1,1,1) first day CE

New class Date member functions:
* AddYears(sal_Int16) to be used instead of
  aDate.SetYear(aDate.GetYear()+sal_Int16) to handle year 0 gap.
* convenience GetNextYear() to be used insted of GetYear()+1
* convenience GetPrevYear() to be used insted of GetYear()-1
* AddMonths(sal_Int32)
* operator=(const css::util::Date&)

New class DateTime member functions:
* operator=(const css::util::DateTime&)

Made some conversion ctors explicit, specifically Date(sal_Int32)

Adapted hopefully all places that used a sal_uInt16 year to use
sal_Int16 where appropriate.

Eliminated some quirks in date handling found on the fly.

Added era handling to i18npool icu calendar setting interface, which
missing was responsible for 0001-01-01 entered in Calc being set as
-0001-01-01, hence subtracting one day resulted in -0002-12-31.

Change-Id: I77b39fba9599ebd5067d7864f6c9ebe01f6f578f
Reviewed-on: https://gerrit.libreoffice.org/27049
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
2016-07-08 20:41:02 +00:00
Stephan Bergmann
d956a5d29e loplugin:passstuffbyref also for {css::uno,rtl}::Reference
Change-Id: I5c973d41381f2bfd39e7a8cf48fd5807852bdc72
2016-07-07 18:59:55 +02:00
Noel Grandin
7001ca25ec merge LineProperties with chart::ErrorBar
Change-Id: Ic3490a15339ff981e90a86cb69c206c231db9161
Reviewed-on: https://gerrit.libreoffice.org/26932
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05 10:51:09 +00:00
Stephan Bergmann
bfff963fef clang-analyzer-deadcode.DeadStores
...after 0f17e343306fd457c542067c09242ddd04ca39e9 "loplugin:singlevalfields in
chart2"

Change-Id: I111d6a0eb5380d9559799db348deb43594f90630
2016-07-01 08:53:14 +02:00
Noel Grandin
0f17e34330 loplugin:singlevalfields in chart2
Change-Id: I8b8bf093736a191c90d765dce82b00e15bb398d6
Reviewed-on: https://gerrit.libreoffice.org/26708
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-28 08:35:03 +00:00
Szymon Kłos
1df394503f GSoC notebookbar: switching tabs depending on context
+ sfx2::sidebar::EnumContext moved to the vcl module
+ TabPage contains vector with context values
+ vcl builder reads control's contexts from the "class" mark
+ ContextTabControl shows tabs depending on context

Change-Id: I661b0d3f35d46ace2a2e8eb1d374148f0c60017d
Reviewed-on: https://gerrit.libreoffice.org/26447
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-27 17:51:56 +00:00
Vasily Melenchuk
a553fa42f3 support for ms binary format validation in chart2 module export tests
Validation is done with Microsoft Office Binary File Format Validator if it
is enabled. However binary files are failing validation, so validation is
disbled in corresponding tests.

Change-Id: I9f6ff5c3dd9e3e3c0bb37ce895e60e38a0b43e9a
Reviewed-on: https://gerrit.libreoffice.org/26510
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-06-23 02:08:58 +00:00
Markus Mohrhard
c4a6f300f5 uitest: set id for chart window
Change-Id: I443dcccf6d560c252da38a0f0c63cc48a212c127
Reviewed-on: https://gerrit.libreoffice.org/26494
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-20 02:26:45 +00:00
Stephan Bergmann
f35b1397ae Clean up uses of Any::getValue() in chart2
Change-Id: I53224053ea05c715f5e359a4c68e1ae5efbfe792
2016-06-17 08:45:28 +02:00
Jochen Nitschke
99226f343e try auto rotate tick labels only when useful tdf#99883
By default we try to fit as many tick labels as possible on an axis.
One way is (auto) rotating the labels at 45 degrees.

But rotating only works for horizontal axes with horizontal text or
vertical axes with vertical text, else rotated tick labels need more space.

Join the check for this prerequisite with isAutoStaggeringOfLabelsAllowed.

while here make isAutoStaggeringOfLabelsAllowed local
and wrap stuff in anonymous namespaces

Change-Id: I5784d0e5aa42ff90927e19d0bd2c6fed488d39f4
Reviewed-on: https://gerrit.libreoffice.org/25792
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-06-11 10:24:57 +00:00
Muhammet Kara
6786842337 Move accessibility relations to .ui files, Part 8: tdf#87026
By removing unnecessary variables/strings/function calls,
and making proper changes in the related .ui files.

Change-Id: I04244b360b4bb32ccbbe5bde4756a9166ae1fcaf
Reviewed-on: https://gerrit.libreoffice.org/26018
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-10 13:54:37 +00:00
Maxim Monastirsky
bdd67652b6 Try to get rid of svt::ContextMenuHelper
Change-Id: I7b43e417607b20c300e3c18e7da76a6173a18b7d
Reviewed-on: https://gerrit.libreoffice.org/26098
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Jenkins <ci@libreoffice.org>
2016-06-09 12:53:43 +00:00
Laurent Balland-Poirier
e420a335f7 tdf#94004 Wrap Power trendline equation
Wrap equation trendline if it is longer than chart width
Continue https://gerrit.libreoffice.org/18397/

Change-Id: If805f712a29c412a01209533842f9a6c797cbaf1
Reviewed-on: https://gerrit.libreoffice.org/25418
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-09 11:00:55 +00:00
Laurent Balland-Poirier
4d636391e3 tdf#94004 Wrap Logarithmic trendline equation
Wrap equation trendline if it is longer than chart width
Continue https://gerrit.libreoffice.org/18397/

Change-Id: Iee374e5db56178a9e87b0f462c3e7deb5e913ab8
Reviewed-on: https://gerrit.libreoffice.org/25416
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-09 10:31:35 +00:00
Laurent Balland-Poirier
9a9c778d81 tdf#94004 Wrap Exponential trendline equation
Wrap equation trendline if it is longer than chart width
Continue https://gerrit.libreoffice.org/18397/

Change-Id: I3938aaeec6c56582ecfe50dbfc54ec711f1b963d
Reviewed-on: https://gerrit.libreoffice.org/25393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-09 10:23:06 +00:00
Gleb Mishchenko
a97b392879 tdf#94698 cleanup Makefiles. Get rid of udkapi and offapi
This patch changes occurences in makefiles
from
$(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \
	udkapi \
	offapi \
))

to
$(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config))

(corrected instead of abandon, jani)

Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e
Reviewed-on: https://gerrit.libreoffice.org/23426
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-09 09:47:11 +00:00
Stephan Bergmann
4d49c9601c Let loplugin:passstuffbyref also look at fn defn not preceded by any decl
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-06-08 17:14:34 +02:00
Markus Mohrhard
78b100ec9c only init the OpenGL context if we need it
Change-Id: Ia88a1720d204b9933f1476bd703b99180e45abde
Reviewed-on: https://gerrit.libreoffice.org/26023
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-07 16:11:20 +00:00
Jochen Nitschke
738aefb51a follow up fix: initialise PointSequenceSequence directly
commit e95be04a73e977022455335d7cbf56804638f761
uses wrong ctor: Sequence( sal_Int32 len )

Change-Id: I08751c10942f705ead008155a6e7e9dcfb0a2ca9
Reviewed-on: https://gerrit.libreoffice.org/25945
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-06 07:11:47 +00:00
Noel Grandin
11b4a6ddce Convert DeactivePage return code to scoped enum
Change-Id: Idd5372ad20fc6676864b31b3796f8b9bc0ad73dd
Reviewed-on: https://gerrit.libreoffice.org/25918
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06 07:02:20 +00:00
Noel Grandin
9f138ffe9d remove unused constants in HRC files
Change-Id: Ia034fb16ce75caeb69fd746d4a602cd5fcfef6d1
Reviewed-on: https://gerrit.libreoffice.org/25817
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06 07:01:43 +00:00
Jochen Nitschke
e95be04a73 initialise PointSequenceSequence directly
this list initialisation is short enough
to remove the local helper function

Change-Id: I17fab47e51fc0b1a0aa0462d517d7861f8a278e0
Reviewed-on: https://gerrit.libreoffice.org/25884
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-06-04 07:41:42 +00:00
Muhammet Kara
3498fd9fe9 Remove SetAccessibleRelationLabeledBy calls tdf#87026
And make proper changes in the related .ui files

Change-Id: Iea998b6de25831c08950a8afa725713288113bfa
Reviewed-on: https://gerrit.libreoffice.org/25807
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-02 10:36:59 +00:00
Jochen Nitschke
4ca9e85538 replace simple macros in chart2
with static constantants or a named value (enum)

Change-Id: I8ef21bc3b9797ed9319e790fc12241d59f07b88c
Reviewed-on: https://gerrit.libreoffice.org/25760
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-02 07:31:39 +00:00
Jochen Nitschke
ef3585340e remove ENABLE_GL3D_BARCHART define
enabled since commit dfb2ab0cee2ba04ce8816580447e7db8160ffac4

Change-Id: Ib260ff1ce4089ecf4778114d249d59af67c94c2c
Reviewed-on: https://gerrit.libreoffice.org/25759
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-02 07:29:05 +00:00
Noel Grandin
850a8d27ca Convert GRAPHIC to scoped enum
Change-Id: I1fd09a729cbda00f99841532e0dd3fa66bce7bea
Reviewed-on: https://gerrit.libreoffice.org/25534
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-27 12:59:23 +00:00
Tor Lillqvist
5e91e48a15 Typo fix
Change-Id: Ibf279e723c11a4a5f62ce082938e723a46e40f6d
2016-05-27 15:01:47 +03:00
Noel Grandin
9eb2e683ab tdf#34465 remove calls to SfxItemSet::Put(const SfxPoolItem&, sal_uInt16)
and put an assert in SfxPoolItem::SetWhich() so nothing new
creeps in.

Change-Id: I6497650fa61ffb2b6941ffff2d471c8f117be1df
Reviewed-on: https://gerrit.libreoffice.org/24324
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-27 07:21:45 +00:00
Andrea Gelmini
2af018e4dd Fix typos
Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266
Reviewed-on: https://gerrit.libreoffice.org/25420
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25 09:50:55 +00:00
Laurent Balland-Poirier
033b2ae877 tdf#94004 Trendline: wrap equation to fit in chart area
If equation is too long compared to chart width:
  equation is wrapped
  and if equation has General format, the number of digits is reduced

In this patch, only polynomial equation is treated. If this approach is ok,
I will extend to other regression curves.

Conflicts:
	chart2/source/view/charttypes/VSeriesPlotter.cxx

Change-Id: I1bfd897881d752655faec6df034c0dde7f78c51b
Reviewed-on: https://gerrit.libreoffice.org/18397
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-22 19:12:07 +00:00