mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
403,714 Commits 1 Branch 0 Tags
12b2803f196b897ffb901b0eebe271c5ee43d03e
Commit Graph

1623 Commits

Author SHA1 Message Date
Stephan Bergmann
6dce9c6757 Add missing #includes 
...and remove some unncessary using directives/declarations, in preparation of
removing now-unnecessary #includes from cppumaker-generated files, post
e57ca02849 "Remove dynamic exception
specifications".

Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
 2017-02-06 17:21:16 +01:00
Noel Grandin
8a16f665b1 makeAny->Any in canvas..configmgr 
Change-Id: Id06812595f373cd0da8b421dbac34a60a266ae6e
Reviewed-on: https://gerrit.libreoffice.org/33869
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-03 10:44:01 +00:00
Noel Grandin
c0f9bdd3e6 unnecessary use of OUStringBuffer in throwing exceptions 
Change-Id: Iec1473264426f19c31e72260dfce9494389e474f
Reviewed-on: https://gerrit.libreoffice.org/33788
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-02 07:48:21 +00:00
Noel Grandin
f1d83ac45f loplugin:stringconstant check for unnecessary OUString constructor.. 
..calls when creating exceptions

Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe
Reviewed-on: https://gerrit.libreoffice.org/33617
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-01-28 09:22:55 +00:00
Samuel Mehrbrodt
3aae650d0f User profile backups: Don't backup user galleries 
As suggested in
https://lists.freedesktop.org/archives/libreoffice/2017-January/076768.html

Change-Id: I2562064ae906eb8b2d507ec971762625692a4bbf
Reviewed-on: https://gerrit.libreoffice.org/33608
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2017-01-27 11:22:14 +00:00
Stephan Bergmann
e57ca02849 Remove dynamic exception specifications 
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-01-26 12:54:43 +00:00
Pranav Kant
75d8b305bb lok: New feature flag to turn off tiled annotations 
Change-Id: Ie418642242ada98d4a41f30bb6cefcd57f398ef0
Reviewed-on: https://gerrit.libreoffice.org/33472
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
 2017-01-23 19:32:03 +00:00
Noel Grandin
a90a4810ae loplugin: unnecessary destructor: comphelper..desktop 
Change-Id: I9df4cb6a4b1734dac6141d6b0ee7a09e3e05f92e
Reviewed-on: https://gerrit.libreoffice.org/33453
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-01-23 16:59:48 +00:00
Noel Grandin
017911facd use rtl::Reference in OPropertyChangeListener 
instead of manual acquire/release

Change-Id: Ie80253b5a59a3e3fcd52f98d9c26bcde42fe985a
 2017-01-23 07:56:34 +02:00
Noel Grandin
f7db2b5b3f use rtl::Reference in OSelectionChangeListener 
instead of manual acquire/release

Change-Id: I33e3018b5deb4240d4aff1d8136ae6f8f538c779
 2017-01-20 12:52:45 +02:00
Noel Grandin
3bb8bdb93f use rtl::Reference in OContainerListener 
instead of manual acquire/release

Change-Id: I83e6229029e662073e2e01e98f4846fb0a0ed643
 2017-01-20 08:51:08 +02:00
Stephan Bergmann
a10b95bcc9 New loplugin:dynexcspec: Add @throws documentation, comphelper 
Change-Id: I115c5c34cf97858d9fdd96432cb57bde6d4537cb
 2017-01-19 18:03:24 +01:00
Noel Grandin
5830ef9a65 use rtl::Reference in DocPasswordRequest and SimplePasswordRequest 
Change-Id: If1bad2bc852712b8315e44480ee81f797736bb95
 2017-01-17 15:27:33 +02:00
Noel Grandin
ee2bd1ee97 use rtl::Reference in OInstanceLocker 
no need to store a raw pointer and a refcount pointer

Change-Id: I2dc3b87dd870c8d8128c2249a18fda30319ba08c
Reviewed-on: https://gerrit.libreoffice.org/33157
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-01-17 07:53:33 +00:00
Noel Grandin
f5e9c29136 use rtl::Reference in MasterPropertySet 
no need to store a raw and a smart pointer

Change-Id: Ic6b0b716812ec1dca3111f2162379c11389e963a
 2017-01-17 08:51:48 +02:00
Noel Grandin
b2a4c1e085 use rtl::Reference in ChainablePropertySet 
no need to store both a raw pointer and a smart pointer

Change-Id: If0bde337e6d9fa575a2fc7104ecffa97a8c37c31
Reviewed-on: https://gerrit.libreoffice.org/33159
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-01-17 06:37:00 +00:00
Noel Grandin
11880ef40a use rtl::Reference in AttacherAllListener_Impl 
no need to store a raw and a smart pointer field

Change-Id: Id9ce8365a413ee2dcac8e92b99768ccbb8bf7697
Reviewed-on: https://gerrit.libreoffice.org/33158
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-01-17 06:36:44 +00:00
Noel Grandin
54019e6601 new loplugin: useuniqueptr: comphelper 
Change-Id: Iafbaff60d10c9de7b57421e0c24809b08d813987
Reviewed-on: https://gerrit.libreoffice.org/33146
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-01-16 11:29:53 +00:00
Kohei Yoshida
4ae705d02d tdf#97597: Ensure that each parsing thread has its own buffer. 
Change-Id: I93077f954a49b3922930e4fc86c80228be0f4dd2
Reviewed-on: https://gerrit.libreoffice.org/33069
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
 2017-01-14 17:30:30 +00:00
Caolán McNamara
87f9e8945f default copy ctor and assignment operator are good enough 
and block default move equivalents

Change-Id: Ib8a1050803446c2e099f66602fae0465bd8165cf
 2017-01-07 21:57:03 +00:00
Huzaifa Iftikhar
5c983bc2ab tdf#70998 Change word "Graphic(s)" to "Image(s)" 
There was an error in the previous patch inside the file embeddedobjectcontainer.cxx
This is fixed in this patch.

Change-Id: I01c9e254e58e1683a8e6e9a0bcff3c4663bf32e0
Reviewed-on: https://gerrit.libreoffice.org/32353
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
 2016-12-23 18:27:05 +00:00
Noel Grandin
46d3163f77 loplugin:unusedmethods 
Change-Id: Ife4c8d948ffa116f044d43903de9485e43cfcae5
Reviewed-on: https://gerrit.libreoffice.org/32336
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-23 04:46:35 +00:00
Noel Grandin
d15b4e2045 teach sallogareas plugin to catch inconsistencies 
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a
Reviewed-on: https://gerrit.libreoffice.org/32004
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-15 06:45:14 +00:00
Noel Grandin
c3586b684c OSL_TRACE->SAL in chart2..oox 
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2
Reviewed-on: https://gerrit.libreoffice.org/31907
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-13 06:12:00 +00:00
Arnaud Versini
033ff2f9ad comphelper: cleanup class NameContainer. 
Remove useless class NameContainerImpl.

Change-Id: I3066abea69ed68d597aeecdd6b3ec7264f7ebe9c
Reviewed-on: https://gerrit.libreoffice.org/31830
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-12 12:18:28 +00:00
Noel Grandin
8228227168 convert OSL_ENSURE to assert in AccessibleEventNotifier 
and fix the places that trigger it

Change-Id: I97a04cff25ab5aa1d42c79a971d15ba742bf384e
Reviewed-on: https://gerrit.libreoffice.org/31760
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-08 17:27:05 +00:00
Stephan Bergmann
21f6405cbe This is presumably not meant to be exported 
Change-Id: Id11393c44ddd217d3def259ea5a8df9f8bb27711
 2016-12-07 22:17:56 +01:00
Samuel Mehrbrodt
4a4c4d3768 SafeModeDialog: Add option to reset bundled extension registration 
Change-Id: Ic83ada7cc76142852643cefa60b4fc9286e0756a
Reviewed-on: https://gerrit.libreoffice.org/31694
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2016-12-06 20:09:22 +00:00
Samuel Mehrbrodt
a3597a3f37 SafeModeDialog: Rename to match reality 
This doesn't remove shared&bundled extensions, but resets the registration
database from shared extensions.

Change-Id: I9f198fc7b771fd3bd31547008fd8d006a6d1b5d5
Reviewed-on: https://gerrit.libreoffice.org/31693
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2016-12-06 20:05:13 +00:00
Noel Grandin
bfde4866e0 convert DecodeMechanism to scoped enum 
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
 2016-12-05 12:49:02 +02:00
Michael Meeks
aa68c99d88 tdf#104126 - comphelper thread-pool, use reliable std::condition_variable. 
The existing osl::Condition is an API and reliability disaster area.

Change-Id: I3be84e1c6a83e58c43c40c9c8720790d923a6694
Reviewed-on: https://gerrit.libreoffice.org/31163
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2016-12-01 18:44:08 +00:00
Stephan Bergmann
d36b3bcb7e Fix race in ThreadTaskTag 
Assume T0 calls ThreadPool::pushTask twice, then ThreadPool::waitUntilDone:

T0 calls ThreadTaskTag::onTaskPushed:
  mnTasksWorking = 1, maTasksComplete.reset

T1 runs the 1st task to completion and calls ThreadTaskTag::onTaskWorkerDone:
  mnTasksWorking = 0; suspended...

T0 calls ThreadTaskTag::onTaskPushed:
  mnTaskWorking = 1, maTasksComplete.reset

T1 continues in the call to ThreadTaskTag::onTaskWorkerDone:
  ..., maTasksComplete.set

T0 calls ThreadTaskTag::waitUntilDone and immediately returns

T2 only now starts to run the 2nd task

Change-Id: Ic29101a4791fca2a1a4d54b559f10ff706e8a20d
 2016-12-01 12:35:36 +01:00
Stephan Bergmann
f8e3e523e2 Rewrite some (trivial) assignments inside if/while conditions: comphelper 
Change-Id: I8361f62199f45dbced45e5d4a4d5eeddf1c42d67
 2016-11-29 17:21:47 +01:00
Stephan Bergmann
0c59e2ddd6 loplugin:unnecessaryoverride (dtors) in comphelper 
Change-Id: I13ebc4efa7f8bd0d3732ed65e397c710ae65d14e
 2016-11-28 14:14:04 +01:00
Noel Grandin
5c2c2d8dc4 loplugin:expandablemethods in comphelper..cppuhelper 
Change-Id: I9d5487af4729bd3ee4f6450092e4b77f74a12e6d
Reviewed-on: https://gerrit.libreoffice.org/30717
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-10 06:51:53 +00:00
Michael Stahl
24063ec94b comphelper: also bump PDBKDF2 count for password-to-modify 
The password-to-modify misfeature does not actually provide any
security, but it may induce users to re-use passwords, so at least make
it harder to crack the passwords.

Change-Id: I0adf0e8e11b222fc469013e17a2695bd7122ad01
 2016-11-09 19:07:34 +01:00
Noel Grandin
389999abdb make comphelper::containerToSequence a little smarter 
So we don't have to specify the source and destination type as often.

Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624
Reviewed-on: https://gerrit.libreoffice.org/30700
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-09 07:48:18 +00:00
Noel Grandin
c123c528bf loplugin:unnecessaryvirtual in comphelper..forms 
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd
Reviewed-on: https://gerrit.libreoffice.org/30679
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-08 06:57:57 +00:00
Samuel Mehrbrodt
e509c22863 SafeModeDialog: Allow to create zip file from profile 
Change-Id: I4296d1cf5058be359ffed46745673cf26eba3375
Reviewed-on: https://gerrit.libreoffice.org/30479
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2016-11-03 12:19:16 +00:00
Samuel Mehrbrodt
69de2b4772 SafeModeDialog: Add link to user profile 
Change-Id: I0096b3d7db51e28eb58c7209109c30b73b382478
Reviewed-on: https://gerrit.libreoffice.org/30448
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2016-11-01 14:58:25 +00:00
Samuel Mehrbrodt
1161de521e safemode: Add option to disable H/W acceleration 
Change-Id: Ic6751717c14d317b5a4bc64c4fd1cf2b2f5efabf
Reviewed-on: https://gerrit.libreoffice.org/30112
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2016-11-01 14:54:04 +00:00
Takeshi Abe
cb90f0976d Omit the default comparator 
Change-Id: Idea8ea8dab6a86d7be6394aef1cf7f25b75009e0
Reviewed-on: https://gerrit.libreoffice.org/30319
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2016-11-01 04:11:44 +00:00
Caolán McNamara
ae68c27457 coverity#1374269 Uncaught exception 
Change-Id: Ib3a876ea6463396784062bd53bfedff177818498
 2016-10-26 09:56:30 +01:00
Andrea Gelmini
525311b0d6 Fix typos 
Change-Id: Ib7b17f85c7b6a1937c3f6e1617ceec58074643b4
Reviewed-on: https://gerrit.libreoffice.org/30040
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
 2016-10-23 17:17:01 +00:00
Julien Nabet
6af27d245a Typos in comments 
Change-Id: I6450d3862a67c2a9275a569a8ee3c29262124409
Reviewed-on: https://gerrit.libreoffice.org/30162
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2016-10-22 18:03:52 +00:00
Armin Le Grand
8dcad50137 profilesafe: Make sure no recursive saving happens 
Change-Id: Idd57a948fcaaf23614ca1a92051a50b86e4bb0c5
Reviewed-on: https://gerrit.libreoffice.org/30145
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
 2016-10-21 17:39:23 +00:00
Armin Le Grand
d1b3a33d99 profilesafe: Added more specific options 
For Extensions there is the possibility to not only
decide enable/disable state for User ones, but also
to deinstall user or all extensions, added these
options to the dialog and the functionality.
Also unified customization name schema to have just
one source of strings to avoid errors in the future.
Small fix in tryPop_extensionInfo

Change-Id: I39acbe9a052ffd4cb78b496f24e5b583136c565a
Reviewed-on: https://gerrit.libreoffice.org/30100
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
 2016-10-21 13:31:29 +00:00
Noel Grandin
5a5731cd05 loplugin:expandablemethodds in include/basic..comphelper 
Change-Id: I1aa9c12e8839325a9fd98530abc89a3d586ff62e
Reviewed-on: https://gerrit.libreoffice.org/30120
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-21 09:57:38 +00:00
Thorsten Behrens
ff84b8a242 coverity#1374089: Unchecked return value 
Change-Id: Ied4e80db512000471b5aa215beeef1277121fe12
 2016-10-21 00:54:46 +02:00
Stephan Bergmann
4fb9926ebc Blind fix for "error: chosen constructor is explicit in copy-initialization" 
...on linux_clang_dbgutil_64 build

Change-Id: I00022749ce12df459ce22333593daa2eb6503fd7
 2016-10-20 13:23:20 +02:00