Noel Grandin
71b809959b
remove unnecessary use of void in function declarations
...
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
Tor Lillqvist
cbd8587ffb
Move osl::LibreOfficeKit stuff to comphelper for now
...
Let's see where it actually will be needed. Sal is a "picky" place for
new API, even inside LIBO_INTERNAL_ONLY.
Change-Id: Ia0c5ee8cfc6ee526c5ad34d2f8aab0b14b5f805b
2015-04-02 13:28:12 +03:00
Noel Grandin
aa1b911b64
loplugin:staticmethods
...
Change-Id: I1f6c6d13697aa397067478d6b07429120106e6bd
2015-04-02 09:38:29 +02:00
Stephan Bergmann
7bcf64c29a
Add isReadOnly() support to simplified configuration access
...
[API CHANGE]: extends the css.configuration.XReadWriteAccess in an incompatible
way, but that is unpublished, has been commented as "still unpublished and
unstable," and was specifically introduced for internal use by the simplified
configuration access, so should not affect 3rd party code.
Change-Id: I99ce045f5bd8c598e689d46fb0d3626dfaa6d0a0
2015-04-01 14:26:26 +02:00
Stephan Bergmann
a88a386c72
Replace remaining getCppuType et al with cppu::UnoType
...
Change-Id: I8dd0e5c8837fe1615aa9d5f546c2fd1c0985f044
2015-04-01 08:36:11 +02:00
Caolán McNamara
026b17b7d7
V597: introduce a rtl_secureZeroMemory
...
Change-Id: Id28046eb318cd3b2ed0b813fd266617547cf6ee2
2015-03-31 13:38:01 +01:00
Stephan Bergmann
581c5075bb
Reduce to static_cast any reinterpret_cast from void pointers
...
Change-Id: I062024d4768374e319b6c67ed8c7abcc89f9d552
2015-03-31 13:12:34 +02:00
Stephan Bergmann
962b77340f
Clean up C-style casts from pointers to void
...
Change-Id: Icdb619101a992a740c71545e669e138cb5dc63a6
2015-03-28 19:09:18 +01:00
Noel Grandin
c4a9241f72
new clang plugin: staticmethods
...
Genius suggestion from Tor Lillqvist, write a clang plugin that finds
methods that can be static.
Change-Id: Ie6684cc95d088e8750b300a028b49f763da00345
2015-03-27 10:51:08 +02:00
Caolán McNamara
944d1fd5ca
fix windows build and sal_Bool->bool
...
Change-Id: If88a5b1171ef0b586861dd071820bc993c4cf06e
2015-03-19 10:21:13 +00:00
Noel Grandin
4d2de58163
fix windows build
...
after my commit 48bb2913a7459edb17a5f62c2f6e6fbc4f1051e2
"convert SFX_FILTER_ constants to enum class"
Change-Id: Ieaf524e076f5ecfe16b312a310cd6f5cb8bd637d
2015-03-19 09:56:24 +02:00
Noel Grandin
48bb2913a7
convert SFX_FILTER_ constants to enum class
...
Change-Id: I7e53cfc90cefd9da7d6ecd795b09214bd44b1613
2015-03-19 08:25:03 +02:00
Jan Holesovsky
a250e9d3ec
Factor out the .uno: command dispatching to a separate function / file.
...
Change-Id: I8486933d57d42992e66be7f17443320cfc2ad629
2015-03-16 09:38:09 +01:00
Swachhand Lokhande
b1534edf52
tdf#89592 Using initializer_lists to populate Sequence<PropertyValue>
...
Change-Id: Idef9dd55eb1719eaf592bc4a86440cbd5aa4fb32
Reviewed-on: https://gerrit.libreoffice.org/14781
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-03-10 10:26:59 +00:00
Caolán McNamara
d22519f62b
V801: Decreased performance
...
Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
2015-03-09 22:04:31 +00:00
Michael Stahl
802fe48751
comphelper: compare implemented as subtraction
...
Change-Id: Ic7abd7dd588339e06b6764659829f35b4ea87adb
2015-02-27 11:25:49 +01:00
Noel Grandin
ba233e87ef
remove unnecessary parenthesis in return statements
...
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'
Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-23 09:26:58 +02:00
Caolán McNamara
01a8bda416
boost::noncopyable->'= delete'
...
Change-Id: If0f898a1e912fcd2095d8ba88b2b8046596e16ea
2015-02-16 12:54:45 +00:00
Caolán McNamara
a1ceacc17e
boost::foo_ptr->std::foo_ptr
...
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
2015-02-16 12:54:44 +00:00
Caolán McNamara
f8b80701e0
these can all be made const
...
Change-Id: I6a8af82e8612196f20143f4997eb95c80a2ca13d
2015-02-12 10:53:18 +00:00
Michael Stahl
e81888278d
comphelper: add SAL_INFO for exception when graphic cannot be loaded
...
Change-Id: Ia0a4834987ae040a31e19276ece20b74b59ca445
2015-02-11 15:12:07 +01:00
Stephan Bergmann
e92e1959ca
loplugin:deletedspecial
...
Change-Id: I0aeba0c65b19c1107f617ed0af0028cced9bd434
2015-02-07 12:35:57 +01:00
Matthew Pottage
4f7a1f5b94
fdo#75757: Remove inheritance from std::vector
...
Deprecated comphelper/sequenceasvector.hxx.
Rewritten code using it. Using instead the functions containerToSequence and
sequenceToContainer, found in include/comphelper/sequence.hxx.
One class that inherits from it (in framework/inc/stdtypes.h), and
the code using that has been left.
Signed-off-by: Michael Stahl <mstahl@redhat.com>
Conflicts:
writerfilter/source/dmapper/DomainMapper.cxx
writerfilter/source/dmapper/TblStylePrHandler.hxx
writerfilter/source/dmapper/WrapPolygonHandler.hxx
Change-Id: Ice61c94ffb052e389281aebb7cdf185134221061
2015-02-06 23:06:58 +01:00
Caolán McNamara
c7258cfccd
shared_ptr<T>(new T(args)) -> make_shared<T>(args)
...
and boost:make_shared->std::make_shared
Change-Id: Ic1e187c52c856a7b27817967b2caa8920f23a98d
2015-02-06 16:45:13 +00:00
Caolán McNamara
4d6a509efe
convert all remaining BOOST_STATIC_ASSERT to static_assert
...
and we can include a few less headers
Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
2015-02-05 22:21:49 +00:00
Michael Stahl
893362bc39
comphelper: do not use "r" prefix for uno::Reference
...
Change-Id: I5e92ca9dbb0c9f33c9511cc4b12db1433e40fa68
2015-02-05 15:29:53 +01:00
Ashod Nakashian
de68bb8514
Updated all precompiled headers.
...
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157
Reviewed-on: https://gerrit.libreoffice.org/14292
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-05 10:46:33 +00:00
Stephan Bergmann
876413440d
Some more loplugin:cstylecast: comphelper
...
Change-Id: I6d3ffb195a7c9a3c44744d296fb9d9eca00115cd
2015-01-20 09:06:46 +01:00
Stephan Bergmann
d3ce5b298e
Fix getTypes() of OPropertySetHelper and derived
...
...broken with 60d60caf99a40ca0c3891bf230c5a1fdbae5f49c "Renamed XPropertySet2
to XPropertySetOption" et al
Change-Id: I684736ffafc4642548b7c24171cc52c1acb32252
2015-01-16 10:19:36 +01:00
Julien Nabet
591ef97787
Really remove events
...
Change-Id: Ie73b7ead02434a0614287f61f0ffd49eeab32aba
Reviewed-on: https://gerrit.libreoffice.org/13681
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-15 13:15:57 +00:00
Caolán McNamara
dc5ae421c3
include time.h for time
...
Change-Id: Id2fbc93fb99cd97473298e127dd5a3d82f22e438
2015-01-06 15:33:18 +00:00
Caolán McNamara
18ad91eec1
boost::random->std::random
...
Change-Id: I1b823b6c17b731e427bff88c6fff7897f66ddb5c
2015-01-06 15:19:41 +00:00
Stephan Bergmann
f8922b67a4
Remove unnecessary comphelper::string::getToken
...
Change-Id: I49192637121441b9a1980350b9bb32cd995d4386
2015-01-02 14:22:21 +01:00
Caolán McNamara
7f476fea47
boost::unordered_map -> c++11 std::unordered_map
...
Change-Id: I28438000c2b0a8e6ce4f5640f861f572c0cb83c8
2014-12-27 23:00:45 +00:00
Stephan Bergmann
85bcf06160
comphelper: Use appropriate OUString functions on string constants
...
Change-Id: Ia09f122d4d968318fc0208b64b9bf7a0bc131f8a
2014-12-12 10:22:13 +01:00
Noel Grandin
7557f23b31
java: reduce visibility of fields and methods
...
found by PMD
Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11 06:09:03 +00:00
Noel Grandin
9adb820158
java: simplify the getMSF() methods
...
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3
Reviewed-on: https://gerrit.libreoffice.org/13406
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10 08:04:58 +00:00
Noel Grandin
dd6c337d83
java: remove some comment noise
...
Change-Id: I4d15a0e606f468346bc5d2f43af2e14bcc758e13
Reviewed-on: https://gerrit.libreoffice.org/13405
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10 08:04:33 +00:00
Stephan Bergmann
b9ca4de985
From ill-named comphelper::getExpandedFilePath to comphelper::getExpanedUri
...
Change-Id: I749d78d115f641b2ac18cd6eb483c69a22ee210c
2014-12-03 16:15:27 +01:00
Stephan Bergmann
fced31697b
comphelper::SequenceAsHashMap: throw IllegalArgumentException
...
...instead of IllegalTypeException (where the latter is not a RuntimeException).
Fixes cid#707218, cid#1224993, etc., and reverts previous fix
358f5280e0f6afb968edc295d8f1dce55f05e18f "Fix coverity#1224993 w/o breaking
JunitTest_framework_unoapi."
Change-Id: I13ce153e1513749fb0be2ee8e560cec86a30c5ba
2014-11-19 18:18:06 +01:00
Michael Stahl
6a0fe37dec
sal: clean up public headers with include-what-you-use
...
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
Tor Lillqvist
bbb675d4f5
Some more compareVersionStrings() tests
...
Change-Id: I5b9dc45352afd63dae4c3952d9647e6e3ec98ef4
2014-11-14 18:27:38 +02:00
Brij Mohan Lal Srivastava
d32be3ace8
fdo#86023 - O[U]String needs a 'clear' method
...
Added clear() method to OString and OUString class, Updated appropriate call-sites.
Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14 09:20:38 +01:00
Andrea Gelmini
da40cac540
Fix common typos. No automatic tools. Handmade…
...
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:04:11 +00:00
Tor Lillqvist
ca2fefb879
Add a function to compare version number strings
...
Change-Id: I88d3d9040f70e84752ade19001a699f60e9e7636
2014-11-11 19:01:58 +02:00
Noel Grandin
705c48d32e
fdo#38835 strip out OUString globals
...
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.
Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-05 08:44:19 +02:00
Matúš Kukan
6f46cf4fe1
thread-pool: Initialize empty pools to start complete.
...
Otherwise waiting for completion if we push no work hangs.
Change-Id: I7103bdb779eb66a65cd8496091e72a0c65eb3567
2014-11-04 19:38:28 +00:00
Michael Meeks
68f912e896
thread-pool: fix waiting until all tasks are complete.
...
Change-Id: Iaf5a3bf28879f229a223a8760fd878f96958a53c
2014-10-31 18:13:05 +00:00
Michael Meeks
593a44a12d
thread-pool: re-work termination semantics to avoid problems.
...
We want a pre-spun-up, shared thread-pool that doesn't get its
workers created & joined frequently.
Change-Id: I29081e3a3e3849ca30e63fd080ee3315d99cbe8d
2014-10-30 22:12:29 +00:00
Michael Meeks
62090f65b8
Move thread-pool down into comphelper for re-use elsewhere.
...
Change-Id: Ib27b8b1ccc07ff194035d6c2ef3d45c429e3cea1
2014-10-30 22:12:27 +00:00