Pedro Giffuni
c6dbbdf851
i125711 - Illumos port: generalize MAX_ALIGNMENT for Solaris
...
GCC in Ilumos appears to behave exactly like the Solaris SUNPRO
compiler so generalize the case for Solaris.
(cherry picked from commit e1da117c49fc02af9543e32526bf1c04657534c4)
Change-Id: I3fa619f34c35608b187c3aa394552ac78c3f0c20
2015-11-25 20:59:45 +00:00
Noel Grandin
aad80e0b9a
cppcheck:useInitializationList
...
Change-Id: I744ff3e268fbffca9499121f3567640934aaae51
Reviewed-on: https://gerrit.libreoffice.org/20110
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-22 12:14:53 +00:00
Stephan Bergmann
4730b58d99
loplugin:nullptr (automatic rewrite)
...
Change-Id: I17eb40b2923793280ea220e519f97563c8490a19
2015-11-10 10:31:20 +01:00
jan iversen
6a2440ea91
cid#1338241 removed throw from C function.
...
Lower level C++ make a throw, this cannot be passed
back in a C function.
Change-Id: I54ace0284d0291d54f53b8947e9f4ffc2e0a56ab
Reviewed-on: https://gerrit.libreoffice.org/19873
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-11-10 07:21:43 +00:00
jan iversen
5ff684477d
cid#1338242 cid#1338241 removed throw from extern "C" function
...
Encapsulated throw from C++ to a return false in the "C" function
Change-Id: I2fc89b0dcf434395859300b3d3890247d1288295
Reviewed-on: https://gerrit.libreoffice.org/19872
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-11-10 07:21:07 +00:00
Noel Grandin
6c80a8fe89
new loplugin: oncevar
...
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f
Reviewed-on: https://gerrit.libreoffice.org/19815
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-09 08:34:40 +00:00
Benjamin Ni
be729e7721
tdf#94269: Replace "n" prefix for bool variables with "b"
...
Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797
Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-11-02 23:40:57 +01:00
Stephan Bergmann
f570f837d6
Avoid ASan new-delete-type-mismatch with -fsized-deallocation
...
...where "subclasses" of typelib_TypeDescription are deleted non-
polymorphically
Change-Id: I708d245e12d2e2159e9df60b61d1b37801083651
2015-11-02 10:50:24 +01:00
Stephan Bergmann
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Andrea Gelmini
3f6da86e9f
Fix typos
...
Change-Id: I13c3dc33722f139582f27412d5d336264d3d15a3
Reviewed-on: https://gerrit.libreoffice.org/18942
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30 13:05:20 +00:00
Caolán McNamara
22b80ac8e2
boost->std
...
Change-Id: I3fd9e1599c5ad812879a58cf1dabbcd393105e1c
Reviewed-on: https://gerrit.libreoffice.org/18564
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-14 12:54:25 +00:00
Stephan Bergmann
b03b8c8c0c
loplugin:stringconstant: OUStringBuffer: appendAscii -> append
...
Change-Id: I22808f7740a9a936deb9160b24fe4634f8613823
2015-08-31 08:04:07 +02:00
Stephan Bergmann
2861d5bedc
Some oslCondition -> osl::Condition
...
Change-Id: I86cfbefd1cb8b22fca659a158b8e31d5c991de7a
2015-08-18 08:16:18 +02:00
Noel Grandin
4712396b3b
loplugin: defaultparams
...
Change-Id: I906912f29448bfc72e8139546aa09525c959867f
2015-08-11 09:48:17 +02:00
Noel Grandin
171990764e
com::sun::star-css in cppu,cppuhelper
...
Change-Id: I84a412f587fd66f6c0610f083e61cf0fa079d4d9
Reviewed-on: https://gerrit.libreoffice.org/17384
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-29 06:44:57 +00:00
Stephan Bergmann
cbce40e965
Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug builds
...
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT
etc. also for --enable-debug builds in addition to --enable-dbgutil builds.
Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13 18:14:11 +02:00
Stephan Bergmann
81275d4725
Avoid loplugin:redundantcast in non-debug build
...
Change-Id: Ib5f57ba5154c56b89ab550aef5a87ee27539ddd9
2015-07-08 20:56:19 +02:00
Stephan Bergmann
a212bd0e36
loplugin:stringconstant: handle OUString+=OUString(literal)
...
Change-Id: I55363639900450c9780dd187805ce0500f68a2f4
2015-06-26 13:55:30 +02:00
Stephan Bergmann
472c0a3dcc
loplugin:stringconstant: Flag more inefficiencies
...
Change-Id: I36ae4b57049fe4deabe785ccfecf78608461086f
2015-06-25 12:38:34 +02:00
Julien Nabet
2a65bf32ec
Revert "Typo: iff->if"
...
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d.
iff can mean "if and only if" so not a typo
2015-06-23 20:42:27 +02:00
Julien Nabet
cf92da3d6e
Typo: iff->if
...
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-06-23 20:30:11 +02:00
Caolán McNamara
ad62165065
cppcheck: noExplicitConstructor
...
Change-Id: Ic33ee6936f40bec4f3a82aea39a180ae6e9a0928
2015-06-09 10:34:00 +01:00
Stephan Bergmann
cd14c53664
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: I2d60f21219adfe9935ad69620f3a7bd856f96376
2015-06-08 16:24:16 +02:00
Stephan Bergmann
75aa1bf8ec
loplugin:cstylecast: deal with those that are (technically) const_cast
...
Change-Id: Ied61df6c80a05037fc6335c098c9ac2671ad1c4d
2015-06-02 11:26:02 +02:00
Julien Nabet
3aebc670e1
Remove include stdio (part2)
...
Change-Id: Iae58d107d8df1c543a165086fb2b7c288e7121dd
Reviewed-on: https://gerrit.libreoffice.org/15775
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-05-18 05:33:52 +00:00
Stephan Bergmann
0bfc98e63b
loplugin:redundantcast: reinterpret_cast to void*
...
Change-Id: I947b49cfb15f0e7d6ddfaae386656c70e4bd48ba
2015-05-12 18:27:54 +02:00
Stephan Bergmann
7e61f39f89
loplugin:cstylecast: nop between pointer types of exactly same spelling
...
Change-Id: Id980379f57590759ebc9b862aad3c6dfb04ddef7
2015-05-11 12:49:21 +02:00
Stephan Bergmann
6ff2d84ade
Various #include <sal/log.hxx> fixups
...
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx>
(and don't make use of it themselves), but many other files happen to depend on
it. Cleaned up some, but something like
grep -FwL sal/log.hxx $(git grep -Elw \
'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx)
shows lots more files that potentially need fixing before the include can be
removed from rtl/string.hxx and rtl/ustring.hxx.
Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-22 09:57:47 +02:00
Noel Grandin
71b809959b
remove unnecessary use of void in function declarations
...
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
Stephan Bergmann
96f5b780f0
Use OUString::unacquired
...
found with
git grep -E '\* *\<reinterpret_cast\>[^>]+\<OUString\>'
Change-Id: I9306d4ad8e3b1664f54cb7df86f2d79bfd3c6cb9
2015-03-31 17:45:27 +02:00
Stephan Bergmann
c57ffac695
Reduce to static_cast any reinterpret_cast from void pointers
...
Change-Id: I22ee2cbacad8b19bb55db234e816d401edcf4a35
2015-03-31 13:12:58 +02:00
Stephan Bergmann
1777f6fedb
Clean up C-style casts from pointers to void
...
Change-Id: I834eb4ecd0fa71caf6fa746901367fac8b538305
2015-03-28 19:09:18 +01:00
Julien Nabet
48f0a5ed35
Typos
...
Change-Id: I845a85e1aad4a0708f2b43f7d94606b4b5513ee4
2015-02-18 21:59:02 +01:00
Caolán McNamara
4d6a509efe
convert all remaining BOOST_STATIC_ASSERT to static_assert
...
and we can include a few less headers
Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
2015-02-05 22:21:49 +00:00
Michael Stahl
4e12f9553b
cppu: convert some OSL_TRACE
...
Change-Id: I5dc00f7b03b51916b1331c4ba64064a5aa5930c9
2015-01-29 21:48:13 +01:00
Michael Stahl
585b789ead
cppu: the LogBrige really needs its own SAL_LOG area
...
Change-Id: I129f3dc1597035664e4ff284276cb0d49a560ab5
2015-01-29 21:48:13 +01:00
Stephan Bergmann
4e3da621fe
Some more loplugin:cstylecast clean-up
...
Change-Id: I132d22e2af3cf673c17d8964f690d48990834884
2015-01-28 13:50:37 +01:00
Stephan Bergmann
9193a15fc5
Some more loplugin:cstylecast: cppu
...
Change-Id: Iec1251648031afa9eddd7445135fb08dc74821bd
2015-01-20 09:06:46 +01:00
Caolán McNamara
d5c3a25aae
valgrind: uninitialized variable
...
Change-Id: I1e166c7e3b58ed565aaf478fa0b6505d1f68b604
2015-01-08 09:23:21 +00:00
Caolán McNamara
900a2996c4
coverity#1261762 Resource leak
...
still leaks the handle of course, but c++izes the code and hides
the leak from coverity as a side-effect
Change-Id: Ieaab1545a98da1d699df93d020f0cb452ddf2516
2015-01-08 09:10:42 +00:00
Stephan Bergmann
4e59046114
Fix include
...
Change-Id: Ie5253f9b32bb6ed1099eca75b442ba26528f2b32
2015-01-05 17:48:23 +01:00
Stephan Bergmann
64ccf3ff30
Include function declarations
...
Change-Id: Ib1ce66bf9ec71280409335c0a5022ecfe229f494
2015-01-05 17:25:50 +01:00
Stephan Bergmann
c662bf350f
Mark function declarations as CPPU_DLLPUBLIC, not only definitions
...
<http://msdn.microsoft.com/en-us/library/8fskxacy.aspx > "Importing into an
Application Using __declspec(dllimport)": "Using __declspec(dllimport) is
optional on function declarations, but the compiler produces more efficient code
if you use this keyword."
Change-Id: I149306049987b2406622d7a0dc5dde92d283a5b3
2015-01-05 17:25:50 +01:00
Stephan Bergmann
9a6e2dd9e7
Missing const
...
Change-Id: I8a1c520023b493c0494ac2ac650542d8ecc11c5d
2015-01-05 14:48:29 +01:00
Stephan Bergmann
f76f40560e
More unnamed namespace clean-up
...
Change-Id: Iaba8b9b3415c357990b795b6f23b98929ac5e00a
2015-01-05 14:02:27 +01:00
Stephan Bergmann
406629e9a0
These extern "C" functions are not in an unnamed namespace
...
Change-Id: I185b29c185094176e0992fc84c9cc82ff93de9c2
2015-01-05 13:53:26 +01:00
Stephan Bergmann
debced0f29
These extern "C" functions are not in namespace cppu
...
Change-Id: Ia98b32bd8451051750fbf810958bdcfe584ea7be
2015-01-05 13:47:54 +01:00
Stephan Bergmann
da2d66ce56
include
...
Change-Id: I77d06a70f9c000f800b9b31d3b04aafe77754446
2015-01-05 13:32:42 +01:00
Stephan Bergmann
9720e8e5ef
Some loplugin:revisibility clean-up
...
Stumbled across such redundant visibility re-specifications when looking at the
odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in
cppu/source/cppu/cppu_opt.cxx and used in inline code in
include/com/sun/star/uno/Reference.hxx with only a declaration lacking
CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows.
However, this plugin is probably not worth it being run all the time, so
committing it to compilerplugins/clang/store/.
Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510
2015-01-05 13:10:48 +01:00
Stephan Bergmann
305b90c999
OSL_FAIL -> SAL_WARN
...
Change-Id: I82ce1030e69f8794c9fdbdc138541e5d7e0541d4
2015-01-02 17:08:48 +01:00