mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
403,714 Commits 1 Branch 0 Tags
12b2803f196b897ffb901b0eebe271c5ee43d03e
Commit Graph

3868 Commits

Author SHA1 Message Date
Xisco Fauli
00271c8eaf tdf#89329: use unique_ptr for pImpl in optpath 
Change-Id: If9e627e2f0f091e8411d0c6f16f29b583723419a
Reviewed-on: https://gerrit.libreoffice.org/25327
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-23 11:32:02 +00:00
irem
a4e8419c8a tdf#99211 Use the restart dialog for notifications about restart 
Change-Id: I97a10cddafc464ccbdd37902c5d24b73246f5c3f
Reviewed-on: https://gerrit.libreoffice.org/24877
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-05-23 08:34:38 +00:00
Noel Grandin
835de2917e Convert HYPERDLG_EVENT to scoped enum 
Change-Id: I8a0248bb91ee67596aa44d11ca862d2e127a65ad
Reviewed-on: https://gerrit.libreoffice.org/25197
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-22 17:51:21 +00:00
Noel Grandin
d4d2fc2479 clang-tidy modernize-make-unique 
Change-Id: I550bb69ddcef69906027516ccde62cf8e87c295b
Reviewed-on: https://gerrit.libreoffice.org/25138
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-19 08:33:10 +00:00
Rishabh Kumar
fe3d9ac20b Addition of new controls and their rearrangement in gradient tab 
1. Addition of increment spin box and slider in gradient tab.
2. Addition of slider for border controls in gradient tab.
3. Rearrangement of controls.
4. Removal of gradient controls from Area tab.

Change-Id: I56c3767a0d54990338982cd45ed10a10dd8a94c1
Reviewed-on: https://gerrit.libreoffice.org/24910
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
 2016-05-18 13:05:03 +00:00
Noel Grandin
21a68e1745 convert TAB to scoped enum 
and rename the SID constant to something more meaningful

Change-Id: Ic07888936df3d537158fd2fb671b0df11350d676
Reviewed-on: https://gerrit.libreoffice.org/24986
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-18 10:13:57 +00:00
Noel Grandin
2c8fe2e737 update unusedmethods plugin to deal with constructors 
and fix the operator< implementations in some of the other
plugins too.

Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035
Reviewed-on: https://gerrit.libreoffice.org/25057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-18 10:03:44 +00:00
Noel Grandin
d96c114171 clang-tidy modernize-make-shared 
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a
Reviewed-on: https://gerrit.libreoffice.org/25056
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-18 06:58:44 +00:00
Susobhan Ghosh
bdcb496858 tdf#88502 Added error box to denote connection errors instead of progress bar 
Change-Id: I8217fa487ed58f5d396e8769c76dd2d16f390472
Reviewed-on: https://gerrit.libreoffice.org/24757
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
 2016-05-17 20:51:32 +00:00
Noel Grandin
c2fc91664f Convert LB flags to scoped enum 
Change-Id: I6bce097e803ece5ddf7764651900e0d14a2d0393
Reviewed-on: https://gerrit.libreoffice.org/24985
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-16 06:42:27 +00:00
Muhammet Kara
98505584ba Give unique, comprehensible names to idles tdf#97087 
Timers and idles should have programmer comprehensible, unique names.

Change-Id: Ida131a4e3ddb7f065d876d78dd501fa831d4cf4a
Reviewed-on: https://gerrit.libreoffice.org/24605
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-05-16 01:06:48 +00:00
Caolán McNamara
71c4a2b761 mpDefDialogParent is not used since 2002 
i.e.

commit c0ae87cb5f
Author: Stephan Schäfer <ssa@openoffice.org>
Date:   Tue Oct 22 08:39:05 2002 +0000

    #103442# choose DefDialogParent on-the-fly

and so calling SetDefDialogParent doesn't achieve anything

Change-Id: I2ec72da47b2dac03fdddbdb9eba5ae4bf205eb22
 2016-05-12 10:09:26 +01:00
Noel Grandin
1342818790 convert SFXWB file dialog flags to scoped enum 
Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b
Reviewed-on: https://gerrit.libreoffice.org/24881
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-12 06:57:19 +00:00
Noel Grandin
08234bab5e Convert MESS_BTN to scoped enum 
Change-Id: I9332216f58268b20b3b8e9488471279d70c519ad
 2016-05-11 11:12:30 +02:00
Stephan Bergmann
14cd5182c5 Replace fallthrough comments with new SAL_FALLTHROUGH macro 
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough.  (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)

Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently.  (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.)  C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.

Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
 2016-05-10 16:42:16 +02:00
Stephan Bergmann
0f3ac23d73 Insert explicit "break" when falling through to empty next case 
...which itself only contains a "break" (or nothing at all at the end of the
"switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these.

Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
 2016-05-10 14:57:26 +02:00
Noel Grandin
9c7222c11c convert WINDOWSTATE_MASK to scoped enum 
Change-Id: Ic8259d81d8080c518aa07697e253a59cd6efaa4b
 2016-05-10 08:40:10 +02:00
Noel Grandin
70d5cd845d fix windows and android build 
Change-Id: I4644c1e5ac143efc6b1e75d041f71fe7d9156f0c
 2016-05-09 13:11:52 +02:00
Noel Grandin
50ac0f503b convert FONT_EMPHASIS_MARK to scoped enum 
Change-Id: I137c78b337e57d3442db08334128e79d186b278f
Reviewed-on: https://gerrit.libreoffice.org/24753
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-09 09:41:34 +00:00
Noel Grandin
bcb41235de convert SfxStyleFamily to scoped enum 
and update the RSC compiler to accept such

In the process fix some confusion in SD where it was confusing
SfxStyleFamily and the index of the relevant family
(which other parts of the code in SVL use)

Change-Id: I1efc9f85fbed8ab76eafe8f6e1ada411753ae5f9
 2016-05-09 10:17:13 +02:00
Susobhan Ghosh
3f22f287b4 tdf#88502 Firefox Theme URL in custom theme search 
Removed "suggested" from categories label. Fixed
URL checking.

Change-Id: Ifbea40cf724c91f6af72c485d9ae7eb599afff65
Reviewed-on: https://gerrit.libreoffice.org/24716
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
 2016-05-07 14:19:07 +00:00
Michael Stahl
58080e8f78 basegfx,oox,slideshow: replace boost::next/prior with std::next/prev 
Change-Id: I38fde54d0fdbb9c61e3df004242a70e14429f52f
 2016-05-06 23:37:10 +02:00
Samuel Mehrbrodt
8e8b51cbe2 tdf#70998 Termchange: Graphic->Image 
Change-Id: I561a4d81a4fa8d5a6cc5f92b11ed480e833dadcc
Reviewed-on: https://gerrit.libreoffice.org/24697
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2016-05-06 12:27:45 +00:00
Noel Grandin
f3d9aab841 teach passstuffbyref plugin to check for.. 
unnecessarily passing primitives by const ref.

Suggested by Tor Lillqvist

Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6
Reviewed-on: https://gerrit.libreoffice.org/24672
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-06 06:48:38 +00:00
Maxim Monastirsky
877f6bbf4b SvxIconSelectorDialog was never destructed 
Change-Id: I6cc9bd70f3e3f4266af0eddfff8be406021a1d66
 2016-05-05 14:35:31 +03:00
Stephan Bergmann
75ac19149d loplugin:staticmethods 
Change-Id: I679fd93c409035ce87101f7fe150822c2214765e
 2016-05-04 22:32:55 +02:00
Susobhan Ghosh
46c87a5e8a tdf#88502 Firefox Theme URL in custom theme search 
Persona Dialog modified. Search supports Firefox Theme URL.
Added display of installed theme on personalization dialog.
Fixed category buttons. Added SOLID as category. Removed
invalid/duplicate results.

Change-Id: I603c0c292fe5c3e380553b9a2eaab6f4bc0683e1
Reviewed-on: https://gerrit.libreoffice.org/23385
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Jenkins <ci@libreoffice.org>
 2016-05-04 15:41:05 +00:00
Noel Grandin
58a32075ca use Any constructor instead of temporaries 
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
 2016-05-04 12:39:40 +02:00
Stephan Bergmann
6e70103da0 While at it, delete Any functions on sal_Bool* 
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of
sal_Bool across the code base

Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
 2016-05-04 11:59:23 +02:00
Stephan Bergmann
ab3d2e568f Prevent Any ctor from reinterpreting bool* as sal_Bool* 
...which only happens to work in environments where sizeof (bool) == 1.  The
simpler alternative is to use the Any ctor template without passing explicit UNO
type information, anyway.

The std::nullptr_t overloads are needed to disambiguate calls with a nullptr
argument.  (Which can at least be meaningful for VOID, but for other types what
it happens to do is store a default value of the given type.)  As std::nullptr_t
is only C++11, this all needs to be LIBO_INTERNAL_ONLY.

Change-Id: I0f72c73a088ef96e069c3ed8c78546b16d89b50a
 2016-05-03 15:25:44 +02:00
irem
2fce97c51c tdf#99211 Use the restart dialog for notifications about restart 
Change-Id: I2093e99d7b377285f6b3248a90072f0dea12f732
Reviewed-on: https://gerrit.libreoffice.org/24556
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-05-03 09:22:16 +00:00
Noel Grandin
82e9cfc991 use Any constructor for bool values, instead of temporary vars 
mostly found with:
   git grep -n 'setValue.*cppu.*UnoType.*bool.*get'

Change-Id: Ie8e5aa6402d25dbe90b0f492031a245bb222c1a5
Reviewed-on: https://gerrit.libreoffice.org/24464
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-03 07:26:26 +00:00
Rishabh Kumar
b1d4f658aa Refactoring transparence tab code 
Move transparence tab code out from Area tab code.

Change-Id: Ia7276aa3b1c438b6c8cff89ab5ca3752ff6bcc0e
Reviewed-on: https://gerrit.libreoffice.org/24368
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
 2016-04-29 12:00:09 +00:00
Muhammet Kara
376c337d46 tdf#97087 Give comprehensible, unique names to idles 
Timers and idles should have programmer comprehensible, unique names

Change-Id: Id0f2c0a77cd28c3ec5473e8432569739b58d2101
Reviewed-on: https://gerrit.libreoffice.org/24388
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2016-04-28 09:34:30 +00:00
Oliver Specht
c3572701cf tdf#89953: put zero kerning if item state has been invalid 
Change-Id: I96d81ed7654dc310df68a7ff376bbcd2e1d5810b
Reviewed-on: https://gerrit.libreoffice.org/24361
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2016-04-26 11:34:13 +00:00
Noel Grandin
e8fd5a07ec update loplugin stylepolice to check local pointers vars 
are actually pointer vars.

Also convert from regex to normal code, so we can enable this
plugin all the time.

Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1
Reviewed-on: https://gerrit.libreoffice.org/24391
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-26 10:55:58 +00:00
Samuel Mehrbrodt
db18de5868 tdf#89953 Character spacing: Increment by 0.1, not by 1 
and adjust the page size to 1 instead of 10

Change-Id: Ia6d964b8bb057ef8161890d36dd059922bbcbe9a
Reviewed-on: https://gerrit.libreoffice.org/24302
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2016-04-22 14:48:11 +00:00
Samuel Mehrbrodt
9a745d54a5 tdf#89953 Character spacing: Allow to enter negative values 
without selecting from a condensed/expanded listbox first.

Change-Id: I1111e6f1d7cdc6c0bc79d542f49c58f1022ad739
Reviewed-on: https://gerrit.libreoffice.org/24301
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2016-04-22 14:47:54 +00:00
Stephan Bergmann
a57049915d Avoid reserved identifiers 
Change-Id: I263603fb81d368ebc8450b2d8cc01752fcd3f29d
 2016-04-22 10:13:56 +02:00
Giuseppe Castagno
37d34e2b6a Related tdf#88502 a better implementation than the one in... 
...commit 70bb8c257e.

This commit reverts previous implementation in commit
70bb8c257e and makes use of a dedicated
interaction wrapper instead.

See comphelper::SimpleFileAccessInteraction for details.

Change-Id: Ia037ea14267afaf66d8f9aa2324649264a7cb4bf
Reviewed-on: https://gerrit.libreoffice.org/24275
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-04-22 07:11:43 +00:00
Stephan Bergmann
783419657c loplugin:salbool: sal_Bool[] -> bool[] 
Change-Id: I3c5bf7a53c9ae173f8fce885ecf022f092aa43a9
 2016-04-21 17:29:40 +02:00
Stephan Bergmann
a123652879 loplugin:rangedforcopy 
Change-Id: I227aa955417385da7cd43cc3641342e66e62ed96
 2016-04-21 16:13:21 +02:00
Noel Grandin
ca771c7e27 fix windows build 
after my commit
e1af7f0c43
"clang-tidy modernize-loop-convert in c*"

Change-Id: Icbc8c30186b0ea33933365951718dfad3fd7c4e2
 2016-04-21 13:21:03 +02:00
Noel Grandin
e1af7f0c43 clang-tidy modernize-loop-convert in c* 
Change-Id: I77d2548f8be97792660761e6156cd24734a95aaf
 2016-04-21 11:03:55 +02:00
Noel Grandin
5abc669599 new plugin stylepolice 
check for local variables which follow our member field naming
convention, which is highly confusing

Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
 2016-04-21 08:32:47 +02:00
Stephan Bergmann
e5434c67b1 loplugin:salbool: Automatic rewrite of sal_False/True 
Change-Id: I0953cecd363dd75e6a4438d34d47035f53f334a6
 2016-04-20 17:25:38 +02:00
Stephan Bergmann
980af0f1ec SvxNumberFormat::SetIncludeUpperLevels takes a sal_uInt8, not a sal_Bool 
Change-Id: Ifc86437140bae3223238fa8e5aaf5a4d57537b32
 2016-04-20 17:25:33 +02:00
Laurent Balland-Poirier
b24cc06769 tdf#99361 Separate checkbox in Number dialog 
"Thousands Separator" and "Engineering notation" used the same checkbox,
 so help tips texts were the same.
This commit creates a second checkbox
 which is hiden/shown according to category selected

Change-Id: I94913e63e47b760deb747ce7cd3d74ab4c109599
Reviewed-on: https://gerrit.libreoffice.org/24224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2016-04-20 13:33:06 +00:00
Noel Grandin
b0c0a074a2 clang-tidy clang-analyzer-deadcode.DeadStores 
suspect that some of these may reveal latent bugs....

Change-Id: I9de9aabbda9c8952715631577c29c1830df1eb71
Reviewed-on: https://gerrit.libreoffice.org/24200
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-20 11:02:45 +00:00
Jochen Nitschke
4054901d69 cppcheck: silence known condition warning in cui 
Change-Id: I8dfe3aa3c133ebb8ab6de058ae8335513bfb3f3b
Reviewed-on: https://gerrit.libreoffice.org/24199
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-04-18 15:55:37 +00:00