150 Commits

Author SHA1 Message Date
Ashod Nakashian
bc990b011a Some LOK notifications are dropped if they are superseeded by later ones
Change-Id: I323e46a2a6c60b200b182b89199945f99a7f384a
Reviewed-on: https://gerrit.libreoffice.org/24567
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
(cherry picked from commit cf98799fff7ae999bd62cec6486c986bf44000cc)
2016-05-09 13:58:29 +02:00
Ashod Nakashian
840e979757 More LOK callback notification compression
SET_PART, CELL_CURSOR, CELL_FORMULA, and CURSOR_VISIBLE are now deduplicated.

Change-Id: I4c17307c6f8b7c68bdfe55b4e90da4d34c55d085
Reviewed-on: https://gerrit.libreoffice.org/24565
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
(cherry picked from commit a9771e1f4d0d2602713983ab1f3e743784e9ae72)
2016-05-09 13:58:28 +02:00
Tor Lillqvist
e216110901 loplugin:redundantcast
reinterpret_cast from 'void *' to 'std::vector<std::tuple<int,
std::string> > *' can be simplified to static_cast.

Change-Id: I1899a1c570c4c56d8c7fe73745eac45061fb8bae
2016-05-09 07:35:19 +03:00
Ashod Nakashian
3d27afd26f Desktop compresses text selection start/end notifications
Change-Id: Ia85ded04d0eaf9d9b846fab6d86a44a758fccb69
Reviewed-on: https://gerrit.libreoffice.org/24320
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
(cherry picked from commit 45037438d84485356a5ceb820ecc3e0bae4b112e)
Reviewed-on: https://gerrit.libreoffice.org/24380
Tested-by: Jenkins <ci@libreoffice.org>
2016-05-09 02:40:38 +00:00
Ashod Nakashian
dc464bdb08 Desktop compresses mouse pointer notifications
Change-Id: Id76f4e2952c4c551b626d094c11eb3339d76e50c
Reviewed-on: https://gerrit.libreoffice.org/24319
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
(cherry picked from commit 7c01cf652850a8b8d3fd5ef6eb0a12ca6e725943)
Reviewed-on: https://gerrit.libreoffice.org/24379
Tested-by: Jenkins <ci@libreoffice.org>
2016-05-08 17:43:01 +00:00
Ashod Nakashian
ace0b3bdec Test desktop notification compression
Reviewed-on: https://gerrit.libreoffice.org/24314
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
(cherry picked from commit bb52a54aa49cbb75820f8ddbfc8e9e94b63281cd)

Change-Id: Ibb9a62bb5e1500a068c24346d6d433012a1bc7dd
Reviewed-on: https://gerrit.libreoffice.org/24378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-08 15:45:00 +00:00
Ashod Nakashian
c327bb5c88 New LOKDocument callback queue to flush events lazily on idle
Since desktop now queues up callback notifications
and flushes them to the client on idle, the
unit-tests must yield and process all tasks
before they validate post-conditions.

(cherry picked from commit e6a429770bde5da75239961ae88c06c78cfa5686)
(cherry picked from commit 1f278848117080cd6e819f04ba428be52416af7c)
(cherry picked from commit 6ca6f22777eb3651109cbf403577d0022a735c9b)
(cherry picked from commit 548faf728cf097d93c3f6478ceea5f8747e789c6)

Change-Id: I78307db29a9ce647ffaed3539f953227c605968e
Reviewed-on: https://gerrit.libreoffice.org/24377
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-07 22:19:50 +00:00
Noel Grandin
e8fd5a07ec update loplugin stylepolice to check local pointers vars
are actually pointer vars.

Also convert from regex to normal code, so we can enable this
plugin all the time.

Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1
Reviewed-on: https://gerrit.libreoffice.org/24391
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-26 10:55:58 +00:00
Pranav Kant
f00fd79f8a lok context menu: Add module specific unit tests
For calc, now click on the image to have more diverse context
menu with checkbuttons etc.

Change-Id: Ibe2471348b2572523f2684144bd18664ab48a2bb
Reviewed-on: https://gerrit.libreoffice.org/24006
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.com>
2016-04-13 16:47:59 +00:00
Stephan Bergmann
d0778636a4 loplugin:defaultparams
Change-Id: I5748482eb246b2ccf87a02df6406e2624ee66921
2016-04-12 17:48:42 +02:00
Pranav Kant
d76b1b5b06 lok context menu: unit test
Change-Id: I244fbf4b98368c7c0d66cdd865e1243639727026
Reviewed-on: https://gerrit.libreoffice.org/23985
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.com>
2016-04-12 14:40:58 +00:00
Miklos Vajna
04216006ee CppunitTest_desktop_lib: avoid #include "../..." style include
Change-Id: Ib5ce0dee00c9306f89ad4b43af4b34e604147a1c
2016-04-07 08:43:45 +02:00
Noel Grandin
1aa4df615f use SAL_N_ELEMENTS in for loops
for with
  git grep -n 'for.*sizeof'

Change-Id: I6211024385e03ac5eeeb38690d2c1c699e015c2f
Reviewed-on: https://gerrit.libreoffice.org/23569
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-31 08:00:13 +00:00
Miklos Vajna
20ad023a91 ccu#1573 sc lok: fix reporting of hidden row height
For columns we use ScDocument::GetColWidth(), which returns 0 for hidden
columsn. Do the same for rows: so instead of using GetOriginalHeight(),
use GetRowHeight(), and then 0 size will be reported for hidden rows as
well.

Change-Id: Ic23b6af744bbc8e194e1906614adebe5ba0c7ced
2016-03-01 12:20:16 +01:00
Miklos Vajna
8071c8cc56 desktop: loplugin:loopvartoosmall
Change-Id: Ic17077b48e0ebf1fe72ba5a5c401dd0e2c609c68
2016-02-19 11:38:55 +01:00
Pranav Kant
f6c9694691 lok: Add a new sheet selection test
This is a test for commit ab199e4748b45384602479c735dbac538e714d34.

Change-Id: I38905cfab8fe1c5721e5fa628ea564f08e0c2ad3
2016-02-19 08:23:00 +01:00
Jan Holesovsky
c0dfafab64 Remove forgotten debug stuff.
Change-Id: Iad6bb5ba62d114ca760c4215aa8eec872c5d181b
2016-02-11 15:22:45 +01:00
Jan Holesovsky
cfa9404319 lok: Extend the StatusModified unit test with Save As.
Change-Id: Ie9bbce6892fe1dcf55e23028e68037f996d7c71f
2016-02-11 15:14:22 +01:00
Miklos Vajna
552361aaad sw: add AnchorType parameter to .uno:Paste
Which allows not hardcoding as-char for LOK.

Change-Id: I3b2987abbaf1f259c614b7b2a8709f15048d362d
2016-01-28 16:43:05 +01:00
Miklos Vajna
e7eca35148 sw tiled editing: default to anchoring new images as-char
Change-Id: I6aeb06fe1697b7a30e83a3b1b364f44e5822fe95
2016-01-21 15:38:43 +01:00
Miklos Vajna
88b458d55d desktop: loplugin:defaultparams
Change-Id: I487cfa6415615e6aa0409889e2c7be5e67eea1c4
2016-01-21 10:41:31 +01:00
Jan Holesovsky
77c677a41d sc lok: Implement unit test for .uno:{Insert,Name,Remove} for sheets.
And fix indexing when at that - the inserting is 1-based, so let's be
consistent in the .uno:Name and .uno:Remove too.

Change-Id: Ib854e81551ae0a39d3ba7c68512e81ea227e9eb1
2016-01-21 08:53:30 +01:00
Stephan Bergmann
c8322b643a loplugin:stringconstant
Change-Id: I678c1fb7d5079dfb1d880e856a0d507f1c89b427
2016-01-20 11:02:04 +01:00
Tor Lillqvist
220b25ba27 WaE: unused variable
Change-Id: I826a1eb45d0669dbe2495b4dbe4a171fcebb0865
2016-01-19 18:17:58 +02:00
Miklos Vajna
cdf08b3aa7 CppunitTest_desktop_lib: add ModifiedStatus callback testcase
Change-Id: Ieb7e808ebc7619c3a4a013cad776eeefd6163e22
2016-01-19 16:45:53 +01:00
Miklos Vajna
802564e036 CppunitTest_desktop_lib: add jpeg paste testcase
Fails without commit 27c6b8586d5d2cd1fa5425b4969d915a0b739475 (svtools:
implement clipboard import of JPEG files, 2016-01-19).

Change-Id: Ic4e3b036b3a6a1c294bf15ef0b206cf1e458fc4e
2016-01-19 14:54:44 +01:00
Caolán McNamara
6fe8925305 basebmp now only used from vcl/headless code
Change-Id: I068d404431d3565f6ad5741edbd3693225824a4d
2016-01-18 20:47:01 +00:00
Miklos Vajna
61161254ab sc tiled rendering: it's pointless to send selection changes during search all
Change-Id: I787cd1760bca0bf7fbc3132579b569882ec25ae2
2016-01-15 10:37:31 +01:00
Caolán McNamara
bc45215ec6 Resolves: tdf#96224 don't fiddle around with a separate alpha buffer
use a format that supports alpha directly

now we can unify the android and linux cases as well and drop the
BGRX support

Change-Id: I3c845913691d8194822423005d308cfa7ef13ec3
Reviewed-on: https://gerrit.libreoffice.org/20440
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-12-07 20:48:41 +00:00
Caolán McNamara
b639fe60ea VirtualDevices either match another device depth, or are 1 bit
cairo can therefore always render to a svp virtual device with
need for a fallback

Change-Id: I5d03ae541820389e26f7448444444be009fb28a4
2015-11-23 14:25:59 +00:00
Miklos Vajna
4bddfc00d2 lok::Document::initializeForRendering: support init. arguments
Change-Id: I8aaf19a50f25f495cb87fba7ff6a4b0f56ed7d80
2015-11-18 16:39:17 +01:00
Andrzej Hunt
396b5f411f sc lok: use client zoom for ViewRowColumnHeaders
Change-Id: I85000851f82ea7cdc4b536683adbc8570de9af7e
2015-11-16 15:42:28 +01:00
Miklos Vajna
1118689e70 CppunitTest_desktop_lib: add Writer comments textcase
Fails without e.g. the last hunk of commit
1ba9d7fd2a7a3e2b4f52ed0f5efdf7df867b9db3 (sw lok: forward key events to
annotation window if necessary, 2015-11-12).

Change-Id: I7f39530881f6141fea956b751aa57eb2bdcadcb2
2015-11-14 17:28:33 +01:00
Andrzej Hunt
fbc3965dc1 lok: send list of commands instead of ClearStyles
We currently send just one command, but this could be expanded
server side in future.

Change-Id: Id8f14196158f3a7fe9c54595d094603efd5e2ce3
2015-11-12 15:09:30 +01:00
Andrzej Hunt
0b5991e486 lok: add Clear formatting to getStyles()
This requires client-side support too.

Change-Id: I5197ed3ed2b8244b50f7faf84a1cadde6a61b2cb
Reviewed-on: https://gerrit.libreoffice.org/19917
Reviewed-by: Andrzej Hunt <andrzej@ahunt.org>
Tested-by: Andrzej Hunt <andrzej@ahunt.org>
2015-11-11 20:36:17 +00:00
Stephan Bergmann
72c48b7166 loplugin:nullptr (automatic rewrite)
Change-Id: I8204a300c98b891a842ef2e40b65f0810dd7817a
2015-11-10 10:31:22 +01:00
Andrzej Hunt
2f13f051c3 sc lok: Add initial test for .uno:CellCursor
This should be extended with checking that we receive "EMPTY"
when there is no cursor shown - that would require e.g. simulating
keyboard input to hide the cell cursor.

Change-Id: Ia7be5ec3e158f21967b4c307ac10abb2b5e2a56a
Reviewed-on: https://gerrit.libreoffice.org/19828
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andrzej Hunt <andrzej@ahunt.org>
Tested-by: Andrzej Hunt <andrzej@ahunt.org>
2015-11-08 09:58:12 +00:00
Miklos Vajna
2bed186753 CppunitTest_desktop_lib: test absolute positions for row/column headers
Change-Id: If2526647221fef2c6b18b21b589192239d8a89ad
2015-11-04 11:23:00 +01:00
Jan Holesovsky
b846b03c70 lok: Fix crash due to non-initialized callback.
Yay for unit tests! :-)

Change-Id: I06b3f929b53d5c03f5722acfdaf0eaf841325e34
2015-11-03 16:59:05 +01:00
Jan Holesovsky
a4988d227c lok: Unit test for LOK_CALLBACK_UNO_COMMAND_RESULT.
Change-Id: I917d47478504dc6fafd3fc675fe8458690c7cc2a
2015-11-03 16:48:10 +01:00
Miklos Vajna
788cec0a60 sc lok: avoid placeholder row when providing all headers
In case the logic visible area is known, info is provided only about the
visible headers. Given that only relative sizes (no absolute positions)
are provided, a placeholder row/col is added to the result that contains
the total size of the skipped items.

These placeholder items are not needed when providing all headers, so
don't emit them.

Change-Id: I48ccb73554313f4d2bb420e4402995719b0f9f7d
2015-11-03 16:27:38 +01:00
Stephan Bergmann
dc586816a9 build fix?
Change-Id: Icb48acfdba90b95ae55d2f4b9f05871dc3a8732b
2015-11-03 14:20:01 +01:00
Miklos Vajna
faa316e670 lok clipboard: support rich text paste
Change-Id: Ida5028969782be792b32b952d3adba0c30dd8bae
2015-10-26 15:39:52 +01:00
Miklos Vajna
7efbbe98d7 lok::Document::paste: check if the given mime type is supported
Change-Id: Ib59ea43700815c53cdd4be819e2e9cf35c6f89e9
2015-10-26 13:38:33 +01:00
Stephan Bergmann
ee5d1b07af loplugin:defaultparams
Change-Id: I12e314ef09ac4b3517135933169de50e8a525dfc
2015-10-22 21:42:05 +02:00
Miklos Vajna
d491ae5692 desktop: add lok::Document::paste() testcase
Also, closeDoc() is called by tearDown(), so no need to call it manually
at the end of tests.

Change-Id: Ib8f61a09fa3fc0885d7ea90ce96210bff4cc9f98
2015-10-22 15:51:41 +02:00
Miklos Vajna
03bb5d52fe sc: initial png export
Change-Id: Iae0e89646eab794879529274f09839ad34aa4696
2015-10-20 18:12:23 +02:00
Miklos Vajna
d42c3e0ddd lok::Document::saveAs: add Writer/Impress/Draw png mapping
Change-Id: I7530281302b9787a9cb9f98f0dee9d98d39cfb05
2015-10-20 17:13:30 +02:00
Miklos Vajna
293dd731e9 vcl: aAlphaBitmap.ImplGetImpBitmap() seen as 0
Change-Id: I3f34f0315045d33ff6e498e24c0dacb0aabb0ff9
2015-10-15 17:18:28 +02:00
Miklos Vajna
d30f5bc3e6 lok::Document::paintTile: fix non-rectangular tiles wrt. transparency
When copying the alpha channel, the offset was incorrect when canvas
width/height did not equal.

Change-Id: If0ab3ec7a4ad4dd958419b566fd473732965cfda
2015-10-15 09:42:26 +02:00