353 Commits

Author SHA1 Message Date
Stephan Bergmann
e57ca02849 Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26 12:54:43 +00:00
Mike Kaganski
1d74d19a76 Monkey business: Fix typo in comments: et -> ed :)
Change-Id: I91440e8582108b9121ac6525c8ac88ad6f218a60
Reviewed-on: https://gerrit.libreoffice.org/31721
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-12-07 11:28:59 +00:00
Andrea Gelmini
f0249a88fc Fix typos
Change-Id: I6730c6c5eab9157533822e5045e9f86109062580
Reviewed-on: https://gerrit.libreoffice.org/29433
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-03 11:21:52 +00:00
Gabor Kelemen
d77a23f8bb tdf#95386 Remove remaining mentions of Help Agent
Replace it with the Help on Help command

Change-Id: Ia454a2f6a123b4fb68fda1eae1e07e99ba81487f
Reviewed-on: https://gerrit.libreoffice.org/29381
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-09-29 09:33:37 +00:00
Markus Mohrhard
4954fff93a disable the two unstable tests for now
We need a replacement for waitUntilDispatcherAvailable that works with
events. Using a timeout will always cause issues.

Change-Id: I8893d701a5f0cf2fd497246d66b220466a000083
Reviewed-on: https://gerrit.libreoffice.org/29275
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-25 17:52:04 +00:00
Luke Deller
328310d52e Fix JunitTest_framework_complex:CheckXTitle
This unit test class relies on calling waitForEventIdle to wait for
UI transitions to complete.  On Windows this is not reliable, due to
VCL's use of PostMessage (Windows message queue) to asynchronously
handle some events such as focus changes.

This issue causes the test to intermittently fail when the dispatcher
for the action the test wants to perform (like closing the print
preview) is not available yet.

 - Change the test code to explicitly wait for the desired dispatcher
   to be available

 - Remove the sleep which was added earlier this year to address this
   symptom in one location

Change-Id: Id701209a28cd0c806ab0a548508d31f9f11211f5
Reviewed-on: https://gerrit.libreoffice.org/29167
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22 09:53:35 +00:00
Tor Lillqvist
3cff108279 Follow-up to 38a3743e0c5d52f9386f74097fd512d3133fbbe3
Change-Id: If70b5754c161a0e1b262abeac8c54dde60515280
2016-08-11 12:16:50 +03:00
Noel Grandin
f4608bde58 remove unused field
Change-Id: Ic8c9b50f496ee97da3f03af966005f28c37ff7e9
2016-06-06 14:28:42 +02:00
Noel Grandin
5f42a268c3 remove unused imports in java code
Change-Id: I95041f49dd22ba9a15da3598b04a010eecf761a8
2016-06-06 14:28:41 +02:00
Miklos Vajna
f8f0f834a1 Add initial CppunitTest_framework_dispatch
Fails with commit 08cf2fd01064306eef7fdbb5b62320947c4d1089 (framework:
last dispatchInterceptor gets asked first, 2016-05-20) reverted.

Change-Id: I0e025a5d8996ecafa6b2fef753d6134079936b00
Reviewed-on: https://gerrit.libreoffice.org/25808
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-06-03 07:03:19 +00:00
Andrea Gelmini
2af018e4dd Fix typos
Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266
Reviewed-on: https://gerrit.libreoffice.org/25420
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25 09:50:55 +00:00
Michael Stahl
e2b37bfb8a framework: CheckXTitle still sometimes fails on WNT...
... when dispatching the .uno:CloseWin.

Change-Id: Iaf0651ea7e05bd8a6629d5af6e62f5918ef241ce
2016-04-28 13:10:34 +02:00
Stephan Bergmann
e2d97f1648 Use UNO service constructors
Change-Id: I8ac2621a4594b2d8a7cf8fdafd2191f3bf52579b
2016-04-13 12:12:14 +02:00
Akash Jain
e1d777722e remove unused m_xFrame in CheckXTitle unit test
Change-Id: I1b654b308b79d13d23a1b9a935fd2eaf84836d91
Reviewed-on: https://gerrit.libreoffice.org/24044
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-13 06:31:22 +00:00
Akash Jain
f6695647b6 add waitForIdleEvent in remaining tests
add waitForIdleEvent in remaining tests in
framework/qa/complex/XTitle/CheckXTitle.java
Change-Id: Ibc98070c797ef56df60cd925353c9e364e83abe0
Reviewed-on: https://gerrit.libreoffice.org/23869
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-07 06:33:16 +00:00
Stephan Bergmann
70ad4333d6 See if waitForEventIdle helps here
...the test often fails with the assertNotNull in prepareQueryAndDispatch
firing, suggesting there's a race in getting the dispatch processed before
proceeding

Change-Id: Ib338d761df638a0c5d53777352cfe7519742112b
2016-04-06 12:19:56 +02:00
Akash Jain
3e253963b9 Add unit tests for XTitle interface
Added several unit tests for the XTitle interface.
Tests are for bugs tdf#96044,tdf#98837,tdf#96896

Change-Id: I9b3990dff02d5d5738024b60e94555199b625a2e
Reviewed-on: https://gerrit.libreoffice.org/23834
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-05 13:33:47 +00:00
Noel Grandin
b9d63d49be remove some unused Java code
found by UCDetector

Change-Id: Ic0295a24b26e206eb53eda2da540755477df86df
2016-03-14 13:44:39 +02:00
Samuel Mehrbrodt
16fb0d3d0f tdf#98407 PathSubstitution: Add substitution for $(username)
This allows to use the username as a placeholder in the config paths (Autotext, Gallery, etc)

Change-Id: I76434e980cd8ec8785a5587d0bc5fdd67dc42de2
Reviewed-on: https://gerrit.libreoffice.org/22901
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-08 15:35:54 +00:00
Andrea Gelmini
534b2a4b58 Fix typos
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3
Reviewed-on: https://gerrit.libreoffice.org/21797
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-05 06:48:38 +00:00
Andrea Gelmini
64d624b651 Fix typos
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10 14:17:20 +00:00
Michael Meeks
3c47809a67 framework: re-enable two dispatch tests, and make them work harder.
Change-Id: I63d72b2d8f0b4835ab0ead51b518deab635ff3b0
Reviewed-on: https://gerrit.libreoffice.org/21222
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-01-08 13:52:47 +00:00
Michael Meeks
3825c28416 framework: restore dispatch API test.
Change-Id: I8a78fee2b43c67feaffb8dbbcd36e96743ca2c9c
Reviewed-on: https://gerrit.libreoffice.org/21208
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-07 17:02:04 +00:00
Noel Grandin
3f50c6e050 java: remove ((unnecessary)) parentheses
Change-Id: I39fbe3a260c8dbfc203662c54eec4db064b88195
2015-11-05 14:55:16 +02:00
Noel Grandin
ff3b3bed94 java: make inner classes static where possible
Change-Id: Icc6444ad15d9f4b50858d8c1b1d3adeaeac40926
2015-11-05 13:43:01 +02:00
Noel Grandin
14bf708ef5 convert "continue" flag to an enum
Change-Id: I160de1152978f301c514d9107c9e9082bab3cf05
2015-10-16 10:56:05 +02:00
Noel Grandin
afc9d56bdd 1327208 UwF: Unwritten field
this class is doing nothing useful at all, just remove it

Change-Id: I77f295f96758f8bf5e29fbdaca5eecc08cd5cf83
2015-10-16 10:16:27 +02:00
Andrea Gelmini
a0649f316e Fix typos
Change-Id: Id94c03249b2752e88499628b3ad12936b361bb2f
Reviewed-on: https://gerrit.libreoffice.org/18950
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
2015-10-01 11:26:35 +00:00
Andrea Gelmini
a18fc918d5 Fix typos
Change-Id: I051caee9ec6181074201ac4a8cb6fcec4fdf2293
Reviewed-on: https://gerrit.libreoffice.org/18951
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
2015-09-30 13:50:06 +00:00
Andrea Gelmini
465489d97a Fix typos
Change-Id: Id884946cae0687d0b71c967e236e58df17567884
Reviewed-on: https://gerrit.libreoffice.org/16707
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-03 09:43:46 +00:00
Andrea Gelmini
5d5dc059cb Fix typos
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9
Reviewed-on: https://gerrit.libreoffice.org/16523
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-28 12:35:58 +00:00
Andrea Gelmini
69c88a32aa Fix typos
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff
Reviewed-on: https://gerrit.libreoffice.org/16522
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-28 12:28:31 +00:00
Andrea Gelmini
aade27554d Fix typos
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b
Reviewed-on: https://gerrit.libreoffice.org/16408
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-22 12:36:21 +00:00
Noel Grandin
754ade38dd speed up Java unit tests by removing sleeps
and replacing them with a call to XToolkitExperimental::
processEventsToIdle

Change-Id: I9fd6cb8af43d902587186310aebe78b5a5ee6932
Reviewed-on: https://gerrit.libreoffice.org/16201
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11 06:47:23 +00:00
Noel Grandin
275f0c7b25 Let JUnit take care of exceptions
Inspired by commit
4dd0ac62855c5b9382cac004c7eebb9bed983a2b

Change-Id: I6ca29aecde357a3cb5852acfc9b5443761052960
Reviewed-on: https://gerrit.libreoffice.org/16094
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-05 13:17:50 +00:00
Noel Grandin
04cadb3191 java: remove some unused code
Change-Id: If1cdc67535b11d9309503b14ffad2aa3718661c6
2015-04-20 11:18:22 +02:00
Julien Nabet
25d3c618d8 Typo: formated->formatted
Change-Id: Iefd4d375a0dfb36732233852f906c6b85dccc2a5
2015-03-25 21:12:16 +01:00
Julien Nabet
ca7f62c826 Typos
Change-Id: Ic03fb2ee6470eac6034be13908dd9ec92cf175b6
2015-02-26 23:03:14 +01:00
Noel Grandin
a7d1292194 java: remove some dead properties
Change-Id: I96adb2941c483ec08c752f35e35cf9ceb941971d
2015-01-13 08:42:56 +02:00
Noel Grandin
7e1dfc0928 java: inline the CheckAPI properties
no need to make this configurable

Change-Id: I0ab149317f4660fc7ebc4c43342d20a386bdbc5f
2015-01-13 08:42:56 +02:00
Noel Grandin
c55f945e4b java: move DEFAULT_SHORT_WAIT_MS to util.utils
so I can turn PopertyNames into an enum

Change-Id: I939a83c0962813302a3653e75976147b2300cb18
2015-01-13 08:42:55 +02:00
Noel Grandin
09330056a0 java: simplify sleeping and waiting in tests
- remove the SHORT_WAIT test parameter, no-one is using it
- inline the various independent shortWait() methods
- use the util.utils.shortWait() utility method everywhere

Change-Id: I93cd4a2580172a1441d2ff3d390f52b9505e2721
2015-01-12 08:36:17 +02:00
Noel Grandin
4bf4e3d407 java: no need to instantiate the AccessibilityTools object
since all of it's methods and fields are static.

Change-Id: Ia2b652969489c5a21e01a35cda65c6e84346aac0
2015-01-12 08:36:17 +02:00
Noel Grandin
3757c03fc8 java: simplify array creation
and remove the need to worry about keeping indexes correct

Change-Id: I9a5fc00f7e28f305279b41099274c96daebebb95
2015-01-09 15:10:51 +02:00
Caolán McNamara
8ab4d2f29f drop crashrep unused since start of LibreOffice
Change-Id: I3df1216054c133314b2317849744a0a37e9fbc8f
Reviewed-on: https://gerrit.libreoffice.org/13733
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-07 11:41:32 +00:00
Noel Grandin
566f16a2fd java: unnecessary imports
found by CodePro

Change-Id: If1b75e43f81d70984422e437147048a491395b66
2015-01-05 10:15:13 +02:00
Noel Grandin
10039462df java: remove more dead code
found by looking for unused parameters (in Eclipse)

Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
2015-01-05 09:59:03 +02:00
Noel Grandin
46540d08b1 java: these fields can become local variables
found by PMD

Change-Id: Id852cfec984a181b91aca1c00a41e342b720a4bf
2015-01-05 08:23:30 +02:00
Noel Grandin
43cc8ad33e java: remove dead code
found by UCDetector

Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2015-01-05 08:23:29 +02:00
Noel Grandin
2d82619a52 java: static fields that should not be static
Found by FindBugs.

Change-Id: I223841f7bb8c515c9612322abc0b13e134385abd
2014-12-19 10:41:58 +02:00