280 Commits

Author SHA1 Message Date
Xisco Fauli
4c8ff754ea tdf#89329: use shared_ptr for pImpl in localisationoptions
Change-Id: I9b2f7f7e59a71c056608635773c4b4fb2120a902
Reviewed-on: https://gerrit.libreoffice.org/26323
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-16 06:46:37 +00:00
Xisco Fauli
3c31796bed tdf#89329: use shared_ptr for pImpl in securityoptions
Change-Id: I91c9c9dcbb9df644836c87d4789521d668c2ba49
Reviewed-on: https://gerrit.libreoffice.org/26319
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-16 06:45:34 +00:00
Xisco Fauli
6cf574071e tdf#89329: use shared_ptr for pImpl in cmdoptions
Change-Id: Ie6297cf8c26964a6c7cc017c1257c61825c2c791
Reviewed-on: https://gerrit.libreoffice.org/26320
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-16 06:44:31 +00:00
Xisco Fauli
11c2acfa5a tdf#89329: use shared_ptr for pImpl in printwarningoptions
Change-Id: I0b202ae78d2afe5fad4aa4bb4a3323f2672b1b93
Reviewed-on: https://gerrit.libreoffice.org/26321
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-16 06:43:44 +00:00
Xisco Fauli
2400c27174 tdf#89329: use shared_ptr for pImpl in extendedsecurityoptions
Change-Id: I3d344c4872bbed9527f254a4eabc48534e38452f
Reviewed-on: https://gerrit.libreoffice.org/26326
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-16 06:42:43 +00:00
Xisco Fauli
912f14c4e5 tdf#89329: use shared_ptr for pImpl in fontoptions
Change-Id: I844f23d7674fe6e564575b150ba1f94754da4d3b
Reviewed-on: https://gerrit.libreoffice.org/26325
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-16 06:42:00 +00:00
Xisco Fauli
6eebac9595 tdf#89329: use shared_ptr for pImpl in misccfg
Change-Id: I90d3d008f68991613775234b29379c31b8f4ad39
Reviewed-on: https://gerrit.libreoffice.org/26237
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-14 11:20:41 +00:00
Xisco Fauli
decc3bfae8 tdf#89329: use shared_ptr for pImpl in compatibility...
... and remove some, at least from my point of view,
useless comments

Change-Id: Id97c90dd7764ae4569468abc73c79ae9b2a56e75
Reviewed-on: https://gerrit.libreoffice.org/26235
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-14 11:19:26 +00:00
Xisco Fauli
7a60b2f3de tdf#89329: use shared_ptr for pImpl in defaultoptions...
instead of unique_ptr as in commit
7bc1c79c26e52d5196fb36eee5c2f12f12d49ba6

Change-Id: I4e57378a333455b818162c6cc8484be9dcaddb03
Reviewed-on: https://gerrit.libreoffice.org/26236
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-14 11:18:27 +00:00
Xisco Fauli
3db4830c41 tdf#89329: use shared_ptr for pImpl in syslocale
Change-Id: I646495e3538cb438a06765fe8cde252bad667bea
Reviewed-on: https://gerrit.libreoffice.org/25969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-14 11:05:22 +00:00
krishna keshav
1d38894b1a tdf#88206 Change uses of cppu::WeakImplHelper*
removed <cppuhelper/implbase1.hxx>

Change-Id: If54eb2fb64be1884ba058858da0d220bbce673f1
Reviewed-on: https://gerrit.libreoffice.org/26074
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-09 07:09:34 +00:00
Mark Page
22fa9289fd tdf#96099 Remove various smart pointer typedefs
Change-Id: I76843139e43ca1c158a977e24d210d5af93e4d0f
Reviewed-on: https://gerrit.libreoffice.org/26014
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08 11:09:44 +00:00
Xisco Fauli
a4a97fb56c tdf#89329: use unique_ptr for pImpl in configvaluecontainer
Change-Id: Ide38cacc59a44515287d51dadb23836eaac14518
Reviewed-on: https://gerrit.libreoffice.org/25904
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06 07:19:06 +00:00
Xisco Fauli
c9ff3efd2c tdf#89329: use unique_ptr for pImpl in accessiblestatesethelper
Change-Id: I768bfd5a19a2633e6d6cd37f919c20cbfc76824e
Reviewed-on: https://gerrit.libreoffice.org/25905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06 07:18:44 +00:00
Xisco Fauli
353e5ea62e tdf#89329: use unique_ptr for pImpl in accessiblerelationsethelper
Change-Id: I29578afa206e869a5b2e6fb42c7f5ebf4a6f2fe8
Reviewed-on: https://gerrit.libreoffice.org/25906
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06 07:10:58 +00:00
Xisco Fauli
5251a7c39c tdf#89329: use unique_ptr for pImpl in fltrcfg
Change-Id: Icbb7d122d7f553215de562a98b0127764b30faa1
Reviewed-on: https://gerrit.libreoffice.org/25628
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30 07:25:10 +00:00
Xisco Fauli
7bc1c79c26 tdf#89329: use unique_ptr for pImpl in defaultoptions
Change-Id: I355888c44d1413f8d0ebd7a247649b79647c38ec
Reviewed-on: https://gerrit.libreoffice.org/25629
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30 07:22:37 +00:00
Andrea Gelmini
2af018e4dd Fix typos
Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266
Reviewed-on: https://gerrit.libreoffice.org/25420
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25 09:50:55 +00:00
Noel Grandin
8a2149c105 clang-tidy misc-assign-operator-signature
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f
Reviewed-on: https://gerrit.libreoffice.org/25154
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-20 07:55:30 +00:00
Noel Grandin
65bfed2bdb loplugin:unusedmethods in unotools
Change-Id: I5729c2a20dd5fb310570cb9e4bb0e0874dbc8049
Reviewed-on: https://gerrit.libreoffice.org/25102
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19 06:41:20 +00:00
Stephan Bergmann
f3e18ad14e loplugin:passstuffbyref
Change-Id: Ifa990214aaf749d039043aa51d3301dc0f1f0e4f
2016-05-12 14:35:23 +02:00
Andrea Gelmini
fc2590cfa1 Fix typos
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73
Reviewed-on: https://gerrit.libreoffice.org/24317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-30 15:06:45 +00:00
Oliver Specht
8d41866f76 tdf#81833: form protection can be modified as compatibility option
ProtectForm is supported to prevent editing outside of form controls
but could only be imported from doc and stored in odt but not changed.
Now it is part of Writer's compatibility settings dialog.

Change-Id: I7337fb3f0774d3c1d26cd8e1485958399b2a70e2
Reviewed-on: https://gerrit.libreoffice.org/24294
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-04-22 13:18:40 +00:00
Stephan Bergmann
4f8756f075 loplugin:salbool: Automatic rewrite of sal_False/True
Change-Id: I57c1bd476183c941a70cc0c60fd4e42bbe95ccb2
2016-04-20 17:27:29 +02:00
Jochen Nitschke
4c7ec9f112 cleanup: remove unused com/sun/star/uno includes
Sequence.h(xx), Any.h(xx) and Type.h(xx)
and remove unused using-declarations from these files.

Add a few missing includes provided by them.

Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4
Reviewed-on: https://gerrit.libreoffice.org/23805
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-12 06:38:26 +00:00
Noel Grandin
fb42d03b5a clang-tidy performance-unnecessary-value-param in unotools
Change-Id: Ife11111b0265da5d5a8a98766a94f3b640b357f5
2016-04-11 15:12:11 +02:00
Noel Grandin
17b1852133 loplugin:constantparam in unotools
Change-Id: I0501e6e7eadd735b1666a8ecb2c5e6da73ce7e67
Reviewed-on: https://gerrit.libreoffice.org/23728
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04 12:03:50 +00:00
Jochen Nitschke
f7a75a66fa cleanup: remove unused Reference.h(xx) includes
and unused using-declarations from Reference.h

Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19
Reviewed-on: https://gerrit.libreoffice.org/23735
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-02 19:01:24 +00:00
Jan-Marek Glogowski
2b11dee484 MM: correctly handle directory in dialog
For convenience we present file URLs in the systems local file
notation. But the directory selection dialog expects an URL, so
we have to convert the local notation from the edit entry to a
file URL.

Change-Id: Idff6f7d4b135eef087c61560b0603b9a6669dbf7
2016-03-24 22:40:50 +01:00
Markus Mohrhard
7da3a53958 don't allocate and destroy a LocaleDataItem for each cell, tdf#97989
Change-Id: I8bcdc7a42c87d17fde1dc9c79bc361bb625f992b
Reviewed-on: https://gerrit.libreoffice.org/23480
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-24 00:29:31 +00:00
Noel Grandin
f958db475d loplugin:constantparam in unotools/
Change-Id: I016cf96af3a93c8f2114657a7e59599f68446ddc
Reviewed-on: https://gerrit.libreoffice.org/23296
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16 10:27:43 +00:00
Eike Rathke
4d857425e0 define ODFSVER_LATEST at a central place
It's already enough to have to adapt the
SvtSaveOptions::GetODFSaneDefaultVersion() mapping for new
ODFDefaultVersion values, get rid of the
SvXMLExport::getSaneDefaultVersion() place.

In the hope that DO NOT USE is taken seriously..

Change-Id: I1eeae698249f68cc375b22cc4cc799107bc14e41
2016-03-15 13:49:12 +01:00
Miklos Vajna
87629f39bb cui: show classification path in SvxPathTabPage
It's not really able to modify it yet, as it wants to select a
directory, and we need a file instead.

Change-Id: I05b0e5a42ef64e56caeae35054fb331e3f1a712c
2016-03-02 13:36:27 +01:00
Miklos Vajna
bf1721917c sfx2 classification: use SvtPathOptions
In preparation to be able to edit the policy path from SvxPathTabPage.

Change-Id: I7a8e03e9acf2e8096a5e00d1424c75fe31735c1d
2016-03-02 13:36:27 +01:00
Matúš Kukan
5a1cd2f30d OSingletonRegistration is dead now
Change-Id: I64a5ffa8790496bd39ba26e0c789db9eedc51071
Reviewed-on: https://gerrit.libreoffice.org/22788
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Matúš Kukan <matus@libreoffice.org>
2016-03-01 19:36:58 +00:00
Noel Grandin
1110346b3b loplugin:unuseddefaultparam in unotools
Change-Id: Icb2dc74263026d90b7998b3fd880fd5d2c67a3b7
2016-02-29 08:04:06 +02:00
Eike Rathke
a097e18323 prepare SearchOptions config with IsUseWildcard
Change-Id: Ifba836f259358d7480502e1701f902c2702b4263
2016-02-25 15:40:08 +01:00
Eike Rathke
1f3357013b SearchFlags::WILD_MATCH_SELECTION, SearchOptions2::WildcardEscapeCharacter
At least '\' (search in Word) and '~' (search in Excel) should be
supported as escape character.

Being able to restrict a match to entire selection instead of substring
speeds up the Calc match whole cell scenario.

Change-Id: Ice242b9cd59009f172b724e03c2cc08feda4cd3c
2016-02-23 23:25:15 +01:00
Stephan Bergmann
b9c71ed6de Avoid -fsanitize=enum when using ScDocOptions::eSearchTypeUnknown
Change-Id: I0ee0c2081b6babb8815d5ba00c5c551854c6a6e9
2016-02-22 12:55:00 +01:00
Eike Rathke
49d2894751 let ConvertToSearchType() also adapt the regex bool, tdf#72196
Change-Id: I6d9c438873f3f26418e6b27884207106ccaea148
2016-02-20 20:04:44 +01:00
Eike Rathke
fb3f66c20f add ConvertToSearchType() ConvertToBool(), tdf#72196
Change-Id: Iaab31cd6afe5cedccd4f79b142aa1ecee8a6e8d4
2016-02-20 00:39:25 +01:00
Chris Sherlock
538f276ae0 Formatting changes across all modules
+ Removed comment cruft
+ Tab formatting in number of files
+ Some commented out code removed
+ Tab characters replaced with spaces
+ Newline cleanup in quite a few files
+ Tweak header guard #endifs

Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc
Reviewed-on: https://gerrit.libreoffice.org/22221
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09 08:11:34 +00:00
Eike Rathke
599f0cbe1d interface to new XTextSearch2 with SearchOptions2, tdf#72196
Places that had utl::TextSearch::UpgradeToSearchOptions2() introduced
are worth an inspection if the new SearchAlgorithms2::WILDCARD search
should be supported or at least use SearchOptions2 instead of
SearchOptions to eliminate the small performance penalty that conversion
involves.

Change-Id: I565f73af2b551ae9ad0f488e672823dc6c5c1109
2016-02-05 17:02:47 +01:00
Noel Grandin
24ada65660 loplugin:unusedmethods unused return value in include/unotools
Change-Id: I3b2281dc713bff92eb3d80fddef04a8a39838aa8
Reviewed-on: https://gerrit.libreoffice.org/21484
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-15 11:51:16 +00:00
Andrea Gelmini
64d624b651 Fix typos
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10 14:17:20 +00:00
Noel Grandin
3f47ffcf58 OModule::onFirstClient is unused
also move the MutexGuard in revokeClient. No need to hold it while doing
an osl_atomic_increment. Save it until we actually need to call
onLastClient.

Change-Id: Ia87f24b66b0430604a2fe717c95223ff1f5ece6d
Reviewed-on: https://gerrit.libreoffice.org/20919
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-24 07:27:05 +00:00
Noel Grandin
1dbe54fd2e loplugin:unusedfields in /include
Change-Id: Ia406e727890a365cc89831c96140cad8240f9b61
2015-12-23 08:13:53 +02:00
Noel Grandin
e18b08363a loplugin:unusedmethods
Change-Id: Ifafdaf6da0225f244853a0042a6458643b570623
2015-12-21 10:20:31 +02:00
Stephan Bergmann
5fa9ce570d Fix order of SAL_WARN_UNUSED and DLLPUBLIC for clang-cl
...which, somewhat arbitrarily, expects GNU extension __attribute__((...)) to
come before MSVC extension __declspec(...) with

  MaybeParseGNUAttributes(attrs);
  MaybeParseMicrosoftDeclSpecs(attrs);

in Parser::ParseClassSpecifier (lib/Parse/ParseDeclCXX.cpp).

Change-Id: I5936558c8fc08b278575b6c678cde6eccd4647fb
2015-12-10 13:30:01 +01:00
Stephan Bergmann
fb8a3fac5d loplugin:nullptr: More NULL -> nullptr automatic rewrite
Change-Id: Ie83819e2bcdc5fa160b39296b005ca9a5ff74b1d
2015-12-10 08:06:06 +01:00