10315 Commits

Author SHA1 Message Date
Caolán McNamara
9954a91eb8 Related: tdf#104312 create palette on demand
Change-Id: I741323c41231a08fe9561d72ca6079079e888e90
2017-01-26 21:04:30 +00:00
Stephan Bergmann
e57ca02849 Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26 12:54:43 +00:00
Noel Grandin
a49cbc5893 loplugin: unnecessary destructor test..unotools
Change-Id: I1fd8a3f39b875d1920759f42e37f4c9d6785d62e
Reviewed-on: https://gerrit.libreoffice.org/33573
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26 10:07:23 +00:00
Stephan Bergmann
00424a277b loplugin:dynexcspec
Change-Id: I5e30befa9338bfd72e237e2bdb7c157526d32b85
2017-01-26 09:07:24 +01:00
Noel Grandin
12ff6d6c35 drop unused param from SV_DECL_PERSIST1 macro
Change-Id: Ie1a0a49effc2d88a4d57cf0e5f3608c6bbf4afb6
2017-01-26 08:13:46 +02:00
Noel Grandin
1480a2d05a add 'explicit operator bool' to our reference classes
Change-Id: I91cfbe2646dcc55b98d2b809c49c9ea073f54f58
Reviewed-on: https://gerrit.libreoffice.org/33517
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26 06:11:42 +00:00
Caolán McNamara
e9c17354d3 move Image ctor variant with mask color to callers
Change-Id: I81a52aeb855edca823881360831b26e252780053
2017-01-25 16:56:08 +00:00
Miklos Vajna
cbc84a6599 tdf#105502 sd increase font size: handle table selection
In part of a table shape is selected, then only operate on the selected
cells, not on all of them.

Change-Id: I3a9ba2b99bcaa2e355b6fcdafdd142d4a809bce6
Reviewed-on: https://gerrit.libreoffice.org/33524
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-01-25 14:38:53 +00:00
Noel Grandin
d5cd223c48 loplugin: unnecessary destructor svx
Change-Id: I7feed30eea4f7367943fa2d6e0d75be5ca209068
Reviewed-on: https://gerrit.libreoffice.org/33516
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-25 11:55:19 +00:00
Noel Grandin
58868eb9ed loplugin: unnecessary destructor svl..svtools
Change-Id: Ie96dda7194c83ba88693f8c91899c732d704a4bd
Reviewed-on: https://gerrit.libreoffice.org/33515
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-25 11:29:08 +00:00
Mohammed Abdul Azeem
8154953add ScXMLTableRowCellContext implements fast interfaces:
Implementation of fast interfaces for contexts in path from
ScXMLImport::CreateFastContext to ScXMLTableRowCellContext.
FastParser is enabled and duplicates are avoided at all
possible places.
OOoXML filters still need those legacy paths we removed,
so I had to temporarily map them to fast elements, which
would increase their load time, but hopefully it should
help us in the long run.

Change-Id: Ie997a9a8b72787da2356abc99ea2cd57c2e5b670
Reviewed-on: https://gerrit.libreoffice.org/28648
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-01-25 11:20:48 +00:00
Noel Grandin
2608523b69 loplugin: unnecessary destructor sfx2..store
Change-Id: Idbf2585e48cd89a43ab68c5c8819880d20461ccf
Reviewed-on: https://gerrit.libreoffice.org/33514
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-25 10:26:05 +00:00
Noel Grandin
ef2b4342e9 loplugin: unnecessary destructor oox..sax
Change-Id: Ie12bfabc92bce04d702f3e77aa5896366e49245e
Reviewed-on: https://gerrit.libreoffice.org/33509
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-25 08:15:36 +00:00
Noel Grandin
96def52140 move GetPosByValue from SfxEnumItemInterface to SfxAllEnumItem
which is it's only use-site

Change-Id: I35943282ad4f5fd5ad297831d63e8abee9a2ddff
2017-01-25 09:10:13 +02:00
Takeshi Abe
6d898945d5 Fix typo in comments: relativ -> relative
Change-Id: I58833e503e93b8057f92710c5828bba6cecd4e09
Reviewed-on: https://gerrit.libreoffice.org/33488
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-25 06:05:54 +00:00
Tor Lillqvist
31e12a9e63 Move two include files to oox/inc as they are used only in oox
Change-Id: Ie13614c1977f45aa8086f4db65ca86b7d9212735
2017-01-24 18:37:56 +02:00
Caolán McNamara
b37ac48935 Resolves: tdf#105450 calc navigator gets 0 height on toggle off/on when docked
Change-Id: Icd346cdf0a208ccaeddd77e6803f4f906361324c
2017-01-24 15:12:32 +00:00
Noel Grandin
1d7c589d50 loplugin: unnecessary destructor cppcanvas..filter
Change-Id: I009cdd60869a67d210edf879ddb451663a7b8676
Reviewed-on: https://gerrit.libreoffice.org/33491
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-24 11:02:35 +00:00
Noel Grandin
a449e0d242 use rtl::Reference in FastParser
instead of storing both a raw pointer and a uno::Reference

Change-Id: I6b67a6098a3ccdce7e29ee8d601c743897032eaf
2017-01-24 10:26:23 +02:00
Noel Grandin
5145f60cc9 loplugin: unnecessary destructor: basctl..codemaker
Change-Id: Iadcfa9bc4fe9efb8d24d6d6afaf2b9b3def0bc3c
Reviewed-on: https://gerrit.libreoffice.org/33452
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-24 04:59:44 +00:00
Takeshi Abe
79497f4587 Fix typo in comments: absolut -> absolute
Change-Id: I8aab9004001a9a2ddd54b4c73857b6f9c5b51515
Reviewed-on: https://gerrit.libreoffice.org/33486
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-24 03:10:14 +00:00
Caolán McNamara
04fafa35fc drop one of the Image ctors
Change-Id: I51178fa30418136d4e5d266715d450f1c967167c
Reviewed-on: https://gerrit.libreoffice.org/33475
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-23 20:38:27 +00:00
Jan-Marek Glogowski
bf110d40ef Change all Idle* LINKs to be Timer*
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles
Link in the Timer class. Now there are two possible solution:

  1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or
  2. split the inheritance of Idle from Timer again to maintain
     different Link<>s and move all common code into a TimerBase.

While the 1st is more correct, the 2nd has a better indicator for
Idles. This implements the first solution.

And while at it, this also converts all call sites of SetTimeoutHdl
and SetIdleHdl to SetInvokeHandler and gets rid of some local Link
objects, which are just passed to the SetInvokeHandler call.

It also introduces ClearInvokeHandler() and replaces the respective
call sites of SetInvokeHandler( Link<Timer *, void>() ).

Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23 20:49:05 +01:00
Pranav Kant
75d8b305bb lok: New feature flag to turn off tiled annotations
Change-Id: Ie418642242ada98d4a41f30bb6cefcd57f398ef0
Reviewed-on: https://gerrit.libreoffice.org/33472
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-01-23 19:32:03 +00:00
Noel Grandin
a90a4810ae loplugin: unnecessary destructor: comphelper..desktop
Change-Id: I9df4cb6a4b1734dac6141d6b0ee7a09e3e05f92e
Reviewed-on: https://gerrit.libreoffice.org/33453
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-23 16:59:48 +00:00
Jochen Nitschke
abc8057ab1 pass ownership by pointer
to show the intend of the code.

assert on invalid objects.
remove useless OSL_ENSURE.
make sure list of owning pointers can't be copied.

Change-Id: I3cccf8ea87585ec9fe62921203a4d12e617ce15c
Reviewed-on: https://gerrit.libreoffice.org/33393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-23 13:50:45 +00:00
Jochen Nitschke
86e99f8461 move defines to only user
Change-Id: I337cc5d58386d9fb018b5343ad76e6f8e8e61405
Reviewed-on: https://gerrit.libreoffice.org/33448
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-23 11:26:21 +00:00
Noel Grandin
00aa9f622c Revert "used std::map in SfxItemSet"
This reverts commit 2757ee9fe610e253e4ccc37423fa420004d0f388.

Besides causing a performance regression, I now notice that
there is code in SW that relies on iterating over two different
SfxItemSet's in parallel, and assumes that missing items are
returned as nullptr, which is not the case for my std::map based
change.

Change-Id: I2b1110350fe4c4b74e5508558e9661ef1e1a103e
2017-01-23 13:19:56 +02:00
Noel Grandin
b0730ff656 fix ubuntu trusty build
Change-Id: I9a7fa68ab69aa9e730bf1e0fb3bc0c49db5f3ef0
2017-01-23 13:18:31 +02:00
Caolán McNamara
936fd770fa just for non exported things
Change-Id: I448d0009d7c8ffec64fdab76897e8684afe7fcd7
2017-01-23 10:22:21 +00:00
Caolán McNamara
aac6bb5bb3 ditch some empty dtors which match the default dtor
Change-Id: Id2450b03e6c8c5461e92d995ea8c33d5dfd55a45
2017-01-23 10:11:59 +00:00
Noel Grandin
abc42b3ea4 use rtl::Reference in SvxPixelCtl
instead of storing both a raw pointer and an uno::Reference

Change-Id: Ie9de5664452545a2a529f753e314aa4678c166fb
2017-01-23 10:56:06 +02:00
Noel Grandin
116fa3a3d2 use rtl::Reference in SvxShowCharSet
instead of storing both a raw pointer and an uno::Reference

Change-Id: I71c9cc4cc643d4b73a34b74c803378da75fd8de0
2017-01-23 10:56:06 +02:00
Regina Henschel
852b29b091 tdf#105266 Make LIGHTEN and DARKEN follow MS specification
Enhanced geometry of custom shapes has got commands for LIGHTEN and
DARKEN of subpaths. MS specifies, that LIGHTEN is a blending with
white and DARKEN is a blending with black. This patch adapts the
calcuation accordingly.

Change-Id: Ie46f1a1a2210c209c3fac34a7a58758b72eb276c
Reviewed-on: https://gerrit.libreoffice.org/33337
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-01-23 08:16:14 +00:00
Noel Grandin
c3199d1d58 fix windows build
Change-Id: Ie32847e22965950d4b2a0e53ccab625a00a6589c
2017-01-23 09:29:05 +02:00
Noel Grandin
98e4013c22 new loplugin useuniqueptr
Change-Id: Ic7a8b32887c968d86568e4cfad7ddd1f4da7c73f
Reviewed-on: https://gerrit.libreoffice.org/33339
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-23 06:59:17 +00:00
Noel Grandin
6f1123d3dd use rtl::Reference in Ruler
instead of manual acquire/release

Change-Id: I7815a0a3c01fce57b4798ac1dbf501e20444c61d
2017-01-23 07:56:34 +02:00
Noel Grandin
ca958f886c use rtl::Reference in SfxInPlaceClient
instead of manual acquire/release

Change-Id: I4ebbdbcbd619991c3dae0733b797f310903f96e6
2017-01-23 07:56:34 +02:00
Noel Grandin
8abcd0c387 use tools::SvRef in ImpSdrObjTextLinkUserData
since the field is SvRefBase-derived

Change-Id: Ie84c48daf93e3805b2db240a497a8496779fe750
2017-01-23 07:56:34 +02:00
Noel Grandin
017911facd use rtl::Reference in OPropertyChangeListener
instead of manual acquire/release

Change-Id: Ie80253b5a59a3e3fcd52f98d9c26bcde42fe985a
2017-01-23 07:56:34 +02:00
Ashod Nakashian
1c27286b9d Lok: support for batch API calls
Mouse and keyboard operations typically
come in batches, and often each results in
tile invalidations and/or layout modifications.

Processing each input event on its own, then processing
the resulting output event is very costly and unecessary
when we know there is more of the same.

The new API adds support for batching such related
input events by disabling the output events generated
by Core until the batch is done. The client can
then process the resulting events, which will
be compressed and deduplicated.

Change-Id: Id381dab807186d010021a8778ee440074a739920
Reviewed-on: https://gerrit.libreoffice.org/33402
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-01-23 03:23:19 +00:00
Caolán McNamara
827dda8c67 coverity#1399437 Uninitialized scalar field
Change-Id: I0df77d7a986ca6485cfe18ee40249d6bb5621528
2017-01-21 17:05:31 +00:00
Caolán McNamara
f9b87a2e50 move GetXGraphic to its only user
Change-Id: I72ec4a7e72ca3355a97f987fab70b3e3a8e45168
2017-01-21 14:46:11 +00:00
Caolán McNamara
370613e591 warn about unused Images
Change-Id: I5502b28411282354019af51a09c860099c652006
Reviewed-on: https://gerrit.libreoffice.org/33348
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-20 18:56:09 +00:00
Caolán McNamara
c41b7a3974 split GetImageForCommand into GetBitmapForCommand and co
Change-Id: I89431532ef26fc33146252e218096e690825b896
2017-01-20 16:46:14 +00:00
Noel Grandin
f7db2b5b3f use rtl::Reference in OSelectionChangeListener
instead of manual acquire/release

Change-Id: I33e3018b5deb4240d4aff1d8136ae6f8f538c779
2017-01-20 12:52:45 +02:00
Jan-Marek Glogowski
7cf3ae68af Apply stricter member access control for Tasks
This disallows changing mbAuto and changing values of
ImplSchedulerData outside of Scheduler / Task functions.

Change-Id: Ia624999bd63190c072eb66427aec38e7ac8cfa1b
Reviewed-on: https://gerrit.libreoffice.org/33317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-01-20 10:32:04 +00:00
Caolán McNamara
8f29ee6c29 Images no longer loaded from resource files
Change-Id: I7155a2c8280b9f511402b908f06470dec419b336
2017-01-20 10:11:59 +00:00
Noel Grandin
84defbc556 new loplugin: useuniqueptr: ucb..ucbhelper
Change-Id: Ib19ca3225b96d1bfec8a43bb762e16597f33b690
Reviewed-on: https://gerrit.libreoffice.org/33297
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-20 06:56:32 +00:00
Noel Grandin
3bb8bdb93f use rtl::Reference in OContainerListener
instead of manual acquire/release

Change-Id: I83e6229029e662073e2e01e98f4846fb0a0ed643
2017-01-20 08:51:08 +02:00