796 Commits

Author SHA1 Message Date
Stephan Bergmann
8af9286632 -Werror=implicit-fallthrough= (GCC 7)
Change-Id: I703a5f19536b08a87f2282a278218d0fcecfb515
2017-01-26 14:07:41 +01:00
Stephan Bergmann
4e3e87e88d Adapt jurt staticsalhack to MACOSX
Change-Id: I0525b68cdb097edd3241809ae0dc9c22e1ad9814
2016-11-07 08:57:33 +01:00
Caolán McNamara
ce757cdd9e coverity#1371380 Resource leak on an exceptional path
Change-Id: I278f8d50dfaaa45e582a34e43ddba3b143203796
2016-08-19 13:00:44 +01:00
Caolán McNamara
29a479c3ce coverity#1371379 Resource leak on an exceptional path
Change-Id: I0e26dfe610aa7e2cb5eb292aca239ba5e1ad34d9
2016-08-19 13:00:44 +01:00
Otto Kekäläinen
428e23f4f7 Fix some spelling errors in comments and strings
Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e
Reviewed-on: https://gerrit.libreoffice.org/26883
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-07-04 06:11:36 +00:00
Noel Grandin
970b0ebb67 [API CHANGE] Drop deprecated I*Description interfaces
And make the fields of com.sun.star.uno.Type private

Change-Id: Ied7698b4157460e9726f271092c92b6b382239fd
Reviewed-on: https://gerrit.libreoffice.org/25971
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-07 08:49:31 +00:00
Noel Grandin
02858c3d49 fix synchronization of JobQueue
Change-Id: I51d58896065a06564d7963aab1145ba9083fdefc
2016-06-06 13:11:55 +02:00
Stephan Bergmann
5c2f970557 cid#1362511: Concurrent data access violation
Change-Id: I35a381f9601178a3aab98b11172d33372d5c3dc1
2016-06-06 10:49:11 +02:00
Noel Grandin
0d1ce0a79e Use AtomicLong in ThreadId instead of synchronizing
Change-Id: Ia10bab23b0cecb587cd3faa9c7e93b18384ecb88
Reviewed-on: https://gerrit.libreoffice.org/25827
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03 09:09:23 +00:00
Noel Grandin
3e4fad756a Use ArrayList for JobQueue
and make various internals of the class privatey

(This is not an ABI change, as package
com.sun.star.lib.uno.environments.remote is not considered part of the
stable URE interface; it is not included in the documentation at
<http://api.libreoffice.org/docs/java/ref/index.html>.)

Change-Id: I25719239c0208b770ecd96b452b4220ac02b309d
Reviewed-on: https://gerrit.libreoffice.org/25779
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-02 07:12:57 +00:00
Miklos Vajna
0c4a408228 jurt: add missing modelines
So that it's harder to introduce tabs in those files.

Change-Id: Iccaf0095fd103c4a3da44afc38f1a9d23be9863f
Reviewed-on: https://gerrit.libreoffice.org/24673
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-05-05 10:17:55 +00:00
Stephan Bergmann
8383055a25 Unused private fields
Change-Id: I69fd266df5cfb5392d1f2b5501bfb0b9e5f2cd83
2016-03-23 08:34:05 +01:00
Christian Lohmaier
69db014220 ThreadPool doesn't exist - etiher point to IThreadPool or implementation
Change-Id: I96e1607945802d06dcc01b64267117d98f9a9994
2016-03-11 13:47:43 +01:00
Christian Lohmaier
a86734ef31 interface is called "DisposeNotifier", not "NotifyDispose"
Change-Id: Ib60120bedb360b178a09a649de635ae3459f3af4
2016-03-11 13:47:42 +01:00
Christian Lohmaier
37e1495307 ComponentFactoryWrapper was removed in 2002
with commit 9e50970ccf5b12d634a8a786579220c0728f1076

Change-Id: Icb1077f9aa47874ec601a93adc3561d0d99c4261
2016-03-11 13:47:42 +01:00
Christian Lohmaier
ee39cab291 [I]ThreadPoolFactory is dead since 2003
f195124f6d58624f31469259a4dd6333e1f5c9cd killed it off for good

Change-Id: Ibf217096d2f14caa5a7b1572895c81ab295f0c46
2016-03-11 13:47:41 +01:00
Stephan Bergmann
b2d53cc003 typo
Change-Id: I8ae443a69aab715a59f347a2de5a36b458a934f5
2016-03-11 11:50:50 +01:00
Stephan Bergmann
feb480d780 Synchronize all access to _sync_counter, _passedAync
Change-Id: I34e9b3fb9481af30ddda8cde45ccbb27819fc452
2016-03-11 11:49:35 +01:00
Stephan Bergmann
1629228b7b cid#1326391: Dereference null return value
...replacing implicit NullPointerException with explicit IOException

Change-Id: I673c836c64e141a7a3e4b40fca0922feee26bd03
2016-02-24 11:33:50 +01:00
Stephan Bergmann
d79ce8ba8f cid#1326441,1326442,1326392: Dereference null return value
...replacing implicit NullPointerException/IndexOutOfBoundsException with
explicit RuntimeException

Change-Id: I519b0fcd2b2d2657ae82ef7eb28f88a0e13fa970
2016-02-24 11:33:50 +01:00
Stephan Bergmann
3e945cbd9b Be specific about illegal input
Change-Id: Ib840f5516e503ce92078150933217149fd322bde
2016-02-24 11:33:50 +01:00
Stephan Bergmann
74a18f64ee cid#1326440 Dereference null return value
...replacing implicit NullPointerException with explicit RuntimeException

Change-Id: I14dfe81a6a05d33cb311a6274c085ea0dcf95692
2016-02-24 11:33:49 +01:00
Caolán McNamara
6727fa5831 coverity#1326462 Dereference null return value
Change-Id: I80358cffe74f64fa710d9381b9615b64f903db3e
2016-02-18 17:21:18 +00:00
Noel Grandin
2087484c65 use consistent #define checks for the Windows platform
stage 2 of replacing usage of various checks for the windows platform
with the compiler-defined '_WIN32' macro

In this stage we focus on replacing usage of the WIN macro

Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84
Reviewed-on: https://gerrit.libreoffice.org/22393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-17 11:33:57 +00:00
Stephan Bergmann
cd9cafe54c cid#1326191 is a false positive
and trying to appease Coverity with throwing a (checked---semantics attached!)
java.io.IOException is plain wrong.

Change-Id: Icece5ac74d482791d089f40ec201bc39d61db177
2016-01-22 12:47:47 +01:00
jan iversen
e39bf36771 cid#1326191, 1326202
Null references elements, introduced throw

Change-Id: I22bf7de5f20c3ca455df31de2a5d7301b436ed82
Reviewed-on: https://gerrit.libreoffice.org/21691
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-22 09:07:53 +00:00
Andrea Gelmini
64d624b651 Fix typos
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10 14:17:20 +00:00
Caolán McNamara
7653682c35 coverity#1326730 DMI: Dubious method invocation
Change-Id: Icf44c82fc485d0172df2a9fb2cbe6b2be61630a1
2015-12-22 20:30:34 +00:00
David Ostrovsky
1fd41f43eb Add build toolchain to upload LibreOffice API to Maven Central
Set up the toolchain to create sources and javadocs artifacts in
addition to JARs created during the build. Use Buck build tool for
that: [1]. This is a fork of Google's build tool Blaze, created by
Xooglers at Facebook. This build tool (like Blaze itself) uses
Python to write build files.

Add needed tools and build files to install LibreOffice API artifacts
to local Maven repository or deploy them to Maven Central.

To build all needed artifacts LibreOffice must be built regularly
with GNU make first. To build the rest of the API (sources and
javadocs):

  $> buck build api

To replace version number with upcoming release version:

  $> solenv/bin/version.py 5.1.0

To install the API to local Maven repository:

  $> buck build api_install

To deploy the API to Maven Central:

  $> buck build api_deploy

Detailed documentation is added to document the prerequisites and
the workflow to upload LibreOffice API to Maven Central.

* [1] https://buckbuild.com

Change-Id: Ibdd552a01110836703bc069abe829b9921491cac
Reviewed-on: https://gerrit.libreoffice.org/20343
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-12-03 23:32:11 +00:00
David Ostrovsky
9ca2de8c59 Expose metadata to deploy LibreOffice artifacts on Maven Central
As outlined in the requirements to deploy the artifacts on Maven
Central, the metdata must be provided:

* Project Name, Description and URL
* License Information
* Developer Information
* SCM Information

[1] http://central.sonatype.org/pages/requirements.html

Change-Id: I0bcd19a22d0e1a48f0faec0b414f816f7da5b318
Reviewed-on: https://gerrit.libreoffice.org/20315
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-12-01 08:45:25 +00:00
Caolán McNamara
8244fc2655 coverity#1340230 Dereference before null check
ah!, the original code had a type in it. That's
why it was refactored to remove the null check.

Now a proper fix for cids: 1326180<->1326190

Change-Id: Iba7fd47c03eb5c157f878e0e297e8688f20ae348
2015-11-25 15:45:58 +00:00
Caolán McNamara
cbc5dc14d6 coverity#1326190 Explicit null dereferenced
set this back to its original code pre..

commit e5bc8b60ecfca09a2014ab7090659f3428c8efa0
Date:   Tue Aug 5 12:18:20 2014 +0200

to silence coverity about it

Change-Id: I9d8f1bda1a32fbf97c0bdc73edfeab9f74d6443a
cids: 1326180<->1326190
2015-11-24 10:35:44 +00:00
Stephan Bergmann
ba8a957bfa Generalize COM_GCC_IS_CLANG -> COM_IS_CLANG
...in anticipation of building with clang-cl.exe on Windows

Change-Id: I1d723c9d3b5ca8a2bc6b27ef0189a7b053581398
Reviewed-on: https://gerrit.libreoffice.org/19928
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-11-12 17:37:11 +00:00
Noel Grandin
b73db446ac java: combine nested if statements
Change-Id: I0457b81668e9427a3c8d6a4af93438b7fb2bb7ba
2015-11-05 14:55:15 +02:00
Caolán McNamara
fb8d764d84 coverity#1327460 DLS: Dead local store
Change-Id: I53431357f153d61d3f80e9a3e76358d8e9bb0e0b
2015-10-20 21:18:33 +01:00
Noel Grandin
846135c4c9 use AtomicInteger for _life_count
(cid#1326323 Unguarded read)
Just switch this to an AtomicInteger, it's cheaper, and doesn't require synchronization,
so less chance of a deadlock.

This is an API change since this is a protected field in a public class, but anyone
messing with the internals of this class should have known better.

Change-Id: Idafc760c2e9d83442b8209ad23d180acb8dccb20
2015-10-15 11:28:09 +02:00
Noel Grandin
a1624a8ecd cid#1327023 to cid#1327077 SIC: Inner class could be made static
Change-Id: I41f89c4feefe4e012d72c663ebb9bbcb4aa7f163
2015-10-15 09:23:16 +02:00
Andrea Gelmini
9956b99e68 Fix typos
Change-Id: I44bdb63bef76e9686e995661a24a3bef7cd50ab7
Reviewed-on: https://gerrit.libreoffice.org/18959
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30 11:03:11 +00:00
Noel Grandin
9ffdcc7685 fix use of TCP_NODELAY for localhost URP connections
we implemented this logic in the C++ URP code a while back, but the Java
code was not correctly updated.

Change-Id: I377d7150f1adb69d6f86d9b4f3406163aaf85aea
Reviewed-on: https://gerrit.libreoffice.org/17427
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-31 08:17:23 +00:00
Andrea Gelmini
9f27e5b0e0 Fix typos
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c
Reviewed-on: https://gerrit.libreoffice.org/17187
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-19 19:45:07 +00:00
Andrea Gelmini
7f73bb5b44 Fix typos
Change-Id: I8e429d1f03aac7c7cdb7ff4b43b3f46d40292510
Reviewed-on: https://gerrit.libreoffice.org/16709
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-03 08:19:04 +00:00
Julien Nabet
2a65bf32ec Revert "Typo: iff->if"
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d.

iff can mean "if and only if" so not a typo
2015-06-23 20:42:27 +02:00
Julien Nabet
cf92da3d6e Typo: iff->if
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-06-23 20:30:11 +02:00
Andrea Gelmini
aade27554d Fix typos
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b
Reviewed-on: https://gerrit.libreoffice.org/16408
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-22 12:36:21 +00:00
Noel Grandin
0c18bedb73 java: 'final static' to 'static final'
this is the canonical order, and it makes the code easier to read

Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470
Reviewed-on: https://gerrit.libreoffice.org/16242
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-15 08:45:19 +00:00
Noel Grandin
efd4bfa818 java:regulatize the order of 'final' and public/private
Make the order be 'public static' or 'private static'
Just makes the code nicer to read.

Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2
Reviewed-on: https://gerrit.libreoffice.org/16202
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11 09:34:00 +00:00
Noel Grandin
14bc818895 java: some random small cleanups
Change-Id: I22a5b9fa29d465a21e682279e6e88d37bd8adf93
2015-04-20 11:18:22 +02:00
Julien Nabet
800e09a3ce Typos: caculate->calculate + acceses->accesses
Change-Id: Id2b645829ceb9affc76483a651fe6830a9f01cda
2015-02-21 14:45:36 +01:00
Noel Grandin
c9e6b58541 enable tcpNoDelay for loopback connections automatically
it can make a significant speed difference for applications
talking to the office binary via UNO

Change-Id: If6e901908fe6a6119ac1fd0bf8feebabe5602ff7
Reviewed-on: https://gerrit.libreoffice.org/13856
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-20 10:40:44 +00:00
Stephan Bergmann
8672eca430 -Werror,-Wmacro-redefined (under Clang -fsanitize=*)
Change-Id: Ifd23373b1ac4919793d1b4251ed90cf2dd6f2bda
2015-01-06 14:35:18 +01:00