2873 Commits

Author SHA1 Message Date
Zdeněk Crhonek
425c92291b add LEN test case
Change-Id: I99ee54406f446d9b97a61cbd3ec1a58115b544bf
Reviewed-on: https://gerrit.libreoffice.org/30392
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-30 16:17:04 +00:00
Zdeněk Crhonek
20dd5fbecc add FORECAST.ETS.ADD test case
Change-Id: I841115854791b329417b7ff0798e55dfccf93a9e
Reviewed-on: https://gerrit.libreoffice.org/30357
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-30 16:16:13 +00:00
Zdeněk Crhonek
40c4cc9a6b add MAXA testcase
Change-Id: I05a15da6526449342c9f0f41960c461e67df50ec
Reviewed-on: https://gerrit.libreoffice.org/30353
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-29 23:08:55 +00:00
Zdeněk Crhonek
6d68b2bbc9 add HYPGEOMDIST test case
Change-Id: I996161ff95fb682f3a9bb62fe6444be96fd6fd3f
Reviewed-on: https://gerrit.libreoffice.org/30355
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-29 18:54:57 +00:00
Zdeněk Crhonek
4d67dca78d add LOGINV test case
Change-Id: Ie05a462418322aac43f36c069749fdae195a8585
Reviewed-on: https://gerrit.libreoffice.org/30354
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-29 18:43:27 +00:00
Zdeněk Crhonek
eef81dd68f add MAX test case
Change-Id: Ie32504b84e227cc3f33d89ec46bca1835e433844
Reviewed-on: https://gerrit.libreoffice.org/30352
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-28 16:08:59 +00:00
Kohei Yoshida
b5c65b53de Rename ClearFormulaContext() to make it more representative.
In the future we might put more prep code in here, in addition
to clearing the context data.

Change-Id: I44256a0dfbe1301e2c1443b291f4635ca0ba80f5
2016-10-24 21:50:47 -04:00
Henry Castro
8dc495c932 sc lok: fix cell cursor when hide column/row
Change-Id: Icfa7debe06f6dfae3efcbd9d878d3b2d5aecf92f
Reviewed-on: https://gerrit.libreoffice.org/30169
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-10-23 13:31:40 +00:00
Miklos Vajna
5d8ba79849 CppunitTest_sc_ucalc: fix loplugin:cppunitassertequals warnings
Change-Id: Ie29cc49b98cb06f9b6a30b27d0c53f9393c28b67
Reviewed-on: https://gerrit.libreoffice.org/30119
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-10-21 08:52:50 +00:00
Eike Rathke
27fcf60468 unit test for tdf#97968, Cut&Paste grouped references adjustment
Change-Id: Id644012454d992c01ebcce6fe35d1dcdd1bc4d53
2016-10-20 19:39:53 +02:00
Stephan Bergmann
d6ff3d49df Plugin::isInUnoIncludeFile should not cover WORKDIR
...that got in, for no apparent reason, when various, slightly different
implementations of isInUnoIncludeFile got consolidated into one.

Change-Id: I64a9eb62703d57a0b7b57720ec9f251ffa780691
2016-10-19 10:56:35 +02:00
Kohei Yoshida
42062d99f1 tdf#93894: Write a new test case for column and row labels combined.
Change-Id: I76e1f6f3c3aed9d940e4433026f752f3630f2373
2016-10-18 20:27:45 -04:00
Kohei Yoshida
2b32042294 tdf#93894: These assumptions no longer hold.
Since we've switched to not grouping formulas with column / row
labels.

Change-Id: I0097a5103b5dfaa5b021ee76545beb9f24ac7bd3
2016-10-18 20:27:36 -04:00
Eike Rathke
5cfbab03f9 unit test for tdf#101583, named expression reference expansion
Change-Id: I40dc157ebb33da59e436214b703800dfabc11a23
2016-10-18 21:00:17 +02:00
Zdeněk Crhonek
5eb51c559f add EXACT testcase
Change-Id: I6e0d868e0e3dc8e1575145fc942fdb208f121887
Reviewed-on: https://gerrit.libreoffice.org/29918
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-18 06:25:20 +00:00
Zdeněk Crhonek
95a5751125 add FIND test case
Change-Id: I4e053243df348f2ad4edfc78bb93c4226fe66d8c
Reviewed-on: https://gerrit.libreoffice.org/29933
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-18 06:25:05 +00:00
Zdeněk Crhonek
b546d20b9d add LOGNORM.INV test case
Change-Id: I0ba74df841161a06d7ce1f697d44ecd9aeaea560
Reviewed-on: https://gerrit.libreoffice.org/29974
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-18 06:23:54 +00:00
Zdeněk Crhonek
c698f78e1a add FIXED test case
Change-Id: I9016563b9d01b3ac917e10f17f844b1ce3a3f13c
Reviewed-on: https://gerrit.libreoffice.org/29979
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-18 06:22:56 +00:00
Zdeněk Crhonek
b868fbfaf3 add LOGNORMDIST test case
Change-Id: I08df55702e8dfe251c57fbb0ff3bde876e0934e8
Reviewed-on: https://gerrit.libreoffice.org/29975
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-18 06:22:42 +00:00
Jochen Nitschke
9ac8a57e52 replace <<= with assign for <<= with rhs Any
makeAny and Any ctor return an Any

Change-Id: Iaa361bc315d785f80153acf1009bf47d109728ec
Reviewed-on: https://gerrit.libreoffice.org/29914
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-17 15:39:13 +00:00
Stephan Bergmann
4cfb22aaf5 clang-cl loplugin: sc
Change-Id: I24d091174ab602ecf80c65ad75fd450e55cb01ac
Reviewed-on: https://gerrit.libreoffice.org/29856
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-16 14:18:19 +00:00
Bartosz Kosiorek
5239cefff5 tdf#46738 Fix exporting .xlsx of coloured empty cells
When spreadsheet contains more that 84 cells, and these
cells are empty, but contains additional data (border color,
text color, specific formatting), the remaining rows are
ignored during export to .xlsx and .xls
As a result such empty rows are not saved during export.
This patch is fixing most cases and make sure that at least
first 84 empty cells will be preserved.
It is not impacting the performance as it is still notchecking
next columns when the visible cells are more that 84 characters.
This patch improve exporting empty cells, but not impacts
performance.

Change-Id: Ia7027e2c8a2fd48ab4a0e840f970d57167454451
Reviewed-on: https://gerrit.libreoffice.org/29899
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-16 11:33:24 +00:00
Zdeněk Crhonek
842e503a03 add BETAINV test case
Change-Id: I0e3ed47b3efd4f869ab7d3b75577282d37b76619
Reviewed-on: https://gerrit.libreoffice.org/29895
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-16 11:29:20 +00:00
Zdeněk Crhonek
f44bb50070 add DOLLAR test case
Change-Id: I8bbc8b14faf17cd2219a26b25fe10ceb448b90ba
Reviewed-on: https://gerrit.libreoffice.org/29896
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-16 11:29:10 +00:00
Zdeněk Crhonek
51069a07fb add CRITBINOM test case
Change-Id: I0f6c28937da22ab3b514a51e5c4f63ca89377169
Reviewed-on: https://gerrit.libreoffice.org/29906
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-16 11:29:01 +00:00
Zdeněk Crhonek
a72f5d020f add GAMMA.DIST test case
Change-Id: Id17a38c823d0dae6bdf2bd7ec550b7b0f6e0c7f2
Reviewed-on: https://gerrit.libreoffice.org/29905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-16 11:28:52 +00:00
Marco Cecchetti
6c9337866d LOK: Calc: missing invalidate when ending larger-than-cell edit text
- reason: when text content goes further than the cell border the
output area of the edit view is grown (extended to an adjacent cell),
on the contrary the output area of edit views used only for
invalidating windows of other view shells is never updated, so, in
other views, only the tile where the edit cell is placed is
invalidated;

- solution: instead of adding fake edit views for invalidation porpuse
(and having to updated the output area of each of them when required),
the new solution provides each new edit view, created on cell editing,
with a set of `foreign` windows related to other views, they are added
and removed to this collection owned by an edit view still using the
ScExtraEditViewManager, which has been in turn simplified; when
EdiEngine::UpdateViews is invoked not only the window where the edit
view lives is invalidated but also all `foreign` windows in the owned
set;

- note: ScTiledRenderingTest::testTextEditViewInvalidations unit test
has been enhanced in order to test correct invalidation when text
content goes out of the starting tile.

Change-Id: Id223fb1a032d3b18d2cf70df31f704abd245b3ac
Reviewed-on: https://gerrit.libreoffice.org/29625
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/29658
2016-10-14 15:01:36 +00:00
Winfried Donkers
f613f6e697 tdf#102212: correct constraints for Calc functions CRITBINOM, BINOM.INV.
Argument alpha can be 0<=alpha<=1.

Change-Id: Ic1e6dec52bcfe227de49f6b9af38a618f4602c95
Reviewed-on: https://gerrit.libreoffice.org/28934
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-10-14 14:11:24 +00:00
Winfried Donkers
d8257535e3 tdf#102742 fix wrong results for MOD function
ScInterpreter::ScMod has been largely rewritten and
a constraint check has been added (numerator != 0).
It appears that integer values of arguments cannot accurately
determined nor converterd accurately to int values, so no simpler
(faster) treatment for integer values.
Updated test document.

Change-Id: I3af60d93019b212ce7c03eea48b509bfbc713cf7
Reviewed-on: https://gerrit.libreoffice.org/29365
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-10-13 19:46:43 +00:00
Winfried Donkers
fb790880eb tdf#94635 follow up; handle linear data properly when samples in period
are to be calculated by function.

Applies to all FORECAST.ETS functions with argument period_length having
value 1.

Change-Id: Icb5a0288670321caf0dd5b70bee4b8811b9ba4a9
Reviewed-on: https://gerrit.libreoffice.org/28923
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-10-13 19:04:48 +00:00
Zdeněk Crhonek
62456ee206 add DECIMAL test case
Change-Id: Ia39837e0bf92008a7aceb97afd2f657c46287514
Reviewed-on: https://gerrit.libreoffice.org/29700
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-13 07:44:23 +00:00
Noel Grandin
fa25280bf8 convert SC_MATVAL constants to typed_flags_set
Change-Id: I973c5253b385a5495bec38201655e3dbcb9a6f81
2016-10-12 08:44:50 +02:00
Noel Grandin
5c84f40ea2 loplugin:constantfunction
update the plugin similarly to
    commit 3ee3b36ae0c064fb5c81268d8d63444309d1b970
    Author: Stephan Bergmann <sbergman@redhat.com>
    Date:   Fri Oct 7 12:05:49 2016 +0200
    loplugin:staticmethods: Don't be fooled by decls starting with macros

Change-Id: I98ac3216d5acf89a49a26feb089ae2fd34e6e510
Reviewed-on: https://gerrit.libreoffice.org/29665
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11 06:15:21 +00:00
Caolán McNamara
e0d442b199 try enabling password tests on mac and windows
Change-Id: I4054a3c285828f8c5a7d2c4b6e2716fd79c5fdf7
Reviewed-on: https://gerrit.libreoffice.org/29666
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-10 19:47:02 +00:00
Jacek Fraczek
f004aa9951 tdf#89307: Removed SvRef::operator T*()
Conditional statements are using SvRef::Is() method.
Changed static_cast<T*>(svRef<T>) occurances to svRef.get().
Added operator == and != to SvRef.

SbxObject::Execute is using SbxVariableRef internally.
SbxObject::FindQualified is using SbxVariableRef internally.

Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395
Reviewed-on: https://gerrit.libreoffice.org/29621
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-10 08:48:30 +00:00
Tamás Zolnai
73268333b0 Pivot table tests: Check also grouped fields' name.
Change-Id: I6b38e8e97613f63accf341115bbc1397ade07415
2016-10-09 20:20:58 +02:00
Kohei Yoshida
f37292941f Write test case for it.
Change-Id: I63f8b5d490686f838c0618d670bb21a957690866
2016-10-07 22:05:11 -04:00
Tamás Zolnai
9d19634c8e Pivot tables: Fix XLSX import of nested date groups
Same fix which was added for other kind of groups:
f697d7aa5c26f9fcfd717b76a4827a5bcb38325e

Change-Id: Ic35602ce32cc35933edebc6256e85b2a2a691b77
2016-10-08 04:52:03 +02:00
Eike Rathke
21d8c021b3 unit test for tdf#101562
Change-Id: I4cf35e541875e89928d43b1f7e8392908c3ffb0b
2016-10-07 20:37:10 +02:00
Henry Castro
af239f5aff sc lok: add .uno:AutoSum
Change-Id: Id2bc0200734308aae1c2e39814c22c6b76664c59
Reviewed-on: https://gerrit.libreoffice.org/29525
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-10-05 17:12:18 +00:00
Noel Grandin
315c06d792 loplugin:unnecessaryoverride in sc
Change-Id: I149e65eb605d405be54c7340ff2e668cc18c7552
2016-10-05 11:48:37 +02:00
Kohei Yoshida
1d37ad2575 Actually this should check for the top shared cell.
To be extra cautious.

Change-Id: I667d01dd82d957a0203a15602d9a2dacf7dc7e83
2016-10-04 20:33:46 -04:00
Tamás Zolnai
7e1fd9aa86 Pivot tables: Fix wrong group field number in cache
getCache should not append new group fields to the cache,
but use those which are stored in the dimension data.

Change-Id: I2011b0d3a22644a86c31500d74469b9c4c641649
2016-10-05 06:03:41 +02:00
Tamás Zolnai
93098854c2 Test XLSX import of number groups
Change-Id: I12a8f301607240684676c5b50bdad0eea0923f97
2016-10-05 06:03:40 +02:00
Tamás Zolnai
f1a97fab95 Test XLSX import of date groups
Change-Id: I25cd7e946231a718ca1c0ed64fb5e32b2a81abe8
2016-10-05 06:03:40 +02:00
Kohei Yoshida
9588276733 tdf#93894: Add unit test for this.
Change-Id: Ifd38b9fde776d9be48e776972993856cfe59b477
Reviewed-on: https://gerrit.libreoffice.org/29515
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2016-10-04 03:50:35 +00:00
Zdeněk Crhonek
f7e01c5834 add INTERCEPT test case
Change-Id: I87038e7f0a33e81815591765550dc08944d7eb3d
Reviewed-on: https://gerrit.libreoffice.org/29505
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-03 20:32:18 +00:00
Zdeněk Crhonek
b5823a8498 add LARGE test case
Change-Id: Id60b843887a9b55fa72bb26199972e32c2ab2ebb
Reviewed-on: https://gerrit.libreoffice.org/29507
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-03 18:28:36 +00:00
Zdeněk Crhonek
c08b96a139 add KURT test case
Change-Id: Ie1f469eebaf85cbb0a519d43e300353dff68922e
Reviewed-on: https://gerrit.libreoffice.org/29506
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-03 18:23:02 +00:00
Marco Cecchetti
8ef2032886 Calc: implemented parallel cell text editing
Change-Id: If8cc7a637cee6ba66813d55b25160fee13a2a219
Reviewed-on: https://gerrit.libreoffice.org/29410
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-10-03 12:13:15 +00:00