14051 Commits

Author SHA1 Message Date
Caolán McNamara
e3203ad42d remove newly unused SfxModule::GetImageList_Impl, etc
Change-Id: Ibb1430d2b6c7994b2425d686cf206d168530faef
2016-12-21 11:07:22 +00:00
Caolán McNamara
e0b71d8e5a remove newly unused SfxImageManager
Change-Id: If68637fe49b5d252ad4ec5d63d56261113be6a7c
2016-12-21 11:07:21 +00:00
Noel Grandin
735a002507 convert EnumContext::Context to scoped enum
Change-Id: I16ec63beb801073e5d604d852892c2fd6e8d8fc3
Reviewed-on: https://gerrit.libreoffice.org/32272
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-21 10:34:13 +00:00
Noel Grandin
5ec1b04b9b convert EnumContext::Application to scoped enum
Change-Id: Ia289a7b63bf8797085315218785e2a2a4c45d232
Reviewed-on: https://gerrit.libreoffice.org/32230
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-21 07:10:54 +00:00
kerem
027a41959c tdf#97361: Changed naming in sfx2 python tests
Change-Id: Iabacaff8fd7f282a903885954a7d725ceb6f6c16
Reviewed-on: https://gerrit.libreoffice.org/32118
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2016-12-20 23:34:30 +00:00
Julien Nabet
6c77c2fdf6 Downgrade SAL_WARN -> SAL_INFO
Change-Id: I2f0957ee2ce7156e8ea9ce376787d2898e517fbf
Reviewed-on: https://gerrit.libreoffice.org/32252
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-20 21:22:08 +00:00
Tibor Móger
86519381cd tdf#94576 handle esc keypress on templatemanagerdialog
SfxTemplateManagerDlg now overrides behaviour of ModalDialog on
EventNotify by checking if the pressed key was esc and
the searchFilter is not empty and it was focused. In this case
instead of letting ModalDialog close the modal
it clears the searchFilter

Change-Id: I90d91a3b152f68b6c8780963d1b95258d9ccf23a
Reviewed-on: https://gerrit.libreoffice.org/31736
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-12-20 20:22:39 +00:00
Stephan Bergmann
8a71eacef7 Don't use 'this' in ctor
Change-Id: I405160743609aae92a37b2359bea5aa42ee66519
2016-12-20 14:13:13 +01:00
Stephan Bergmann
1b616752ea Result of css::ui::ContextChangeEventMultiplexer::get cannot be null
Change-Id: I00fba6c2a79404c824feaa5bb302d37c4158f9a3
2016-12-20 11:44:27 +01:00
Noel Grandin
ed2b8ca92a convert SFX_EVENT constants to scoped enum
SFX_EVENT_CLOSEAPP and SFX_EVENT_TOGGLEFULLSCREENMODE are never
generated,
so remove them and delete the code that receives them

Change-Id: I2d003ba73fff0b02120ba29ff58e1d2399dedf00
Reviewed-on: https://gerrit.libreoffice.org/32168
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-20 06:08:30 +00:00
Gaurav Dhingra
9fa5439cb6 tdf#104622 Add duplicate node entry to elements in emoji.json database
Add boolean field "duplicate": true

Change-Id: I8e45ed4694bfc75b18c2405146e5eaa142559c1b
Reviewed-on: https://gerrit.libreoffice.org/31997
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-12-19 18:22:50 +00:00
Tor Lillqvist
b01c31598d loplugin:unreffun
Change-Id: I4663de7eb81b7af39b5a24581667fd7fcfb829cd
2016-12-19 11:32:28 +02:00
Noel Grandin
f573de2a95 no need to wrap calls to SAL_INFO in #ifdef DBG_UTIL
Change-Id: Ic373a8f145f3f78c3f109e36a9c1dd9156f0dd75
Reviewed-on: https://gerrit.libreoffice.org/32034
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-19 08:29:01 +00:00
Caolán McNamara
429290b8cf -Werror=maybe-unintialized
Change-Id: I73eb58e44c00d5e1cfcabe71f2ba946a81a62fa7
2016-12-16 15:24:22 +00:00
Pranav Kant
c5ceb0134d lok: Fix state feedback for ToggleMergeCells
Now it broadcasts "disabled" to disable the command and
true/false to tell the status of the command which automatically
means "enabled"

Change-Id: I3314da77fb2b84d97f64b9832d65791b84fcd7df
Reviewed-on: https://gerrit.libreoffice.org/32086
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2016-12-16 15:07:31 +00:00
Pranav Kant
3ab307e568 lok: Sort ascending/descending is enabled/disabled state
... and not true/false

Change-Id: Ie9ae6cbf70c1934dda1002deabda23c9f461c8b1
Reviewed-on: https://gerrit.libreoffice.org/32085
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2016-12-16 15:06:31 +00:00
Caolán McNamara
eb0e2dabde coverity#1397200 Unchecked return value
and

coverity#1397201 Unchecked return value
coverity#1397202 Unchecked return value

Change-Id: I73cc6e3b08e6a44b27be2093ba568d46ebe0659a
2016-12-16 01:48:37 +00:00
Noel Grandin
d15b4e2045 teach sallogareas plugin to catch inconsistencies
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a
Reviewed-on: https://gerrit.libreoffice.org/32004
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-15 06:45:14 +00:00
Katarina Behrens
8020215f1f SafeMode: s/LibreOffice/%PRODUCTNAME/, small UI changes
nouns are written Upper Case only in German
also Cancel button looks odd as secondary

Change-Id: Id1b051cbb86ab69ea88c7b1da2cda3eb19f063de
Reviewed-on: https://gerrit.libreoffice.org/31971
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-12-14 09:00:50 +00:00
Stephan Bergmann
e90b004a41 That's probably not meant to be a C++ reference to a uno::Reference
...as introduced with e75f6e549eb825c310d16d11babf0fba5ee7fd7a "sfx2: make
SfxClassificationHelper not require a full doc shell".  Made
CppunitTest_sfx2_classification crash now when dereferencing
m_xDocumentProperties in
SfxClassificationHelper::Impl::pushToDocumentProperties, when built with a
recent Clang trunk build.

Change-Id: Id0b7fa0627b9642f748f07d7dfa05353114225fa
2016-12-13 19:34:00 +01:00
Adam Kasztenny
69d11029d6 tdf#95416 Fix an include for sfx2
This .hrc file was used in multiple places.

Change-Id: I603c6d35da2e870d8586f081ccd2672065ade5db
Reviewed-on: https://gerrit.libreoffice.org/31928
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-13 12:02:16 +00:00
Samuel Mehrbrodt
0fda52cc4a SafeMode: Restart goes into safe mode again
Looks like the XRestartManager keeps all command line arguments when
restarting, so it also keeps --safe-mode.

Solution is to add a flag file when restarting from safe mode,
to prevent going into safe mode again.

Change-Id: I9820d3ccbddf98b0bf6132f254c989f52ea5e808
Reviewed-on: https://gerrit.libreoffice.org/31913
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-13 07:25:31 +00:00
Noel Grandin
d6f2dd831a remove useless Mutex guards
Change-Id: Ib1edb681b47ce98e2e810d15111932002786aa51
Reviewed-on: https://gerrit.libreoffice.org/31875
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12 09:16:09 +00:00
Noel Grandin
4ef9ccea6c OSL_TRACE -> SAL in sfx2..svx
Change-Id: I78cf8058a5682baa3d7b00a25feeb2d28fb3e66e
Reviewed-on: https://gerrit.libreoffice.org/31799
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-11 18:56:16 +00:00
Caolán McNamara
f5edbb4158 Related: rhbz#1397939 crash with null pSidebarController
Change-Id: I7627ff30564b2de61669c71dafd15e7b1778b5c6
2016-12-09 11:14:03 +00:00
Noel Grandin
a66731982e convert SFX_HINT to scoped enum
Notes

(*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a
dynamic_cast check.

(*) In SC, removed the hint id field from ScIndexHint, no point in
storing the hint id twice

(*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no
point in storing two different hint ids

(*) In some cases, multiple #define's used to map to the same SFX_HINT
value (notably the SFX_HINT_USER* values). I made all of those separate
values.

Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5
Reviewed-on: https://gerrit.libreoffice.org/31751
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-08 12:35:09 +00:00
Noel Grandin
2d48f5fc0a convert VCLEVENT constants to scoped enum
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba
Reviewed-on: https://gerrit.libreoffice.org/31675
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07 07:10:39 +00:00
Stephan Bergmann
dd8e21c2c7 loplugin:unnecessaryoverride
Change-Id: Ifa46b0eb0fb8f288acbcf19f7090a62c6a1ecef3
2016-12-06 22:30:00 +01:00
Mark Page
e67857cb18 Convert TextView to unique_ptr
The destructor contains reset to the unique_ptr's because
it is not clear of the importance of the destruction order

Change-Id: Ifbbb4fe8352cb3b50f18cebd60cf00af010c086a
Reviewed-on: https://gerrit.libreoffice.org/31673
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06 18:21:01 +00:00
Stephan Bergmann
9b8fb82150 loplugin:unnecessaryoverride
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-06 10:20:01 +01:00
kerem
25cc8979c5 tdf#97361 remove = None assignments in sfx2 python unit tests
Change-Id: Iba3926d1b044ade69e1306941ed70b644dc577d6
Reviewed-on: https://gerrit.libreoffice.org/31602
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-05 11:30:29 +00:00
Noel Grandin
50151db9f7 convert FSysStyle to o3tl::typed_flags
Change-Id: I58a63a0e6f619442f21827064644ecd8ca57b8ff
2016-12-05 12:49:02 +02:00
Noel Grandin
bfde4866e0 convert DecodeMechanism to scoped enum
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05 12:49:02 +02:00
Noel Grandin
803215142e convert INetURLObject::EncodeMechanism to scoped enum
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05 12:49:02 +02:00
Stephan Bergmann
196d191136 loplugin:unnecessaryoverride (dtors) in sfx2
Change-Id: Ic086a22bccd267824e68df6c963df8da76e6df2c
2016-12-05 08:59:52 +01:00
Caolán McNamara
a064f1226b usageinfo causes one of our more frequent fedora 25 crashes
https://retrace.fedoraproject.org/faf/problems/bthash/?bth=17ba9a57f40d5ca29778866a9f96c1c0dfc7593c&bth=2f1801e44e9cb0be2b013624521fb0959dc2c73a&bth=5e8a1e07503f53b13b3a6779084f8b0637aaf5a7&bth=8033013a2ce586bccc23245583fa86ef4a761dce&bth=975271167132418534cb07336601efb5b0c711f0&bth=de75c2ad7917bc889d6307b152f79d34e79ce74d

Change-Id: Ie93afa476eca9fdbf7ea17ff0189fbaa493a5531
2016-12-02 14:23:45 +00:00
Michael Stahl
bac1c69c65 sfx2: convert legacy DBG_ASSERT in SfxDocumentMetaData
Change-Id: Ic340d7226ea3af4bbd6e52c415b32d9be7cd453f
2016-12-01 23:29:48 +01:00
Stephan Bergmann
424d17e62e ScTabViewShell::InnerResizePixel must not mark document as modified...
...when merely toggling the edit mode of a Calc document embedded in another
document (via "Insert - Object - OLE Object... - LibreOffice 5.4 Spreadsheet").

Interestingly, none of the other document kinds seem to have this problem.
(Maybe it's even unhelpful that ScTabViewShell::InnerResizePixel calls
SetDocumentModified() at all?)  Anyway, pass this inplaceEditModeChange
information down there.

Change-Id: Iffb24b068419e3608c9f4b5e9645e44e1716aafe
2016-11-30 15:27:25 +01:00
Miklos Vajna
b18b1e80e9 sw: use auto when initializing with a cast to avoid duplicating the type name
Change-Id: Ide7bd0f1f444824b78aa53cfe1db0129cbca1a5d
Reviewed-on: https://gerrit.libreoffice.org/31397
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-11-30 10:43:43 +00:00
Akshay Deep
70c03ec408 Emoji Control: Larger emoji rendering
Change-Id: Iec51d4e73926cf8203638d2ad013ddfdd47d8ee4
Reviewed-on: https://gerrit.libreoffice.org/31256
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-30 08:42:05 +00:00
Noel Grandin
e6ffb539ee loplugin:vclwidgets check for assigning from VclPt<T> to T*
Inspired by a recent bug report where we were assigning the result
of VclPtr<T>::Create to a raw pointer.

As a consequence, we also need to change various methods that were
returning newly created Window subclasses via raw pointer, to
instead return those via VclPtr

Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b
Reviewed-on: https://gerrit.libreoffice.org/31318
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-29 06:45:42 +00:00
Akshay Deep
9abc547ef2 tdf#101870 - Template manager thumbnail view control needs a border
Change-Id: If1773b99aa816b2b45fe16127ff09a646e3702ae
Reviewed-on: https://gerrit.libreoffice.org/31324
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-11-28 20:44:18 +00:00
Adolfo Jayme Barrientos
b28b05053b These don’t need to be translatable
Change-Id: I889c5130bd32f038cb0b45d959b40bf63c0b3a58
2016-11-28 07:46:42 -06:00
Maxim Monastirsky
afe7f73910 tdf#104106 Enable save whenever edit mode active
but in case of a r/o medium do "save as" instead.

Change-Id: If99602481deb053c2f834b1c7f5d24eb725df9c1
Reviewed-on: https://gerrit.libreoffice.org/31308
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-11-28 09:34:45 +00:00
Michael Stahl
6bb20609a2 vcl: rename Window::Notify to EventNotify
There is annoying overloading between Window::Notify and
SfxListener::Notify, and the Window one has apparently fewer
implementations, so rename that and remove lots of disambiguating
"using Notify" in multiply inheriting classes.

Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-24 22:56:34 +01:00
Noel Grandin
5af0071d42 convert SFX_VISIBILITY constants to scoped enum
* split the position and the flags information
* remove unused DESKTOP constant

Change-Id: Ibfccb44c7567e89d4527bfd36b3915a73682e6e2
2016-11-24 08:05:55 +02:00
Noel Grandin
0e04b53144 convert SFXWB_ constants to scoped enum
Change-Id: I63d442e51b7e22093da1c232e1b575bc961c0e69
2016-11-24 08:05:55 +02:00
Andras Timar
666eb88b31 make strings localizable
Change-Id: Ic74b55b12926a23e9e98308407a88e73dc9cb0c7
2016-11-23 08:51:43 +01:00
Gabor Kelemen
75346b4144 Kill the AutoPilotPresentations UNO command
The presentation wizard was removed in
bb8040595c9b6f0ccde39e6833f27a50abb891d8 but the
corresponding UNO command is still available.

Change-Id: I54e676672bb53d0283394a0ebffbe9f94f29d9c0
Reviewed-on: https://gerrit.libreoffice.org/30983
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-21 08:48:15 +00:00
David Tardon
c80c6b5694 add missing dep
Change-Id: I0d2a2c32d99ee11e63a2363f8a17bd4efd72cc22
2016-11-21 09:44:42 +01:00