3181 Commits

Author SHA1 Message Date
Stephan Bergmann
9f8986660c loplugin:unnecessaryoverride (dtors) in starmath
Change-Id: I7d987fdab23a708a75e7d2e8bd2aabdb96e53140
2016-12-02 11:16:13 +01:00
Takeshi Abe
7d1be94484 starmath: Prefix members of SmTextNode
Change-Id: Ic2509e7ee4040fec8173861f319bce61804837cf
Reviewed-on: https://gerrit.libreoffice.org/31468
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-12-02 02:34:44 +00:00
Stephan Bergmann
424d17e62e ScTabViewShell::InnerResizePixel must not mark document as modified...
...when merely toggling the edit mode of a Calc document embedded in another
document (via "Insert - Object - OLE Object... - LibreOffice 5.4 Spreadsheet").

Interestingly, none of the other document kinds seem to have this problem.
(Maybe it's even unhelpful that ScTabViewShell::InnerResizePixel calls
SetDocumentModified() at all?)  Anyway, pass this inplaceEditModeChange
information down there.

Change-Id: Iffb24b068419e3608c9f4b5e9645e44e1716aafe
2016-11-30 15:27:25 +01:00
Miklos Vajna
b18b1e80e9 sw: use auto when initializing with a cast to avoid duplicating the type name
Change-Id: Ide7bd0f1f444824b78aa53cfe1db0129cbca1a5d
Reviewed-on: https://gerrit.libreoffice.org/31397
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-11-30 10:43:43 +00:00
Takeshi Abe
d53262282a starmath: Prefix members of SmSpecialNode etc.
Change-Id: I7a1ac67f5fb3066b16b59a3a8277952d66572fb6
Reviewed-on: https://gerrit.libreoffice.org/31353
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-30 01:12:53 +00:00
Stephan Bergmann
4f2d4e20a8 Rewrite some (trivial) assignments inside if/while conditions: starmath
Change-Id: I7a7eaf1e99216d3985ff654e7c4df7e19dd0ae24
2016-11-29 17:19:00 +01:00
Takeshi Abe
4130c8def8 starmath: these static functions can be local
Change-Id: I5babffab846a9f17cd14cbf8ffd3b34b6bb27abd
Reviewed-on: https://gerrit.libreoffice.org/31322
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-29 01:04:31 +00:00
Takeshi Abe
2bad9f1cd8 tdf#103430 Apply mathvariant attribute to <mi> and <mo>
by emulating it with SmFontNode.
In case of <mo>, current implementation supports only the one named
with an alphabet.

Change-Id: I827a7e80f5aa94e243098a6e50eb758cf915c282
Reviewed-on: https://gerrit.libreoffice.org/31240
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-29 01:04:08 +00:00
Takeshi Abe
142618ecae starmath: Separate color name and operand by space
Otherwise, errors happen at MathML import.

Change-Id: I17037b430710ea4d26340e7ce13c7972a76f614f
2016-11-28 09:47:12 +09:00
Takeshi Abe
3f20d98131 starmath: Prefix members of SmBinDiagonalNode etc.
Change-Id: Icd863b23cfca635f901a0aea65fa26dace0aa8f9
Reviewed-on: https://gerrit.libreoffice.org/31188
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-25 13:11:04 +00:00
Takeshi Abe
32cbe71253 starmath: Prefix members of SmFontNode
Also, make SmFontSize::GetSizeType() return value, not reference.

Change-Id: Ifec68cfbdd5f05396fb0d913ddd6888749fdcfbd
Reviewed-on: https://gerrit.libreoffice.org/31157
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-24 14:30:05 +00:00
Noel Grandin
04a84913ea use o3tl::typed_flags in ConfigurationListener::ConfigurationChanged
Change-Id: I0ad7c02953aa53168dc242f1f374ab871728c84e
2016-11-24 11:27:51 +02:00
Noel Grandin
5af0071d42 convert SFX_VISIBILITY constants to scoped enum
* split the position and the flags information
* remove unused DESKTOP constant

Change-Id: Ibfccb44c7567e89d4527bfd36b3915a73682e6e2
2016-11-24 08:05:55 +02:00
Takeshi Abe
803ad61c80 starmath: Prefix members of SmNodeMatrix
Change-Id: I76c7e34878b9d2bc74d2499cf65448f0dd3a17b3
Reviewed-on: https://gerrit.libreoffice.org/31034
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-11-23 00:36:22 +00:00
David Tardon
bbb9264610 add missing deps on ui files
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-21 09:44:39 +01:00
Takeshi Abe
172325bedf tdf#79645 Add line spacing only between rows of SmMatrixNode
Change-Id: Icb785aff47de434fd8a99d1841dcbe4464df039f
Reviewed-on: https://gerrit.libreoffice.org/31007
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-21 05:25:16 +00:00
Norbert Thiebaud
d8a8ed04b1 gbuild allow unitest to run once per lang in WITH_LANG_LIST
this is motivated by the new screenshot feature
the initial proposed solution involved running make screenshot once per lang
which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big
windows slavebot.

with this patch, one can run make screenshot just once and get all the screenshot
the elapsed time is 36 inutes on the same box/same config a 10x improvement.

Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939
Reviewed-on: https://gerrit.libreoffice.org/30970
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-20 13:34:40 +00:00
Takeshi Abe
f533b3f399 tdf#103500 Import stretchy integral symbol from MathML
as "intd".

Change-Id: Ic8a4feef7a3a19c8ed5bca2f09f80901e2b6d343
Reviewed-on: https://gerrit.libreoffice.org/30953
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-19 07:51:01 +00:00
Noel Grandin
0a840edcc1 includes should be at the top of the file
not randomly scattered through the code

found with something like:
   git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include"

Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351
Reviewed-on: https://gerrit.libreoffice.org/30952
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-18 09:25:06 +00:00
Miklos Vajna
3ab9cebf45 starmath: fix loplugin:cppunitassertequals warnings
Change-Id: I49bddc1e51550c1696a1e93ce22e6b85bb663cd6
Reviewed-on: https://gerrit.libreoffice.org/30949
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-11-18 08:27:24 +00:00
Takeshi Abe
395295a40c tdf#84650 Fix X-coordinate of SmMatrixNode's elements
which are aligned to left or right against the column.

Change-Id: Ie2b6944bc0dddb0e1589842472298f787fabf596
Reviewed-on: https://gerrit.libreoffice.org/30929
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-18 01:30:15 +00:00
Takeshi Abe
5c49c13b7b tdf#101472 Prompt repaint of Elements window when mouse leaves
This also reduces some cycles in SmElementsControl::MouseMove().

Change-Id: I1dd5f9cd37e4a78010ebb719b4726f9b061d8ff2
Reviewed-on: https://gerrit.libreoffice.org/30897
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-16 12:55:05 +00:00
Samuel Mehrbrodt
ec4e48c750 Fix typos
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672
Reviewed-on: https://gerrit.libreoffice.org/30872
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15 14:51:34 +00:00
Takeshi Abe
074f0ab1d7 tdf#76296 Import MathML's <mspace>
as possibly multiple "~" and/or "`" by honoring its width attribute.

Change-Id: I17e361c3f8f5d061c856b72266332369497d16b9
Reviewed-on: https://gerrit.libreoffice.org/30809
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-15 00:27:30 +00:00
melikeyurtoglu
c5f5b3e533 tdf#91222 VclBuilder constructor cleanup
Change-Id: I29a8ca55d1d9f319cd57e5e30fa7e58e4d91dc5c
Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/30810
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-14 06:22:40 +00:00
Takeshi Abe
18629fbb91 starmath: Prefix member of SmBlankNode
Change-Id: I20b9fa14d42549a3c5be8a7d4f52c85fcef52cf5
2016-11-12 12:34:25 +09:00
Stephan Bergmann
8cfa3f4b52 'make screenshot' use-after-free fixes
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10 22:00:41 +01:00
Stephan Bergmann
d543b4df80 'make screenshot' loplugin fixes
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-10 22:00:41 +01:00
Takeshi Abe
287b35c437 tdf#44839 Add an "Evaluated At" command in "Brackets" section
of Elements window.

Change-Id: I221dacad297c7713f9cdde6d8ffdecf3caa2c3bd
Reviewed-on: https://gerrit.libreoffice.org/30714
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-09 13:04:55 +00:00
Takeshi Abe
6984fd5a75 tdf#102008 Drop whitespace between "fact" and brace
for consistency with "abs{<?>}", "sqrt{<?>}", etc.

Change-Id: I53106d6daf99f72f1a064bc6f5e0fe4dab55cc02
Reviewed-on: https://gerrit.libreoffice.org/30556
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-05 02:00:09 +00:00
Takeshi Abe
239b662753 tdf#102007 Surround widebslash's placeholders with braces
like wideslash's.

Change-Id: Icddd563ee64510c0df8bfa8d4a5274a00f60162a
Reviewed-on: https://gerrit.libreoffice.org/30555
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-05 01:59:40 +00:00
Stephan Bergmann
1fa19c7385 Use a single method of converting between points and 100th mm in starmath
The SmFormat ctor (starmath/source/format.cxx) uses SmPtsTo100th_mm(12) to
initialize aBaseSize, resulting in a height of 422 100th mm.  Getting that value
(and writing it out to a file) through SmModel::_getPropertyValues mapped back
to 12 point, but in turn setting that value (as read from a file) through
SmModel::_setPropertyValues resulted in a height of 423 100th mm.  That, in
turn, caused SmDocShell::GetSize (starmath/source/document.cxx) to compute
diverging sizes, so e.g. clicking into an OLE-embedded formula in a Writer
document caused the Writer document to be marked as modified (as the embedded
formula's size had changed).

Change-Id: Ia90654aeaaf779690997b5c3bb868b193eaf46c6
2016-11-03 13:33:33 +01:00
Takeshi Abe
063593972e starmath: Remove unnecessary overriding
Change-Id: If64c3a1dbb27e85e2562cca78b608250b7e90c6d
Reviewed-on: https://gerrit.libreoffice.org/30480
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-03 04:08:38 +00:00
Noel Grandin
9bdec0831a loplugin:oncevar in sd..svgio
Change-Id: I58565460fcc3279c9771c6e1272d0af540b2c87c
Reviewed-on: https://gerrit.libreoffice.org/30459
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01 13:25:08 +00:00
Caolán McNamara
117fc49c97 ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivatives
Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2
Reviewed-on: https://gerrit.libreoffice.org/30344
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-28 09:08:50 +00:00
Noel Grandin
618171552e loplugin:expandablemethods in sot..starmath
Change-Id: I5b718bbda9ceca5bbfd1e6482ebd215e15884956
Reviewed-on: https://gerrit.libreoffice.org/30318
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-27 11:38:22 +00:00
Miklos Vajna
36c4fd5c33 svl: the compiler can generate the same SfxGrabBagItem copy ctor itself
Change-Id: I54f94e8ec710ca117ecdf33ebe97a0e5f07c59ec
Reviewed-on: https://gerrit.libreoffice.org/30283
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-10-26 11:21:04 +00:00
Julien Nabet
168eb0bfd3 tdf#103452: add missing xPopupMenu.disposeAndClear();
See https://bugs.documentfoundation.org/attachment.cgi?id=128226

Change-Id: If6641531b96f33b2864f69bd4195c92548fce148
Reviewed-on: https://gerrit.libreoffice.org/30234
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-10-24 20:27:40 +00:00
Noel Grandin
6f428c38c5 remove unused SfxListener subclassing
where the Notify method is doing nothing

Change-Id: I834aa40a9bcb0dd8d7335a5688acc5da6f40b0a2
2016-10-24 08:21:28 +02:00
Noel Grandin
40fc2c1a0d loplugin:expandablemethodds in sfx2..starmath
Change-Id: Ia4c411f5a9a68c2f344188ce6b6bc1815c89f993
Reviewed-on: https://gerrit.libreoffice.org/30055
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-20 06:12:24 +00:00
Olivier Hallot
e91a1abe4c tdf#96015 (part) link to Doc'tation in Help menu
Add the entry "Documentation" to the modules Help menu.

on click, the system browser opens
http://hub.libreoffice.org/documentation/?&LOlang=<locale>

<locale> is obtained from .getLocale()

Patch2: create a member with try/catch for external URLs

Patch3
Use sfx2::openUriExternally
Revert to User Guides.. in UI.

Change-Id: I8332253c31bd3be330cdd794f9e056b632b38037
Patch4: remove 1st '&' in URLs
Reviewed-on: https://gerrit.libreoffice.org/28817
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-19 16:07:33 +00:00
Miklos Vajna
10cfa2abee starmath: clean up redundant virtual keywords in unofilter
Change-Id: I97af23d22c0b4eb416172e9ebea9544541621cb0
Reviewed-on: https://gerrit.libreoffice.org/30031
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-10-19 08:00:17 +00:00
Jacek Fraczek
398d641664 tdf#89307: Removed T* SvRef::opeartor &()
Usage has been replaced with SvRef::get() or removed where applicable.

Change-Id: I49f108910b668466134c40940b53fc3ab2acd816
Reviewed-on: https://gerrit.libreoffice.org/29780
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-18 09:27:56 +00:00
Noel Grandin
faf4bf0c3e loplugin:countusersofdefaultparams in sot..svtools
Change-Id: Ifce19de3518f3eaf5a1b6439f9053feee4a33c14
2016-10-14 10:53:30 +02:00
Caolán McNamara
32675bd4f1 flatten RID_LOCALIZED_NAMES by a level
Change-Id: I5e6fe76d01b82ff6d9f7fde06f4349d54493bf1b
2016-10-13 10:36:01 +01:00
Samuel Mehrbrodt
ae94c223e2 safemode: Add uno command and menu entry
Change-Id: I1843767160b79041c42e506eff0cf39399c74f26
Reviewed-on: https://gerrit.libreoffice.org/29668
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-10 18:30:57 +00:00
Jacek Fraczek
f004aa9951 tdf#89307: Removed SvRef::operator T*()
Conditional statements are using SvRef::Is() method.
Changed static_cast<T*>(svRef<T>) occurances to svRef.get().
Added operator == and != to SvRef.

SbxObject::Execute is using SbxVariableRef internally.
SbxObject::FindQualified is using SbxVariableRef internally.

Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395
Reviewed-on: https://gerrit.libreoffice.org/29621
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-10 08:48:30 +00:00
Takeshi Abe
33c57f1550 starmath: Simplify code with std::unique_ptr
Change-Id: I2f6f993b92ae7f2f89b2d9d6c89b51d827226a3d
Reviewed-on: https://gerrit.libreoffice.org/29554
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-07 04:10:23 +00:00
Noel Grandin
7618302b9c loplugin:unnecessaryoverride in sd/starmath
Change-Id: I5a9d776af761fcaed7a6961e151feb38fc6353ed
2016-10-05 12:06:47 +02:00
Noel Grandin
954f752cf1 convert MapUnit to scoped enum
I left a prefix on the names "Map" so that I would not have to re-arrange
each name too much, since I can't start identifiers with digits like "100thMM"

And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore.

Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224
Reviewed-on: https://gerrit.libreoffice.org/29096
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05 06:51:20 +00:00