1916 Commits

Author SHA1 Message Date
Stephan Bergmann
8646ab97dc Remove MinGW support
In OOo times, there'd originally been efforts to allow building on Windows with
MinGW.  Later, in LO times, this has been shifted to an attempt of cross-
compiling for Windows on Linux.  That attempt can be considered abandoned, and
the relevant code rotting.

Due to this heritage, there are now three kinds of MinGW-specific code in LO:

* Code from the original OOo native Windows effort that is no longer relevant
  for the LO cross-compilation effort, but has never been removed properly.

* Code from the original OOo native Windows effort that is re-purposed for the
  LO cross-compilation effort.

* Code that has been added specifially for the LO cross-compilation effort.

All three kinds of code are removed.

(An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing
--with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.)

Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568
Reviewed-on: https://gerrit.libreoffice.org/34127
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-10 18:01:27 +00:00
Caolán McNamara
55e203a0c6 add --disable-pdfium
Change-Id: I9137dc0030c3c752ffc0931721bf6b0013309d39
2017-02-10 14:03:37 +00:00
Miklos Vajna
f9b3257655 pdfverify preview: fix macOS color space
Unlike on Linux and Windows, we need to do an ARGB -> BGRA conversion
here.

Change-Id: Ifa539973de439de25125e544cfbbe941d08dee00
2017-02-10 14:08:23 +01:00
Miklos Vajna
ea92b7cc2e xmlsecurity: use pdfium to generate a preview in pdfverify
This is just test code to check if the bundled pdfium is usable.

Change-Id: I1f1d808796fe77924518cd004d99affe70279e88
Reviewed-on: https://gerrit.libreoffice.org/34081
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-02-10 07:06:51 +00:00
Noel Grandin
a4d0ec84da convert SvtSecurityOptions::EOption to scoped enum
and drop unused E_MACRO_DISABLE enumerator

Change-Id: I0bd706d4d4e1d8b9004e68c9e77c11410c62a64a
Reviewed-on: https://gerrit.libreoffice.org/34067
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-10 06:05:54 +00:00
Miklos Vajna
91af0067c9 xmlsecurity: remove unused EncryptorImpl
No longer necessary since commit
50669de68785d61534c4c3fe101fd8e1d12fae65 (xmlsecurity: remove unused
xsec_fw_component_getFactory(), 2017-02-02).

Change-Id: Ibbc78888abcd1cb6d7f242c93f28cdaf836cca14
2017-02-09 11:50:12 +01:00
Stephan Bergmann
fed3783e77 Add missing #includes
...like 6dce9c6757823b9e89863716ae70ff4e8ddd4e60, for Windows-only code

Change-Id: I35f37aae2e6f55ff8ed82afc710a9b59a43b028c
2017-02-08 08:40:06 +01:00
Stephan Bergmann
6dce9c6757 Add missing #includes
...and remove some unncessary using directives/declarations, in preparation of
removing now-unnecessary #includes from cppumaker-generated files, post
e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception
specifications".

Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-06 17:21:16 +01:00
Julien Nabet
223f1f2b81 Typos
Change-Id: I36f443c266670bd26aa6b813075e18653f372f52
Reviewed-on: https://gerrit.libreoffice.org/33900
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-03 21:09:44 +00:00
Stephan Bergmann
5595ee701e loplugin:useuniqueptr
Change-Id: I3a246a22baaac8195dc1b94c42994de7d80e8336
2017-02-02 15:17:52 +01:00
Miklos Vajna
50669de687 xmlsecurity: remove unused xsec_fw_component_getFactory()
No longer needed since commit a4af8986c94ff2d1bea0c21f798330efcc97b133
([API CHANGE] offapi: remove unused xsec_fw UNO services, 2017-01-26).

Change-Id: I428c07bfe2846cdc54b35a62554a21197e62245f
2017-02-02 11:56:26 +01:00
Miklos Vajna
68c58b4691 xmlsecurity: various small cleanups
Change-Id: Id713460036331fd9f98fd1eca85ca61f57cf5afe
Reviewed-on: https://gerrit.libreoffice.org/33779
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-02-01 12:01:24 +00:00
Samuel Mehrbrodt
1478f81f23 tdf#105637 Digital signatures dialog has unnessary labels
Change-Id: I474968d566a31fba29bcdc1f74749de8e86fedce
Reviewed-on: https://gerrit.libreoffice.org/33754
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-31 15:42:30 +00:00
Noel Grandin
1c3e84d819 teach lolugin:stringconstant about calling constructors
so we can remove unnecessary calls to the OUString(literal) constructor
when calling constructors like this:
   Foo(OUString("xxx"), 1)

Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36
Reviewed-on: https://gerrit.libreoffice.org/33698
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31 08:56:20 +00:00
Julien Nabet
018ed00d5b cppcheck: postfix operator
Change-Id: I2b6f0c922b0e70ecbf79f60831ff5d71cd1438fb
Reviewed-on: https://gerrit.libreoffice.org/33656
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-29 09:46:36 +00:00
Noel Grandin
f1d83ac45f loplugin:stringconstant check for unnecessary OUString constructor..
..calls when creating exceptions

Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe
Reviewed-on: https://gerrit.libreoffice.org/33617
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-28 09:22:55 +00:00
Noel Grandin
4142e0a0c0 loplugin: unnecessary destructor writerfilter..xmloff
Change-Id: I511822dc874101ed3b9850b015b746a86d26c3b5
Reviewed-on: https://gerrit.libreoffice.org/33578
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-27 06:51:11 +00:00
Stephan Bergmann
e57ca02849 Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26 12:54:43 +00:00
Miklos Vajna
a4af8986c9 [API CHANGE] offapi: remove unused xsec_fw UNO services
This is mostly just the offapi/ part, more C++ code can be removed in
xmlsecurity/ after this. SignatureVerifier, SAXEventKeeper,
SignatureCreator, XMLSignatureTemplate and XMLEncryptionTemplate was
only used inside xmlsecurity, but they all are accessed directly
already. Decryptor and Encryptor wasn't even used by internal code since
they were added in commit 9f34fde7a8750b856570b5e855d2ecb226bf0c23
(libxmlsec, 2004-07-12).

It seems to be unlikely that any of these non-published services were
used by 3rd-party code, since they were specific to other xmlsecurity/
code, not generic functionality that could be useful in other contexts.

Change-Id: I4bcfa88d11d2b92a440f6617193c6460125ce4fd
Reviewed-on: https://gerrit.libreoffice.org/33569
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-26 10:43:25 +00:00
Takeshi Abe
6d898945d5 Fix typo in comments: relativ -> relative
Change-Id: I58833e503e93b8057f92710c5828bba6cecd4e09
Reviewed-on: https://gerrit.libreoffice.org/33488
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-25 06:05:54 +00:00
Stephan Bergmann
8cb18eb82d loplugin:dynexcspec (clang-cl), xmlsecurity
Change-Id: Iaa817d1da0c648c3a1feb0ef1e4500808a868644
2017-01-20 11:53:29 +01:00
Stephan Bergmann
8ccd11e1ae New loplugin:dynexcspec: Add @throws documentation, xmlsecurity
Change-Id: I2447c028add359952e4bd36dbdc1d5431fe48104
2017-01-19 18:03:08 +01:00
Miklos Vajna
716db7dd4a xmlsecurity: hold XMLEncryptionTemplateImpl by rtl::Reference
Going via UNO for a class in the same directory is an overkill.

Change-Id: Ia06561a95cd10a7aa52a1b84598f88c43e57e7a1
Reviewed-on: https://gerrit.libreoffice.org/33300
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-01-19 10:02:48 +00:00
Caolán McNamara
f6572fa96c tweak to avoid coverity#1371169 Missing move assignment operator
Change-Id: I0d29ce18c19c26a7526dad98d77db4670d0c5303
2017-01-19 10:02:13 +00:00
Caolán McNamara
16c9933666 convert to std::vector
Change-Id: I77ac7701ccb35aa32152d85a20fc59ed0bd942cf
2017-01-18 21:33:47 +00:00
Caolán McNamara
a98c28cc30 u*,v*: load BitmapEx resources instead of Image ones
Change-Id: If279c55a0055e51e04b31e0db745779c3a44bcd6
2017-01-14 20:55:56 +00:00
Stephan Bergmann
33c81a4580 loplugin:externvar (clang-cl)
Change-Id: I6f4c294cb15a4426545d05be7b0a7f26f580563c
2017-01-11 13:42:42 +01:00
Stephan Bergmann
91425be3c6 New loplugin:conststringvar: xmlsecurity
Change-Id: Ifec5c8a9addca5976714eec64385b3f87e5380c5
2017-01-10 08:09:29 +01:00
Noel Grandin
b022985505 loplugin:unusedfields
Change-Id: I9611511cb3480734dea3c3cbaf0d659071366ad1
Reviewed-on: https://gerrit.libreoffice.org/32873
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-10 06:28:22 +00:00
Stephan Bergmann
a32c0f4a1e New loplugin:externvar: xmlsecurity
Change-Id: I25ee9a65b481c63ab2629be54768793d254341b5
2017-01-09 15:38:51 +01:00
Miklos Vajna
9739392cbd xmlsecurity: hold XMLSignatureTemplateImpl by rtl::Reference
Going via UNO for a class in the same directory is an overkill.

Change-Id: I3dd09a74b6113c472402632bd54bc5bcf32f69bf
Reviewed-on: https://gerrit.libreoffice.org/32748
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-01-05 15:31:33 +00:00
Noel Grandin
46d3163f77 loplugin:unusedmethods
Change-Id: Ife4c8d948ffa116f044d43903de9485e43cfcae5
Reviewed-on: https://gerrit.libreoffice.org/32336
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-23 04:46:35 +00:00
Tor Lillqvist
b1c1458760 Revert "[API CHANGE] createSecurityContext() was always called with an empty string"
I got cold feet. I don't want to have to revert this many years later
instead, when some obscure 3rd-party software stops working.

This reverts commit e1ce7bad62f07faf8f21adac6c3848d142f61953.
2016-12-22 08:48:16 +02:00
Tor Lillqvist
e1ce7bad62 [API CHANGE] createSecurityContext() was always called with an empty string
So drop the parameter then and propagate fallout in the Windows
implementation in xmlsecurity. The NSS implementation already ignored
the parameter completely.

This interface is not 'published' and the parameter was even marked as
'reserved for internal use' so I doubt any external code has used it.

Change-Id: I5915b941b79cfddadc8137c32ed07c20c9ccaa37
2016-12-21 21:24:09 +02:00
Noel Grandin
6b8ee3c9ba convert VclButtonsType to scoped enum
Change-Id: I9b91108c18e190060dc71546977aa8a3c11f06e1
Reviewed-on: https://gerrit.libreoffice.org/32285
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2016-12-21 16:19:37 +00:00
Tor Lillqvist
317278525a Bin now unused fields
Change-Id: Ie2179bc61ca59a5f5ea2bed1c5c0b2c1dea55474
2016-12-21 17:49:18 +02:00
Tor Lillqvist
62fe303d16 Bin now unused functions
Change-Id: I515279becbb219c94a52bb1ebf9d1ab33402dae0
2016-12-21 17:49:18 +02:00
Tor Lillqvist
efe9d1df69 Don't add empty TODO functions to libxmlsec, and don't call them
Change-Id: Iaec1de29a0e7f3ea8eb10869382401d121de2c8a
2016-12-21 17:35:24 +02:00
Miklos Vajna
517994c640 xmlsecurity: instantiate SignatureCreatorImpl directly in XSecController
Going via UNO for a class in the same module is an overkill.

Change-Id: I3a24bc770e40be5b0a6fc34206e92f968de060ae
Reviewed-on: https://gerrit.libreoffice.org/32271
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-12-21 08:06:26 +00:00
Caolán McNamara
8092d344fa use new ENABLE_NSS for code which needs nss
which isn't available on a static-only build (iOS and fuzzing) and
android

Change-Id: I99bb7c0b45d4499579ddf73f469a762ddcae99ab
Reviewed-on: https://gerrit.libreoffice.org/32182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-20 14:20:47 +00:00
Stephan Bergmann
83d2c5180d Adapt to no-longer explicit OUStringLiteral ctor
...from previous commit

Change-Id: I062b7cd212c17e7eb5274476e6859228d0477c7f
Reviewed-on: https://gerrit.libreoffice.org/32098
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-17 16:12:02 +00:00
Stephan Bergmann
54c401d775 loplugin:staticmethods (clang-cl)
Change-Id: Id97600a7d29fbe938d67ea074ca12dd665a29cc3
2016-12-16 15:28:40 +01:00
Miklos Vajna
107bcc8839 cid#1374075 cid#1374076 Executable_pdfverify: uncaught exceptions
SAL_INFO() throwing std::length_error and other uninteresting cases.

Change-Id: I841c7d81ff51c95ea60d63625e296f9886798f92
2016-12-16 09:13:18 +01:00
Tor Lillqvist
48e956e506 Try to fix Android and iOS build
Fix what probably is fallout from
a7c35729e00f18f79156b3f8f57472506f786074.

Just bypass all of xmlsecurity for Android and iOS. At least the iOS
demo app, TiledLibreOffice, builds then.

Change-Id: Ibc9486c0d67d1aeafa08932809b23ceeb9b5c2f3
2016-12-15 16:46:48 +02:00
Stephan Bergmann
721116c7ad Phase out support for HAVE_BROKEN_STATIC_INITIALIZER_LIST
...I'm pondering a change that would make that a hard requirement, and from the
comment in configure.ac it looks like only old Clang < 3.4 were affected.

Change-Id: I8ef64f759fed1a45d88f94d0e8a60839ad10b263
Reviewed-on: https://gerrit.libreoffice.org/32029
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-15 11:24:53 +00:00
Miklos Vajna
a7c35729e0 xmlsecurity: hold XMLDocumentWrapper by rtl::Reference in XSecController
Going via UNO for a class in the same module is an overkill.

Change-Id: Idf706782e5844fd2e553c44966e1dd1104dce8e7
Reviewed-on: https://gerrit.libreoffice.org/32030
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-12-15 09:15:38 +00:00
Stephan Bergmann
1f32fdc712 Unnecessary includes
Change-Id: I9816e320d9ed31b8af50d20d207a9be21b58ace3
2016-12-15 08:50:20 +01:00
Adam Kasztenny
13cba3505f tdf#95416 Fix an include for xmlsecurity
Move one header file to inc/

Change-Id: If8f4bfcf29464011fe68573e7d4e67900aacc2cd
Reviewed-on: https://gerrit.libreoffice.org/31891
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-12-12 08:53:53 +00:00
Miklos Vajna
9bd471cb76 xmlsecurity: clean up not needed C2U macro in xmldocumentwrapper
Also remove some auto-generated documentation that adds no useful
information.

Change-Id: I5e5c5dd6aaa3fb6953c38d6e82fa13737217c25c
Reviewed-on: https://gerrit.libreoffice.org/31748
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-12-08 09:17:53 +00:00
Miklos Vajna
81f7824a98 xmlsecurity DigitalSignaturesDialog: show signature type on the UI
The code already knew if the signature was AdES-enabled or not, but that
info wasn't available on the UI.

The values are all names of standards, Andras says it's OK to have them
non-translatable.

Change-Id: I20baf0871fe2c84b04b7fc64014061e341744db8
Reviewed-on: https://gerrit.libreoffice.org/31718
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-12-07 12:45:12 +00:00