403714 Commits

Author SHA1 Message Date
Noel Grandin
62410ecd5d remove unused constant from SdrInsertReasonKind enum
Change-Id: I29fda2c0124b438eb9a2926c6dfefa801c670a27
Reviewed-on: https://gerrit.libreoffice.org/33968
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-07 06:01:58 +00:00
Noel Grandin
c1380c0039 drop unused FONT_PROPTYPE_CELL constant
which makes this enum not necessary anymore

Change-Id: I0194634d357569aee502f1e8a7fd95c49e23040c
Reviewed-on: https://gerrit.libreoffice.org/33967
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-07 06:01:50 +00:00
Noel Grandin
d91c81e433 convert GalleryBrowserTravel to scoped enum
and drop unused GALLERYBROWSERTRAVEL_CURRENT value

Change-Id: Id91824cbe024d4b5109ee0755b518164837bc6a6
Reviewed-on: https://gerrit.libreoffice.org/33965
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-07 06:01:27 +00:00
Noel Grandin
c57cbcea9a remove unused value from SW_KeyState enum
Change-Id: Ied6ac5724957ff10fd1e9e217bbb32c1187f3cba
Reviewed-on: https://gerrit.libreoffice.org/33963
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-07 06:01:14 +00:00
Katarina Behrens
83e059af22 tdf#103636: In Draw sidebar, switch fitting objs to paper format off
So FuPage::ExecuteDialog and ::ApplyItemSet misuses SID_ATTR_PAGE_EXT1
to distinguish between Impress and Draw, making fit objects to paper
format on in Impress and off in Draw.
That setting is not persistent, but that is a separate issue and until
it is fixed, we will do the same here

Change-Id: Ie55a131d375fa32d856bde4d9fda4fb54dd0d29f
Reviewed-on: https://gerrit.libreoffice.org/33976
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-02-06 23:24:29 +00:00
Maxim Monastirsky
486c310151 MenuToolbarController improvements
- Make it self-contained, instead of having its code
  spread across ToolBarManager.
- Base it on svt::ToolboxController directly, since it
  uses nothing from GenericToolbarController.
- Move the code from dtor to dispose method.
- Call ToolBox::SetItemDown to make the button work on
  a second click.

Change-Id: I5b38ef532ba40ef0ac31bc53de5b6be4ccd1a118
Reviewed-on: https://gerrit.libreoffice.org/33982
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-02-06 23:05:17 +00:00
Maxim Monastirsky
f1552a48c3 Silence "Invalid SlotId" warnings
Change-Id: I7c3742fc94ef587526e4f6079c4f7aa245a0c116
2017-02-07 00:54:28 +02:00
Michael Stahl
e1d0c42826 sw: convert some OSL_ENSURE to assert
Change-Id: I93fa70ef9b09afb9a4582a5942b4269afeece666
2017-02-06 23:33:16 +01:00
Michael Stahl
56206c8a5e vcl: fix inconsistent GraphicsStateUpdateFlags asserts
(regression from f4826959c1a5b0e6d2849d4240668b2087582848)

Change-Id: If530503a667f765c38a6b226bb0627506dbb0900
2017-02-06 23:03:08 +01:00
Patrick J
b322fbc548 tdf#101626: replace soft-hyphen by hard-hyphen in ooxml import
If a list bulletChar is a soft-hyphen, it will disappear in PDF export.
Therefore, replace it by a hard-hyphen.

Change-Id: If0b535e7d2e23454136f25a2b7acf4b294b8dd27
Reviewed-on: https://gerrit.libreoffice.org/33707
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-06 22:05:43 +00:00
Stephan Bergmann
a34d9150b4 Add missing #includes
...like 6dce9c6757823b9e89863716ae70ff4e8ddd4e60, for macOS-only code

Change-Id: I0b4c0ba12df487107661a6af54fba42122e8f023
2017-02-06 22:40:16 +01:00
Stephan Bergmann
6dce9c6757 Add missing #includes
...and remove some unncessary using directives/declarations, in preparation of
removing now-unnecessary #includes from cppumaker-generated files, post
e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception
specifications".

Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-06 17:21:16 +01:00
pv2k
a73fb11cb2 tdf#92492 function placed in a wrong category in customise functions list
"Table To Text","Text To Table" and "Text<->Table" have been removed from
"Options" category and placed in "Table" category

Change-Id: Ic5717e4cf91ce3fde2d40b3a3f567747fa7b983f
Reviewed-on: https://gerrit.libreoffice.org/33919
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-02-06 16:09:30 +00:00
Michael Stahl
23972ff57f sw: translate more german comments
Change-Id: I662cde51b6fbf4e44c8a0a0314f057fdc1a764f0
2017-02-06 15:27:52 +01:00
Fakabbir Amin
cf2e9ded20 tdf#87605 Added some new terms
Few important terms added

Change-Id: I40281ff2052a1b0978978b2b1e12e7453e04e1b8
Reviewed-on: https://gerrit.libreoffice.org/33840
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-06 14:30:36 +00:00
Jeremy Bicha
585ac5b5f3 officecfg: Drop hyphen from "Check Out" in menus
The verb is "check out"; the noun is "checkout"

Change-Id: I8f779604b5b069c77db2ab705993db3dceeab50d
Reviewed-on: https://gerrit.libreoffice.org/33973
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-06 14:28:33 +00:00
Tor Lillqvist
e1e4efdc71 Typo: s/dependend/dependent/i
Change-Id: If02798894ad6f0e0442ed60aaec6eca40e6dcb61
2017-02-06 16:03:34 +02:00
Jeremy Bicha
5c54971cbc officecfg: Fix title case for several menu items
Change-Id: I21364f7cab88cf7ab8d757d4e44da3b6cf28dacd
Reviewed-on: https://gerrit.libreoffice.org/33962
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-06 13:43:27 +00:00
Noel Grandin
9724a107ab remove unused values from SwDocumentSettingsPropertyHandles enum
Change-Id: I9aa77050b2e6c3e0d364428eb759b389c078b206
Reviewed-on: https://gerrit.libreoffice.org/33957
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06 13:34:35 +00:00
Stephan Bergmann
ccedfa046a Revert "fix desktop scripts"
This reverts commit f52eb759f61e1806014972cb736e07479f157aa6.  I assume this was
intented to be a fix for e6a9dc22a4e58b565894f8cdb6a19755af7b14de "tdf#105204
fix shellcheck warnings in desktop/scripts" (later addressed with
7ba0b28cc3ac82f5c5c6d7e2536cb89771041893 "Unbreak soffice.sh").  But I think
these quotations are actually useful parts of that original commit.  I fail to
see how pathname expansion (aka globbing; nor field splitting, if that is what
was actually meant in "we want globbing here") should be a useful feature here.

Change-Id: I5c33c40cfe2a817f628442fed70a07f06dd275cc
2017-02-06 13:58:30 +01:00
Lukas Röllin
71160b4cd3 Translate German comments
Change-Id: Iafca03642f7053cb9c5009163cb80528d88bca47
Reviewed-on: https://gerrit.libreoffice.org/33960
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-06 12:47:39 +00:00
Tamás Zolnai
fedf4e5db7 Fix copy paste error
Change-Id: I88af4618dfbeab920163117c2da9e51fcf694d84
2017-02-06 13:15:52 +01:00
brainbreaker
3f19e27638 Retaining the default file explorer view
Change-Id: I273ee17fc94e9d6e3b73ca0b9a4853a632123bd0
Reviewed-on: https://gerrit.libreoffice.org/33946
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-06 11:42:18 +00:00
Noel Grandin
fde0b8df30 loplugin:unusedenumconstants in oox
Convert FragmentHandler2::MCE_STATE to scoped enum and drop MCE_UNUSED
constant

Change-Id: Id0b3a81e61d77af5d3837527b008e196835f57cd
Reviewed-on: https://gerrit.libreoffice.org/33954
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06 11:36:17 +00:00
Stephan Bergmann
3ea39bda0e loplugin:unusedenumconstants should apparently not be run by default
Change-Id: I42f479de39b94ca8e9c72a6e92534f602a9fad39
2017-02-06 11:57:39 +01:00
Miklos Vajna
ad6fd88ae8 sw: prefix members of SwAccessibleFrame
Change-Id: Ia8513e6c9c32c9c80c7b261eb356ae793ae7ab32
Reviewed-on: https://gerrit.libreoffice.org/33951
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-02-06 10:34:01 +00:00
Takeshi Abe
8e53f220ff framework: Pass Item ID to Menu::GetUserValue() instead of index
This also avoids needless cast.

Change-Id: I3fd1517657b489115f20e26f4f75f3e3a5b7c9b7
Reviewed-on: https://gerrit.libreoffice.org/33944
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-02-06 10:32:42 +00:00
Johnny_M
d8662a6950 Translate German comments in svdoedge
Change-Id: Ia338c8b63d3ba42aa4705b2f147f49b0d4713b18
Reviewed-on: https://gerrit.libreoffice.org/33912
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-02-06 09:55:40 +00:00
Caolán McNamara
bac4b46e86 Resolves: ofz#547 Floating-point-exception
Change-Id: I9612bef0198ce8f09d39f5000a31819c175027d1
2017-02-06 09:29:27 +00:00
Noel Grandin
c9c3cb5446 loplugin:unusedenumconstants in connectivity..cui
Convert ExpressionFunct to scoped enum and drop FUNC_CONST value.
Convert MQueryExpressionBase::node_type to scoped enum and drop Unknown
value.
Dop PageType::Color value

Change-Id: Icb1f5503c230fb91329acc7d9e1da665fa28d95e
Reviewed-on: https://gerrit.libreoffice.org/33948
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06 09:13:25 +00:00
Caolán McNamara
d8a1059ef2 OpenGLWindow typeinfo unavailable without HAVE_FEATURE_OPENGL
Change-Id: Ie06c1121502db9b1a869f657f70d3b45db610e2f
2017-02-06 08:42:55 +00:00
Noel Grandin
a6fd34907f loplugin:unusedenumconstants in reportdesign
Change-Id: I19c9a72f36bcb70ca33192a75946698c64e9375a
Reviewed-on: https://gerrit.libreoffice.org/33950
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06 08:29:00 +00:00
dilekuzulmez
1cf15a4cdd tdf#43157 Clean up OSL_ASSERT, DBG_ASSERT, etc.
Change-Id: I37b62b7cc4b26789e961148c0411615ef1c2ffa1
Reviewed-on: https://gerrit.libreoffice.org/33884
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-06 08:09:29 +00:00
Miklos Vajna
7fb2b60804 Indentation fixes
Change-Id: I3e7262c26c848f8c16564d4b27218611bf880903
2017-02-06 09:04:56 +01:00
Takeshi Abe
9a5e2d01c5 framework: Retrieve shortcuts from document-specific configuration
No known symptoms, but it seems like a typo when comparing with
MenuBarManager::RetrieveShortcuts().

Change-Id: I83f6e5766f5e0a0e01f5fd4863772ad1d99c70d2
Reviewed-on: https://gerrit.libreoffice.org/33945
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-06 08:00:06 +00:00
Noel Grandin
bac9a5d634 loplugin:unusedenumconstants in framework
Convert EProtocol to scoped enum and drop E_UNKNOWN_PROTOCOL.
Convert ToggleButtonToolbarController::Style to scoped enum and drop
STYLE_TOGGLEBUTTON.
Convert TargetHelper::ESpecialTarget to scoped enum and drop
E_NOT_SPECIAL.

Change-Id: I412adacac15192cf6563ce4d5e5b74bfffff4737
Reviewed-on: https://gerrit.libreoffice.org/33949
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06 07:57:28 +00:00
Noel Grandin
fcb0280c10 remove accidentally committed files
Change-Id: Ib41f16f945f6b7a5ba314b13ce8a7b24c35a8edb
Reviewed-on: https://gerrit.libreoffice.org/33947
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06 07:57:15 +00:00
Noel Grandin
3211dbd1b6 loplugin:unusedenumconstants in basctl
drop UNKNOWN constant and convert to scoped enum

Change-Id: Iffeb27193cd0df47c781f2b84144d6f85a6b49e0
Reviewed-on: https://gerrit.libreoffice.org/33888
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06 05:48:26 +00:00
Noel Grandin
8b2ffb280b loplugin:unusedenumconstants in vcl
- drop TTCR_GLYPHSEQ
- drop ImageType::Invalid
- give preedit_data_t a default constructor, so my plugin spots that the
eState field is being initalised to DontKnow effectively by a memset
- document ToolbarIconSize::Small as unused, but can't remove since
it might be stored in a user-setting somewhere

Change-Id: I94b34bba83a04de16f95e4faec95b4bd29f3c652
Reviewed-on: https://gerrit.libreoffice.org/33887
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06 05:48:02 +00:00
Noel Grandin
005ef926c6 writerfilter: convert ResourceType to scoped enum
and drop unused constant StreamProperties

Change-Id: I6a358cf7914412231d6c8f926a0d2fbd4bb8009b
Reviewed-on: https://gerrit.libreoffice.org/33885
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06 05:46:29 +00:00
Jochen Nitschke
b524ace6f5 loplugin:nullptr
seen on tinderbox Linux-F19-x86_64_14-with-check

Change-Id: Ica9c2707b43317f7dd1cf99440c6cdb7fe28e0bc
Reviewed-on: https://gerrit.libreoffice.org/33938
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06 04:38:48 +00:00
Jochen Nitschke
3f6643b927 default ctor is fine here
this was hiding a Wunused-variable warning

Change-Id: I32bd853846bc6f56c082541109eedfdab2402c3d
Reviewed-on: https://gerrit.libreoffice.org/33942
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06 04:38:01 +00:00
Pranav Kant
5bafdc99a1 lok: Disable map mode when calculating annotation rectangles
Change-Id: I4803ca9b52ce76ff9f7461253ec78bfcbc26690c
Reviewed-on: https://gerrit.libreoffice.org/33879
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-02-06 03:44:59 +00:00
Pranav Kant
a51faf9ead lok: Emit modify comment callback when anchor changes
Change-Id: Ibe4a66b93768eb446a04cab8cfdd4bdebee13d1f
Reviewed-on: https://gerrit.libreoffice.org/33878
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-02-06 03:43:12 +00:00
Pranav Kant
5596b3f86f lok: comments: emit add callback after layout finishes
Change-Id: Ie6eba244dd5eb78813185f8c7aceed841d05d48b
Reviewed-on: https://gerrit.libreoffice.org/33877
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-02-06 03:42:44 +00:00
Andreas Kainz
a296a69c98 tdf#103677 Windows installer icons
Icons refreshed according Tango style

Change-Id: Ibb86ea0a7153f0ac7331d278b2dcd8f8c64835e7
Reviewed-on: https://gerrit.libreoffice.org/32998
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-02-06 00:02:16 +00:00
Matteo Casalin
c6f32df907 sal_uIntPtr to sal_uInt16
Change-Id: If463ae457f53a0a8b12cc0748afbc654f54ae3c3
2017-02-05 21:44:49 +01:00
Maxim Monastirsky
eb0b727b87 .uno:ScriptOrganizer should be menu:menuitem
... so it won't show as an empty submenu in the
customization dialog, and allow accidentally
overwriting it.

Change-Id: I9431e5240485a58f63a2333850a9052e475db63e
2017-02-05 22:08:43 +02:00
Maxim Monastirsky
88a0a17ae4 chart2: Remove empty labels from main menu
Change-Id: I600d5bd2d502ffce7d54a699f390d30874323ca8
2017-02-05 22:08:27 +02:00
Maxim Monastirsky
9421a4c053 tdf#105737 Menu::GetItemType takes position not item id
And get rid of a pointless sal_uInt32-sal_uInt16 casting.

Change-Id: Ia27fd87ceb4d060dab9ea7fffd4803903a1893da
2017-02-05 20:57:01 +02:00