Commit Graph

474805 Commits

Author SHA1 Message Date
Kevin Suo
22c7ce6c8e UI Workaround for tdf#146653: change localized Source Han {Sans,Serif} CN...
...to Source Han Sans CN Normal and Source Han Serif CN Medium for Simplified Chinese UI, so that
the font shown is not bold.

Tranditional Chinese and Japanese settings are not touched. It is up to the
zh-TW and JA l10n team to decide whether to apply the same change.

This does not resolve the bug itself, but makes the UI usable when the
system has Source Han Sans CN or Source Han Serif CN fonts installed,
so that the default font used is normal weight rather than bold.

Change-Id: I52753448d886854d92ba8a26d8b03bf42522735f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128798
Tested-by: Jenkins
Reviewed-by: Franklin Weng <franklin@goodhorse.idv.tw>
Reviewed-by: Eike Rathke <erack@redhat.com>
2022-04-12 19:28:35 +02:00
Ilmari Lauhakangas
89dfd5058a odk: update DevGuide wiki links and correct history in footer
Change-Id: I95c78d1346d354b755aeecaa1e6c9d789be0b693
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132905
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-04-12 17:32:02 +02:00
Luboš Luňák
c358ed52ad compress row height calculation (tdf#148492)
Change-Id: I42346472485f00bd64d08d2e2d0aef0ec02423f1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132897
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-12 17:06:57 +02:00
Luboš Luňák
9efb19a6ad bail out of the loop when the item is found
Change-Id: If0816f38eeeb3330738ab40bc8a72f1e14575c33
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132904
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-12 17:06:37 +02:00
Stephan Bergmann
48e277ad1d Fix unoidl-read invocation
...that had inadvertently been missing from
bb64cd2884 "Add unoidl-read to the SDK"

Change-Id: I4003e1dede9c8d6caf036534f4c3d0e59a24da14
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132903
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-12 16:45:24 +02:00
Gabor Kelemen
2b44f94908 Recheck modules [uU]* with IWYU
See tdf#42949 for motivation

Change-Id: If710445176681de8e0a0b6c65f58ecaca19dbccf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132768
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-12 15:20:47 +02:00
Caolán McNamara
67a5469f1c ofz#46639 Timeout
Change-Id: I04f61749104bd21fa53edefd57a737d85c1d4faa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132898
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12 15:16:34 +02:00
Caolán McNamara
f0801aba21 ofz#46638 Integer-overflow
Change-Id: Iaf3a6d1b5db1428a4cdfa440ac3484d115a491cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132896
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12 14:57:27 +02:00
Caolán McNamara
71a11d27e2 drop unused width variable
Change-Id: I836234f86c01300d1a55e901699fee840efb37dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132895
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12 14:57:12 +02:00
Caolán McNamara
0c7f683766 ofz#46352 assert on bad string offset
Change-Id: I60123fd0460b8038f08582a0bcbf2307af321df1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132899
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12 14:56:32 +02:00
Xisco Fauli
58e156bc54 tdf#148423: subsequent_filters_test2: Add unittest
Change-Id: If630a0e0fe6370212c9d54a58b1b84dbe8b2dc64
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132892
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-12 14:49:33 +02:00
Jan-Marek Glogowski
af6dd54d53 tdf#148115 Qt handle tooltips via event loop
Instead of calling QToolTip::showText directly from LO, this
defers showing the tooltip to the QEvent processing, which takes
the tooltip timeouts into account. So tooltips are shown with
a slight delay, therefore they happen less fast on mouse move,
reducing / avoiding artifacts of fast changing windows.

This unfortunately comes with yet an other hack in the area of
our fake popup windows...

New handling is based on the code of the Qt Tool Tips example.

Change-Id: I42634ad36dd12171c30f52f07a02a88d3c48a718
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132841
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2022-04-12 14:09:00 +02:00
Luboš Luňák
ea68de2968 use gb_DEBUGINFO_FLAGS consistently in gbuild ExternalProject's
A number of them didn't use it at all, others had it hand-written
in various ways.

Change-Id: Iaf86325f9cdc032926bac917dc3eef4e34661544
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132818
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-12 13:57:32 +02:00
Caolán McNamara
967717e65f ofz: Use-of-uninitialized-value
Change-Id: I87cfad2da9b90bc4487dc4deb2fda5bb31a6b763
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132888
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12 13:37:12 +02:00
Luboš Luňák
3361db2179 include OutputDevice MapMode in SalLayoutGlyphsCache key (tdf#148400)
The mapmode also affects the layout of the glyphs.

Change-Id: I9492bc4d3d9e991ef8ab5dc30ce424e44cbc79f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132822
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-12 13:31:09 +02:00
Noel Grandin
cbaf1fbaa6 loplugin:stringview more o3tl conversion
look for call sequences that can use string_view and the new o3tl
functions in o3tl/string_view.hxx

Also add a few more wrappers to said #include file

Change-Id: I05d8752cc67a7b55b0b57e8eed803bd06bfcd9ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132840
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-12 12:42:15 +02:00
Jan-Marek Glogowski
f751417b77 tdf#148491 Qt reconnect the QMenuBar close button
When the QMenuBar of a QMainWindow is replaced, an existing
corner widget is preserved / transferred, but its connections
are still severed; a bit unexpected...

The documentation for QMenuBar::setCornerWidget is not really
clear what is happening, but the code has this nice comment:
"// Reparent corner widgets before we delete the old menu".
At least there is no need to explicitly delete the button.

Still we must reconnect an existing button on each SetFrame.

Regression from commit 9c4ef8ce31
("tdf#145954 Qt unshare QMenubar usage").

Change-Id: I13c31734e665b78231a08cd76ca6305122e08879
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132836
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-12 12:24:29 +02:00
Caolán McNamara
88fca5281d use cairo_font_face_t* instead of void* + casting
Change-Id: If3f5883790e4eee4dd4c519074b02d9cc2eda86c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132889
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12 12:16:31 +02:00
Stephan Bergmann
6400c23d6a Pick better type for a variable
Change-Id: I30916b188c7f8de06aec0719e79aa134a3250aef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132890
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-12 11:50:35 +02:00
Justin Luth
5453721050 tdf#148380 docx export: support CREATEDATE without format
When CREATEDATE is given as a field command without the optional
format string, then export was treating it as bWriteExpand
(aka ww::eUNKNOWN) and just dumped out the field name.

Instead, accept an empty string as a valid number format
in order to maintain it as a field.

In order to do this, we have to also turn off write-expand
for fixed fields, since import always treats CREATEDATE as FIXED.

The other existing example is
writerfilter/qa/cppunittests/dmapper/data/create-date-preserve.docx

DOC: not yet importing as FIXED
RTF: seems to just ignore bWriteExpand and does the right thing anyway.

Change-Id: If0aef38f6730f55b5fa1be6a62e0b6a0b4871658
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132662
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-12 11:46:44 +02:00
Shady Mohamed
4d27d087de tdf#143148 Use pragma once instead of include guards
Change-Id: I6262d64edcff4e73f2b148e98a62ee8d4b0d3294
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132839
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-04-12 10:29:28 +02:00
Stephan Bergmann
812081337a Delete tempfile when done
Change-Id: Ide7acab1ab8eae760f9818248ce44d07ca92a6f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132884
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-12 10:05:19 +02:00
Luboš Luňák
e97fc93876 libwebp is a C library, set CFLAGS and not CXXFLAGS
Change-Id: I79da4dcc61f50634dc8812dc5bf382053c170a9a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132817
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-12 09:55:10 +02:00
Miklos Vajna
846e57fd31 CppunitTest_sw_ooxmlexport8: avoid mustTestImportOf()
Can use CPPUNIT_TEST_FIXTURE() instead.

See commit a226cec52e
(CppunitTest_sw_rtfimport: convert one testcase to use
CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.

Change-Id: I92e2c25121a543747471e4066b55ddaf87a7a88b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132874
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2022-04-12 09:20:35 +02:00
Miklos Vajna
b40f9c536c sw content controls: add initial DOCX export
Wrap the text portions inside the content control inside <w:sdtContent>
and <w:sdt>. Also map the (so far) single property of it to
<w:showingPlcHdr>.

This is just initial export for inline text content controls, more
properties are to be added in follow-up commits.

Change-Id: I21e085496b4c79114b158656c5611aff8ffdd08a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132875
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2022-04-12 09:06:47 +02:00
Samuel Mehrbrodt
618d40799d tdf#147876 Fix crash when cancelling Dialog import dlg
Regression from 9a55b97e98

Change-Id: I3fc35981a0cb81e5b59236ec3b07450aec10541a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132737
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-04-12 08:56:12 +02:00
Tomaž Vajngerl
6790220e01 vcl: use auto delegate for X11SalGraphics and remove duplicates
X11SalGraphics can derive from SalGraphicsAutoDelegateToImpl to
remove many calls to the mxImpl, which can instead be done by the
auto delegator.

Change-Id: I7add2e824eb1be01f8d278e5af8a378a34b32671
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132826
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-04-12 08:25:28 +02:00
Miklos Vajna
732d430f7a sw: document SwXMeta::Impl
It already had some comments, but turn it into markup that is picked up
by doxygen + mention the locking aspect.

Change-Id: I6d9dba02f5be2e6f262733dfc124f09e29ba47eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132838
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-12 08:17:35 +02:00
Dennis Francis
92caeb1a36 unit test: use temp copy in testInvalidEntrySave()
Use a temporary copy of the source file to run this test otherwise it
will execute a .uno:Save on the original document in the git tree!

Change-Id: I673aad64453e72a9140efcad2b0ff9c0ceabc038
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132854
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-12 08:17:17 +02:00
Andreas Heinisch
e38374b15b tdf#56363 - UI test fails if the selected font is not present
Change-Id: Ic8ff99464b435169460d678590896decc91f5152
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132712
Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-04-12 08:06:40 +02:00
Szymon Kłos
657de28184 lok: run autofilter without timers
so we are sure we will get correct position

Change-Id: Idd218e19b8b3f3d6da67e325472e11b5661bc3b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130725
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131123
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131512
Tested-by: Jenkins
2022-04-11 23:10:47 +02:00
Xisco Fauli
9fcd2dc178 tdf#148395: sw: Add UItest
Change-Id: Id0e49ba6f0834dc85a26f4d9064dfe029a50fa35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132837
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-11 22:47:15 +02:00
Szymon Kłos
b5e2a004dc lok: fix formulabar rendering
While forwardporting it was not taken into account that
no pixel/logic conversion is needed.

regression in:
commit cf5b0d5972
Author: Szymon Kłos <szymon.klos@collabora.com>
Date:   Mon Jan 17 13:11:19 2022 +0100

    RTL: lok: render correctly interim windows

Change-Id: Ic6716bf9335d4a9297e3e5edfeb161702b846efb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132424
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132809
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-04-11 20:59:51 +02:00
Szymon Kłos
94d59b6227 lok: use JsonWriter for annotations notification
This will unify received objects in LOK.
boost::property_tree used "string" for number values
we expect them to be a "number" type.

Change-Id: Ie90d7e2dd98bb371fc09878dcc6e96f4cdf73f3b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132054
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132808
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-04-11 20:59:31 +02:00
Jan-Marek Glogowski
9ae3980548 tdf#148481 Map RefHand cursor to Qt::PointingHand
Change-Id: I79c7008655f22737f92a4a6430f1380e81c1c386
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132833
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-04-11 20:30:51 +02:00
Michael Weghorn
2f998468b0 android: Drop leftover German translation
The English string had already been dropped in

    commit a23bd42e9b
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Tue Apr 6 14:26:06 2021 +0200

        android: Drop custom file abstraction + UI

While the leftover German translation is just ignored
in development builds, it resulted in an error
when building a release APK like this:

> ./gradlew assembleStrippedUIEditingRelease
> warn: removing resource org.libreoffice:string/filter without required default value.
>
>
> > Task :compileStrippedUIEditingReleaseJavaWithJavac
> warning: [options] source value 6 is obsolete and will be removed in a future release
> warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
> Note: /home/michi/development/git/libreoffice-WORKTREE-for-android-x86/android/source/src/java/org/libreoffice/SettingsActivity.java uses or overrides a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: /home/michi/development/git/libreoffice-WORKTREE-for-android-x86/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java uses unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 2 warnings
>
> > Task :lintVitalStrippedUIEditingRelease
> /home/michi/development/git/libreoffice-WORKTREE-for-android-x86/android/source/res/values-de/strings.xml:28: Error: "filter" is translated here but not found in default locale [ExtraTranslation]
>     <string name="filter">Filtern nach</string>
>             ~~~~~~~~~~~~~
>
>    Explanation for issues of type "ExtraTranslation":
>    If a string appears in a specific language translation file, but there is
>    no corresponding string in the default locale, then this string is probably
>    unused. (It's technically possible that your application is only intended
>    to run in a specific locale, but it's still a good idea to provide a
>    fallback.)
>
>    Note that these strings can lead to crashes if the string is looked up on
>    any locale not providing a translation, so it's important to clean them
>    up.
>
> 1 errors, 0 warnings
>
> > Task :lintVitalStrippedUIEditingRelease FAILED
>
> FAILURE: Build failed with an exception.

Change-Id: I9a6c984d3250852d0e806cffdff81770ed868299
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132834
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-11 19:53:36 +02:00
Stephan Bergmann
de46531735 -Werror,-Wstrict-prototypes (clang-cl)
Change-Id: I72e35f51eb607662608ccaf944bec64ed422cef4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132835
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-11 19:40:51 +02:00
Noel Grandin
6fc3dfd3f1 use more string_view
found by tweaking the loplugin:stringview and making it whitelist
getLength

Change-Id: Ic41cd4e3026d93b70a76fe1279c6de3abbe6b4a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132820
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-11 17:44:46 +02:00
Olivier Hallot
8cbb08de38 Update git submodules
* Update helpcontent2 from branch 'master'
  to 8219f0b1d741dc3e3927a1fb9ee4fc0b916d57e1
  - tdf#102265 Add Format - List submenu for Impress
    
    + usual refactoring and icon size adjustments
    
    Change-Id: I614438a36fa1ca34ddfaac81aadb0f54bd51940e
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132736
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-04-11 17:22:33 +02:00
Olivier Hallot
6c4a7c3ebc Update git submodules
* Update helpcontent2 from branch 'master'
  to 2dac57ec902e35a673966e66956a19096ed09f45
  - Fix alternate text in images for Manual Break page
    
    Add index for proper search
    
    Change-Id: I22591b61d6a42f0ac6cfae06e4d77a29050bcf55
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132821
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-04-11 17:21:46 +02:00
Miklos Vajna
ab8d141967 sw: add sub Title impl for SwInputField
It is advertised as a property, but it's not implemented: just avoid the
assert fail on inspecting the UNO wrapper.

Change-Id: Id482443aeeee71198dbddbcb3810ae0c4b7b30bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132819
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2022-04-11 17:04:31 +02:00
Tomaž Vajngerl
538166da77 sc: fix rendering when sparkline doesn't have a data range
Change-Id: I945594d93c893043cea1758b3ad9c4e7692ef27e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132815
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-04-11 16:43:04 +02:00
Christian Lohmaier
5e28945bd4 Update git submodules
* Update translations from branch 'master'
  to 4d46412589f57e6ee772560a2d71b3263dfffbce
  - update translations for master
    
    and force-fix errors using pocheck
    
    Change-Id: I962121d5d277887d6ecd827c183c177ea578bcd7
2022-04-11 16:21:31 +02:00
Xisco Fauli
bc227a15db tdf#148052: sw_ooxmlexport17: add unittest
Change-Id: I4153e4598114e54481fc25d174c3ccb9394de6b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132811
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-11 15:36:56 +02:00
Stephan Bergmann
bb64cd2884 Add unoidl-read to the SDK
...as a replacement for the legacy regview

Change-Id: I1e1eecb45f27422727f28feb19c2479af867bd79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132816
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-11 15:10:12 +02:00
Noel Grandin
85c2ed8dc7 loplugin:stringview add check for getToken().toInt32
where we can convert that to
    o3tl::toInt32(o3tl::getToken(
and avoid the heap allocation of a temporary string

Change-Id: Ib11c19c6e6cdc0de3e551affd3578d181e292de4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132810
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-11 14:45:38 +02:00
Adolfo Jayme Barrientos
117688bd3f Update git submodules
* Update helpcontent2 from branch 'master'
  to 62983d1d5abdc3409b84bccc29a9cca6ae659a8e
  - Improve text further
    
    Attempting to make it a little less difficult to read.
    
    Change-Id: I3e852d95b32b3a56900d221a6e3a971a7d715f28
2022-04-11 14:39:03 +02:00
Stephan Bergmann
77db890a80 unoidl-check does not need to be part of installation sets
...it is a build-time tool used from solenv/gbuild/UnoApiTarget.mk, and should
be of no value for users of LO (or of the SDK).  It was presumably a historic
mistake that its predecessor regcompare was included in installation sets in the
first place.  (The only mention of it in the Developers' Guide, which only
acknowledged its existence without giving any details how to use it, has been
removed in
<https://wiki.documentfoundation.org/index.php?title=Documentation/DevGuide/Writing_UNO_Components&oldid=492551>
"Drop mention of build-time tool unoidl-check that should not be part of any
installation sets".)

Change-Id: I626e22fa18ad900af150afe29a36aa1ceaf5e259
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132814
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-11 14:12:21 +02:00
Michael Weghorn
9c5facd726 android: Pass variable for "selected" param
... of the CalcHeaderCell ctor, to simplify this a bit.

Change-Id: I02ff00acccaec26de54534c6c021b9cd05f1d472
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132813
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-11 13:19:07 +02:00
Stephan Bergmann
bdfab729df Drop duplicate regmerge/regview items
...that had been added with 26db47abd0
"CWS-TOOLING: integrate CWS jsc312", probably due to a mis-merge.  (The first
occurrences had been updated over time, and the second ones not, but lets keep
the second ones, properly updated, as that matches the order in which the tools'
full descriptions appear further down below.)

Change-Id: I725105e926a5761c210c5901e00179ea9a1b6b5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132812
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-11 13:12:28 +02:00