I found this fix by testing "pure" red/green/blue files (see attachments in the bugtracker)
where red 16 bits file was ok but not green and blue 16 bits ones.
Change-Id: Ic700a0fa17c3056d1d4f1d1a7f16a799ff4c7378
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133108
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Messages to thrown `RuntimeException` instances have been added to make
the error clearer.
Change-Id: I566c475bd4ddf891a2cebf15664576cff792c118
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133100
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This used to be GetCntnt, but then out of the blue in a huge
squashed commit, it changed to GetFieldName. So I assume that
was just debugging code that got accidentally committed.
It just doesn't make any sense to export the field name
as the plain text content instead of the field's value.
commit ed40f62e64564d2b22c9285cfdc6778aeac8fd68
Author: Michael Meeks on Mon Mar 14 16:51:14 2011 +0000
Merge commit 'ooo/DEV300_m101' into integration/dev300_m101
NOTE: DOC also does a .replace(0x0A, 0x0B),
//replace LF 0x0A with VT 0x0B
//#i19604# convert hard line breaks inside fields to word equivalent
After taking care of SAVEDATE, PRINTDATE, I tested this with
assert(rInfos.pField->GetFieldName() == "Sender");
and found no other examples.
Change-Id: Ie24b8c176fe6df4015be221c87aa249fe9b8ce92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132666
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
* Update helpcontent2 from branch 'master'
to 24828f91e22842cdaf64faf7d22a028541e5746c
- tdf#148621 Improve Basic Help layout
- Get rid of tables
- Add normalize-whitespace Prism plugin to get rid of useless indents
- Fix code blocks poking through sticky header
- Add some word wrapping CSS to fix mobile-unfriendliness
Change-Id: I73fd1e0678624b0d4bd5561f50e80990db5567be
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133096
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
references to footnotes and endnotes
Change-Id: Ie1828c9c4ec0c3c8159c8e5653b09b2b7bd8a5e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133092
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
when entry is not found in content tree
This happens when the document cursor is positioned on table of content
hyperlinks.
Change-Id: I717b2dae31780b26cf5450fbea0c8f461659770c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132989
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
...since a8383345174d91f6e722128e1d53c9a4ebc18195 "No Win16-style WIN.INI since
Windows Vista"
Change-Id: I36fa3f6516a6bd9ac6593e01163c1f3427933e42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133090
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This is the same idea as the earlier patch for CREATEDATE.
However, it isn't safe to import these as fields,
so a round-trip test can only test the string itself.
The unit test here really doesn't test any of the code changes,
but is just pre-emptive to ensure that if DI_CHANGE
is imported as a field that it will have the right
output.
(P.S. Expected date output matches MS Word 2003
even after an F9 refresh.)
Change-Id: I30a8b1fc851246898a67e6241a35e927f85dfbb9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132664
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
there is no DeinitVCL for fuzzing, so fill the fontoptions,etc cache
before starting
Change-Id: I14a30c3d38490d03c31b4c349674ba48dd32de15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133088
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
The shapes 'Octagon Bevel', type col_60da8460, and 'Diamond Bevel',
type col-502ad400, are LO specific preset shapes. They have neither a
counterpart in MS binary nor in OOXML. So they need to be exported
with custGeom. To force custGeom these shape types are moved from
vDenylist to vAllowlist.
These shapes were exported as prst='rect' before.
Change-Id: I9619345812b6dba8f14ec2cc6a92ae808a56b595
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133069
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
which solves the problem of parts of the gtk ui remaining in the old
theme when switching dark<->light
Change-Id: I59060dfdf3937ca13cd706eefc9e67c133478992
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133076
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
See also 263961306ede0656ebb7904034a2172615ce81d0
Change-Id: Ib64ec43dba59ffddb34fe7f1a0f0d2e589c3455c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133063
Tested-by: René Engelhard <rene@debian.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
My previous implementation was changing current format selection
only for field edit dialog. However it should be initialized also
for insert field dlg. It is not always first element. Instead of
older confusing approach right now there is a switch to set
defaults: it is less confusing IMO.
Change-Id: I189339ba66effc49267004a42345a28892cb693c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132980
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
I can't see anything that is useful which could be used to derive this
so just pick a better hard coded color
Change-Id: Ia351e636ed3a44e9af79147b2d9dfcf347bd8ea9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133068
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
in the conversion in
commit 74957c7d2f3697fbf2b6f4d6a31c61d5d7df039b
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Wed Apr 13 13:54:22 2022 +0200
use more string_view in l10ntools
where the prior code might have been relying on the -1 returned by
indexOf and lastIndexOd
Change-Id: Ief5dedccbaf4e14e5f59aa3c2f7481ff0bb7e2e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133027
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
call popdown so we will mark popup as closed in DockingManager
this fixes crash when trying to open autofilter popup second time
Change-Id: I9f2db6fe284d9b9770c20dea4b8a4054524a998b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132619
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132917
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
- remove special type "autofilter"
- now autofilter will be handled by dialog code in online
Change-Id: I3478c3e05ab2e83030a8d68632d0426a5cc0accd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132539
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132916
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
