Commit Graph

194 Commits

Author SHA1 Message Date
Andrea Gelmini
534b2a4b58 Fix typos
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3
Reviewed-on: https://gerrit.libreoffice.org/21797
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-05 06:48:38 +00:00
Caolán McNamara
bf4ee8ee31 coverity#1326386 Dereference null return value
Change-Id: Ifd1cd2cfb6032e7a2d14d926d4de8be22160daee
2016-02-04 15:47:11 +00:00
Michael Stahl
969a760e2b reportbuilder: tdf#92720: add loext namespace
... to allow export of paragraphs in shapes.

(regression from 6acc6c011d)

Change-Id: I2c23e686a2cfcd997d3393b0f9fb4cdcab7252b7
2016-02-03 23:43:34 +01:00
Caolán McNamara
08680c58de coverity#1326438 Dereference null return value
and

coverity#1326439 Dereference null return value

Change-Id: Idf7e6f34accfb5d5b98a62f6ad221c325e24586a
2016-01-21 15:15:52 +00:00
Caolán McNamara
2043556e6c coverity#1326551 Dereference before null check
Change-Id: I11a65723909b7ed78a487ece7456c0e5a4d1aa8b
2016-01-21 15:15:52 +00:00
Caolán McNamara
5e89fc23a8 coverity#1327068 SIC: Inner class could be made static
Change-Id: I1fd9d122f2bde1db9101e937999d75ac19cc4dfb
2015-11-04 13:55:53 +00:00
Caolán McNamara
385e9afea2 coverity#1327210 UwF: Unwritten field
Change-Id: I6fb5b18b6a6e51727d7350039da97f06f65736ff
2015-11-04 13:55:53 +00:00
Noel Grandin
a1624a8ecd cid#1327023 to cid#1327077 SIC: Inner class could be made static
Change-Id: I41f89c4feefe4e012d72c663ebb9bbcb4aa7f163
2015-10-15 09:23:16 +02:00
Caolán McNamara
e75701ce9e coverity#1327210 UwF: Unwritten field
Change-Id: I1021bd43a93b9b7f1b4e0f73f75e7a7f7c52b857
2015-10-14 11:40:23 +01:00
Noel Grandin
abd980d4ec cid#1326605, cid#1326604 BC: Bad casts of object references
Change-Id: I85fa5fd4671d749850af854a7d4ba934416d892b
2015-10-14 09:55:11 +02:00
Andrea Gelmini
d721cc515b Fix typos
Change-Id: I8f4500fc7a901c5cc73634ba6da6b9541452e5ae
Reviewed-on: https://gerrit.libreoffice.org/18966
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30 06:43:52 +00:00
Tor Lillqvist
395d922f58 chmod -x
Change-Id: I4a248b59e12587c3b2ce79676fdce29a348b6751
2015-07-29 14:17:05 +03:00
Andrea Gelmini
e544f449ed Fix typos
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920
Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-07-08 12:21:19 +02:00
Andrea Gelmini
3dfdd18707 Fix typos
Change-Id: Iddcc22f62ea134ea797292daa02e47042d52d0d1
Reviewed-on: https://gerrit.libreoffice.org/16710
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-04 10:22:11 +00:00
Noel Grandin
0c18bedb73 java: 'final static' to 'static final'
this is the canonical order, and it makes the code easier to read

Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470
Reviewed-on: https://gerrit.libreoffice.org/16242
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-15 08:45:19 +00:00
Noel Grandin
efd4bfa818 java:regulatize the order of 'final' and public/private
Make the order be 'public static' or 'private static'
Just makes the code nicer to read.

Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2
Reviewed-on: https://gerrit.libreoffice.org/16202
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11 09:34:00 +00:00
Julien Nabet
48f0a5ed35 Typos
Change-Id: I845a85e1aad4a0708f2b43f7d94606b4b5513ee4
2015-02-18 21:59:02 +01:00
Lionel Elie Mamane
cc376d8785 set java throwable cause argument (erroneously removed by previous commit)
Change-Id: Ib4516eec5e47d95d53dbb5002f7258514c93f2c9
2015-01-22 13:18:55 +01:00
Lionel Elie Mamane
f4a2cff16e Don't try to pass an arbitrary Java exception through UNO
also make other exceptions more verbose

Change-Id: Id6bf88b1ec228b20b19c89ccf6ee14d0c1ffb44d
2015-01-21 18:26:06 +01:00
Stephan Bergmann
01fb1701c8 Related fdo#85190: Don't dress arbitrary Java Throwables as UNO Any values
Regression introduced with 9341bf3dc3 "java: when
rethrowing, store the original exception," but these two appear to be the only
two cases related to com.sun.star.lang.WrappedTarget[Runtime]Exception in that
patch that would now create bad UNO Any values.  Happily reverted to the
original but oddly inconsistent setting of the WrappedTargetException's
TargetException member...

Change-Id: I9421da721d5a111d0d89ee0601238a2c01cfc12c
2015-01-21 17:31:41 +01:00
Noel Grandin
10039462df java: remove more dead code
found by looking for unused parameters (in Eclipse)

Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
2015-01-05 09:59:03 +02:00
Noel Grandin
46540d08b1 java: these fields can become local variables
found by PMD

Change-Id: Id852cfec984a181b91aca1c00a41e342b720a4bf
2015-01-05 08:23:30 +02:00
Noel Grandin
a49b2ba1a6 java: remove dead stylemapper code in reportbuilder
as far as I can tell, this has been dead since the original import
of this code

Change-Id: I4bd47e55eb0abc991ea1d58c16fba6fa6c7878d9
2015-01-05 08:23:30 +02:00
Noel Grandin
43cc8ad33e java: remove dead code
found by UCDetector

Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2015-01-05 08:23:29 +02:00
Noel Grandin
581d1e35f8 java: reduce visibility of some methods and fields
found by UCDetector

Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
2014-12-19 11:49:10 +02:00
Lionel Elie Mamane
9c346fbcf2 Revert "reportbuilder: re-add numerous bits of dead code needed by bug fix"
This reverts commit 458f22c338.

Since we reverted d6ce95ae22, this code
is again unused.
2014-12-17 11:01:17 +01:00
Lionel Elie Mamane
08715e24c1 Revert "fdo#87044: reportbuilder: Revert "fdo#67930 don't use variables ..."
This reverts commit d6ce95ae22.

Not necessary to fix fdo#87044, commit
1e10f6d229 is sufficient. Since the code
that is reintroduced leads to an overly complex and fragile document
structure, I'd rather not have it.
2014-12-17 11:01:17 +01:00
Lionel Elie Mamane
1e10f6d229 fdo#67930 work around fdo#68024
don't emit string-value attribute

Change-Id: I3668b88437451523f2b6bb3c2c82e1929f7ba3d8
Reviewed-on: https://gerrit.libreoffice.org/5371
Tested-by: Miklos Vajna <vmiklos@suse.cz>
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
(cherry picked from commit 76408b0f0d7e91cddb8b056069a2ee547109b156)
2014-12-12 18:04:40 +01:00
Michael Stahl
d6ce95ae22 fdo#87044: reportbuilder: Revert "fdo#67930 don't use variables ...
... for formattedtext in header/footer"

This reverts commit b0e3c6b8fa.
This reverts commit fc92c1abeb.

The other fix from the libreoffice-4-1 branch seems to work better.

Change-Id: Idc5d7543c11dff74977729dab5afd978197dab6a
2014-12-12 18:04:39 +01:00
Michael Stahl
458f22c338 reportbuilder: re-add numerous bits of dead code needed by bug fix
Change-Id: Ia0a8b8ec3b4684ad6766467c8e3413f91dc8bf67
2014-12-12 18:04:39 +01:00
Noel Grandin
7557f23b31 java: reduce visibility of fields and methods
found by PMD

Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11 06:09:03 +00:00
Noel Grandin
7d812b09b5 java: unused imports
Change-Id: I05824a6f19a5f3048a52101b96f6bf3d3099df08
Reviewed-on: https://gerrit.libreoffice.org/13403
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10 08:03:50 +00:00
Noel Grandin
6636b2baca no need to call getComposer by reflection
Change-Id: Icf2cdeaab013814b669ce6d6cd243ce43856e940
2014-12-09 13:34:47 +02:00
Noel Grandin
c199b76d88 java: remove some unused local variables
Change-Id: Ia01528460e2f4b610d123e29cad66520abc6a965
2014-12-05 11:15:57 +02:00
Noel Grandin
0063cf2856 java: make fields final where possible
found by PMD

Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-18 12:44:28 +02:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade…
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:04:11 +00:00
Noel Grandin
bb437029c1 java: convert fields to local variables where possible
found by PMD

Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542
Reviewed-on: https://gerrit.libreoffice.org/12376
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:03:29 +00:00
Robert Antoni Buj i Gelonch
5d8ecad569 java: Method uses the same code for two switch clauses
Change-Id: Ied82b0a39ff9dc9c7cc9539dec2b963059f3d4a5
Reviewed-on: https://gerrit.libreoffice.org/12139
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-30 08:57:28 +00:00
Robert Antoni Buj i Gelonch
d807cba9ee java: loss of precission
Change-Id: I0563a76b1d2c838e6301bf7a9ed154c77a98c0d9
Reviewed-on: https://gerrit.libreoffice.org/12000
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-18 08:40:17 +00:00
Noel Grandin
03c7c26cbe java: final fields that can be static
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-17 08:26:21 +02:00
Noel Grandin
9341bf3dc3 java: when rethrowing, store the original exception
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
2014-10-16 12:27:15 +02:00
Noel Grandin
973eb2f6db java: reduce the depth of some deeply nested if blocks
Change-Id: I3c0c7f08d4d8ea594e72fc0d9b93d085d4ab4bf5
2014-10-16 08:15:48 +02:00
Robert Antoni Buj i Gelonch
a667840368 reportbuilder: import from java.lang package
Change-Id: I039f7cf28dddede48627c3c624c87741ee9de0ed
Reviewed-on: https://gerrit.libreoffice.org/11956
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13 15:16:35 +00:00
Noel Grandin
726fc58d0c java: log exceptions correctly, using the right version of WARN
Change-Id: Ide21786d5275802ee60de2d5f056aa08cc8497ca
2014-10-07 13:20:02 +02:00
Noel Grandin
060956beaa fix classname in logger
Change-Id: Id4d954059d63036b78cfeb7b14a7ebd8eae73f46
2014-10-07 13:20:01 +02:00
rbuj
da3b039d41 reportbuilder: fix javadoc error: reference not found
Change-Id: Ic548a23a9d1e1acc90386da76416c76990f3a5b3
Reviewed-on: https://gerrit.libreoffice.org/11309
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-07 13:03:24 -05:00
rbuj
653025e6f1 reportbuilder: fix unknown tag: noinspection (IntelliJ)
Change-Id: I97c464547068d0d17a0d4423e8462097c73624aa
Reviewed-on: https://gerrit.libreoffice.org/11243
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-09-02 06:11:52 -05:00
rbuj
4db06c5a69 reportbuilder: fix javadoc error: no summary or caption for table
Change-Id: I5697ebe0481491d70ee728cac5343aaf892ad29f
Reviewed-on: https://gerrit.libreoffice.org/11242
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-02 02:14:57 -05:00
rbuj
18d72e76f1 reportbuilder: fix javadoc error: self-closing element not allowed
Change-Id: Iabfa4dd2c1018b982b50798bf09347e0b11901a4
Reviewed-on: https://gerrit.libreoffice.org/11240
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-02 02:13:49 -05:00
rbuj
fbe8186434 reportbuilder: fix javadoc error: unknown tag: returns
Change-Id: I3cc2afca6e59a8bc9e3374e5cebf9b2e903da78b
Reviewed-on: https://gerrit.libreoffice.org/11241
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-09-02 02:07:26 -05:00