Commit Graph

152 Commits

Author SHA1 Message Date
Stephan Bergmann
abfc2c7493 ODR violation (base class must be the same across compilation units)
Change-Id: I3693e543fcca3796e3a3dfccabb8dce3f029531d
2016-12-21 15:05:10 +01:00
Noel Grandin
d15b4e2045 teach sallogareas plugin to catch inconsistencies
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a
Reviewed-on: https://gerrit.libreoffice.org/32004
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-15 06:45:14 +00:00
Noel Grandin
02ed1924eb OSL_TRACE->SAL in sd..sdext
Change-Id: I6b224fa890dc96aada7140af27078da5e25c3ff8
Reviewed-on: https://gerrit.libreoffice.org/31898
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12 12:17:26 +00:00
Noel Grandin
89687d651e loplugin:expandablemethods in sd
Change-Id: I87a537928bdf42285448bba7cb50c497f2637c3c
Reviewed-on: https://gerrit.libreoffice.org/30330
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28 07:08:47 +00:00
Stephan Bergmann
106ea87205 Remove _TYPED suffix from tools/link.hxx macros
...which was introduced with 3ead3ad52f "Gradually
typed Link" to distinguish the new, typed versions from the old, untyped ones,
but is no longer necessary since 382eb1a23c
"remove untyped Link<>" removed the old versions.

Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-05 07:56:12 +02:00
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13 13:19:22 +02:00
Muhammet Kara
376c337d46 tdf#97087 Give comprehensible, unique names to idles
Timers and idles should have programmer comprehensible, unique names

Change-Id: Id0f2c0a77cd28c3ec5473e8432569739b58d2101
Reviewed-on: https://gerrit.libreoffice.org/24388
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-28 09:34:30 +00:00
Noel Grandin
f946e905c6 loplugin:constantparam in sd
Change-Id: I7f5065c08f539ceefa4b8d3925b9c09e72b25a44
2016-03-10 10:09:59 +02:00
Michael Stahl
57200e6a1c sd: replace boost::bind with C++11 lambdas
Change-Id: I17328cd13b44b4406013ec06521246ad8363b5a3
2016-03-02 22:28:49 +01:00
Noel Grandin
9570bdfcb9 loplugin:unusedfields in sd
Change-Id: I59a127dace4a1818dfb2ccd6a7b673d39a9c5c60
2015-12-22 09:53:26 +02:00
Philippe Jung
229fc164dc Impress: Rework the way the display modes are presented.
TODO: take into account remarks from Gerrit

New combo to select display mode among:
 - Slide edition (Normal)
 - Outline
 - Notes
 - Slide sorter
 - Slide master
 - Notes master
 - Handout (master, as we are designing the template used to generate
   the handout)

The combo is based on uno command .uno:DisplayMode

Center pane tabs are hidden by default. A new uno dispatch
command (.uno:ToggleTabBarVisibility) is available to show/hide
this tab bar.

Modified uno dispatch commands:

No uno name has been modified.

.uno:DiaMode :
SID_DIAMODE renamed SID_SLIDER_SORTER_MODE

.uno:OutlineMode
SID_OUTLINEMODE renamed SID_OUTLINE_MODE

.uno:NotesMode
No change

.uno:HandoutMode
SID_HANDOUT_MODE renamed SID_HANDOUT_MASTER_MODE
All internal code also considers the edit mode as master

.uno:SlideMasterPage
SID_SLIDE_MASTERPAGE renamed SID_SLIDE_MASTER_MODE
If the input parameter SfxBoolItem Isactive is true or not provided,
activates Slide Master mode. If parameter is false, activates the
"Normal" (slide editing) mode.

.uno:NotesMasterPage
SID_NOTES_MASTERPAGE renamed SID_NOTES_MASTER_MODE
If the input parameter SfxBoolItem Isactive is true or not provided,
activates Notes Master mode. If parameter is false, activates the
"Notes" mode.

Modified behaviours: Now only one mode can be chosen. It is possible to
navigate from a mode to any other mode.
Previous behaviour: the following navigation
     Normal -> Slide Master -> Notes -> Normal
was displaying slide master. It was required to activate Normal once more
to get back to normal.
Now the same commands will display the requested mode.

Still to come (at least):
- Fix reopen the last display mode.
- Center pane tabs are now presenting all buttons for all modes (TODO).

Change-Id: I11ab59d2f3caa9149260c5e55d44d598d0ce3390
Reviewed-on: https://gerrit.libreoffice.org/16723
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2015-11-18 14:09:27 +00:00
Stephan Bergmann
92c697c0e3 loplugin:nullptr (automatic rewrite)
Change-Id: If1b80da64ba575f07b31dce9bc0e34b7eb9f11a4
2015-11-10 10:31:38 +01:00
Noel Grandin
1d67ca08da use uno::Reference::set method instead of assignment
Change-Id: Ib224c60d3e5afc968bf4ef5ff58c3a71893b811c
2015-11-05 07:41:29 +02:00
Noel Grandin
a279535660 com::sun::star->css in sd
Change-Id: Ic0cbc857a3a9c66241b94c30bf8c859435f5a4b4
2015-10-29 09:50:19 +02:00
Noel Grandin
e6dce26083 cppcheck:noExplicitConstructor
Change-Id: I06f33af242c60e0349417ceab3ca4a6d47cd402d
Reviewed-on: https://gerrit.libreoffice.org/19589
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-26 05:47:06 +00:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Caolán McNamara
4b16c89f06 sd/source/ui/framework boost::scoped_ptr->std::unique_ptr
Change-Id: I37e8c596d7afc3f7d0461b40e596dea45e9470a4
Reviewed-on: https://gerrit.libreoffice.org/18824
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-24 23:35:17 +00:00
Caolán McNamara
b71ba617e5 sd/source/ui/inc boost::scoped_ptr->std::unique_ptr
Change-Id: Icf32ccd437c97dfa0ac3a569a3f2ec2b746ac300
Reviewed-on: https://gerrit.libreoffice.org/18822
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-24 16:54:36 +00:00
Caolán McNamara
177ea7a281 boost::shared_ptr->std::shared_ptr
Change-Id: I2c6ac98f0984534894759cfbf4449eb554801cf8
Reviewed-on: https://gerrit.libreoffice.org/18678
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-23 11:19:17 +00:00
Caolán McNamara
d030c4a2a5 revert for mac and win unit case crashes after boost->std
Change-Id: I82c7084f203a834c2d42f9527705288e6036019b
2015-09-17 18:59:32 +01:00
Caolán McNamara
6f495a195b boost->std
Change-Id: I1e6a7fd66f90e6acd803c6cd464f1d73252f7bcb
2015-09-17 17:01:14 +01:00
Takeshi Abe
c1c6a8615c sd: tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants.

Change-Id: I01909ee45c31d17356e13b1ff2430440daff9aa7
Reviewed-on: https://gerrit.libreoffice.org/18146
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-31 07:14:47 +00:00
Stephan Bergmann
c9b4c56811 Use typed Idle::SetIdleHdl Link
Change-Id: I189937950325dc4ef663f7f49cb45f38f8537de9
2015-05-05 12:05:38 +02:00
Noel Grandin
71b809959b remove unnecessary use of void in function declarations
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
Stephan Bergmann
c1e4a1d347 Clean up previous commit
Change-Id: I94a0aeac85918f2eb91421e46e75283f839e7425
2015-03-12 08:17:10 +01:00
Chris Sherlock
4dafecfe4a sd: convert sd.component to constructor usage
Change-Id: I844a7387253960059855346faa62c4ae51b97b18
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2015-03-12 08:17:10 +01:00
Tobias Madl
8f9b0c8692 Idle: Changed to new enum name
Change-Id: Id3852abe9bc7bbe774331a7d691abd2a79ff59b4
2015-03-06 12:27:10 +00:00
Tobias Madl
2d95bc0510 Idle: Removed VCL_IDLE_PRIORITY_ prefix of enum
Change-Id: I12290bed7e4f298ab90393b8de6e2b6e7061e53f
2015-03-06 12:27:09 +00:00
Tobias Madl
826143684d Timer: Adapted all idle includes and enum uses
Change-Id: Id4ef36d6c80ad62306bdbaa7094c2cb0b8ff77da
2015-03-06 12:27:05 +00:00
Caolán McNamara
0be5d2b2f6 boost::unordered_map->std::unordered_map
Change-Id: I82f668ef72e916d2ff11df5cda2a02653999f66f
2015-01-04 11:07:58 +00:00
Tobias Madl
d1577ee1ed priorities: prevent future compatibility problems
Change-Id: I735bac570a0bed35d9ddc07e5f107fb696b49082
2014-12-10 12:06:42 +00:00
Jennifer Liebel
d843f3de73 changed timers to idle
Change-Id: I92f40d3dad133347f1b8db0b025b624d3305f885
2014-12-09 12:34:58 +00:00
Brij Mohan Lal Srivastava
d32be3ace8 fdo#86023 - O[U]String needs a 'clear' method
Added clear() method to OString and OUString class, Updated appropriate call-sites.

Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14 09:20:38 +01:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade…
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:04:11 +00:00
Stefan Weiberg
35354e6cef Related fdo#82088: removing aliases in headers
Change-Id: Id3496d1720630dd7a873edd04b664fc279c1c25e
Reviewed-on: https://gerrit.libreoffice.org/11294
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-06 15:54:28 -05:00
Markus Mohrhard
ed6b8a100c remove whitespaces
Change-Id: I9daea42a433b5032931a722878874917cf37f4d1
2014-06-25 05:41:09 +02:00
Stephan Bergmann
c6eb208473 loplugin:staticcall
Change-Id: I502702dfd04405748a314bd171e6298850777c0a
2014-06-13 17:54:31 +02:00
Caolán McNamara
a921f41a26 coverity#1219795 Uncaught exception
Change-Id: I24f5abd0e0b28c11c22c7871e10f42abb9908775
2014-06-02 16:59:57 +01:00
Caolán McNamara
a0a724d57c coverity#707105 Uncaught exception
Change-Id: Ice8f9633a9dddd492ce8c5d1d88961ecbed59216
2014-05-28 13:49:51 +01:00
Noel Grandin
b45a12c37d sd: sal_Bool->bool
Change-Id: I3172a42f6b6abe434ffe0475d1201ff50b6c06ea
2014-04-24 10:53:17 +02:00
Stephan Bergmann
1531b523bf Clean up function declarations and some unused functions
Change-Id: I7a2b5970fd0ab2059b5f5b0100a049e04ba54ee3
2014-04-14 17:55:32 +02:00
Thomas Arnhold
13943b18b7 typo: controlls -> controls 2014-04-14 12:32:29 +02:00
Stephan Bergmann
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
Stephan Bergmann
078199a243 bool improvements
Change-Id: I943e54afaf6ce58aaccbf588ffd9b9e235ef3b39
2014-01-22 08:22:35 +01:00
Stephan Bergmann
e9c62a2d9c Get rid of unnecessary comphelper::UStringEqual
Change-Id: Ia8718e49f21ccec239b2769eafa6bef90e0e9e40
2013-12-06 14:28:36 +01:00
Stephan Bergmann
895e6e7bb7 Get rid of comphelper::UStringLess
...default std::less<OUString> is just fine.

Change-Id: Ib9d3c10f2817d757f3c19eb3d4607095883af91a
2013-12-05 18:36:22 +01:00
Thomas Arnhold
3b58ababc5 fixincludeguards.sh: sd
Change-Id: Ic831838b377656015d645eec9d439424378e08af
2013-10-23 23:22:33 +02:00
Caolán McNamara
d023339c2f Turn sidebar back to non-experimental
This reverts commit 7ce2a89f4f.

Change-Id: I53f572777e84f66fd4c3d18fb686dac09095804a

revert d38cb53e3b

Change-Id: I5b243b69e50084316aaeab250d6b01079c12b718

Revert "sidebar: disable impress task pane if sidebar is enabled."

This reverts commit ee1726bfdb.

revert 54d820a781

Change-Id: Ie7c83d88f5427a7e42fa50879280a0c4a7c2cdd1

Revert "Only register and use the Sidebar if it is globally enabled."

This reverts commit 66a5cc468c.

Conflicts:
	sfx2/source/view/viewfrm.cxx

Change-Id: I17fe702996c4adf7f387573d36ea993f8cc32c96

Revert "disable sidebar menu option if it is disabled."

This reverts commit 05f0eb5761.

Revert "finally get the taskpane rendering again"

This reverts commit 228bb7ffe0.

Conflicts:
	officecfg/registry/data/org/openoffice/Office/Impress.xcu
	sd/source/ui/framework/factories/TaskPanelFactory.cxx
	sd/source/ui/framework/tools/FrameworkHelper.cxx

Change-Id: I248cc9a769695cde19e78774d42ce666dc685599

Revert "don't throw up the sidebar on start."

This reverts commit 645db9a2bd.

Conflicts:
	officecfg/registry/data/org/openoffice/Office/Views.xcu

Change-Id: I911859757e2e019836e8ed5213d2ba69ff82aec8

Revert "update to the right service name for new URLs."

This reverts commit 55f49970f4.

Conflicts:
	sd/source/ui/framework/tools/FrameworkHelper.cxx

Change-Id: I1ba2762a4c969a9125ff8354a9b6035813290021

Revert "tentatively restore more UNO / task-pane goo ..."

This reverts commit 052ac10a6f.

Conflicts:
	officecfg/registry/data/org/openoffice/Office/Impress.xcu

Change-Id: I7e62f27329af033df811549436718648a6447dea

Revert "more reverts, first cut at making sidebar optional."

This reverts commit a65a423e22.

Revert "add experimental option for sidebar to 'Advanced' pane."

This reverts commit 54d820a781.

Conflicts:
	cui/source/options/optjava.cxx
	sd/source/ui/framework/module/ImpressModule.cxx

Change-Id: I09a6c0f7834c8ef330d05a014505aaaf09ae096f

Revert "Restore FrameworkHelper taskpane URLs."

This reverts commit e9c2d5b26b.

more foo

Change-Id: I2eaa2fbd74dc7a2f7ba937d310472cee6b5a0b57

really go to town on it

Change-Id: I885dc03cd0286bbfdf05c05da9f0bbea2b78bcf4
2013-09-20 16:35:29 +01:00