Sorry to have to revert this, but it is too broken on Windows.
Even on linux it needed some work to get right. Just stick with
what was there while the author works on a better version.
This reverts commit 21155b8739.
Change-Id: Iaa075c2bd4d2fccf4d58052888735bedc83605c7
I added a GetPos() method because quite a lot of code used that
method and the existing code is quite tied to the precise
return values of that method.
Change-Id: I9af6b923d978abe758b63d835f228495c020455a
Removed the copy constructor because it was dangerous,
it could result in accessing an SwTOXSortKey object after it was released.
Removed the operator= because it was private, and no longer used.
Change-Id: Ifaf21cbbad5f8b9cabddcc3009e4ed776b1fdd71
Method assumed that not much attribution happens below data and started from
the end of attribution, in the case of not much attribution it worked fine.
For the case of many differently formatted areas with a sufficiently large
area of visibly equal attribution near data end it was a bottle neck looping
over unnecessarily many comparisons. Start at data end instead. For the case
of not much attribution it doesn't really matter, and for the case of no
sufficiently large area below data end it doesn't matter at all and compares
the same number of entries. The drawback would be a large area near
attribution end with many small areas between data end and the large area.
Observed with test case of fdo#46160
CppunitTest_basic_enable.mk & test_basic_enable.dll seems to suffer for some strange multiple defined symbol crack which is killing the tinderboxes, disable for the moment
Change-Id: I1584c11a0445ac36c138ae075ca365ad4b2effe1
Do not call gfxFont->getName() twice; Thanks David Tardon for catching this.
Heh, I wonder if gfxFont->getOrigName() ever given any different value
than getName() ;-)
Change-Id: Idaf95a6a024076c6d450519923b6129166a5f8bd
retain this as an int so that on platforms where char is unsigned
we don't mangle the value and get this all wrong.
Fixes database opening tables on ppc if -fsigned-char is removed
Change-Id: I66f0c6b1b19191595f8b348377579f2daabf7ada
This reverts commit 875c9a28f4.
because it doesn't make sense to build the dmake modules
without -fsigned-char and the gbuild modules with -fsigned-char
and we're still got a few bugs where we assume chars are signed
Conflicts:
solenv/inc/unxlngppc.mk
Change-Id: I6ac07fa3ebadd83efd0da1ee69a010b62dfaad59
It still fails to load the file (General input/output error), because
RTFDocumentImpl::resolve() throws io::UnexpectedEOFException, but that
is a bit better than a crash .-)
Example of such a file can be found in fdo#49666 or rhbz#819304 .
Change-Id: I I1e575bf8e3194afe063297a4daf3e98eaaa510cc
