mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
342,262 Commits 1 Branch 0 Tags
1b33a38e32e89c63f4a2270db341cd13e91f5c64
Commit Graph

2966 Commits

Author SHA1 Message Date
Stephan Bergmann
1b33a38e32 Whatever those "true" arguments to SotStorage ctor may once have meant 
...is lost to history, but they are effectively equivalent to pssing default
SorageMode nStorageMode = 0 today, as the only thing that is done with that
nStorageMode value (in SotStorage::CreateStorage, sot/source/sdstor/storage.cxx)
is to compare it against STORAGE_TRANSACTED (0x04) STORAGE_CREATE_UNPACKED
(0x44).

Change-Id: I6ce79c03aff941b5abb5370e52a30b2294690b3a
 2014-01-17 18:45:13 +01:00
Andras Timar
99159a618f fdo#73698 check for empty aOut 
Change-Id: I0da26ef746553618bd8aee69f21ff0d1261efbf6
Reviewed-on: https://gerrit.libreoffice.org/7474
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-01-17 06:09:55 +00:00
Andras Timar
da67f5b162 Environment variables can contain >127 characters 
Change-Id: Iaeb690429d835ab2e6c13a8890a1b27b9405796a
 2014-01-16 17:00:32 +01:00
Noel Grandin
c648d08720 convert SvStream::operator<< overloads to more explicit methods 
This is in preparation for more conversion of SvStream::operator<< calls
to use more explicit method names.
This converts the subclasses that have their own convenience overloads
of operator<< to use normal methods.

Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
 2014-01-16 16:08:34 +01:00
Stephan Bergmann
0d29aab156 bool improvements 
Change-Id: Ic9ea40c430e0b0ab0d46bac3ba150ddac96c6acc
 2014-01-14 18:11:10 +01:00
Noel Grandin
b69864f3f8 re-write SvStream operator<< to non-overloaded methods 
This is the actual re-write.

Use a clang rewriter to rewrite SvStream::operator<< to methods
like WriteuInt32.
Note that the rewriter is not perfect, and I hand-tweaked the output.
In particular, I had to adjust places doing things like
  (*this) << 1;

Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a
Reviewed-on: https://gerrit.libreoffice.org/7342
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2014-01-10 13:26:24 +00:00
Herbert Dürr
9e77ddcd19 Resolves: #i123817# prepare codebase for updating to boost 1.55 
(cherry picked from commit c31988351c10e9f3fd783730d95da34efd52c153)

Conflicts:
	basic/source/comp/parser.cxx
	basic/source/comp/token.cxx
	dbaccess/source/ui/dlg/generalpage.cxx
	sc/source/ui/unoobj/chart2uno.cxx
	vcl/quartz/salbmp.cxx

Change-Id: Ic9580f2d4a44959cb3e38906eb4153b2c2a54899
 2014-01-06 16:32:20 +00:00
Andras Timar
b55259eeb5 typo fixes 
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
 2013-12-20 15:55:00 +01:00
Stephan Bergmann
83e191e25d Do not use C++-UNO internal static_type functions in client code 
...use cppu::UnoType instead.

Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
 2013-12-12 11:10:10 +01:00
Tor Lillqvist
4b0f171b24 sbxbase.hxx is private to basic 
Change-Id: I108bd247a40ce2b46034cabe8b075fa4f5a396df
 2013-12-11 10:49:57 +02:00
Tor Lillqvist
d76178b52d sbstdobj.hxx is private to basic 
Change-Id: I131dfeded783edfea94208d1cf8d70a2090785fa
 2013-12-11 10:48:12 +02:00
Tor Lillqvist
0a33e24d11 sbobjmod.hxx is private to basic 
Change-Id: I4ad28b049de5f7268ee1ca2e8992e2f29ed05380
 2013-12-11 10:39:57 +02:00
Tor Lillqvist
dde119c8f2 basic/global.hxx is private to basic 
Change-Id: I90a28e34eb45819e240931cd751ac0a546ea6be8
 2013-12-11 10:36:58 +02:00
Takeshi Abe
526a60086c Drop duplicate #include 
Change-Id: I05569ef98293445916e8f48e7f06abd795fe9bb5
 2013-12-08 17:20:40 +09:00
Herbert Dürr
3a437baee2 Resolves: #i74854# fix buttons in MsgBox with info icon 
Patch by: hanya.runo@gmail.com
Found by: ooo@catcons.co.uk
Tested by: hdu@apache.org

(cherry picked from commit 02cc651a1b45cbfbdab0aca6b57bff7bdf9e4f2c)

Conflicts:
	basic/source/runtime/methods.cxx
	vcl/inc/vcl/msgbox.hxx

Change-Id: I1656263e189f1a6cfa58436741bfa74ae0e6fffa
 2013-12-02 16:45:50 +00:00
Noel Grandin
610b2b94b3 remove unnecessary use of OUString constructor when assigning 
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
 2013-11-19 10:29:31 +02:00
Stephan Bergmann
ab5d1fbfb4 SAL_WARN_UNUSED com::sun:⭐:uno::Any 
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
 2013-11-14 21:02:40 +01:00
Noel Grandin
d366c9b20e remove unnecessary sal_Unicode casts in various places 
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
 2013-11-14 08:17:32 +02:00
Norbert Thiebaud
8b308d510e basic: include <> for external includes 
Change-Id: I4715bbe853d60ef15f20a4d2441c688003ca568e
 2013-11-11 22:37:24 -06:00
Stephan Bergmann
a2505ae731 SAL_WARN_UNUSED INetURLObject 
Change-Id: Ia9af3b76c2a2ac654b02c1502aa2d0c2c987fbf2
 2013-11-11 16:50:05 +01:00
Noel Grandin
fcd1637d51 convert OUString compareToAscii == 0 to equalsAscii 
Convert code like
   aStr.compareToAscii("XXX") == 0
to
  aStr.equalsAscii("XXX")
which is both easier to read and faster.

Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
 2013-11-11 12:58:13 +02:00
Noel Grandin
e9c4ee996d remove unnecessary use of OUString constructor in BASIC module 
Change-Id: Iee86ce9200285647d5031cb2f89266a52704dd44
 2013-11-11 11:21:25 +02:00
Caolán McNamara
609f0b8bff add limits.h for rhel-6 build 
Change-Id: I9d355be54eb4072044ad660296375fca8d0fa831
 2013-11-01 08:54:20 +00:00
Noel Grandin
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith 
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
 2013-10-31 08:34:21 +02:00
Thomas Arnhold
4adf622925 fixincludeguards.sh: basic 
Change-Id: Id797a8969e42876092da347d8e1bba6195b697dc
 2013-10-28 15:16:20 +01:00
Thomas Arnhold
54a17dd246 windows: warning 4355 is disabled globally in com_MSC_defs.mk 
So there is no need to do this locally, too.

Change-Id: I0fa1d0cd3e077ba0985848a9d2cbb061b123e8ad
 2013-10-28 01:02:13 +01:00
Noel Grandin
8396cce9b5 clean up places accessing the NULL at the of an OUString 
There were only a couple of real bugs fixed, but we're a little
bit safer now.
This also fixes the assert and the comment in OUString::operator[]
about this.

Change-Id: Ibe16b5794e0ba7ecd345fa0801586d25b015974c
 2013-10-23 13:12:55 +02:00
Tor Lillqvist
a7724966ab Bin comments that claim to say why some header is included 
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
 2013-10-22 16:56:28 +03:00
Caolán McNamara
b37e2dd071 Resolves: fdo#38838 remove UniString 
hammer silver nails into coffin and bury in concrete

Change-Id: I3fda2ff47738bb33793adab97faba2d439ac9a28
 2013-10-22 12:50:48 +01:00
Thomas Arnhold
8fc6905674 fdo#68849 add some header guards 
Change-Id: I9d25a58f22095689eccc0ac444c163d1e9bee69f
Reviewed-on: https://gerrit.libreoffice.org/6364
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-10-21 09:15:59 +00:00
Stephan Bergmann
2d1675c3ad The getSupportedServiceNames implementations will already take care 
Change-Id: I0c7ae8e0393f069259b943e04368e874abdf8386
 2013-10-17 15:03:50 +02:00
Marcos Paulo de Souza
3d3293144b fdo#54938: Adapt svtools and comphelper module ... 
to  use cppu::supportsService and other pieces.

Change-Id: I16893b3d31a8055acd214ff23d01e63d38fe0826
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2013-10-17 14:43:28 +02:00
Eike Rathke
66a96c8274 clean up SbiScanner::NextSym() a little, fdo#70319 follow-up 
Number recognition was suboptimal and didn't properly resync scan
positions after having detected an error.

Change-Id: I278fdaaf17ed40560785deaaad0e3412a249d90a
 2013-10-15 12:52:15 +02:00
Stephan Bergmann
458c5a0f47 Defer OUString -> OString conversion 
...to avoid converting back OString -> OUString in SbiIoSystem::WriteCon.

Change-Id: I17024891d0babaa589f2c65f1123f1905c4338bb
 2013-10-15 10:33:26 +02:00
Tor Lillqvist
ff7ba8c81c Nothing Unix-specific about <stdlib.h> 
Although unsure whether this source file actually uses anything declared in
<stdlib.h>...

Change-Id: Ibb5dfe5d0de1576a37a5f2c9cffcd9b850602b14
 2013-10-12 10:08:17 +03:00
Tor Lillqvist
b680e35254 Test WNT instead of the vague UNX 
Change-Id: Icacdae592f05bcdcf50223d607976d687e182c96
 2013-10-12 09:55:48 +03:00
Tor Lillqvist
9097611359 We already have SAL_CALL that means __cdecl on Windows 
Not that there should be any need to use it here; it is the default anyway.

Also the extern "C" is bogus here as far as I know; that affects only the
external name of the function, and that a function is passed to bsearch()
doesn't set any requirements on the external name of it. It could be a static
function with no global symbol name. But oh well.

Change-Id: Ia264bf2f952fd6f38aa36a25a084383d4d3f1bdc
 2013-10-12 09:45:27 +03:00
Tor Lillqvist
7329fbd9c4 Bin two unused functions 
Change-Id: I8362bfa0152f84a425ea3d461653d45c07816b92
 2013-10-12 09:42:24 +03:00
Caolán McNamara
d22fb8a608 CID#1103740 uninitialized value 
Change-Id: I2d10104277d8ad0781e3dd088d51d62fa759fe57
 2013-10-11 09:12:38 +01:00
Thomas Arnhold
39022b8b7d little String to OUString + documentation 
Change-Id: I982e44150fd2909da0571409f16051d79377d7a3
Reviewed-on: https://gerrit.libreoffice.org/6192
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-10-10 17:58:31 +00:00
Stephan Bergmann
f58ee783ee Improve ErrorCodeIOException messages 
...and clean up some includes.

Change-Id: Ia5843cd38f967722d7173a6c87fba26064e3ffd6
 2013-10-09 21:02:11 +02:00
Caolán McNamara
9cff818949 CID#708773 unused pointer value 
Change-Id: Ib394a444882f5ffa1e0c5e833d59f4e4985479df
 2013-10-07 11:46:59 +01:00
Caolán McNamara
470af978eb CID#707648 uninitialized member 
Change-Id: Ib8371710dd6c856b143782ca9c18f4ee76798f0e
 2013-10-07 11:46:58 +01:00
Caolán McNamara
3c2983ded9 CID#707646 uninitialized member variables 
also CID#707647

Change-Id: I9962bd2417119944a243d8a92711866548248e36
 2013-10-07 11:46:58 +01:00
Caolán McNamara
ef53bd8ab2 CID#707643 uninitialized members 
Change-Id: I23386c780bf484652a518d907d7dc0cc3c910040
 2013-10-07 11:46:58 +01:00
Caolán McNamara
1ce668649b CID#738564 uninitialized member 
Change-Id: I35a4d3d412b1848fe3ef8aed600471fc1c8a61d2
 2013-10-07 09:16:26 +01:00
Caolán McNamara
dbd73b7097 CID#707638 uninitialized members 
Change-Id: Ic0757e544e42f7ca07cddec379d2d647822d9923
 2013-10-07 09:16:26 +01:00
Caolán McNamara
12b3dc2390 CID#707636 uninitialized members 
Change-Id: I7eba8ac0f676a2a16dc12ed423356539aec7148b
 2013-10-07 09:16:24 +01:00
Caolán McNamara
5d61c4f8be CID#738563 uninitialized member 
Change-Id: I5413099beb3b30f92b58f973fa4bb03f29e7f5c3
 2013-10-07 09:16:24 +01:00
Takeshi Abe
d57010faf1 sal_Bool to bool 
Change-Id: Ie8e35c4342db6e2dc35fca33cee7b4d71cfcb732
 2013-10-07 17:08:18 +09:00