mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
383,463 Commits 1 Branch 0 Tags
1d2a407d90c140e2edab6390c7d46814993b988f
Commit Graph

39 Commits

Author SHA1 Message Date
Stephan Bergmann
141b01ac65 Some more loplugin:cstylecast: connectivity 
Change-Id: Iee1d11aef454284dbe050780c4308917c1a2b36f
 2015-01-20 09:06:46 +01:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Noel Grandin
705c48d32e fdo#38835 strip out OUString globals 
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.

Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
 2014-11-05 08:44:19 +02:00
Noel Grandin
0371a63365 remove unnecessary 'using namespace rtl' declarations 
It turns out that almost none of them were necessary.

Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-29 11:28:54 +00:00
Michael Stahl
a2e4d4329b connectivity: firebird: use Reference for Connection where appropriate 
ODatabaseMetaData and OResultSetMetaData apparently have life-times
independent of their creating object, so they need to own the
Connection too.

Change-Id: Idee28a96e318ca4b3d804084d609737a7fc75862
 2014-10-21 15:08:57 +02:00
Noel Grandin
7d7b289da4 loplugin: cstylecast 
Change-Id: I114924d5e0407883b2e77016da3c2e3e55657b21
 2014-10-03 15:20:03 +02:00
Noel Grandin
199d333f13 connectivity: sal_Bool->bool 
Change-Id: I96371121ce6697f153f4e973e65831ea2265eb56
 2014-04-16 11:51:51 +02:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Lionel Elie Mamane
d1fdaafd7c fdo#6412 firebird-sdbc DatabaseMetaData unimplemented getXXX: provide empty RS 
As opposed to NULL object. Else, callers that do a UNO_QUERY_THROW get unexpected results.

Change-Id: Ie9dd157eed03031ba04ed59c363a45e246bbb001
 2013-10-25 10:09:21 +02:00
Stephan Bergmann
3ade152323 -Werror,-Wunused-const-variable 
Change-Id: I07351213c3a8c215a3c02f263f872cee8f7c7cfd
 2013-10-02 16:49:30 +02:00
Andrzej J.R. Hunt
c461cc8473 Remove redundant comment. (firebird-sdbc) 
Change-Id: I17105f474dea07a1a980252309a3ccd88a558db9
 2013-09-11 18:40:44 +01:00
Andrzej J.R. Hunt
2a9c0cb864 Remove unnecessary sal_Bool(bool) casting. (firebird-sdbc) 
Change-Id: I3d9cf598404d137e0f13667ea8f0dc7be6253f7a
 2013-09-11 18:40:44 +01:00
Andrzej J.R. Hunt
00d3a96936 Don't format integers as currency by default. (firebird-sdbc) 
Change-Id: I228bb9f5d1121c1e328daa3d677cc54254255beb
 2013-09-11 18:40:43 +01:00
Andrzej J.R. Hunt
5b74c6563c Cleanup Connection and rename from OConnection. (firebird-sdbc) 
Change-Id: I06cfdc29d7613638d3cea080e7b39c67c74d4de0
 2013-09-09 19:52:27 +01:00
Andrzej J.R. Hunt
79eae295dd Comment out unused parameters instead of (void) cast. (firebird-sdbc) 
Firebird doesn't support catalogs or schemas hence these parameters
are unused in the various get[...] methods. Previously these were (void)
casted however commenting out the parameters seems more correct and reduces
the amount of code.

(This was omitted for as-of-yet unimplemented methods since they will still
 be looked at in detail.)

Change-Id: Ic6566ff0b3e873b802deec79d5497efdd21e577d
 2013-09-06 21:27:57 +01:00
Andrzej J.R. Hunt
748bf45544 Actually use table name in getIndexInfo. (firebird-sdbc) 
Otherwise dbaccess's indexcollection gets confused and can segfault
when indexes not belonging to the desired table are returned.

Change-Id: I4dfe62bf1053c65cac907bf490749ee2cc24e6ca
 2013-09-06 13:46:50 +01:00
Andrzej J.R. Hunt
17a2a19ca2 Implement getIndexInfo. (firebird-sdbc) 
Change-Id: I8c3393fbc7c4fb418f31a80b23360c6c7bf21a25
 2013-09-06 13:46:49 +01:00
Andrzej J.R. Hunt
76e6c6f3ea Add some comments on foreign key retrieval (firebird-sdbc) 
These two methods don't seem to be used at all within the LO codebase.
They are also extremely complicated to implement hence will be left for
later implementation -- my part implementation will be put on the wiki
firebird page.

Change-Id: I72922a4f3c4705fdcc3bbca140d6df64a1e16253
 2013-09-03 19:41:34 +01:00
Andrzej J.R. Hunt
fc7e7b6831 Improve TIMESTAMP display. (firebird-sdbc) 
Change-Id: Ief7ec180e3787a3354e2034693052ebf05a30e81
 2013-08-30 11:33:12 +01:00
Andrzej J.R. Hunt
9310cf2b9f Firebird uses "DOUBLE PRECISION" for doubles. (firebird-sdbc) 
Change-Id: I99bac2cfde956d2b91dce33fc12ce9044a9c219a
 2013-08-28 17:56:20 +01:00
Andrzej J.R. Hunt
e43f05f5b1 Simplify some sql statements with multiple conditions. (firebird-sdbc) 
By prepending a "WHERE (0=1)" we can avoid having to detect when
we specifically need to add "OR"s, and vice-versa for "AND", simplifying
the code.

Change-Id: Idde5c0691788051f87eb1e868bf6b74a8ae72da3
 2013-08-21 11:29:44 +01:00
Andrzej J.R. Hunt
a22f4351cc Sanitize primary key names too. (firebird-sdbc) 
Change-Id: I28b195280a02883c3bf597f4ded470ced0b74f14
 2013-08-21 11:29:44 +01:00
Andrzej J.R. Hunt
e0157dfec5 Simplify/improve sanitizeIdentifier usage. (firebird-sdbc) 
Change-Id: Ic0f66cc68b49a2e9d9f9b8b139a479a7179cc08b
 2013-08-21 11:29:43 +01:00
Andrzej J.R. Hunt
1c3f2bff49 Retrieve nullable from correct table. (firebird-sdbc) 
Change-Id: Iaa84c26bb87ea834297e67af7a3e0ac20efba574
 2013-08-21 11:29:43 +01:00
Andrzej J.R. Hunt
4365e13a0c Enable Core SQL Grammar. (firebird-sdbc) 
This is needed e.g. to enable primary keys.

Change-Id: I400637550b96d6e0aa880edea9678024f300f616
 2013-08-16 21:13:12 +01:00
Andrzej J.R. Hunt
2594878f70 Correct negation to detect view. (firebird-sdbc) 
Change-Id: I24e1bab96e9890bbe32a7e2f3edf8ed1ec15ef92
 2013-08-14 17:24:57 +01:00
Andrzej J.R. Hunt
c73286f83c Use table type in getTables. (firebird-sdbc) 
Change-Id: I78dc0afed58ad7dc51c64cac8c89abcda601f8b5
 2013-08-14 17:24:56 +01:00
Andrzej J.R. Hunt
baaa43446f Reduce getColumnPrivileges verbosity. (firebird-sdbc) 
Change-Id: I06f7d7e12c5b5dce1f902261e45afa39ed7a8665
 2013-08-11 16:05:12 +01:00
Andrzej J.R. Hunt
e6ae90b072 Reduce verbosity of getTables. (firebird-sdbc) 
Change-Id: Ief8d962d39b27acfb19adaee5e470417ee98b371
 2013-08-11 16:05:11 +01:00
Andrzej J.R. Hunt
54a138db91 Commit after DDL statement. (firebird-sdbc) 
Changes made in a DDL statement are only usable after a
commit in firebird, e.g. a created table won't appear etc.

Change-Id: I3b537f495b6bc96fa48ebc1a3e46205da60bb2d4
 2013-08-07 18:23:37 +01:00
Andrzej J.R. Hunt
c3aaa4e401 Simpligy getTablePrivileges. (firebird-sdbc) 
Change-Id: I3a858fc3c94bbf6c32cc7fdae60d0ee45acb3cf2
 2013-08-06 22:17:23 +02:00
Andrzej J.R. Hunt
935eab83a9 Make getPrimaryKeys actually work. (firebird-sdbc) 
Change-Id: Ia300e85675a24a2900cfeb8ee75bf58356b14b30
 2013-08-02 15:39:52 +02:00
Andrzej J.R. Hunt
6f92b92458 Tidy up Transaction info in DatabaseMetaData. (firebird-sdbc) 
Change-Id: I77af538722e7e512db9bcd48d90f5c98ead379a2
 2013-08-02 15:39:52 +02:00
Andrzej J.R. Hunt
5292d90f24 Implement supportsResultSetConcurrency. (firebird-sdbc) 
Change-Id: Id830f703c40c3b16db5f6237325762619cbe54eb
 2013-08-02 15:39:51 +02:00
Andrzej J.R. Hunt
d74ca3bc99 Some more DatabaseMetaData. (firebird-sdbc) 
Change-Id: Ic8f1a2c1d67d163e6bd326d9b759b9f9cda67b35
 2013-08-02 15:39:51 +02:00
Andrzej J.R. Hunt
fe010c7c19 Use correct MetaDataResultSetType (firebird-sdbc). 
Change-Id: I9f501dc9e578c9d7bd997072345578bdc860f6a6
 2013-07-31 19:04:24 +02:00
Andrzej J.R. Hunt
43095140eb Cut identifier to correct length (firebird-sdbc). 
Currently firebird returns table and column identifiers as being
93 chars long (rather than 31 as per spec), this leads to problems
with ALTER and DROP commands which are unable to deal with the incorrect
length. For now we simply discard the extra characters (which are
blank characters).

(SELECT and similar commands have been able to deal with the overlength
identifiers previously, which is why this hack wasn't required
beforehand.)

Change-Id: Ib6c984b5fc72dc4e326b3f8d36f6cbc4a3c9086a
 2013-07-31 19:04:23 +02:00
Andrzej J.R. Hunt
da25756ba9 Remove unnecessary F- prefix for firebird-sdbc files. 
Change-Id: I6574ef7fd1c26770a74b2d1f2b0d997fcca97779
 2013-07-31 16:06:58 +02:00