mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
383,463 Commits 1 Branch 0 Tags
1d2a407d90c140e2edab6390c7d46814993b988f
Commit Graph

46 Commits

Author SHA1 Message Date
Stephan Bergmann
c0bd59c15b loplugin:nullptr (automatic rewrite) 
Change-Id: Iefeeb51c2b101c097a8d77a4625f84baf1f2da44
 2015-11-10 10:31:20 +01:00
Noel Grandin
8601307838 loplugin: defaultparams 
Change-Id: Id0a933d3507bc0f8145afa04effadf8475c8e210
 2015-08-14 10:52:46 +02:00
Stephan Bergmann
1b42acc95e Clean up C-style casts from pointers to void 
Change-Id: I6c7c31befd61cbf0800a62c08e7395ddf78e4b30
 2015-03-28 19:09:18 +01:00
Stephan Bergmann
141b01ac65 Some more loplugin:cstylecast: connectivity 
Change-Id: Iee1d11aef454284dbe050780c4308917c1a2b36f
 2015-01-20 09:06:46 +01:00
Michael Stahl
137131b1e0 connectivity: firebird: fix Connection leak in OStatementCommonBase 
bin/refcount_leak.py was very helpful here.

Change-Id: I61dc57408cf1533f733c08b701884851ec6afb8d
 2014-10-21 15:08:51 +02:00
Noel Grandin
fc04f76336 fdo#82577: Handle Time 
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-01 07:34:23 +00:00
Caolán McNamara
968f633b24 coverity#706382 Uncaught exception 
and

coverity#706377
coverity#706378
coverity#706382

Change-Id: I17f672e31867b1be77c16a8a6e121a8f67df7c90
 2014-07-01 16:43:05 +01:00
Norbert Thiebaud
f7453024e1 fdo#80574 firebird memory management issues 
Change-Id: I37438cd3f9c8e197e5a3aa3d9cbcc5bf3681d792
 2014-06-27 23:37:51 +02:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Lionel Elie Mamane
b065cddb0a TODO comment 
Change-Id: I3df4810534d64bb7f546cc18124edb6ebf3a147d
 2014-01-30 06:13:45 +01:00
Lionel Elie Mamane
5e951de925 fdo#74160 firebird XParameters::setString truncate to 65535 characters 
as opposed to 17 characters

Change-Id: I65c82243946c22eee0f033977b1cd0c5a84d226b
 2014-01-30 06:13:44 +01:00
Tor Lillqvist
51145fa544 WaE: C4701: potentially uninitialized local variable 'aErr' used 
Change-Id: I420a103fc62091319ec2d466c037d7c6631dde5d
 2014-01-03 12:32:52 +02:00
Andrzej Hunt
cb4b290bcf fdo#70664 Implement Blob writing (firebird-sdbc). 
Change-Id: Ia95c6e1a0ede2103aae25610baeb3c7a9642113a
 2014-01-01 19:10:17 +00:00
Andrzej J.R. Hunt
acef4b2687 fdo#70144 Mark database document as modified when data inserted in firebird. 
This only applies to embedded databases where any changes to the database
only affect the temporary extracted db which still has to be stored into
the .odb.

This only fixes the status for modification/insertion/deletion of data
in existing tables. Insertion of new tables still does not result
in the modified state being set.

Change-Id: I553f67127672f2cf49b98ddcdf7d25f22bef5074
Reviewed-on: https://gerrit.libreoffice.org/6621
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
 2013-11-14 11:50:29 +00:00
Andrzej J.R. Hunt
65719df3e3 Cleanup exceptions in PreparedStatement. 
Change-Id: Ice11ec8131a00335db48a05661bbe0285bb53fea
 2013-09-19 20:37:55 +01:00
Andrzej J.R. Hunt
52841daec9 Throw sane exception when wrong type used in PreparedStatement. 
Change-Id: Ie9577ed021930c56f3270aa30306d89365c1b3b1
 2013-09-19 20:37:54 +01:00
Andrzej J.R. Hunt
a11b6d5356 Don't throw unnecessary exception. 
Even an empty ResultSet can be valid, and no other drivers do this.

Change-Id: Ie3aee718f0187d039dbd0c53fc32a71be4a1d9e9
 2013-09-19 20:37:54 +01:00
Andrzej J.R. Hunt
9ae206996d Ensure we have prepared the statement before modify null. 
Currently if the first set* method to be called is setNull, then
we segfault since we try to access m_pInSqlda which doesn't exist
yet.

Change-Id: I4ad9c0a7d68da11b2260a596dd95c4c2cb5bcd4c
 2013-09-11 18:40:43 +01:00
Andrzej J.R. Hunt
87bd0c8c8f Reintroduce Statement specific mutexes. (firebird-sdbc) 
This replaces the erronous Connection wide mutex. Libfbembed
is multithreaded hence we don't need a connection wide mutex.

Change-Id: Ifae79cdefecfe6597a535e36bda318563092bf6c
 2013-09-10 19:52:00 +01:00
Andrzej J.R. Hunt
5b74c6563c Cleanup Connection and rename from OConnection. (firebird-sdbc) 
Change-Id: I06cfdc29d7613638d3cea080e7b39c67c74d4de0
 2013-09-09 19:52:27 +01:00
Andrzej J.R. Hunt
0dbe580f0f Some stylistic cleanup in PreparedStatement. 
Change-Id: Idaddaeff58fa9433c678e7913435ad81bd615934
 2013-09-06 21:27:58 +01:00
Andrzej J.R. Hunt
f9a7f0340e CID#1079051 Uncaught exception. (firebird-sdbc) 
In this case we can just pass the DisposedException (is a RuntimeException)
onto the calling methods.

Change-Id: I89d2421c03a5f8e81f209b94109ffde117cfb0cd
 2013-09-06 08:41:00 +01:00
Andrzej J.R. Hunt
ce1006f529 CID#1079048 CID#1079049 CID#1079050 Uncaught exception. (firebird-sdbc) 
In this case we can just pass the DisposedException (is a RuntimeException)
onto the calling methods.

Change-Id: Ia85a2d147ed3822847fe64b8cac671c88c6444fe
 2013-09-06 08:41:00 +01:00
Andrzej J.R. Hunt
84fe40e369 Implement set[Date|Time]. (firebird-sdbc) 
Change-Id: Ia519b2ec9c6be94f6f21bbd2951a295da8079479
 2013-08-30 11:33:11 +01:00
Andrzej J.R. Hunt
d5cb782f9e Implement setTimestamp. (firebird-sdbc) 
Change-Id: I0c009a99061de787cd250912406a74a75fbc260a
 2013-08-29 10:07:41 +01:00
Andrzej J.R. Hunt
e218242ebd Pass by reference instead of value, fix template parameters. (firebird-sdbc) 
We will also want to pass structs etc. into setValue hence we should pass
by reference.

Change-Id: Ia8aa02ca14414003c33cd8d070510759091b5ec9
 2013-08-29 10:07:41 +01:00
Andrzej J.R. Hunt
0501026fb8 Implement set[Float|Double]. (firebird-sdbc) 
Change-Id: I70d5ab9bacdeabe6c4edf6f70a9ba283b46c180f
 2013-08-28 17:56:21 +01:00
Andrzej J.R. Hunt
fe8e3be835 Remove unused code (firebird-sdbc) 
Change-Id: I88f47ee442ade499c7f4018ce8b1ffe54b362067
 2013-08-28 17:56:19 +01:00
Andrzej J.R. Hunt
c338f1cf70 Use template to set integer parameters. (firebird-sdbc) 
Change-Id: I8a6c9f335574196a50827db7eb44b82f9ea4df16
 2013-08-28 17:56:19 +01:00
Andrzej J.R. Hunt
7bc88db8c5 Implemet setNull. (firebird-sdbc) 
Change-Id: I9fd53a5e8b5d1dba467fa8064f9f2ea1b93f26df
 2013-08-27 20:58:32 +01:00
Andrzej J.R. Hunt
186f264dc2 Implement set[Int|Long]. (firebird-sdbc) 
Change-Id: I234b8f136b90f56c689553d0df8ec2d473a92225
 2013-08-27 20:58:31 +01:00
Andrzej J.R. Hunt
8620524f19 Implement setShort. (firebird-sdbc) 
Change-Id: Ia543f34344915c4621ba0c6ce6984dce7ca9e08b
 2013-08-27 20:58:31 +01:00
Andrzej J.R. Hunt
73aaa4da67 Implement retrieving change count for executeUpdate. (firebird-sdbc) 
Change-Id: Ied47f421dc801bb6790bed49b28d3231844e6ee5
 2013-08-27 20:58:31 +01:00
Andrzej J.R. Hunt
3b22854129 Quick hack to make driver usable with dbaccess/KeySet. (firebird-sdbc) 
Change-Id: I6500a7666ad2fc2ffcb29934d6f2b36761867950
 2013-08-26 18:52:15 +01:00
Andrzej J.R. Hunt
35ab624acd Set Null indicator in input SQLDA as appropriate. (firebird-sdbc) 
If this is incorrectly (or randomly set) then firebird will end up just
ignoring any input parameters (previously the case). The documentation
claims that -1 is the null indicator, however the inevitably-random
values previously provided (from malloc) also caused firebird to treat
all input data as null.

Change-Id: I79b9704df0a307ec493e74e782551b9b0ff109a2
 2013-08-23 17:52:01 +01:00
Andrzej J.R. Hunt
1f50aee94d Improve comment. (firebird-sdbc) 
Change-Id: Iec5c5a434a371d73bba0345362f991a948d28c6a
 2013-08-23 17:52:01 +01:00
Andrzej J.R. Hunt
19cb39f0ff Close cursors in PreparedStatement. (firebird-sdbc) 
Trying to reuse a statement that still has an open cursor leads to
errors -- in this usage isc_free_statement doesn't actually free
the statement but simply closes the db-internal cursor used by
that statement previously.

Change-Id: Iedbe42bc46e6b6f972b7b19f17a60d5f59bae28c
 2013-08-23 10:32:20 +01:00
Andrzej J.R. Hunt
ddc3818322 Use correct sqlda for number of parameters. (firebird-sdbc) 
Change-Id: Ief966fb9bd9f3344cfe9f3b4c4b37540e00ad063
 2013-08-23 10:32:20 +01:00
Andrzej J.R. Hunt
aca3d35a3b Free SQLVAR as appropriate. (firebird-sdbc) 
Change-Id: I5742e178baa85f3faf80d95f57fed248f7984793
 2013-08-15 20:31:14 +01:00
Andrzej J.R. Hunt
75b2c92cfb Improve exceptions in Statement. 
Change-Id: Ib1915c143abee8c9162477da07462a68dd45e03c
 2013-08-11 16:05:09 +01:00
Andrzej J.R. Hunt
6e11164d57 Explicit close/disposing. 
Change-Id: Idcd89bd5f879a38f4c06f3602313672fb20bd098
 2013-08-11 16:05:08 +01:00
Andrzej J.R. Hunt
6044f52c5e Improve statement handle handling. 
Change-Id: I81809634600c580bb50843e697071d62bc6802a4
 2013-08-11 16:05:08 +01:00
Andrzej J.R. Hunt
ebe37593c5 Clean up ResultSet management. (firebird-sdbc) 
Change-Id: I00cd0aa08a5a3da17f06933ebc3422a6b4b8bc74
 2013-08-07 18:23:37 +01:00
Andrzej J.R. Hunt
89fdead645 Correctly handle varchar. (firebird-sdbc) 
Previously SQL_VARYING was cerced to SQL_TEXT which
loses the string length.

Change-Id: I5ab6c0ce2892dcb986282d6bf6fbb770b4fbafeb
 2013-08-06 22:17:23 +02:00
Andrzej J.R. Hunt
da25756ba9 Remove unnecessary F- prefix for firebird-sdbc files. 
Change-Id: I6574ef7fd1c26770a74b2d1f2b0d997fcca97779
 2013-07-31 16:06:58 +02:00