Commit Graph

24 Commits

Author SHA1 Message Date
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Takeshi Abe
1a24285dd5 tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants, for connectivity.

Change-Id: I3645a2855e903848936520ac854fc1039fc456e8
Reviewed-on: https://gerrit.libreoffice.org/16971
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-17 07:17:37 +00:00
Stephan Bergmann
f1b0eec9d3 loplugin:cstylecast: deal with remaining pointer casts
Change-Id: I8c3f4d39629bbfee91402bddfe27b4d104c524c0
2015-06-08 16:23:57 +02:00
Noel Grandin
b44cbb26ef new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-26 08:42:28 +02:00
Michael Stahl
137131b1e0 connectivity: firebird: fix Connection leak in OStatementCommonBase
bin/refcount_leak.py was very helpful here.

Change-Id: I61dc57408cf1533f733c08b701884851ec6afb8d
2014-10-21 15:08:51 +02:00
Lionel Elie Mamane
d2d2136f3f fdo#73352 firebird don't claim to support interfaces one doesn't
and then throw an exception when the interface is used

Change-Id: Id5e2c852323d49f51ab55cf46ab54223cf8ccf03
Reviewed-on: https://gerrit.libreoffice.org/9590
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-05-31 03:57:26 +00:00
Thomas Arnhold
888057cb5c fixincludeguards.sh: connectivity 2014-04-19 11:10:08 +02:00
Noel Grandin
199d333f13 connectivity: sal_Bool->bool
Change-Id: I96371121ce6697f153f4e973e65831ea2265eb56
2014-04-16 11:51:51 +02:00
Stephan Bergmann
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Andrzej J.R. Hunt
101040a130 Set sane default for type.
Change-Id: Ib63e6abd7b378671d1e01bf9357dd811ae88fc40
2013-09-19 20:37:55 +01:00
Andrzej J.R. Hunt
831f01b739 Move type conversion into template.`
Change-Id: I7b646673eacf2abbac8a2bcfa744f840ff344c84
2013-09-19 20:37:55 +01:00
Andrzej J.R. Hunt
fc118515ee Implement implicit type conversion in ResultSet. (firebird-sdbc)
Change-Id: I9faf9752556b7e0769d3a353e393924f5a1edb63
2013-09-19 20:37:54 +01:00
Andrzej J.R. Hunt
936cce1110 Add some type checking to ResultSet.
This is in preparation for complying with the API by allowing
implicit type conversion.

Change-Id: I5e52fdc2f3562f806d7f9fba5d558ece4bd182ac
2013-09-18 20:57:08 +01:00
Andrzej J.R. Hunt
87bd0c8c8f Reintroduce Statement specific mutexes. (firebird-sdbc)
This replaces the erronous Connection wide mutex. Libfbembed
is multithreaded hence we don't need a connection wide mutex.

Change-Id: Ifae79cdefecfe6597a535e36bda318563092bf6c
2013-09-10 19:52:00 +01:00
Andrzej J.R. Hunt
5b74c6563c Cleanup Connection and rename from OConnection. (firebird-sdbc)
Change-Id: I06cfdc29d7613638d3cea080e7b39c67c74d4de0
2013-09-09 19:52:27 +01:00
Andrzej J.R. Hunt
08081fffa0 CID#1079047 Uncaught exception. (firebird-sdbc)
In this case we can just pass the DisposedException (is a RuntimeException)
onto the calling methods.

Change-Id: I379974fd7998151d503020742ae7ae18cbdfaf7c
2013-09-06 08:41:00 +01:00
Andrzej J.R. Hunt
98862b0fde CID#1079045 CID#107946 Uncaught exception. (firebird-sdbc)
In this case we can just pass the DisposedException (is a RuntimeException)
onto the get* methods.

Change-Id: I97a3575709e2f50fa651a5d26c3029ed014630da
2013-09-06 08:41:00 +01:00
Michael Stahl
250864d869 connectivity: firebird::OResultSet: convert to C++98
Change-Id: I9036539204789d0886a51fcbc3d821012cc9eaee
2013-08-26 20:26:39 +02:00
Andrzej J.R. Hunt
b3b560e295 Clean up PropertyHelper stuff, set ResultSet properties. (firebird-sdbc)
Change-Id: If2f2041b0f072f36fe56e92b9e54bbb0be8a5860
2013-08-26 18:52:14 +01:00
Andrzej J.R. Hunt
ab59b7176f Remove unsupported XRowLocate/XDeleteRows (firebird-sdbc)
Change-Id: I74bf84c8aae4d4ba6b9a2a9ca497ed0cbc092d35
2013-08-23 10:32:19 +01:00
Andrzej J.R. Hunt
f69b198ded Remove unsupporte XRowUpdate/XResultSetUpdate. (firebird-sdbc)
Change-Id: I3b9f8c7199e66f90e1573069996962294793d95e
2013-08-23 10:32:19 +01:00
Andrzej J.R. Hunt
aca3d35a3b Free SQLVAR as appropriate. (firebird-sdbc)
Change-Id: I5742e178baa85f3faf80d95f57fed248f7984793
2013-08-15 20:31:14 +01:00
Andrzej J.R. Hunt
da25756ba9 Remove unnecessary F- prefix for firebird-sdbc files.
Change-Id: I6574ef7fd1c26770a74b2d1f2b0d997fcca97779
2013-07-31 16:06:58 +02:00