Commit Graph

269 Commits

Author SHA1 Message Date
Stephan Bergmann
c0bd59c15b loplugin:nullptr (automatic rewrite)
Change-Id: Iefeeb51c2b101c097a8d77a4625f84baf1f2da44
2015-11-10 10:31:20 +01:00
Noel Grandin
6c80a8fe89 new loplugin: oncevar
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f
Reviewed-on: https://gerrit.libreoffice.org/19815
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-09 08:34:40 +00:00
Benjamin Ni
be729e7721 tdf#94269: Replace "n" prefix for bool variables with "b"
Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797
Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-11-02 23:40:57 +01:00
Noel Grandin
cb4fa1d1e2 use uno::Reference::set method instead of assignment
Change-Id: I080668f86f0ab8b3bba857ee21411f907ae285c4
2015-10-30 11:08:36 +02:00
Noel Grandin
3bc5df7f32 UNO: no need to use OUString constructor when calling createInstance
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526
Reviewed-on: https://gerrit.libreoffice.org/19682
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-30 08:59:59 +00:00
Noel Grandin
1716b3a338 remove some useless comments
found with git grep '// /'

Change-Id: I948cf9ae61bbbf2ec706ca5b0572c4f27c58c745
2015-10-13 10:07:49 +02:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Stephan Bergmann
bff4c13475 Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12 17:52:26 +02:00
Andrea Gelmini
3f6da86e9f Fix typos
Change-Id: I13c3dc33722f139582f27412d5d336264d3d15a3
Reviewed-on: https://gerrit.libreoffice.org/18942
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30 13:05:20 +00:00
Caolán McNamara
33cddeea13 boost->std
Change-Id: Iff14f69c200217c5d868978e8ffc06962b99ac09
Reviewed-on: https://gerrit.libreoffice.org/18568
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-14 19:32:42 +00:00
Daniel Robertson
87a2c1d5a0 tdf#88462 connectivity convert manual XInterface
Convert postgresql driver ReflectionBase manual XInterface
implementation to use ::cppu::WeakComponentImplHelper.

Change-Id: I738bd7df33de9c0fe0e3242eb5a4fab6a8dcb3f0
Reviewed-on: https://gerrit.libreoffice.org/18207
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-03 08:08:31 +00:00
Stephan Bergmann
7bff36d45d loplugin:stringconstant: OUStringBuffer: appendAscii -> append
Change-Id: I68b02ad101c4c2165b4618ed5d97cbffc2c43d2d
2015-08-31 08:04:12 +02:00
Noel Grandin
8601307838 loplugin: defaultparams
Change-Id: Id0a933d3507bc0f8145afa04effadf8475c8e210
2015-08-14 10:52:46 +02:00
Noel Grandin
403c13487c loplugin:unusedmethods
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba
Reviewed-on: https://gerrit.libreoffice.org/17506
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-05 09:39:22 +00:00
Noel Grandin
3ff2e30ff6 cui,connectivity: inline some use-once typedefs
Change-Id: I1b043031014a3e823cd614966984a2ac2be1ac71
2015-08-04 08:55:56 +02:00
Takeshi Abe
1a24285dd5 tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants, for connectivity.

Change-Id: I3645a2855e903848936520ac854fc1039fc456e8
Reviewed-on: https://gerrit.libreoffice.org/16971
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-17 07:17:37 +00:00
Takeshi Abe
871cd42b95 Fix an opposite condition
... slipped in at 54013188b2.

Change-Id: Ib18b2f12d4ad97b9ec5dd771d5f13b35e0274e33
Reviewed-on: https://gerrit.libreoffice.org/16932
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-10 19:53:50 +00:00
Noel Grandin
54013188b2 cleanup some unnecessary direct usage of the OString/OUString C API.
Change-Id: I6edee95aae1c169ce70063562a0c1b287e0c4735
Reviewed-on: https://gerrit.libreoffice.org/16861
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-10 08:09:00 +00:00
Andrea Gelmini
87dc6c82d5 Fix typos
Change-Id: Ideb5688a8c9e7cf10038f2e9d00991e8653b1875
Reviewed-on: https://gerrit.libreoffice.org/16706
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-03 09:02:48 +00:00
Andrea Gelmini
8a2efbb717 Fix PostgreSQL function name
Change-Id: Ic089540c07c7fe7c85705fc3513411a7e2571a12
Reviewed-on: https://gerrit.libreoffice.org/16640
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-07-02 13:40:06 +00:00
Caolán McNamara
e678100a40 coverity#1308573 Uncaught exception
Change-Id: Ie3ecffe0fe91572ffff6e124075e1be1ef978731
2015-06-29 09:43:33 +01:00
Lionel Elie Mamane
5652313e8a postgresql-sdbc: fixup string2intarray
this allows getGeneratedValues to work

Change-Id: Ia87e87afa8cdb01f1d39c84bc7d7143c101d8891
2015-06-17 14:19:26 +02:00
Lionel Elie Mamane
eb0c95c56e postgresql-sdbc: include error message in SQLException
Change-Id: I9d91503e6beb08f11368fc6b80fefb61f60d4486
2015-06-17 14:19:25 +02:00
Caolán McNamara
8066c73940 cppcheck: noExplicitConstructor
Change-Id: I2b5fba9cdd950349a8e8d22bbd7bb6e17f008920
2015-06-15 11:11:42 +01:00
Julien Nabet
6e62d72b93 Remove include stdio (part1)
Change-Id: I364aedbd8870c2bbd3440f144143c503dd7ff2c1
Reviewed-on: https://gerrit.libreoffice.org/15767
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-05-17 14:57:02 +00:00
Noel Grandin
71b809959b remove unnecessary use of void in function declarations
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
Stephan Bergmann
17e74bf1a0 Replace remaining getCppuType et al with cppu::UnoType
Change-Id: Id2361bd7b50f4724211661b024583b8a3445500b
2015-04-01 08:36:20 +02:00
Stephan Bergmann
1b42acc95e Clean up C-style casts from pointers to void
Change-Id: I6c7c31befd61cbf0800a62c08e7395ddf78e4b30
2015-03-28 19:09:18 +01:00
Stephan Bergmann
d3d34a289b const_cast: convert some C-style casts and remove some redundant ones
Change-Id: If7e4e3cae1021529819e0b43ef334020ff8b7a43
2015-03-26 15:33:29 +01:00
Noel Grandin
c7a50d072f new constantfunction loplugin
Change-Id: Ie9b7a0c41fc4dbd2560ceff6bae9ab85357f518b
2015-03-25 08:55:31 +02:00
Noel Grandin
3e8a7ce7df Revert "loplugin:constantfunction: connectivity"
it seems to be causing unit-test and build failures

This reverts commit 5cbb51c009.

Change-Id: Idc6372f98200b23828aa19b22a75b6b2b640d1ab
2015-03-23 11:02:11 +02:00
Noel Grandin
5cbb51c009 loplugin:constantfunction: connectivity
Change-Id: Ic1a71851a80ed2715969b0f00a0e59ab3a0593db
2015-03-23 09:42:23 +02:00
Caolán McNamara
5a308b1239 V801: Decreased performance
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
2015-03-09 12:41:09 +00:00
Noel Grandin
a3646d5572 cppcheck: duplicate inherited member
Change-Id: Iee20ca4523739eb082ea1fa8c1145891c0caed29
2015-03-02 10:25:49 +02:00
Noel Grandin
4a87597e42 remove unused struct
Change-Id: Icabf74fde82e917826f20ffdc8fcd71a26538bbe
2015-03-02 08:59:19 +02:00
Caolán McNamara
a0c81e5ad4 V804: Decreased performance
Change-Id: I484dd153e5d7f0664eac85595011d610f2b8df7b
2015-03-01 21:14:52 +00:00
Stephan Bergmann
c6be3cf03b loplugin:deletedspecial
Change-Id: I0faa47383f8952a74742a640ab2af602b4fcba8f
2015-02-07 12:35:57 +01:00
Stephan Bergmann
4e3da621fe Some more loplugin:cstylecast clean-up
Change-Id: I132d22e2af3cf673c17d8964f690d48990834884
2015-01-28 13:50:37 +01:00
Noel Grandin
b44cbb26ef new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-26 08:42:28 +02:00
Stephan Bergmann
141b01ac65 Some more loplugin:cstylecast: connectivity
Change-Id: Iee1d11aef454284dbe050780c4308917c1a2b36f
2015-01-20 09:06:46 +01:00
Lionel Elie Mamane
79b5bf5cab PostgreSQL statement: use :cppu::WeakComponentImplHelper
Change-Id: I081d375b0249a3b0e47c1dd6db3f86fef272e7fd
Reviewed-on: https://gerrit.libreoffice.org/13925
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-15 13:01:00 +00:00
Lionel Elie Mamane
d7a6017e2a PostgreSQL statement: deliver promised XMultipleResults interface
Change-Id: I0bb6df332a6666a0ae96bba38626b2626f880490
2015-01-15 12:49:57 +01:00
Lionel Elie Mamane
1000d7499b PostgreSQL boolean more accurately described as boolean
Let's see if this breaks anything...

Change-Id: Id7503f8059ca99ec155d72c275a7657280ee2bc6
2015-01-07 16:03:12 +01:00
Lionel Elie Mamane
b39f07f1a0 protect agains past-the-end string access
Change-Id: I651c7b062b454fad85eff8852f7e62804a0d0058
2015-01-07 16:01:54 +01:00
Miklos Vajna
311a92f23b connectivity: fix gcc-4.8 build
Change-Id: I2df7eb2af12f235cfa05bc75da32e8baf1455b5b
2015-01-04 14:21:13 +01:00
Caolán McNamara
ca8787a981 boost::unordered_map->std::unordered_map
Change-Id: I5d458f43616edc395faa8c27edaddc7d515166db
2015-01-04 12:51:09 +00:00
Stephan Bergmann
bca00da686 connectivity: Use appropriate OUString functions on string constants
Change-Id: I10b2ddf9dcc83219fea8eb55783507eed52702e8
2014-12-12 17:51:11 +01:00
Michael Stahl
15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18 18:51:49 +01:00
Brij Mohan Lal Srivastava
d32be3ace8 fdo#86023 - O[U]String needs a 'clear' method
Added clear() method to OString and OUString class, Updated appropriate call-sites.

Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14 09:20:38 +01:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade…
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:04:11 +00:00