Commit Graph

43 Commits

Author SHA1 Message Date
Stephan Bergmann
217f7f236f loplugin:nullptr (automatic rewrite)
Change-Id: I9fe00eef7ddcd4a3c87e497a8d62f98e71a0d6d8
2015-11-10 10:31:24 +01:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Caolán McNamara
3a00aaef2a boost->std
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-18 07:59:14 +00:00
Caolán McNamara
267f401e2a cppcheck: noExplicitConstructor
Change-Id: I2a1add8cf526cdb305ad99ccb138454a88f2fdbd
2015-09-07 09:56:07 +01:00
Noel Grandin
2660d24a07 new loplugin: refcounting
This was a feature requested by mmeeks, as a result of
tdf#92611.

It validates that things that extend XInterface are not
directly heap/stack-allocated, but have their lifecycle managed
via css::uno::Reference or rtl::Reference.

Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692
Reviewed-on: https://gerrit.libreoffice.org/16924
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03 06:37:16 +00:00
Stephan Bergmann
eb0f855f8c editeng: Use appropriate OUString functions on string constants
Change-Id: Iab879390c18a3ce2c5bfc49548ca273ce0b907da
2014-12-18 14:12:25 +01:00
Tor Lillqvist
f1e7489d98 Adapt to int/sal_Int32 mismatch on 32-bit build
Change-Id: I9c5cb458ea7595c1b623ce14ed58fd3d5b3d961e
2014-12-02 08:21:31 +02:00
Tor Lillqvist
9bdde8b420 Adapt to int/sal_Int32 mismatch on 32-bit build
Change-Id: Ifef81d53bee4241be3c0dd6b7ddb2c1bbf419b5e
2014-12-02 07:54:10 +02:00
Michael Stahl
846b56b6b9 fdo#85496: editeng: do not add multiple 0-length attributes...
... at the same position.

Since commit 0d57434180 these will be
exported by the ODF filter as duplicate attributes.

Change-Id: I8befe55f61c59ab968409fa03359540c300f9198
2014-12-01 23:12:55 +01:00
Tor Lillqvist
36e1a903c4 WaE: overriding virtual function declaration not marked 'override'
Change-Id: I18274d920865f8e28377acce8084eb1629ff8127
2014-07-28 09:43:14 +03:00
Michael Meeks
274b628a2b bnc#467459 - fix editeng text search with expanded fields.
Change-Id: If59d0e2f886e94148b81cb6cfcad067733fcb918
2014-07-27 17:06:06 -04:00
Stephan Bergmann
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
Noel Grandin
fdf284276f editeng: sal_Bool->bool
Change-Id: Ice3b0a4ccf7a6d25311ff65a23efa9082cd501de
2014-02-27 12:30:29 +02:00
Michael Stahl
ebd0d0056d fdo#74363: fix auto correct of initial capitals on start of first para
The GetPrevPara() method apparently has to return 0 when there is no
previous paragraph.

(regression from ac85b6cff1)

Change-Id: I09a3e1d3a3adb33562e4e03c0755447047cbd433
2014-02-08 00:32:20 +01:00
Norbert Thiebaud
3cbfcee36d xub_StrLen and tools/string.hxx final straw
Thre is still some 0xffff limit left and possibly some
less than gracefully handled overflow/error cases

Change-Id: I00957ee3a30b02f73918ea49d7353056263dc638
Reviewed-on: https://gerrit.libreoffice.org/7787
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-02-03 07:44:28 +00:00
Caolán McNamara
2e5ec4f5b6 Related: #i17171# big xub_Strlen -> sal_Int32 changes
Change-Id: I31bce794c95062abfa1171c13cf565498688b5f3
2014-01-15 13:26:08 +00:00
Andras Timar
1ba111343e bugs.freedesktop.org -> bugs.libreoffice.org
Change-Id: I56c1190c93333636981acf2dd271515170a8a904
2013-11-17 08:33:01 +01:00
Eike Rathke
a641bbff59 map autocorrection files with LanguageTag key
... as several tags (i.e. renamed) may map to the same LangID.

Change-Id: I8202b18ea0dc8034522017be59bb104b3d06c0f4
2013-09-21 15:30:00 +02:00
Caolán McNamara
163975fd41 convert SvxAutoCorrect::DoAutoCorrect to OUString
which makes autocorrect in the editengine work again

Change-Id: I97d56448e4abd6e563479ffee706b86cb04199ec
2013-09-18 15:06:21 +01:00
Noel Grandin
ac85b6cff1 convert SvxAutoCorrDoc from String to OUString
Also:
- simplify the return type of the GetPrevPara method, there is no
  need return an OUString by pointer
- simply the ppPara parameter of the ChgAutoCorrWord method,
  passing a pointer to a pointer to a value type is unnecessary.

Change-Id: I4a8c44fdab1cf68af88c34003827d1c20704f839
2013-09-11 09:45:30 +02:00
Kohei Yoshida
6a4dd39379 Rename SectionAttribute to Section.
It fits better this way.

Change-Id: I139de7858e999a6dd26633a548c47634dfad8a65
2013-08-28 14:48:11 -04:00
Kohei Yoshida
923d4435cc Fix incorrect logic in section attribute array construction.
And a new test case to catch it.

Change-Id: Ie51ddf185f70c656e7d838fc7016b5726efbdf3f
2013-08-28 11:17:46 -04:00
Kohei Yoshida
9ca5e3da5c Add a means to retrieve all formatting attributes in non-overlapping sections.
Change-Id: Id04dffc135fad6bb66ea157cd280dd481cb80117
2013-08-20 22:57:13 -04:00
Matteo Casalin
31ab7f0c7d String to OUString
Change-Id: I8d4f62b473ad43807621a9dbb826ed33857b737e
Reviewed-on: https://gerrit.libreoffice.org/5189
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-07-30 14:40:30 +00:00
Stephan Bergmann
41e5c4b0de Work around -Werror=strict-aliasing
Change-Id: I0184488344bd11c50bddd1bb1726e0d1225aff7e
2013-06-11 15:01:43 +02:00
Michael Stahl
e2b9946022 sw: fix AutoCorrect bold/underline regression
The horrible SvxAutoCorrect::AutoCorrect() inserts the character into
the document half-way through, and then _expects_ this inserted
character to show up in its rTxt parameter.  This broke in Writer when
SwTxtNode::m_Text was converted to OUString, because now a
temporary String copy is created.  Work around this disaster area for
now.

(regression from 0295c8a34e)

Change-Id: I1cb11a20cb0c2577036176e605426105631f3311
2013-06-07 00:09:34 +02:00
Michael Meeks
62badf3828 Move to MPLv2 license headers, with ESC decision and author's permission. 2013-04-22 09:37:38 +01:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Caolán McNamara
a526370737 Related: fdo#55693 add regression tests for autocorrection
Change-Id: Ie9bbeb38ec9cc2fa0377709e75abb0338b20bab5
2013-03-01 12:20:24 +00:00
Michael Meeks
328e2263fb targetted re-work of cppunit pieces. 2012-06-27 19:13:11 +01:00
Kohei Yoshida
204555c107 Renamed FILE to DOCINFO_TITLE, which is more appropriate for this field.
Change-Id: I1267629da8b66fc21c4ae2e78634c2093274aa61
2012-05-14 12:09:57 -04:00
Kohei Yoshida
8ed129b22d Unit test for UNO field item implementation.
Make sure the type IDs are associated with correct service names.

Change-Id: I5ff8ec7fb56f2790f9a3eca8e019c784cb27de43
2012-05-11 23:12:28 -04:00
Caolán McNamara
8d7e8a0a3b setup/teardown default component context once before/after all tests
avoids the problems of dangling uno singletons invalidated after the first
dispose and the chain of other singletons that don't expect to need to
re-initialize, etc.

reenable editeng cppunit test

inherit i18npool cppunit test from unotest base

drop LibreOfficeProtector, do "throwable" work in setUp/tearDown not
in ctors/dtors
2012-04-13 13:15:25 +01:00
Caolán McNamara
43aabb908e partially revert the editeng singleton stuff to get build to complete 2012-04-12 13:28:06 +01:00
Kohei Yoshida
5b14929dd4 Handle the correct deletion order of EditDLL in the base class.
Turns out that this change affected all cppunit runs.
2012-04-12 00:53:55 -04:00
Kohei Yoshida
c0de63a858 Remove the TODO comment that's no longer relevant. 2012-04-11 23:42:19 -04:00
Kohei Yoshida
b5800fac1d We need to delete EditDLL before de-initialize vcl to avoid crash.
Without manually releasing the EditDLL singleton instance, it gets
deleted *after* the cppunit does its cleanup, which de-initializes VCL.
The problem is, when the EditDLL instance is destroyed, its member
GlobalEditData instance deletes the OutputDevice instance that it owns,
which in turn accesses font caches in VCL.  But by the time we reach
that point, VCL is already de-initialized, hence the problem.
2012-04-11 23:41:51 -04:00
Kohei Yoshida
a9448bd1b7 Avoid duplicate symbols & use setUp() and tearDown() for the item pool. 2012-04-11 21:53:33 -04:00
Kohei Yoshida
1bcd2c9493 Just use the internal item pool already written for the edit engine. 2012-04-11 21:27:34 -04:00
Kohei Yoshida
e487d2fbf6 You *are* fixed. 2012-04-11 20:47:58 -04:00
Kohei Yoshida
8b216a7aa3 Set default items to the item pool, do this and that, and now the test passes. 2012-04-11 20:46:45 -04:00
Caolán McNamara
6089be1a7a needs ure and base-class setUp does necessary stuff 2012-04-11 21:22:55 +01:00
Kohei Yoshida
d241251638 Attempt to add general-purpose unit test for editeng.
But instantiating EditEngine causes segfault.  The line is commented
out for now.
2012-04-11 14:30:58 -04:00