mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
383,463 Commits 1 Branch 0 Tags
1d2a407d90c140e2edab6390c7d46814993b988f
Commit Graph

493 Commits

Author SHA1 Message Date
Stephan Bergmann
c3dcdeb1d2 loplugin:nullptr (automatic rewrite) 
Change-Id: Idec97093ca48c14b825c7b87ec050cc99aadc526
 2015-11-10 10:31:27 +01:00
Noel Grandin
59b072e22b yyyyy 
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
 2015-11-04 14:10:44 +02:00
Noel Grandin
0e6544903b no need to be so verbose in constructing uno::Reference 
Change-Id: I187a26e200e9ecaff2adaf53a2ba3f6e87346030
Reviewed-on: https://gerrit.libreoffice.org/19724
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-01 15:26:10 +00:00
Noel Grandin
b5db48ada1 no need to use OUString constructor in call to createInstance 
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296
Reviewed-on: https://gerrit.libreoffice.org/19704
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-01 15:25:43 +00:00
Noel Grandin
e26c4b4f09 com::sun::star->css in hwpfilter/ 
Change-Id: I2ec12da777d04855d34233d5781f2304e181bbbd
 2015-10-19 15:33:26 +02:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Stephan Bergmann
f9e5b678ec Reduce variable scope 
Change-Id: I5d2d7e7991c3727ed6367fe22ebddd5c2e2e9265
 2015-10-07 11:32:44 +02:00
Stephan Bergmann
41e2f34548 clang-analyzer-deadcode.DeadStores 
The code had been like this ever since 16cba77220
"#112673# initial checkin of HWP filter."  Assuming that the second line should
rather read

  angle = 1800 - angle * 10;

instead of

  angle = 1800 - prop->angle * 10;

does not look too plausible:  It would keep mapping

   -1  ->  181
    0  ->  180
    1  ->  179
       :
  179  ->    1

but then would discontinuously map

  180  ->  180
  181  ->  179
       :

instead of continuously mapping

  180  ->    0
  181  ->   -1
       :

Change-Id: I8cf97eeb53409b18bda6777b09a20331f3c8132a
 2015-10-07 11:32:43 +02:00
Noel Grandin
58aea3f36c loplugin:unusedmethods 
- improvements to the plugin to find more method calls
- improvements to python script to remove more false+
- fix the FORCE_COMPILE_ALL build flag to include code in
  the $WORKDIR

Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836
Reviewed-on: https://gerrit.libreoffice.org/19064
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-01 10:43:24 +00:00
Andrea Gelmini
a50539e2aa Fix typos 
Change-Id: Iab78219aff60a7a45a319a96f326e27a6e8e25b8
Reviewed-on: https://gerrit.libreoffice.org/18953
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
 2015-09-30 12:41:09 +00:00
Noel Grandin
34180700b2 loplugin:removeunusedmethods, remove unused stuff 
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
 2015-09-29 15:08:43 +02:00
Caolán McNamara
3a00aaef2a boost->std 
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-09-18 07:59:14 +00:00
Caolán McNamara
22b80ac8e2 boost->std 
Change-Id: I3fd9e1599c5ad812879a58cf1dabbcd393105e1c
Reviewed-on: https://gerrit.libreoffice.org/18564
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-09-14 12:54:25 +00:00
Stephan Bergmann
42e379a542 clang-tidy clang-analyzer-deadcode.DeadStores 
...ever since its inception in 16cba77220
"#112673# initial checkin of HWP filter" (but curr is needed as a local scratch
pad in the STARTT macro)

Change-Id: I7233bf99b7d6f9ac0d3d3384ba4508f84ba8fa38
 2015-09-03 11:43:57 +02:00
Michael Weghorn
25accda781 tdf#39440 reduce scope of local variables 
This addresses some cppcheck warnings.

Change-Id: I6ab170c4426494ab9fc53017f88e47fbfdbd9aad
Reviewed-on: https://gerrit.libreoffice.org/17920
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2015-08-22 13:02:08 +00:00
Caolán McNamara
5684fbce64 add hwp to fftester 
Change-Id: Ibf819307905295580cb6a813f6d003a7dabc86b5
 2015-08-21 16:17:26 +01:00
Takeshi Abe
370a26f780 hwpfilter: tdf#88206 replace cppu::WeakImplHelper* 
with the variadic variants.

Change-Id: Ibfe59dc7631cf499f42ff998066ed73d1eb257b3
Reviewed-on: https://gerrit.libreoffice.org/17767
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-08-18 07:11:34 +00:00
Noel Grandin
403c13487c loplugin:unusedmethods 
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba
Reviewed-on: https://gerrit.libreoffice.org/17506
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-08-05 09:39:22 +00:00
Noel Grandin
a45827b230 loplugin:unusedmethods 
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971
Reviewed-on: https://gerrit.libreoffice.org/17378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-30 06:23:00 +00:00
Noel Grandin
e963a88912 formatting of public/private/protected section qualifiers 
make it consistent across the codebase, no space between keyword
and the colon

Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5
Reviewed-on: https://gerrit.libreoffice.org/17148
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-17 09:49:35 +00:00
Jihui Choi
188208d93a tdf#91067: Translate Korean comments 
Change-Id: Idbee9cb5a1745bb2cc3c4cb1238773da7ff2a0a3
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
 2015-07-16 05:35:30 -05:00
Noel Grandin
593206bda7 loplugin:unusedmethods hwpfilter,i18npool 
Change-Id: Ied85d93019d0f6c01c14045758b405f2ac316676
Reviewed-on: https://gerrit.libreoffice.org/16783
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-06 11:54:54 +00:00
Andrea Gelmini
420923ba76 Fix typos 
Change-Id: Ie2bbe020fc6e3a4a4f913208c245f395849bb9ee
Reviewed-on: https://gerrit.libreoffice.org/16708
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-07-03 09:32:26 +00:00
Noel Grandin
4729774b24 remove unnecessary check for null when calling delete 
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'

Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
 2015-06-15 14:46:41 +02:00
Stephan Bergmann
3c7a66a031 loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I8a8ba86dd78e30146f7b9dd7071f5641d496a67a
 2015-06-08 16:25:38 +02:00
Stephan Bergmann
34c2adbdfb loplugin:cstylecast: deal with those that are (technically) const_cast 
Change-Id: Ia48650597a4854cbb92ef203b3c1338b4f47becc
 2015-06-02 11:26:43 +02:00
Stephan Bergmann
35f8f29395 loplugin:cstylecast: nop between pointer types of exactly same spelling 
Change-Id: I10dfaab18f39df8766718370d0bee6c9e41d1a42
 2015-05-11 12:49:47 +02:00
Caolán McNamara
24736e724e cppcheck: memleakOnRealloc 
Change-Id: Ibdf762b0d397f798372d9bf882aa82a6e5fd0229
 2015-05-04 20:13:53 +01:00
Caolán McNamara
90911df79e hstream.h->hstream.hxx 
Change-Id: Icc4a3d3661c3d40f9e71215bdc875c6a25f40ac1
 2015-05-04 20:13:53 +01:00
Caolán McNamara
e0380df3ee sequence operator twaddle + silly cast 
Change-Id: I8804bfb39d8306762cbe39ac4b6df9128a8e0069
 2015-04-29 10:12:49 +01:00
Caolán McNamara
626fe1669f redundant cast 
Change-Id: Ib812a7cafabc4820946da67fb3f8896b6aad1461
 2015-04-29 10:12:49 +01:00
Stephan Bergmann
e58fccdadb More loplugin:simplifybool 
Change-Id: I64ec8a0525b935d12455f7ed236ffd367f47c070
 2015-04-27 15:30:57 +02:00
Stephan Bergmann
691197bff7 loplugin:simplifybool 
Change-Id: Ic42cf05f9eddb0cd7724d16cc73a8d6495c193f2
 2015-04-24 12:36:22 +02:00
Caolán McNamara
028769528d cppcheck: silence assertWithSideEffect 
Change-Id: Iaaf69ea5e8d5eeaa3a61660c3abe04ff3e83d061
 2015-04-23 21:08:21 +01:00
Caolán McNamara
720dff2545 cppcheck: unsignedLessThanZero 
Change-Id: I1043e24fdf0350e38b587f11a2916bd54e8f718f
 2015-04-23 09:51:58 +01:00
Noel Grandin
71b809959b remove unnecessary use of void in function declarations 
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
 2015-04-15 11:47:12 +02:00
Noel Grandin
26ec80f47d loplugin:staticmethods 
Change-Id: I33a8ca28b0c3bf1c31758d93238e74927bebde9c
 2015-04-13 09:37:12 +02:00
Stephan Bergmann
9ad3eafb03 Reduce to static_cast any reinterpret_cast from void pointers 
Change-Id: I75514fe3a3c55691ca9adfa136bfcd5ff9a2b706
 2015-03-31 13:14:19 +02:00
Stephan Bergmann
33815ec449 Clean up C-style casts from pointers to void 
Change-Id: Ifbdbd2bb8a21afa76271728c46f88c11a887fc5a
 2015-03-28 19:09:21 +01:00
Stephan Bergmann
b98a8221c7 const_cast: convert some C-style casts and remove some redundant ones 
Change-Id: I74898e791e17971a3105febe660a2140aafaece9
 2015-03-26 15:33:31 +01:00
Noel Grandin
c3dc467232 loplugin:constantfunction: hwpfilter 
Change-Id: I2504291e2167cbc4be91e01de654ca63f89dbd2a
 2015-03-24 10:31:18 +02:00
Noel Grandin
48bb2913a7 convert SFX_FILTER_ constants to enum class 
Change-Id: I7e53cfc90cefd9da7d6ecd795b09214bd44b1613
 2015-03-19 08:25:03 +02:00
Noel Grandin
fb14be5f8f create new 'enum class' SotClipboardFormatId to unify types 
of which there are several.

There are some issues here I am unsure of
- the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids
  Perhaps I should change them to use the common values and create new enum values where necessary?
- the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff
   numeric values to the underlying code, but perhaps further fixing is necessary?

Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923
 2015-03-18 14:23:50 +02:00
Caolán McNamara
556373c41f V668 no sense in testing the result of new against null 
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
 2015-03-11 09:58:36 +00:00
Caolán McNamara
d22519f62b V801: Decreased performance 
Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
 2015-03-09 22:04:31 +00:00
Julien Nabet
5f6fcb4e7c Typos 
Change-Id: Ibc378fa5f515de61bb768b4ef082638b40c94e00
 2015-03-08 16:45:30 +01:00
Caolán McNamara
ab86a53623 V805: Decreased performance 
Change-Id: I822c5ebc321ebda87c238a1781a31793c1623e34
 2015-03-02 14:21:52 +00:00
Markus Mohrhard
d731835266 more efficient check for empty strings 
Change-Id: Ibc2f7412b6bf8ef75f93d649812836c01224e43f
 2015-03-01 18:58:43 +01:00
Caolán McNamara
b6336c9c67 wrong skip set here 
Change-Id: I86bdd1c2603c984380b52b080504b7583155b0fb
 2015-02-26 16:26:38 +00:00
Caolán McNamara
b1453e7fc7 fix bustage 
Change-Id: I249fe09319d6e0995d9ffdc7e4396b9b1787ad28
 2015-02-25 17:28:42 +00:00