mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
343,111 Commits 1 Branch 0 Tags
22c0cdc0146598cad53180be9b5f9378d2bc1d0c
Commit Graph

2982 Commits

Author SHA1 Message Date
Caolán McNamara
5c734f440a coverity#738565 Uninitialized scalar field 
Change-Id: Ie969773240bd7ecdcf56d7c533010d0aa32872c8
 2014-01-28 11:29:15 +00:00
Caolán McNamara
8cccfb8f8f coverity#441077 Dereference after null check 
Change-Id: Ia6a04846068e0bc500942e9a2dc6ee2e72d9d527
 2014-01-27 14:38:39 +00:00
Caolán McNamara
4e8692a3bf coverity#984078 Uninitialized scalar field 
Change-Id: I36b4a8c7d047f392fdbbe167a0e801b9a6d80b03
 2014-01-27 14:38:38 +00:00
Caolán McNamara
3848819cac coverity#707652 Uninitialized scalar field 
Change-Id: I6d561955454b0619255296704812b41a10ffe962
 2014-01-27 14:38:38 +00:00
Caolán McNamara
fd7dbe5a15 coverity#707651 Uninitialized scalar field 
Change-Id: I6e497d60e72efd1df6c271ce6bf8d5e46ba09ea7
 2014-01-27 14:38:38 +00:00
Caolán McNamara
81926e66d1 coverity#707650 Uninitialized pointer field 
Change-Id: I6843ce28f3e1395a2ab3c5515f393cce5096674b
 2014-01-27 14:38:38 +00:00
Caolán McNamara
7acea5ae4c coverity#707649 Uninitialized scalar field 
Change-Id: I1a95a051463860dc9c7b087bfaf17f3b70f297ee
 2014-01-27 14:38:37 +00:00
Caolán McNamara
7593b006df coverity#736909 Allocation too small for type 
Change-Id: I330ebdfd94d0c30b40e180e307d7543c09fd334b
 2014-01-24 15:27:57 +00:00
Caolán McNamara
28793abda5 coverity#736908 Allocation too small for type 
Change-Id: Ic41c5071957f5e95322971f8ec3ef864edecdb20
 2014-01-24 15:26:47 +00:00
Caolán McNamara
fcf23e8a44 coverity#706117 Allocation too small for type 
Change-Id: I1bb2bd26e533cf5b7de5225f0bcf323446e69f63
 2014-01-24 15:22:55 +00:00
Noel Grandin
16a2e90335 remove SvStream::operator<< methods 
.. and convert the last few places still using those methods.

Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd
Reviewed-on: https://gerrit.libreoffice.org/7495
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2014-01-22 22:00:47 +00:00
Noel Grandin
d803483f6a convert more SvStream::operator<< calls 
.. to more explicit SvStream::Write* calls
This was done using another run of the clang rewriter, and then
a lot of hand tweaking to fix all the places where the rewriter
did not play nice with various macros.

Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18
Reviewed-on: https://gerrit.libreoffice.org/7494
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2014-01-22 22:00:39 +00:00
Stephan Bergmann
6cccf0f388 bool improvements 
Change-Id: I64288207adb083e006b4acc5e7f26d647236a443
 2014-01-21 18:24:03 +01:00
Julien Nabet
ff48f28f71 Resolves: fdo#73771 Non-standard behaviour for Function Mid 
Change-Id: I90be516235228574dc219447a0eef3a34f83bee2
Reviewed-on: https://gerrit.libreoffice.org/7539
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-01-21 15:50:51 +00:00
Markus Mohrhard
5f893db57d how should I fix this memory leak?? 2014-01-19 18:28:39 +01:00
Markus Mohrhard
d3b60aa648 CID#706118: possibly invalid cast 2014-01-19 18:15:49 +01:00
Stephan Bergmann
1b33a38e32 Whatever those "true" arguments to SotStorage ctor may once have meant 
...is lost to history, but they are effectively equivalent to pssing default
SorageMode nStorageMode = 0 today, as the only thing that is done with that
nStorageMode value (in SotStorage::CreateStorage, sot/source/sdstor/storage.cxx)
is to compare it against STORAGE_TRANSACTED (0x04) STORAGE_CREATE_UNPACKED
(0x44).

Change-Id: I6ce79c03aff941b5abb5370e52a30b2294690b3a
 2014-01-17 18:45:13 +01:00
Andras Timar
99159a618f fdo#73698 check for empty aOut 
Change-Id: I0da26ef746553618bd8aee69f21ff0d1261efbf6
Reviewed-on: https://gerrit.libreoffice.org/7474
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-01-17 06:09:55 +00:00
Andras Timar
da67f5b162 Environment variables can contain >127 characters 
Change-Id: Iaeb690429d835ab2e6c13a8890a1b27b9405796a
 2014-01-16 17:00:32 +01:00
Noel Grandin
c648d08720 convert SvStream::operator<< overloads to more explicit methods 
This is in preparation for more conversion of SvStream::operator<< calls
to use more explicit method names.
This converts the subclasses that have their own convenience overloads
of operator<< to use normal methods.

Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
 2014-01-16 16:08:34 +01:00
Stephan Bergmann
0d29aab156 bool improvements 
Change-Id: Ic9ea40c430e0b0ab0d46bac3ba150ddac96c6acc
 2014-01-14 18:11:10 +01:00
Noel Grandin
b69864f3f8 re-write SvStream operator<< to non-overloaded methods 
This is the actual re-write.

Use a clang rewriter to rewrite SvStream::operator<< to methods
like WriteuInt32.
Note that the rewriter is not perfect, and I hand-tweaked the output.
In particular, I had to adjust places doing things like
  (*this) << 1;

Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a
Reviewed-on: https://gerrit.libreoffice.org/7342
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2014-01-10 13:26:24 +00:00
Herbert Dürr
9e77ddcd19 Resolves: #i123817# prepare codebase for updating to boost 1.55 
(cherry picked from commit c31988351c10e9f3fd783730d95da34efd52c153)

Conflicts:
	basic/source/comp/parser.cxx
	basic/source/comp/token.cxx
	dbaccess/source/ui/dlg/generalpage.cxx
	sc/source/ui/unoobj/chart2uno.cxx
	vcl/quartz/salbmp.cxx

Change-Id: Ic9580f2d4a44959cb3e38906eb4153b2c2a54899
 2014-01-06 16:32:20 +00:00
Andras Timar
b55259eeb5 typo fixes 
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
 2013-12-20 15:55:00 +01:00
Stephan Bergmann
83e191e25d Do not use C++-UNO internal static_type functions in client code 
...use cppu::UnoType instead.

Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
 2013-12-12 11:10:10 +01:00
Tor Lillqvist
4b0f171b24 sbxbase.hxx is private to basic 
Change-Id: I108bd247a40ce2b46034cabe8b075fa4f5a396df
 2013-12-11 10:49:57 +02:00
Tor Lillqvist
d76178b52d sbstdobj.hxx is private to basic 
Change-Id: I131dfeded783edfea94208d1cf8d70a2090785fa
 2013-12-11 10:48:12 +02:00
Tor Lillqvist
0a33e24d11 sbobjmod.hxx is private to basic 
Change-Id: I4ad28b049de5f7268ee1ca2e8992e2f29ed05380
 2013-12-11 10:39:57 +02:00
Tor Lillqvist
dde119c8f2 basic/global.hxx is private to basic 
Change-Id: I90a28e34eb45819e240931cd751ac0a546ea6be8
 2013-12-11 10:36:58 +02:00
Takeshi Abe
526a60086c Drop duplicate #include 
Change-Id: I05569ef98293445916e8f48e7f06abd795fe9bb5
 2013-12-08 17:20:40 +09:00
Herbert Dürr
3a437baee2 Resolves: #i74854# fix buttons in MsgBox with info icon 
Patch by: hanya.runo@gmail.com
Found by: ooo@catcons.co.uk
Tested by: hdu@apache.org

(cherry picked from commit 02cc651a1b45cbfbdab0aca6b57bff7bdf9e4f2c)

Conflicts:
	basic/source/runtime/methods.cxx
	vcl/inc/vcl/msgbox.hxx

Change-Id: I1656263e189f1a6cfa58436741bfa74ae0e6fffa
 2013-12-02 16:45:50 +00:00
Noel Grandin
610b2b94b3 remove unnecessary use of OUString constructor when assigning 
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
 2013-11-19 10:29:31 +02:00
Stephan Bergmann
ab5d1fbfb4 SAL_WARN_UNUSED com::sun:⭐:uno::Any 
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
 2013-11-14 21:02:40 +01:00
Noel Grandin
d366c9b20e remove unnecessary sal_Unicode casts in various places 
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
 2013-11-14 08:17:32 +02:00
Norbert Thiebaud
8b308d510e basic: include <> for external includes 
Change-Id: I4715bbe853d60ef15f20a4d2441c688003ca568e
 2013-11-11 22:37:24 -06:00
Stephan Bergmann
a2505ae731 SAL_WARN_UNUSED INetURLObject 
Change-Id: Ia9af3b76c2a2ac654b02c1502aa2d0c2c987fbf2
 2013-11-11 16:50:05 +01:00
Noel Grandin
fcd1637d51 convert OUString compareToAscii == 0 to equalsAscii 
Convert code like
   aStr.compareToAscii("XXX") == 0
to
  aStr.equalsAscii("XXX")
which is both easier to read and faster.

Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
 2013-11-11 12:58:13 +02:00
Noel Grandin
e9c4ee996d remove unnecessary use of OUString constructor in BASIC module 
Change-Id: Iee86ce9200285647d5031cb2f89266a52704dd44
 2013-11-11 11:21:25 +02:00
Caolán McNamara
609f0b8bff add limits.h for rhel-6 build 
Change-Id: I9d355be54eb4072044ad660296375fca8d0fa831
 2013-11-01 08:54:20 +00:00
Noel Grandin
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith 
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
 2013-10-31 08:34:21 +02:00
Thomas Arnhold
4adf622925 fixincludeguards.sh: basic 
Change-Id: Id797a8969e42876092da347d8e1bba6195b697dc
 2013-10-28 15:16:20 +01:00
Thomas Arnhold
54a17dd246 windows: warning 4355 is disabled globally in com_MSC_defs.mk 
So there is no need to do this locally, too.

Change-Id: I0fa1d0cd3e077ba0985848a9d2cbb061b123e8ad
 2013-10-28 01:02:13 +01:00
Noel Grandin
8396cce9b5 clean up places accessing the NULL at the of an OUString 
There were only a couple of real bugs fixed, but we're a little
bit safer now.
This also fixes the assert and the comment in OUString::operator[]
about this.

Change-Id: Ibe16b5794e0ba7ecd345fa0801586d25b015974c
 2013-10-23 13:12:55 +02:00
Tor Lillqvist
a7724966ab Bin comments that claim to say why some header is included 
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
 2013-10-22 16:56:28 +03:00
Caolán McNamara
b37e2dd071 Resolves: fdo#38838 remove UniString 
hammer silver nails into coffin and bury in concrete

Change-Id: I3fda2ff47738bb33793adab97faba2d439ac9a28
 2013-10-22 12:50:48 +01:00
Thomas Arnhold
8fc6905674 fdo#68849 add some header guards 
Change-Id: I9d25a58f22095689eccc0ac444c163d1e9bee69f
Reviewed-on: https://gerrit.libreoffice.org/6364
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-10-21 09:15:59 +00:00
Stephan Bergmann
2d1675c3ad The getSupportedServiceNames implementations will already take care 
Change-Id: I0c7ae8e0393f069259b943e04368e874abdf8386
 2013-10-17 15:03:50 +02:00
Marcos Paulo de Souza
3d3293144b fdo#54938: Adapt svtools and comphelper module ... 
to  use cppu::supportsService and other pieces.

Change-Id: I16893b3d31a8055acd214ff23d01e63d38fe0826
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2013-10-17 14:43:28 +02:00
Eike Rathke
66a96c8274 clean up SbiScanner::NextSym() a little, fdo#70319 follow-up 
Number recognition was suboptimal and didn't properly resync scan
positions after having detected an error.

Change-Id: I278fdaaf17ed40560785deaaad0e3412a249d90a
 2013-10-15 12:52:15 +02:00
Stephan Bergmann
458c5a0f47 Defer OUString -> OString conversion 
...to avoid converting back OString -> OUString in SbiIoSystem::WriteCon.

Change-Id: I17024891d0babaa589f2c65f1123f1905c4338bb
 2013-10-15 10:33:26 +02:00