Commit Graph

594 Commits

Author SHA1 Message Date
Stephan Bergmann
bbd9668d5f bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-22 15:00:54 +01:00
Alexandre Vicenzi
9f76437548 Removed unused solar.h reference
Change-Id: I1ff7d4bad068a8bc8cdc7f27dbfaee199d0f2e5f
Reviewed-on: https://gerrit.libreoffice.org/7513
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-20 21:32:27 +00:00
Stephan Bergmann
9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..."
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
Noel Grandin
909b27df48 remove unnecessary double calls to OUString constructor
Change-Id: Ib2690e3ec9987b97363687b61fe8ddae4ace9058
2013-12-17 11:49:04 +02:00
Stephan Bergmann
e9c62a2d9c Get rid of unnecessary comphelper::UStringEqual
Change-Id: Ia8718e49f21ccec239b2769eafa6bef90e0e9e40
2013-12-06 14:28:36 +01:00
Stephan Bergmann
895e6e7bb7 Get rid of comphelper::UStringLess
...default std::less<OUString> is just fine.

Change-Id: Ib9d3c10f2817d757f3c19eb3d4607095883af91a
2013-12-05 18:36:22 +01:00
Noel Grandin
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
Noel Grandin
39c8da8c86 remove unnecessary sal_Unicode casts in XMLOFF module
Change-Id: I836c7a28d5ec9039c0b185e8db2aa6d01ac62566
Reviewed-on: https://gerrit.libreoffice.org/6665
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-11-14 06:16:12 +00:00
Norbert Thiebaud
21123da759 xmloff: include <> for external includes
Change-Id: Ic92d0121e928041bcff00b12706f794a4d8e25c8
2013-11-11 22:37:28 -06:00
Julien Nabet
fd2d0bc88f cppcheck: reduce scope
Change-Id: I7a20f89e5a113c6c8760d51475d8198e28ad6aac
2013-11-10 14:32:25 +01:00
Noel Grandin
aeb41c9b9b remove redundant calls to OUString constructor
Change code like this:
  aStr = OUString("xxxx");
into this:
  aStr = "xxxx";

Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04 10:11:07 +02:00
Stephan Bergmann
8b8ef8d633 Remove the xmloff::token::ResetTokens race condition
...where multiple parallel calls to xmloff::token::ResetTokens or
xmloff::token::GetXMLToken can see dangling pOUString pointers.  There is no
point in releasing this (bounded) amount of memory referenced from global
aTokenList, anyway.

There is still a race when parallel calls to xmloff::token::GetXMLToken write to
a pOUString pointer in parallel, but that's more harmless, and maybe calls to
GetXMLToken are synchronized by Solar Mutex?  Calls to ResetTokens (e.g., via
URP remote release request -> ~ScXMLExport -> ~SvXMLExport) were definitely
/not/ synchronized via any mutex.

The xmloff::token::Inc/DecRescheduleCount functions are now pointless and have
been removed, too.

Change-Id: I85905d4de1f042ed5c9a37589f942910d8ef80fd
2013-10-31 12:45:04 +01:00
Thomas Arnhold
a45953ed7c fixincludeguards.sh: xmloff
Change-Id: I0e7d9daac1ad88fad8d240373e91ef323966bb47
2013-10-23 23:22:32 +02:00
Thomas Arnhold
67aec43915 cleanup
Change-Id: I7bfd221f89718ba8634417c93a26b3a199178694
2013-10-16 05:41:26 +02:00
Takeshi Abe
3bba060388 sal_Bool to bool
Change-Id: I826911bdf06b8047ca8e3bd256687e10fb51962d
2013-09-12 17:58:12 +09:00
Takeshi Abe
9ab5bb0cc2 Mark as const
Change-Id: I1d62c66bd89ec5a813eb7b211042e392903c8baf
2013-09-12 17:58:11 +09:00
Luboš Luňák
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
Jelle van der Waa
fa0e48c5e4 fdo#57950: Remove some chained appends in xmloff
Change-Id: Iff0c43d190e6afa26c23416db4da9843cf7f41a5
Reviewed-on: https://gerrit.libreoffice.org/5327
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
2013-08-19 15:50:01 +00:00
Jelle van der Waa
4f360266cd fdo#62475 removed pointless comments
Change-Id: I176886fbc9f3d9e2b8ad2308ac2b127d9c68d9a6
Reviewed-on: https://gerrit.libreoffice.org/5331
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-08-10 14:55:06 +00:00
Takeshi Abe
a2e599f16b Mark as static and/or const
Change-Id: I45a890bb793a6d92546c05bd75738d4dd753a01e
2013-07-18 22:18:25 +09:00
Thomas Arnhold
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
Thomas Arnhold
955ebe83a8 String to OUString and cleanup
Change-Id: Idc18c1a6a64edea3399c8747ec0f096a2f964b68
2013-06-29 16:23:24 +02:00
Noel Grandin
b12dab7bd2 fdo#46808, Convert some XMultiServiceFactory to XComponentContext
Change-Id: I2e3480bf4f616231ee50a83f440d9bb0955e4ce6
2013-05-15 08:25:36 +02:00
Radu Ioan
ac937d8be6 fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT
- replaced osl_trace with sal_info
 - replaced dbg_* with sal_*

Change-Id: I80aca85562e4a43fded5c37f9895e51f79e42c14
Reviewed-on: https://gerrit.libreoffice.org/3771
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
2013-05-14 13:59:53 +00:00
Luboš Luňák
ba044b1e96 remove needless forward rtl::OUString declarations
Change-Id: I97d91a758dd82d64768d75c1d2ddd279de5f6034
2013-04-07 14:23:12 +02:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Stephan Bergmann
aa753f01ba -Wunused-macros
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27 09:36:53 +01:00
EricSeynaeve
bf033461c5 fdo#61135 stepped lines graph: handle ods files
The boilerplate code for drawing the 4 types of stepped is in place (as
described in ODF1.3,
https://tools.oasis-open.org/issues/browse/OFFICE-3662).
We can also read the current attribute values used in Gnumeric. These values
are converted to ODF1.3 during save.

Change-Id: I0f04a779de4b65326ed7ce6de56191f11b51c596
2013-03-19 02:36:46 +01:00
Thomas Arnhold
937b63af33 use startsWith() instead of compareToAscii()
brain damage...

Change-Id: I4dc63c7346f724eded9ac7b82cda25c2bb60beff
2013-03-11 11:07:09 +01:00
Chr. Rossmanith
a20d634b61 Removed RTL_CONSTASCII_USTRINGPARAM in xmloff(transform)
Change-Id: I3b32ef3bad9700f24c898b6b5bf1a8cd6a97f426
2013-03-10 07:52:58 +01:00
Thomas Arnhold
4bf95c4c31 make use of startsWith()
Change-Id: Ie70097de550ddd1cddc6714f8f86f9723cb36679
Reviewed-on: https://gerrit.libreoffice.org/2599
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-08 13:16:49 +00:00
Thomas Arnhold
f5ca04caca Related to fdo#60724: correct spelling
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
Norbert Thiebaud
7bf7d96a65 coverity#705351 missing break in switch
Change-Id: I8fa9ddbf6966ee2520e6245f7e014ee6df914486
Reviewed-on: https://gerrit.libreoffice.org/2238
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-02-18 13:44:18 +00:00
Norbert Thiebaud
753d92968a coverity#705351 Missing break in switch
Change-Id: Id6d35b951ff78f21e3ea5a9beed22081f8c466fa
Reviewed-on: https://gerrit.libreoffice.org/2237
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-02-18 13:43:10 +00:00
Miklos Vajna
4fd5136cbd xmloff: mostly kill CONSTASCII_STRINGPARAM usage 2012-12-28 13:37:02 +01:00
Michael Meeks
17ff7b41d1 re-base on ALv2 code. Includes:
Patches contributed by: Armin Le Grand.
    #118558# Correcting OLE attributes of LO3.4 at load time by loading as OOo3.3, details see task.
    http://svn.apache.org/viewvc?view=revision&revision=1195906
    #118485# - Styles for OLEs are not saved.
    http://svn.apache.org/viewvc?view=revision&revision=1182166
    #118898# Adapted ImpGraphic::ImplGetBitmap to correctly convert metafiles
    http://svn.apache.org/viewvc?view=revision&revision=1293316
    #119337# Solves the wrong get/setPropertyValue calls in
    SvxShapeText (and thus in SvxOle2Shape)
    http://svn.apache.org/viewvc?view=revision&revision=1344156

    Patches contributed by Mathias Bauer (and others)
    gnumake4 work variously
    http://svn.apache.org/viewvc?view=revision&revision=1394707
    http://svn.apache.org/viewvc?view=revision&revision=1394326
    cws mba34issues01: #i117717#: remove wrong assertion
    http://svn.apache.org/viewvc?view=revision&revision=1172349

    Patch contributed by Herbert Duerr
    goodbye Registration and License dialogs, don't let the door hit you
    http://svn.apache.org/viewvc?view=revision&revision=1172613
    help gcc 4.6.0 on 32bit ubuntu 11.10"
    http://svn.apache.org/viewvc?view=revision&revision=1245357

    Do not add targets for junit tests when junit is disabled.
    Patch contributed by Andre Fischer
    http://svn.apache.org/viewvc?view=revision&revision=1241508

Revert "sb140: #i117082# avoid unncessary static class data members
    commit 21d97438e2.
remove obsolete FreeBSD visibility special case.
retain consolidated BSD bridge code, remove OS/2 pieces.
2012-11-15 16:06:08 +00:00
Noel Grandin
0666e43c45 fdo#46808, use service constructor for i18n::CharacterClassification
Change-Id: I0499ad7de27b1539e97f01ab8aa0ef2d6713ae76
2012-11-05 18:05:00 +01:00
Miklos Vajna
7fe8d9328c xmloff: drop unused OUStrings
Change-Id: I040e9a5c9e60a27aa82fd624cc01edfecf5cc8de
2012-11-03 18:36:03 +01:00
Noel Grandin
5aa2cd1d3f fdo#46808, use service constructor for uri::UriReferenceFactory
Change-Id: I4e72bf5880fa28cb96d93ede7730a63220af7fa6
2012-10-23 11:45:47 +02:00
Caolán McNamara
1f9f8f4f40 loplugin: some log, indent and unused variable warnings
fix up some indents, remove some unused OUStrings and add some log areas

Change-Id: I5c50807aff7a726b03b72522975d9b75e6685b9b
2012-10-13 20:34:54 +01:00
Arnaud Versini
7378c5cb16 Replace usage of rtl/memory.h in xmloff with equivalent from string.h
Change-Id: Ie4747a424bb688263dd578905b44c849e3cac08d
2012-08-04 17:46:59 +02:00
Luboš Luňák
e0f7e213af the unknwon typo is surprisingly popular
Change-Id: Iffe25051c8357019521196f9a27065d6108ede47
2012-07-16 19:40:58 +02:00
Takeshi Abe
6013882bdf removed unnecessary forward declarations of class
except moving SvXMLStyleContext into xmloff/source/forms/layerimport.hxx

Change-Id: I5e16b54f98ccdd54bc0bb373d3fe92ed1bef3c5e
2012-06-27 20:05:51 +09:00
Michael Meeks
b9042fad7c re-base on ALv2 code.
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00
Norbert Thiebaud
d29d9399d4 targeted string re-work
Change-Id: I342f1b8ac6c8205b6c587578a6b10a6ca51758fa
2012-06-02 16:48:34 -05:00
Norbert Thiebaud
0aca973181 targeted string re-work
Change-Id: I588fadc51fec90b3b04d61c2c63880236c535183
2012-06-02 16:48:34 -05:00
Takeshi Abe
00f1180c96 removed unused const rtl::OUString
Change-Id: If02be864f958de96ae1c54fe575b1828410390b1
2012-05-18 22:56:54 +09:00
Szabolcs Dezsi
d6bc02f8c4 Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator 2012-04-06 20:03:42 +02:00
Michael Stahl
9429bbb0c4 .component files don't need executable bits 2012-03-23 21:58:14 +01:00
Takeshi Abe
3006397439 Prefer equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM("..."))
to equalsIgnoreAsciiCaseAscii("...")
2012-02-21 01:07:21 +09:00