Commit Graph

7555 Commits

Author SHA1 Message Date
Caolán McNamara
29b9df16df [API CHANGE] add Author Initials to XAnnotation
and use the users preferred initials for impress annotations

i.e. the ones entered in the tools->options

and save and load those to/from odf similarly to
what we do for writer annotation initials

Change-Id: Iadc0e994bfaf58632ce25b8f7cdc737580ee97bc
Reviewed-on: https://gerrit.libreoffice.org/22143
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2016-02-18 11:06:27 +00:00
Noel Grandin
0f8ec3036f [API CHANGE] add operator==/!= to UNO structs
this is useful now that we are storing UNO structs in std::vector

Change-Id: Ic558bcd669bd2b3cdf9eb8393269eb906ac52369
Reviewed-on: https://gerrit.libreoffice.org/22257
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-11 06:22:28 +00:00
Chris Sherlock
a238b1f8d3 Remove excess newlines
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09 08:18:05 +00:00
Chris Sherlock
538f276ae0 Formatting changes across all modules
+ Removed comment cruft
+ Tab formatting in number of files
+ Some commented out code removed
+ Tab characters replaced with spaces
+ Newline cleanup in quite a few files
+ Tweak header guard #endifs

Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc
Reviewed-on: https://gerrit.libreoffice.org/22221
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09 08:11:34 +00:00
Andrea Gelmini
534b2a4b58 Fix typos
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3
Reviewed-on: https://gerrit.libreoffice.org/21797
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-05 06:48:38 +00:00
Stephan Bergmann
9599cf88b1 Replace push(std::make_tuple(...)) with emplace(...)
...the former reportedly caused problems now with GCC 6 libstdc++

Change-Id: I4b13adc71d9e00b14df1c8e875dba9e90cbcdcc7
2016-02-04 15:56:58 +01:00
Jochen Nitschke
bd76d319bb remove bogus nullprt checks for pContext
reported by Cppcheck

Change-Id: I737c2bd7be197ef9d0b29b922acd8021fefb7af6
Signed-off-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-on: https://gerrit.libreoffice.org/22059
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-03 02:17:32 +00:00
Michael Stahl
8dadefc35f xmloff: tdf#96147: ODF export: fix duplicate fo:background-color
... attributes that happen if both CharHighlight and CharBackColor
properties are used, because the CharBackTransparent property wasn't
taken into account, and combining the CharBackColor and
CharBackTransparent properties happens *after*
XMLTextExportPropertySetMapper::ContextFilter() runs.

Also, it looks like a transparent highlight wouldn't export properly but
apparently DomainMapper::getColorFromId() won't create such.

(regression from f880962f5b)

Change-Id: Ib628ef8bb377482f74fadb97c81afb95fbbf7184
2016-02-02 14:58:34 +01:00
Caolán McNamara
1fd280f2c6 boost::tuple -> std::tuple
Change-Id: Ia08c184b792ff73d3ed49d6a5d54dec1a35943e9
Reviewed-on: https://gerrit.libreoffice.org/21955
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-31 17:25:52 +00:00
Noel Grandin
1ef9f3988e unnecessary use of OUString constructor
Change-Id: Idd31b0a53c8318af69bbcd32f6798721ec8eb8e1
Reviewed-on: https://gerrit.libreoffice.org/21945
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-31 12:04:02 +00:00
Stephan Bergmann
adbad2a557 Move XMLMetaExportComponent_get_implementation to a more reasonable place
Change-Id: Iaf3dc5351453b4aee8ffc1e7fb1bc670c45c507f
2016-01-21 20:00:51 +01:00
Caolán McNamara
5705773267 cppcheck: variableScope
Change-Id: Id7cf5887c1ef0e0c0aad72ea5ac49f4d3db5065e
2016-01-21 11:47:18 +00:00
Caolán McNamara
86963c2e23 Resolves: tdf#96245 relax test for duplicate frame names
to allow duplicated unnamed frames

Change-Id: I871849b23d01209f027b6295777db705f7dc86d8
2016-01-19 15:33:29 +00:00
Peter Foley
8633e6b3f5 Convert NULL/0 to nullptr
Change-Id: Iee6bb0867afd8aebe36e62b507f1332e3a581838
Reviewed-on: https://gerrit.libreoffice.org/21549
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-18 18:43:51 +00:00
Stephan Bergmann
22fa5972ec loplugin:unreffun
Change-Id: If023e3916c7d2fa7f22958304606a2eec418fcf7
2016-01-18 10:11:26 +01:00
kripton
94699cdec8 tdf#74608 xmloff: Constructor feature for XMLMetaExportComponent
Change-Id: I3edde1291e9dec21420238edb5a05f25849ebfff
Reviewed-on: https://gerrit.libreoffice.org/19792
Reviewed-by: Matúš Kukan <matus@libreoffice.org>
Tested-by: Matúš Kukan <matus@libreoffice.org>
2016-01-18 09:05:12 +00:00
Noel Grandin
f0920199f2 -Werror=unused-but-set-variable
Change-Id: I981e1b660dc94333935b3a451847198940e47e99
2016-01-15 10:42:24 +02:00
Noel Grandin
ed373ea7ef loplugin:unusedmethods unused return value in include/xmloff
Change-Id: I6615a467152a50e9c65f04fd0d6c8cc128517bdb
2016-01-15 09:36:42 +02:00
Stephan Bergmann
09f1bd85d4 -Werror=address
the original looks odd, but the code was like that ever since it got introduced
with 44cfc7cb65 "re-base on ALv2 code. Includes
(at least) relevant parts of:"

Change-Id: I327c5a53a2634aca1b36367ee09c068ac610d3f4
2016-01-13 17:29:51 +01:00
Noel Grandin
c2460312ff -Werror=unused-but-set-variable
Change-Id: I61a07db63cc8a6bad159ca455f92d604c5e78edc
2016-01-13 13:59:52 +02:00
Noel Grandin
60904f1a7e loplugin:unusedmethods unused return value in xmloff/
Change-Id: Ia5a3716ca4f7eb987092837ac83a415e5c0730df
2016-01-13 12:16:24 +02:00
Michael Stahl
6640bfc66d xmloff: SvXMLExport::mbExtended is dead now
Change-Id: Ie679259deccce87949d7bf8767af707827b4134c
2016-01-12 23:25:24 +01:00
Michael Stahl
d277ac8745 xmloff: there is no reason why office:version should be omitted
... if a document contains foreign elements or attributes.

In fact since ODF 1.2 the office:version attribute is mandatory and any
document that omits it is therefore invalid, while "extended conforming"
documents are allowed to contain foreign elements and attributes.

This mysterious check was there since CVS initial import, but without
any justification.

Change-Id: Ifeafad2b7af41f06356461adb7ae65dbf7bae11d
2016-01-12 23:24:57 +01:00
Michael Stahl
2bebf67790 typos
Change-Id: I970429c266cc1a8cf36cfba379b447899b5dbce9
2016-01-12 12:22:31 +01:00
Laurent Balland-Poirier
3ee66e306c tdf#40517 Export/Import in ODF decimal replacement with space
Number format such as "0.???" is saved in ODF with number:decimal-replacement=" "

Change-Id: I0dd19b5ea126f380bcf17a3ccc5d8c355119e23b
Reviewed-on: https://gerrit.libreoffice.org/21021
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-01-11 13:21:43 +00:00
Andrea Gelmini
64d624b651 Fix typos
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10 14:17:20 +00:00
Michael Stahl
774fb6d2e7 tdf#96480: ODF import: eliminate duplicate cross reference heading bookmarks
7c3c3006de is apparently worse than it
appeared at first glance since there are numerous assumptions about
bookmarks, such as that if they were inserted successfully they may be
copied successfully, which isn't the case for duplicate cross reference
bookmarks.

So fix this differently, by eliminating the duplicates and mapping all
reference fields to refer to the surviving bookmark.

It was not possible to do this in SwXBookmark by checking the makeMark()
return as that would raise interesting problems such as it's currently
guaranteed to have 1:1 SwXBoomarks to core Marks so we can't just
connect 2 SwXBookmarks to the same core Mark, and we also can't leave
the SwXBookmark unconnected after attach.

Another alternative would be to temporarily allow inserting the
duplicate bookmarks and then eliminate them after the import, but what
is implemented now is to check from xmloff for duplicates, which is
reasonably simple.

Change-Id: I7ee4854d1c9d8bf74201089cbb7287b1bd8ee3b9
2016-01-08 20:31:47 +01:00
Markus Mohrhard
070258271c indentation fixes
Change-Id: Ibc652519d7ccc9a1ec483f19d443c9b5303e0f92
2016-01-08 03:35:22 +01:00
Sheikha AL-Hinai
d75b9fd582 tdf#94205: Use o3tl::make_unique insted of new+std::move.
Change-Id: I9ff14760479d2ac882546e2e5b74ab750ba2fa4b
Reviewed-on: https://gerrit.libreoffice.org/20984
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-05 11:47:50 +00:00
Caolán McNamara
bea8a7ad63 cppcheck: noExplicitConstructor
Change-Id: Ib43e53d5b6c9c130adb765ac9b769f58060ac640
2015-12-29 19:46:23 +00:00
Chris Sherlock
f547c51c8e xmloff: indent cleanup in header
Change-Id: Ibcd03dcdc8936ce95feada20c72a358d5021a1d9
Reviewed-on: https://gerrit.libreoffice.org/20962
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-12-26 19:23:08 +00:00
Chris Sherlock
0cb61caefa xmloff: change instances of maName to more descriptive names
Change-Id: I7ff771f78481677ae65f933608e484714cd43f4f
Reviewed-on: https://gerrit.libreoffice.org/20961
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-12-26 19:09:00 +00:00
Xisco Fauli
307421ba93 tdf#96181 SVG: Add support for <use> element
Change-Id: Ia95c7e35158f8a4c6a597662524c74e1909983bb
Reviewed-on: https://gerrit.libreoffice.org/20483
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2015-12-22 13:13:04 +00:00
Noel Grandin
44f2edbf7a loplugin:unusedfields in include/vcl
Change-Id: I61fc04e00970ea0d398ff80f6b1f81ec2f62dd5e
Reviewed-on: https://gerrit.libreoffice.org/20868
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-22 09:44:37 +00:00
Noel Grandin
4c7ce41582 loplugin:unusedfields in xmlhelp,xmloff
Change-Id: I4d2f0ff95da5abaa3d0a0a5223616e09e0c476fc
2015-12-21 12:45:49 +02:00
Miklos Vajna
f2d5d0ac1d xmloff: one more missing include
Change-Id: I92080eefa485dec86c3a10f978831157b04a0c53
2015-12-19 22:50:31 +01:00
Caolán McNamara
8f85595371 coverity#1343637 Double free
and

coverity#1343638 Double free
coverity#1343639 Double free
coverity#1343640 Double free
coverity#1343641 Double free

Change-Id: I8ce42f03d40fe514f73b3a7eabdb4f323b2239e6
2015-12-19 18:10:11 +00:00
Stephan Bergmann
d138573103 Avoid memory leaks
...when exceptions get thrown while a context owns an rewind map

Change-Id: I90d26caa57ef2ff508e6eae05ddbc62cdb3f01ea
2015-12-17 16:51:17 +01:00
Stephan Bergmann
ba3a918404 Remove trivial class XMLTransformerContextVector
Change-Id: I140614895d5727ffd97681ddd06bf7439fe7a443
2015-12-17 16:51:16 +01:00
Stephan Bergmann
21e72c5f1d Hold XMLTransformerContext by rtl::Reference
Change-Id: I60b8d422d53d47537996756aa1b7fb3c26f8383a
2015-12-17 16:51:16 +01:00
Xisco Fauli
dc3eb865bd tdf#32248 SVG: first attempt to support tspan elements
it's not perfect but at least we can already display the text,
which is better than displaying nothing

Change-Id: I89627010ac8071c106b41c1de6b183a619f8158b
Reviewed-on: https://gerrit.libreoffice.org/20642
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2015-12-17 12:23:38 +00:00
Armin Le Grand
e67a834c5d Resolves: tdf#93994 flush API objects at load time
When importing SdrObjCustomShape for each an Outliner and a
VirtualDevice as RefDevice are created and held. On 32bit systems this
breaks the import with many such objects (in the bugdoc around 4300). On
64bit it works, but more memory as necessary is used. To avoid this,
flush the UNO API implementations at these objects after one page is
imported.  Do not do this for each single object, that will break the
connector import which does some processing later.

Change-Id: I7296edd40f01c1a40258808d78bf39e6d4fe29bf
Reviewed-on: https://gerrit.libreoffice.org/19990
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-12-11 17:10:14 +00:00
Stephan Bergmann
fb8a3fac5d loplugin:nullptr: More NULL -> nullptr automatic rewrite
Change-Id: Ie83819e2bcdc5fa160b39296b005ca9a5ff74b1d
2015-12-10 08:06:06 +01:00
Stephan Bergmann
efa5c54373 -Werror,-Wunused-private-field
Change-Id: I3f328023d99d3505ab2ce2a80eef82d84d81446e
2015-11-26 12:59:32 +01:00
Noel Grandin
a508f639a0 mark UNO structs as SAL_WARN_UNUSED, where possible
Change-Id: Ie3de518f60c9f1313c68df54dbdc1fb2804f1f0d
2015-11-26 13:26:25 +02:00
Noel Grandin
abc6071b7a loplugin:unusedfields various
Change-Id: I18f94269a1172cf195ee402384f7144610e1e82d
2015-11-26 13:26:25 +02:00
Noel Grandin
80735fcbb0 com::sun::star->css in xmloff/
Change-Id: Iee6e21e093fb1383f19a0716dbc1c341f446b8c2
Reviewed-on: https://gerrit.libreoffice.org/20192
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-26 10:47:02 +00:00
Noel Grandin
3e6ba91e2d loplugin:unusedfields in include/xmloff
Change-Id: I979743671e9a2e868d815f917427588b7b0320ba
2015-11-25 13:57:29 +02:00
Markus Mohrhard
4d9a757a38 store custom icon set info into ODF
Change-Id: I1581b28237d2b9f9c22d3f3b0436dc281508aafa
Reviewed-on: https://gerrit.libreoffice.org/20118
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-11-25 08:50:42 +00:00
Caolán McNamara
7acbf173fc crashtesting: ooo72999-1.ods NaNs found in light direction
and NaN != NaN so busted logic propogates, drop invalid directions
on initial read

Change-Id: Ic76c714666df14d37a4c68f43b817327675bd0e0
2015-11-24 15:19:02 +00:00