Commit Graph

160 Commits

Author SHA1 Message Date
Maxim Monastirsky
2d4e9abc07 tdf#93837 chart2: Convert shape context menus to xml
Change-Id: Ie0589c576b26dd74b9bc16d78a37a01c9bb2985e
2016-03-21 13:48:16 +02:00
Stephan Bergmann
576c7562ec Return std::unique_ptr from svt::AcceleratorExecute::createAcceleratorHelper
...to prevent errors like 5ac6e00274 "Memory leak"

Change-Id: I3e20393af628849d8a387b491b75e1aacdea982a
2015-12-11 16:15:53 +01:00
Stephan Bergmann
40c4a08652 loplugin:nullptr (automatic rewrite)
Change-Id: I71de514405bb9bcc746c1ab9633e7fe659888943
2015-11-10 10:31:18 +01:00
Noel Grandin
0f88736128 loplugin:mergeclasses
Change-Id: Icd01de71fe87e0bf17eba39f5b00fc9a46765509
2015-10-12 09:13:33 +02:00
Oliver Specht
ac9671f948 tdf#94559: second step to remove rtti.hxx
replaced use of PTR_CAST, IS_TYPE, ISA in
    chart2, connectivity, editeng, extensions, filter, forms, framework, idl

Change-Id: I6a2f9d8bbccb07088413f7552af4b5af8f0cad99
Reviewed-on: https://gerrit.libreoffice.org/18920
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-09-30 06:07:57 +00:00
Andrea Gelmini
a6e622480f Fix typos
Change-Id: Icf15b5ea2e5b9cd62645bab2f9ccaada948322a7
Reviewed-on: https://gerrit.libreoffice.org/18940
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30 06:00:42 +00:00
Stephan Bergmann
f9f3e97ca8 SdrObjEditView::IsTextEditHit effectively ignores its nTol argument
...ever since

  nTol=0; // Joe am 6.3.1997: Keine Hittoleranz mehr hier

had been added into it sometime prior to
fd069bee7e "initial import."  So lets assume Joe
meant that as a permanent fix rather than a temporal hack (which would have
survived for longer than 18 years anyway).

Change-Id: Ib30ac8d578f70c861d4c0f5f71bf4c13e9281db8
2015-09-09 14:01:18 +02:00
Noel Grandin
70a30fd179 loplugin: defaultparams
Change-Id: I65c0ed65b20f606cf1409a3158ff1ef1e2d6cd9f
2015-08-14 10:52:46 +02:00
Andrea Gelmini
9f27e5b0e0 Fix typos
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c
Reviewed-on: https://gerrit.libreoffice.org/17187
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-19 19:45:07 +00:00
Michael Meeks
ba81e5c6bd tdf#91702 - fix stack-based MessBox allocation.
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7
Reviewed-on: https://gerrit.libreoffice.org/15954
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-29 12:16:28 +00:00
Noel Grandin
ac3802da9a convert WINDOW_POSSIZE constants to scoped enum
Change-Id: Id85137ffc7309a66b04132d588d289db136117b9
2015-05-22 10:37:59 +02:00
Noel Grandin
e929194317 convert POINTER constants to scoped enum
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19
Reviewed-on: https://gerrit.libreoffice.org/15825
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-22 06:32:35 +00:00
Jens Carl
5bf6fecde7 tdf#91054: cleanup weirdo function prototypes
cleanup the folders chart2/ and ucb/

Change-Id: Ia5f230703e55da5710eaa52bbd9e22a6395a49ad
Reviewed-on: https://gerrit.libreoffice.org/15832
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-21 06:34:45 +00:00
Tomaž Vajngerl
73e45da4f5 refactor chart2 classes to use RenderContext
Change-Id: I245af77126739bb219f6a085a47cee2efac2c351
2015-05-14 09:58:14 +09:00
Noel Grandin
82d68f9cbc convert COMMAND_ constants to scoped enum
Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95
Reviewed-on: https://gerrit.libreoffice.org/15671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-11 12:17:42 +00:00
Stephan Bergmann
8cafd08278 Use typed Timer::SetTimeoutHdl Link
Change-Id: Iaaf0c93e5b28c0f7dbe4f02eda8beeae30708100
2015-05-05 10:21:54 +02:00
Noel Grandin
0a9f331de4 convert SDRMOUSE constants to scoped enum
Change-Id: Ia5389095683a1c012a988ed71bf769a1f25d80fb
2015-04-29 10:41:40 +02:00
Stephan Bergmann
91b9148829 Change tools::Time::GetSystemTicks to sal_uInt64
...as follow-up clean-up after 71fefe1dc2 "Change
'blink times' to be of type sal_uInt64 and thus consistent with
Timer::Get/SetTimeout since 9c7016b5b5 'Scheduler:
Changed uLong to uInt32/uInt64.'"

Transitively meant to change quite a number of further time-related places from
sal_uLong/sal_uIntPtr to consistently use sal_uInt64.

Change-Id: I38eb493943906356138bf58eb098d2f54a3dee34
Reviewed-on: https://gerrit.libreoffice.org/15214
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-04-09 18:57:00 +00:00
Stephan Bergmann
31e24f487e Remove redundant Reference<> from within UnoType<> uses
Change-Id: I1aeb9c73c284e39f371e49ded98e8dba0d055056
2015-04-01 10:42:57 +02:00
Swachhand Lokhande
b1534edf52 tdf#89592 Using initializer_lists to populate Sequence<PropertyValue>
Change-Id: Idef9dd55eb1719eaf592bc4a86440cbd5aa4fb32
Reviewed-on: https://gerrit.libreoffice.org/14781
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-03-10 10:26:59 +00:00
Radu Ioan
a8e6f0bea0 tdf#39440 - cppcheck cleanliness
Fixed some cppcheck defects

Change-Id: I25fd6aba9d76df98d20b9a1bb4c9d3c1bf6f84bb
Reviewed-on: https://gerrit.libreoffice.org/14487
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-17 06:15:54 +00:00
Stephan Bergmann
acb7ca4283 chart2: Use appropriate OUString functions on string constants
Change-Id: Ifc28920e69db410b00312e634caba33b0e286b7f
2014-12-18 14:12:23 +01:00
Noel Grandin
31d902d3c0 fdo#84938: replace MOUSE_ modifier constants with enum
and make the two categories of constants non-overlapping, we
really don't need to risk confusion in order to save 6 bits in
a data structure like this.

Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-07 14:53:36 +02:00
Jan Holesovsky
31af61ea09 Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"
This reverts commit 47a2d7642d.

Conflicts:

	cui/source/tabpages/transfrm.cxx
	svx/source/svdraw/svdedtv1.cxx
	svx/source/svdraw/svdibrow.cxx
	sw/source/filter/ww1/w1filter.cxx
	tools/source/generic/rational.cxx

Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23 18:34:39 +02:00
Jan Holesovsky
858c2a2977 Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"
This reverts commit 582ef22d3e.

Conflicts:

	svx/source/svdraw/svdedtv1.cxx
	svx/source/svdraw/svdibrow.cxx
	sw/source/filter/ww1/w1filter.cxx

Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23 18:34:34 +02:00
David Tardon
582ef22d3e fdo#84854 it seems long is not enough on 32 bit
Fraction used BigInt internally for computations, rational does nothing
like that.

Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16 17:44:44 +02:00
Juan Picca
47a2d7642d fdo#81356: convert Fraction to boost::rational<long> - wip
* Added rational util functions used by Fraction class not
  available in the boost::rational class.
* Replaced usage of Fraction by boost::rational<long>
* Removed code that relies on:
  1. fraction.IsValid() -- rational only allow valid values, ie
     denominator() != 0
  2. rational.denominator() == 0 -- always false
  3. rational.denominator() < 0 -- always false but implementation
     detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation
* Simplified code that relies on:
  1. rational.denominator() != 0 -- always true
* BUGS EXIST because Fraction allows the creation of invalid values but
  boost::rational throws the exception boost::bad_rational

Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9
Reviewed-on: https://gerrit.libreoffice.org/11551
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-10-09 11:33:33 +00:00
Noel Grandin
8dbde0845a fdo#82577: Handle Region
Put the VCL Region class in the vcl namespace. Avoids clash with the X11
Region typedef.

Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-30 09:58:23 +02:00
Noel Grandin
827c46e7d7 fdo#82577: Handle Window
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
Tor Lillqvist
30ae83c268 fdo#82577: Handle KeyCode
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
Markus Mohrhard
3575dba98d remove whitespaces
Change-Id: I05ef3c1ffd4e2179e0142a21abf8a4578718102e
2014-07-02 23:03:07 +02:00
Markus Mohrhard
7fd1fd1dea remove unneeded code for 3D charts in controller
Change-Id: I5c1f624cc05a90878f717abc8ffb0b2220ce94d5
2014-06-21 04:21:41 +02:00
Caolán McNamara
c4415f16fb coverity#706260 Uncaught exception
Change-Id: Ieef198f6aab05928bf3b77097466eb7ac728481f
2014-05-28 13:49:50 +01:00
Julien Nabet
db3b1dd86e Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part3
Change-Id: Ibabd6d2d5e84fe007364bd1a4182a01ea2352b7a
2014-05-06 22:51:42 +02:00
Noel Grandin
4f9b21248f simplify ternary conditions "xxx ? yyy : false"
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
Thomas Arnhold
97a5ba4a71 remove comments why a file gets included
also remove some commented out code

Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-21 18:08:28 +02:00
Noel Grandin
329332ba52 chart2: sal_Bool->bool
Change-Id: I85751b4e636596ef88ef02bc958abdc6abf98427
2014-04-15 15:23:29 +02:00
Kohei Yoshida
ba1452c261 Several more Window events to intercept for the GL3D chart.
But not painting or resizing events. Those are generic enough that no
branching is needed.

Change-Id: I0fb186da61c583c5326d2608b2153aced3fab77b
2014-04-11 09:36:40 -04:00
Kohei Yoshida
a3354ecf4f Separate mouse event handlers for GL3D bar chart.
They are just skeletons for now.

Change-Id: I7e5e95ad8a2809125cbcf3affd17e663aafa99b0
2014-04-11 09:36:40 -04:00
Kohei Yoshida
6f97be903b Reduce indentation by early bailout.
Change-Id: I64c88b007564d3ca7b4f4bd95a458fee6bda7854
2014-04-10 10:13:54 -04:00
Alexander Wilms
f2cdf8848c Remove visual noise from chart2
Change-Id: Ic8dc71c2815df265e1935e629e0220396a50aaac
Reviewed-on: https://gerrit.libreoffice.org/8239
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-27 00:44:41 -06:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
Tobias Lippert
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
Markus Mohrhard
61e28e86ed add a way to dump chart content to console
CTRL + F12 will dump the chart with the XShapeDumper

Change-Id: I1f40ddf7f51c2038be7af8fc56f626393f11da90
2014-02-06 16:15:05 +01:00
Caolán McNamara
a2a0e1b2a5 coverity#704212 Logically dead code
Change-Id: I1f915b4419ae754a3827c2c662e5799bade66835
2014-01-28 11:29:16 +00:00
Andras Timar
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
Markus Mohrhard
401f01caf5 use ChartModel instead of XModel in a few places
This allows us easier implementation of some advanced features. Mainly
the 4D chartting will now be able to work without several ugly layers of
UNO.

Change-Id: I74d07229eaef921c508f3bab8fae6d6075ad737a
2013-11-19 13:47:36 +01:00
Jelle van der Waa
dd9c97d587 fdo#62475 removed pointless comments
Change-Id: I3f5e86dba2df950aeb12c895f52d99274c0959aa
Reviewed-on: https://gerrit.libreoffice.org/5148
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-07-29 11:34:33 +00:00
Caolán McNamara
5efc15f000 reduce use of UniString from ResID ctor
Change-Id: I8d7619e7807ff2d400ec5c7fd181375130245728
2013-07-28 16:45:48 +01:00