mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
370,076 Commits 1 Branch 0 Tags
2e293978d80c5113ea37f4c7f4b18ee01f2022e1
Commit Graph

125 Commits

Author SHA1 Message Date
Noel Grandin
ba233e87ef remove unnecessary parenthesis in return statements 
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'

Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
 2015-02-23 09:26:58 +02:00
Stephan Bergmann
35ce36b713 Some more loplugin:cstylecast: mysqlc 
Change-Id: I7849658606931b231c2bde0c8143bc1f325c80d4
 2015-01-20 09:06:49 +01:00
Noel Grandin
45ec1d9b56 brute-force find-and-remove of unused #define constants. 
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
 2015-01-08 10:39:36 +02:00
Stephan Bergmann
d5c86be04e No need for RTL_USING in addition to LIBO_INTERNAL_ONLY 
Change-Id: Iaa65658aed6bb4abb20a4d95dc9c6caf7c1c764b
 2014-12-19 14:28:13 +01:00
Stephan Bergmann
6bca90dd62 mysqlc: loplugin:cstylecast 
Change-Id: I293f6fc392f6d081d08d2f53886f534409e38bd5
 2014-12-04 09:36:45 +01:00
Michael Stahl
a0eb1be3a9 mysqlc: fix build after cppuhelper header cleanup 
Change-Id: I8d331914736e17d5aad2ee761fc6d758c2dea1ad
 2014-11-18 23:38:33 +01:00
Brij Mohan Lal Srivastava
d32be3ace8 fdo#86023 - O[U]String needs a 'clear' method 
Added clear() method to OString and OUString class, Updated appropriate call-sites.

Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2014-11-14 09:20:38 +01:00
Noel Grandin
705c48d32e fdo#38835 strip out OUString globals 
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.

Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
 2014-11-05 08:44:19 +02:00
Vinicius Vendramini
5c8ea6d943 fdo#83991 - cleanup whitespace after folding comment removal. 
Change-Id: I31149484d626013ddcd52356be7d416b435cebcc
 2014-10-23 10:39:22 +01:00
Vinicius Vendramini
f73112e229 fdo#83991 - remove redundant function folding comments. 
Change-Id: I630aeedc31099e11d4bd0e91a05943e926efd61e
 2014-10-22 12:03:35 +01:00
Stephan Bergmann
2bb99ca189 mysqlc: These shall be plain "Time" not "tools::Time" apparently 
Change-Id: Id96a75bb8a07ea3b9701b9fe4692dfc81dbd8295
 2014-10-01 10:35:31 +02:00
Noel Grandin
fc04f76336 fdo#82577: Handle Time 
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-01 07:34:23 +00:00
Stephan Bergmann
f94fffaf52 mysqlc: std::auto_ptr -> std::unique_ptr 
Change-Id: I0eb5f9fab5955d1f5790d3f5d269e069aff1c201
 2014-09-30 12:28:53 +02:00
Stephan Bergmann
9703cc63ce Remove o3tl/heap_ptr.hxx, use std::unique_ptr instead 
Change-Id: Iac70c9be13892a36bfb5975f62e5345b88d4f144
 2014-09-24 14:54:51 +02:00
Michael Meeks
be75acefbc Translate German comment. 
Change-Id: I3d452ac218005b40568ec116ede9962cc1e60a18
 2014-09-17 14:11:17 +01:00
Stephan Bergmann
dbf99dfb98 mysqlc: sal_Bool -> bool 
Change-Id: Ie479e1671b03fbb958886d4c01ecff41b2ad1d23
 2014-07-02 08:42:58 +02:00
Noel Grandin
6b50e21473 deb#749592 mysql-connector doesn't work with remote connections 
and also
fdo#77584 mysql-connector doesn't work over SSH tunnel

Not sure exactly how this got broken, I suspect that the UI code
has started unconditionally passing down the properties, just filling
them with empty spaces for the unused ones.

Anyhow, this appears to fix the problem.

Change-Id: I7ac2a0d6bae610f47d2a28daa9beb3ef0e2dbb52
Reviewed-on: https://gerrit.libreoffice.org/9565
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-05-30 08:24:31 -05:00
Noel Grandin
624a116d14 use OUString::startsWith() 
Change-Id: I0fc77b50792e48be175ab7cc151509e097676849
 2014-05-29 09:01:40 +02:00
Noel Grandin
ebc0a15515 remove more unnecesary OUString constructor use 
when throwing exceptions

Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
 2014-05-29 09:01:40 +02:00
Julien Nabet
ac76cc7e60 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20 
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
 2014-05-23 22:11:52 +02:00
Julien Nabet
aa214079b4 Kill DECL_PROP1IMPL and related 
See http://nabble.documentfoundation.org/About-removing-macros-td4106620.html

Change-Id: Ib934eb3f27b656b5b2f8488c2103e8eee73f9623
 2014-05-11 22:52:24 +02:00
Noel Grandin
794f09f195 simplify ternary conditions "xxx ? true : yyy" 
Look for code like:
   xxx ? true : yyy;
Which can be simplified to:
   xxx || yyy

Change-Id: Ib7ca86580bfd0cf04674328a3c0cf3747de4758d
 2014-05-06 07:45:25 +02:00
Thomas Arnhold
8bb2ce61c0 fixincludeguards.sh: some smaller dirs 
Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
 2014-04-19 11:10:13 +02:00
Stephan Bergmann
b154c61766 Do not use sal/log.hxx in extensions 
"For now, this functionality should only be used internally within LibreOffice.
It may change again in a future version." (sal/log.hxx)

And the condition that was checked already causes a RuntimeException, so was
somewhat redundant anyway.  Thanks to mstahl for spotting this.

Change-Id: I51cc4e75b3d3ffc97943613c61cb93c1fb48e59b
 2014-04-07 13:39:09 +02:00
Michaël Lefèvre
453ee351f3 fdo#43157 : clean up more OSL_POSTCOND 
Change-Id: Iaca31b4e12c258b762b3d88fbad0fb08b4f1fc16
Reviewed-on: https://gerrit.libreoffice.org/8832
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-04-04 07:23:43 -05:00
Stephan Bergmann
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
 2014-03-26 16:39:26 +01:00
Marcos Paulo de Souza
4d6560f506 fdo#54938: Convert some places to use cppu::supportsService 
The last cases are non obvious, so it's pratically done

Change-Id: Icae1da8e238f516eaed0f7fbdf96fff778eac547
Reviewed-on: https://gerrit.libreoffice.org/8445
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
 2014-03-04 07:30:02 -06:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexander Wilms
5d70084bc6 Remove visual noise from mysqlc 
Change-Id: I5ee918bb193ea887e728e271dd4c0fb49a4dd6e9
Reviewed-on: https://gerrit.libreoffice.org/8282
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-26 10:07:23 -06:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Stephan Bergmann
01b7bab713 auto_ptr -> heap_ptr 
Change-Id: I1b11593fc936c0a4b45c319fd73ef3b629950752
 2014-02-03 11:15:56 +01:00
Stephan Bergmann
9072e25992 auto_ptr -> scoped_ptr 
Change-Id: I878aae330a3b1658c8bca83bd8a1126d2a8d26b6
 2014-02-03 11:15:56 +01:00
Stephan Bergmann
c2c9e3969c USE_CPP_CONN is unused 
...ever since 4946c62f29 "mysqlconnector: initial
import from CWS mysqlnative"

Change-Id: I787d2ac5e48be307f47e41ecac907c36b07a92ea
 2014-02-03 11:15:56 +01:00
Stephan Bergmann
396248a6bf Get rid of macros 
Change-Id: Ic43441201309c3b466ed3dc7a5e85d0d006c0e44
 2014-02-03 11:15:55 +01:00
Stephan Bergmann
22c6d5739e Fix typos 
Change-Id: I0314d439412e9fcc0fbc6a7702e5ec3cddafc0c5
 2014-02-03 09:47:44 +01:00
Alexandre Vicenzi
32b8c5c4a9 fdo#54938 Convert basctl, mysqlc, sdext, svgio, writerp. to cppu::supportsSer. 
Change-Id: I60128dbb5bf83f25eea847fe655d7126c9077414
Reviewed-on: https://gerrit.libreoffice.org/7756
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Souza <marcos.souza.org@gmail.com>
 2014-02-02 18:53:03 +00:00
Andras Timar
b55259eeb5 typo fixes 
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
 2013-12-20 15:55:00 +01:00
Stephan Bergmann
fa2a7c1c95 Keep using component_getImplementationEnvironment in extensions 
...instead of relying on the implicit CPPU_CURRENT_LANGUAGE_BINDING_NAME
convention.  Keeping that convention an implementation detail makes it easier to
do improvements in the future.  (Theoretically, the bundled extension in mysqlc
could be considered internal code and not adapted, but just be safe.)

Change-Id: Iae41a6e072dabc2bf7c1481ba6cfed61680edf37
 2013-12-17 11:05:59 +01:00
Noel Grandin
08fe82e59c Remove unnecessary use of OUString constructor in + expressions 
Convert code like
  aFilename =  OUString::number(nFilePostfixCount) + OUString(".bmp");
to
  aFilename =  OUString::number(nFilePostfixCount) + ".bmp";

Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
 2013-12-17 11:49:03 +02:00
Takeshi Abe
dae9b7060d Drop duplicate #include 
Change-Id: Ib8969d5cd4898b81a5dcd90dc313abd28adfe052
 2013-12-10 15:52:49 +09:00
Noel Grandin
610b2b94b3 remove unnecessary use of OUString constructor when assigning 
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
 2013-11-19 10:29:31 +02:00
Noel Grandin
d366c9b20e remove unnecessary sal_Unicode casts in various places 
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
 2013-11-14 08:17:32 +02:00
Noel Grandin
ef90021abe convert OUString !compareToAscii to equalsAscii 
Convert code like
   if( ! aStr.compareToAscii("XXX") )
to
   if( aStr.equalsAscii("XXX") )
which is both clearer and faster.

Change-Id: I267511bccab52f5225b291acbfa4e388b5a5302b
 2013-11-11 12:58:12 +02:00
Noel Grandin
e52779d2f8 remove unnecessary use of OUString constructor 
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
 2013-11-11 11:21:26 +02:00
Lionel Elie Mamane
02a11749da fdo#70496 revert to using libmysqlclient 
Change-Id: I5b98b5e7840e4f1c6005aee0c1f43ef814ecf77b
 2013-10-19 23:03:14 +02:00
Thomas Arnhold
67aec43915 cleanup 
Change-Id: I7bfd221f89718ba8634417c93a26b3a199178694
 2013-10-16 05:41:26 +02:00
Stephan Bergmann
3bafe5f5f5 Extension shared library components must not use the "prefix" feature 
...at least no non-bundled ones, see 9dfcee9266c9769153444cdcd4ab0e6e636c3eb6
"Not being able to honor a 'prefix' is a rather hard error" and the description
there how that can lead to a crash when using mysql-connector-ooo.oxt:  "'rm -rf
instdir/*/share/extensions/mysql-connector-ooo', 'instdir/*/program/soffice
workdir/*/Extension/mysql-connector.oxt', install the [extension] per-user, then
'File - New - Database - Connect to an existing database: MySQL - Next >> -
Connect directly - Next >> - Database name: foo - Server / Port - Server: bar -
Next >> - Test Connection', crash."

This is a partial revert of cd79d51420 "prefix all
component_getFactory methods."

Change-Id: Ia7a6272eb0597e3b3bbf4ab333174b3232448539
 2013-10-11 15:03:11 +02:00
Andrzej J.R. Hunt
3f31bdd67a Update mysqlc's ColumnLocate::findColumn to throw for invalid column. 
(This is to comply with the updated API specification.)

Change-Id: I4542fecc78a6e64011276dafc72c31d5533af1ab
Reviewed-on: https://gerrit.libreoffice.org/5923
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
 2013-09-12 17:26:27 +00:00
Thomas Arnhold
ba0a57702c remove OUString wrap for string literals 
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-06-29 21:52:54 +00:00
Stephan Bergmann
8a8b1ae3e9 Some more toInt32 clean up 
Change-Id: I4f7911cb283d67e7c7b883d629b39588e96f32c2
 2013-06-14 18:33:07 +02:00