This patch adds support for 'Table Row Redlines' (such as 'table row inserted'
or 'table row deleted' in SW core).
This is done by adding a new object called 'SwExtraRedlineTbl' that holds all
the redlines that are not of type 'SwRangedRedline'.
Also this patch adds a function for adding these types of redlines to the
'SwExtraRedlineTbl' object.
It also further develops the 'SwTableRowRedline' object.
Change-Id: Ic285f33e4f5af8f197d8fc24c2a8a3777755afad
Reviewed-on: https://gerrit.libreoffice.org/7821
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
...from 2bf2dee04c "Werror=strict-overflow." The
warning (generated e.g. by --disable-debug --disable-dbgutil builds with
GCC 4.8.2) orginates from the call to
InvalidateRange( SwCharRange( GetOfst(), COMPLETE_STRING ) );
in SwTxtFrm::Prepare further down in txtfrm.cxx, which inlines the IsIdxInside
code to
if( GetOfst() > GetOfst() + COMPLETE_STRING )
where COMPLETE_STRING is SAL_MAX_INT32. The problem is that before
ba27366f3d "Resolves: #i17171# Writer paragraph
cannot be longer than 65534 characters" that code would inline to
if( GetOfst() > GetOfst() + STRING_LEN )
where STRING_LEN was 0xFFFF, so the calculation on effectively 16-bit quantities
stayed nicely in the bounds of (32-bit) int.
Change-Id: I958514e52e9102236844eefa4fe92a401be6ab01
This handler will process 'track changes' information for 'extra' redline
objects (such as 'table row insert\delete' redlines)
Reviewed on:
https://gerrit.libreoffice.org/7802
Change-Id: I8dd0bd70dbdcb3cb7eae76595957817de08c66fc
...so no need to return non-empty SunInfo::getLibraryPaths (for the Oracle JRE,
cf. how this had always returned an empty set for the Apple JRE in
otherjre.cxx).
This fixes the bug that selecting the Oracle JRE in the Advanced options pane
didn't stick, because jfw_areEqualJavaInfo was called on a JavaInfo read back
from XML where nRequirements had been cleared (in CNodeJavaInfo::loadFromNode)
and a JavaInfo where non-empty SunInfo::getLibraryPaths ->
VendorBase::needsRestart() == true -> nRequirements == JFW_REQUIRE_NEEDRESTART,
so always returned false.
(There's multiple errors here. It is questionable whether jfw_areEqualJavaInfo
should take nRequirements into account, at least when used from
SvxJavaOptionsPage. And VendorBase::getLibraryPaths appears to be only used to
compute VendorBase::needsRestart, ignoring the actual path data. But leave that
for future clean-up.)
Change-Id: I5f004434b1cb7e909a153c43c474a2317f24b0c1
We should survive without deployment_component_getFactory,
although Android build may need some changes.
ContextChangeEventMultiplexer seems to be useful.
Change-Id: I20544429425675449ad0471190968c5bfb97bbf9
Currently a mail merge loads the styles from the source document
and also loads the original source per mail merge dataset.
The new code is based on the MergeDocuments function and swaps the
loading with an internal document copy to improve mail merge
throughtput.
For a mail merge with 99 datasets and a two pages document,
callgrind shows an improvement from routhly 44 to 31 billion
inclusive instructions for the single SwXMailMerge::execute call.
Change-Id: I6929ba371f81c3ea1f26ea3a25e7751bc53256e3
Reviewed-on: https://gerrit.libreoffice.org/7433
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Add stub derived class 'SwTableRowRedline' that will hold information
about the table row that got the changes, including the actual change
that was done (inserted\deleted).
Change-Id: I8b6ef9da3f3d9859a1e908dbcc018bc5c54b8329
Reviewed-on: https://gerrit.libreoffice.org/7466
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Added a new redline object for non-ranged redlines called 'SwExtraRedline'.
Examples for such redlines are 'table row was inserted \ deleted',
'table properties changed', 'text was moved' etc.
Also - added a table for these redlines called 'SwExtraRedlineTbl'.
Change-Id: I9190093c97108b7e4923bc8a9feb441ad5c5694f
Reviewed-on: https://gerrit.libreoffice.org/7464
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
when breaking links to graphic contents in Writer
(cherry picked from commit a9325263271883fb147351d287c817ea7984fbe9)
Conflicts:
sw/source/core/graphic/ndgrf.cxx
Change-Id: I86e2b80b95f4e26a734f56d060f97e6430ae56b8
This reverts commit 138bd3d656. See
comment 5 in the bugreport, the fix in its current form causes more
trouble than it fixes.
Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport.cxx
Change-Id: I64f64f02a2e073b96e165c81bd2f85928e5527bc
