mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
349,320 Commits 1 Branch 0 Tags
2fc50ff8bea6f64b367d44a1760b8dd9fb69a401
Commit Graph

232 Commits

Author SHA1 Message Date
Valentin Kettner
061130bd6d fdo#75280 Started cleaning up of sal_uIntPtr usage. 
Converted wrong usage of sal_uIntPtr to appropriate other types in basic
module.

The bug is not fully fixed with this since many other occurences of sal_uIntPtr remain.

Update due to code review comments:
Fixed forgetting to change some declarations in iosys.cxx.
Cleaned up the one remaining sal_uIntPtr in iosys.cxx
Fixed adding a sal_uInt64 to a Date (uses long now instead) in methods.cxx
Fixed the VarDecFromUI4 call in sbxdec.cxx from sal_uLong to ULONG .

Conflicts:
	basic/source/runtime/iosys.cxx

Change-Id: Ia6460be04967deb68b92eb62d945da8814fae605
 2014-03-28 20:08:46 +01:00
Takeshi Abe
dd52330db6 Avoid possible resource leaks by boost::scoped_array 
Change-Id: I14e1f7ef217eb5e8e9db9f8962af868ab0a4ab81
 2014-03-25 20:08:26 +09:00
Noel Grandin
39c7532933 basic: prefer passing OUString and OString by reference 
Change-Id: I8121204cdb37d4e1d8967397f3e45bdab6aaddad
 2014-03-13 08:39:26 +02:00
Alexander Wilms
6a38eace8c Remove visual noise from basic 
Change-Id: I10865b94f67de39e9dbcbe71ede42aa94d81db61
Reviewed-on: https://gerrit.libreoffice.org/8234
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-25 21:09:17 +00:00
Norbert Thiebaud
295bc8703f basic: remove use of sal_uIntptr in favor of more appropriate type 
Change-Id: Ie878f43c7245838519fe7477b039827b079dde63
Reviewed-on: https://gerrit.libreoffice.org/8214
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2014-02-25 00:26:43 +00:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Noel Grandin
15535e32dd convert SvStream::operator>> methods to ReadXXX methods 
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".

Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2014-02-12 15:31:40 +00:00
Stephan Bergmann
f96f38f8f8 bool improvements 
Change-Id: I571354540f1ab108c55d32c20786d34a799c3bed
 2014-01-28 20:26:30 +01:00
Julien Nabet
ff48f28f71 Resolves: fdo#73771 Non-standard behaviour for Function Mid 
Change-Id: I90be516235228574dc219447a0eef3a34f83bee2
Reviewed-on: https://gerrit.libreoffice.org/7539
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-01-21 15:50:51 +00:00
Noel Grandin
c648d08720 convert SvStream::operator<< overloads to more explicit methods 
This is in preparation for more conversion of SvStream::operator<< calls
to use more explicit method names.
This converts the subclasses that have their own convenience overloads
of operator<< to use normal methods.

Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
 2014-01-16 16:08:34 +01:00
Stephan Bergmann
0d29aab156 bool improvements 
Change-Id: Ic9ea40c430e0b0ab0d46bac3ba150ddac96c6acc
 2014-01-14 18:11:10 +01:00
Tor Lillqvist
d76178b52d sbstdobj.hxx is private to basic 
Change-Id: I131dfeded783edfea94208d1cf8d70a2090785fa
 2013-12-11 10:48:12 +02:00
Tor Lillqvist
0a33e24d11 sbobjmod.hxx is private to basic 
Change-Id: I4ad28b049de5f7268ee1ca2e8992e2f29ed05380
 2013-12-11 10:39:57 +02:00
Herbert Dürr
3a437baee2 Resolves: #i74854# fix buttons in MsgBox with info icon 
Patch by: hanya.runo@gmail.com
Found by: ooo@catcons.co.uk
Tested by: hdu@apache.org

(cherry picked from commit 02cc651a1b45cbfbdab0aca6b57bff7bdf9e4f2c)

Conflicts:
	basic/source/runtime/methods.cxx
	vcl/inc/vcl/msgbox.hxx

Change-Id: I1656263e189f1a6cfa58436741bfa74ae0e6fffa
 2013-12-02 16:45:50 +00:00
Noel Grandin
e9c4ee996d remove unnecessary use of OUString constructor in BASIC module 
Change-Id: Iee86ce9200285647d5031cb2f89266a52704dd44
 2013-11-11 11:21:25 +02:00
Tor Lillqvist
a7724966ab Bin comments that claim to say why some header is included 
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
 2013-10-22 16:56:28 +03:00
Tor Lillqvist
b680e35254 Test WNT instead of the vague UNX 
Change-Id: Icacdae592f05bcdcf50223d607976d687e182c96
 2013-10-12 09:55:48 +03:00
Caolán McNamara
d22fb8a608 CID#1103740 uninitialized value 
Change-Id: I2d10104277d8ad0781e3dd088d51d62fa759fe57
 2013-10-11 09:12:38 +01:00
Noel Grandin
41dec09ed3 convert BASIC from String to OUString 
Change-Id: I4b046e4c460305acad29862341092af948639215
 2013-09-17 09:05:52 +02:00
Lionel Elie Mamane
b31f33bcc1 Easier conversion between Basic Date and UNO Date/Time 
Utility functions to convert between Basic Date type
and the representations of Date and Time in UNO, namely:
 - com.sun.star.util.Date
 - com.sun.star.util.Time
 - com.sun.star.util.DateTime

Name of new functions:
 - CDateToUnoDate
 - CDateFromUnoDate
 - CDateToUnoTime
 - CDateFromUnoTime
 - CDateToUnoDateTime
 - CDateFromUnoDateTime

Change-Id: I2b971df20df1c0351d071023e042169b548894f1
Reviewed-on: https://gerrit.libreoffice.org/5897
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
 2013-09-11 20:40:19 +00:00
Luboš Luňák
64b993e046 finish deprecation of O(U)String::valueOf() 
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
 2013-08-21 15:10:35 +02:00
Lionel Elie Mamane
5e505896a5 Basic: make sure a messagebox has solarmutex 
Change-Id: Icc5f05456e4031ffbc88d6128689465f08eb5f0d
 2013-07-29 15:27:46 +02:00
Lionel Elie Mamane
e436c49188 fixup nanosecond precision 
This was broken before...
Time used to take centiseconds, so the nanoseconds should have been *divided* by 10^7 for conversion.
Now Time takes straight nanoseconds, so no conversion necessary.

Change-Id: Ibac3eeca7020c5d8c5ff4be3e7617fac26ee8180
 2013-07-05 12:22:03 +02:00
Armin Le Grand
e0cce521f1 Resolves: #i121504# Support for alpha channel in clipboard for all systems 
(cherry picked from commit ef3931ff410117e1237b3bef7bc090e8b83b9519)

Conflicts:
	automation/source/server/statemnt.cxx
	basic/source/runtime/methods.cxx
	canvas/source/vcl/devicehelper.cxx
	canvas/source/vcl/spritedevicehelper.cxx
	drawinglayer/source/processor2d/vclhelperbufferdevice.cxx
	drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
	drawinglayer/source/tools/converters.cxx
	dtrans/source/win32/dtobj/FmtFilter.cxx
	editeng/source/items/bulitem.cxx
	extensions/source/scanner/sanedlg.cxx
	external/gcc3_specific/makefile.mk
	filter/source/graphicfilter/eos2met/eos2met.cxx
	filter/source/graphicfilter/ios2met/ios2met.cxx
	filter/source/msfilter/msdffimp.cxx
	fpicker/source/office/iodlg.cxx
	framework/source/fwe/classes/addonsoptions.cxx
	framework/source/fwe/helper/actiontriggerhelper.cxx
	sc/source/filter/excel/xiescher.cxx
	sc/source/ui/docshell/docsh.cxx
	sc/source/ui/inc/viewfunc.hxx
	sd/source/ui/app/sdxfer.cxx
	sd/source/ui/unoidl/unopage.cxx
	sd/source/ui/view/sdview3.cxx
	sfx2/source/appl/fileobj.cxx
	sfx2/source/appl/linkmgr2.cxx
	sfx2/source/dialog/filedlghelper.cxx
	sfx2/source/dialog/intro.cxx
	sfx2/source/doc/docinf.cxx
	sot/inc/sot/formats.hxx
	sot/source/base/formats.cxx
	svtools/bmpmaker/bmpcore.cxx
	svtools/bmpmaker/bmpsum.cxx
	svtools/inc/svtools/transfer.hxx
	svtools/source/filter/filter.cxx
	svtools/source/filter/wmf/emfwr.cxx
	svtools/source/filter/wmf/enhwmf.cxx
	svtools/source/filter/wmf/winwmf.cxx
	svtools/source/filter/wmf/wmfwr.cxx
	svtools/source/graphic/graphic.cxx
	svtools/source/graphic/provider.cxx
	svtools/source/misc/transfer.cxx
	svx/inc/svx/xoutbmp.hxx
	svx/source/sdr/overlay/overlaymanagerbuffered.cxx
	svx/source/xoutdev/_xoutbmp.cxx
	sw/source/core/view/viewsh.cxx
	sw/source/filter/ww1/w1filter.cxx
	sw/source/filter/ww8/ww8par.hxx
	sw/source/ui/dochdl/swdtflvr.cxx
	toolkit/source/awt/vclxbitmap.cxx
	toolkit/source/helper/vclunohelper.cxx
	vcl/Library_vcl.mk
	vcl/Package_inc.mk
	vcl/aqua/source/dtrans/DataFlavorMapping.cxx
	vcl/aqua/source/dtrans/OSXTransferable.cxx
	vcl/aqua/source/dtrans/PictToBmpFlt.cxx
	vcl/aqua/source/dtrans/PictToBmpFlt.hxx
	vcl/inc/vcl/alpha.hxx
	vcl/inc/vcl/bitmap.hxx
	vcl/inc/vcl/bitmapex.hxx
	vcl/inc/vcl/pngwrite.hxx
	vcl/inc/vcl/salbtype.hxx
	vcl/inc/vcl/wall.hxx
	vcl/source/gdi/animate.cxx
	vcl/source/gdi/bitmap2.cxx
	vcl/source/gdi/bitmapex.cxx
	vcl/source/gdi/bmpconv.cxx
	vcl/source/gdi/cvtsvm.cxx
	vcl/source/gdi/impgraph.cxx
	vcl/source/gdi/impimagetree.cxx
	vcl/source/gdi/metaact.cxx
	vcl/source/gdi/wall.cxx

Change-Id: I79938bc412c048c3d4e64f430f216e73bec16167
 2013-06-13 14:50:46 +01:00
Caolán McNamara
5405451440 bogus TRUE/FALSE -> sal_False/sal_True 
Change-Id: I72e0b6b3261422bd5fc47445d38cc64241d62362
 2013-05-29 12:58:47 +01:00
Noel Power
1755091764 fix wildcard handling regression( for basic functions like Dir ) fdo#64536 
Tweak another fallout from String->OUString

Change-Id: I3932bdb441fe6b08cefa6331870956664ade77bd
 2013-05-20 12:19:36 +01:00
Tor Lillqvist
cb6d67c21f Spelling "separate" (etc) correctly is hard 2013-05-15 11:14:28 +03:00
Noel Power
894a0348dc fix VBA mode MkDir when passed folder is not a full path 
Change-Id: I7fd804999f1b96e6aab112445edcd9dcf7753c24
 2013-05-09 14:11:21 +01:00
Thomas Arnhold
1e83da9aed some more namespace cleanup 
Change-Id: Ib1e80d717f199db8f8ac4181d4377a86d88e3244
 2013-04-26 18:01:51 +02:00
Marcos Paulo de Souza
0f200cc30e fdo#63154: Change Min/Max/Abs for std::min/max/abs 
Now all these usages were removed from LO.

Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Reviewed-on: https://gerrit.libreoffice.org/3326
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
 2013-04-20 11:09:54 +00:00
Lionel Elie Mamane
9830fd36db date/time IDL datatypes incompatible change 
- nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
 2013-04-18 21:34:46 +02:00
Stephan Bergmann
52ede08a65 -Werror=unused-macros (MinGW, GradientStyle_RECT) 
...hopefully unnecessary today anyway?

Change-Id: Ib3c621f46311c90d159fe0f08655c01d25024d7d
 2013-04-17 11:51:13 +02:00
Eike Rathke
876c619b94 new module i18nlangtag 
Moved portions from module i18npool, all of former i18nisolang1 library
that now is i18nlangtag. Included are languagetag, isolang and mslangid.

This i18nlangtag code is now even used by module comphelper, so
disentangling i18npool and making this an own module was needed to not
create circular module dependencies.

Change-Id: Ib887c3d6dde667403fd22d382310ba5f1a9b0015
 2013-04-05 19:10:48 +02:00
Thomas Arnhold
47664d3f2e fdo#58807 bring Beep() for basic back 
The functionality was removed by fdo#48549.

This partially reverts

0f6101cfef
0bdf6fc7c7
85cb908453

I changed the behavior to always beep, because only the basic macro
function is using Beep(). Looks like the Beep macro function didn't
even work correctly before the removal, because the default was to
not beep for most platforms. So I set the volume from disable (0)
to 50% for XBell().

Change-Id: I663ffb7af75d2fd6d2c1f94073e4412d9744de4a
Reviewed-on: https://gerrit.libreoffice.org/3124
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>
 2013-04-03 10:24:40 +00:00
Stephan Bergmann
aa753f01ba -Wunused-macros 
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
 2013-03-27 09:36:53 +01:00
Thomas Arnhold
7f4a34e314 basic: Remove non working AboutStarBasic 
The content of this function was commented out since the first import. So as it does nothing remove it.

Change-Id: Ia46674f7bdc12e80d61a8142697e875f5c58f482
Reviewed-on: https://gerrit.libreoffice.org/2899
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
 2013-03-24 14:49:52 +00:00
Julien Nabet
97fa9a882c coverity#704205/704206/704207 Logically dead code 
Change-Id: Ic2cbd96f393a21cf2c6634d3c5e5a4c5a5b486ef
 2013-03-23 14:13:20 +01:00
Eike Rathke
e8638ad5a7 in Val() check status after stringToDouble() 
instead of calling checkArithmeticOverflow()

Change-Id: I2e3307ee054db77bab0a106d886823dba9e56ea8
 2013-03-22 17:47:17 +01:00
Andras Timar
5f0ad2a5ac windows build fix 
Change-Id: I6ff724052660d73b583fb1e44265a60a6fa4379f
 2013-03-19 23:01:16 +01:00
Andras Timar
438efb38ec fdo#39445 writing out tools/fsys.hxx (basic) 
Change-Id: I2ec7546572fa72359615f371715b4aa82b1182ca
 2013-03-19 22:42:02 +01:00
Noel Power
0054b43801 follow on fix for fdo#62090 ensure out of range startpos is handled 
Change-Id: Ic1f57480a36415998748faeea3b606a47d277181
 2013-03-19 15:59:21 +00:00
Noel Power
205277f5e6 remove commented out line I inserted to screw up Juliens patch 
Change-Id: I7f874267a640a7cc754eb7477b764f7546fdc5ea
 2013-03-19 15:48:39 +00:00
Julien Nabet
14d452d0c2 fix for fdo#62090 Mid function regression 
Change-Id: Ia6a73d6a44a34345b512922037d01b8b40ac24a8
 2013-03-19 15:45:56 +00:00
Takeshi Abe
ce33f85ffd sal_Bool to bool 
Change-Id: I8c554fb3faead41c974af9c2a89728bd0bdf5eb6
 2013-03-04 23:14:41 +09:00
Thomas Arnhold
26e37ca4c7 doubled includes 
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e
 2013-03-04 13:58:40 +01:00
Thomas Arnhold
405caad685 loplugin: unused variables 
Change-Id: I46a748bf2c54d15c0f5718901197f3b4c34b82bf
 2013-02-25 03:14:00 +01:00
Julien Nabet
3a014901fd Fix typo seperated/separated 
Change-Id: I133423de994b1befe246b6c921802428a3528202
 2013-02-23 17:20:45 +01:00
Norbert Thiebaud
558e956403 coverity#704204 Logically dead code 
Change-Id: I0a8dbbb3dbe7408e6f4d92c0bbebdaaa7d882f01
Reviewed-on: https://gerrit.libreoffice.org/2271
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2013-02-22 07:53:22 +00:00
Caolán McNamara
9a55875ef4 coverity#707496 Uninitialized scalar variable 
also...
 coverity#707497 Uninitialized scalar variable

Change-Id: Ie3ac361685a52b23e088b78404ea4e013407fe2a
 2013-02-17 09:10:52 +00:00
Noel Grandin
f95a7c2c6d fdo#46808, Convert SvNumberFormatter to use XComponentContext 
Change-Id: If4e8312dae6bc5eb8bb7655cf250f06ab37b7e5c
 2013-01-28 08:25:24 +02:00