Commit Graph

341 Commits

Author SHA1 Message Date
Anderson Roberto
330c6cb59a fdo#57950: Remove chained appends in accessibility
Change-Id: I4ba583a891933068ab4003307d09693180c7b61f
Reviewed-on: https://gerrit.libreoffice.org/7436
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-01-15 10:47:57 +00:00
Michael Stahl
158b4df603 svtools: rename IAccessibleTableControl::dispose()
... to not confuse it with XComponent::dispose().

Change-Id: I056fdf77f9116d1c22f8ca9313a0ea313fb1c4aa
2013-12-16 16:21:09 +01:00
Michael Stahl
449e0c9c73 accessibility: don't crash if the TableControl is dead
AccessibleGridControlAccess: clear the m_pTable member in dispose() so
it is no longer accessed later.

Change-Id: I490c84ce1bee55c9c69eb29b81ddfbe808301797
2013-12-16 16:21:09 +01:00
Michael Stahl
9eccfd86ee accessibility: Mutex cleanup in AccessibleGridControl* classes
For unknown reasons this uses both SolarMutex and a OBaseMutex::m_aMutex
to lock some but not all methods, which seems odd.

- remove a third mutex AccessibleGridControl::m_aMutex that appears
  unused
- lock OBaseMutex::m_aMutex in AccessibleGridControlBase::isAlive()
  which accesses rBHelper members, which should be sufficient
- lock SolarMutex in all UNO methods
- remove misc weird stuff like TC_SolarMethodGuard

Change-Id: I8321757fb4a5043a05c23f2dc9801f5d8c8d911e
2013-12-16 16:21:08 +01:00
Herbert Dürr
5585c4f2bf Related: #i123768# [ia2] remove pseudo-automatic noisy comments
Change-Id: I346518267294556ce529966fe168440de05a38c6
2013-11-28 14:33:55 +00:00
Stephan Bergmann
382421189f Improve exception message
Change-Id: I06ffe3088546d55b29d61ccfae16937d8a7ce9e8
2013-11-27 09:15:14 +01:00
Stephan Bergmann
1533129759 Revert sense in VCLXAccessibleBox::getAccessibleActionCount again
...this had been switched from "m_bIsDropDownBox ? 1 : 0" to "m_bIsDropDownBox ?
0 : 1" in efb23f2998 "Integrate branch of
IAccessible2" for no apparent reason and broke JunitTest_testtools_unoapi.

Change-Id: I276d2f452648387a5fa693349cf868787b2d48e1
2013-11-27 09:12:38 +01:00
Stephan Bergmann
62fcdfa34a -Werror,-Wunused-private-field
...fixed more thoroughly than 49c1964b42 "WaE:
private field 'm_bCompoundControlChild' is not used."

Change-Id: Ief1093c054fe272b82da78ab103e8ca3feb72b90
2013-11-26 15:56:33 +01:00
Tor Lillqvist
49c1964b42 WaE: private field 'm_bCompoundControlChild' is not used
Change-Id: I656c044de766e274f4938facc3a85b6152ba79ed
2013-11-26 16:11:36 +02:00
Stephan Bergmann
383c7a4b90 statement aligned as second statement in if body but not in a statement block
Change-Id: I237148ec56164994e5c3168ef5b7dfc56588cad9
2013-11-26 14:41:27 +01:00
Stephan Bergmann
cbb8e6d1b6 -Werror,-Wunused-variable
Change-Id: I4a501430d6ea8fdf6d2ae748fd3e122846c0b4cd
2013-11-26 14:34:33 +01:00
Tor Lillqvist
378963fdb2 WaE: unreachable code
Change-Id: I21cce258c0cc978bd8a45148102787d3c4017e64
2013-11-26 15:14:46 +02:00
Caolán McNamara
e579d45354 Document::ProcessWindowEvent now just forwards to baseclass
Change-Id: Ia4c224105e15c8eea90a9c98161981ff10661044
2013-11-26 10:24:30 +00:00
Steve Yin
efb23f2998 Integrate branch of IAccessible2
(cherry picked from commit e2f90c93c97f3cf137c348ed302c6470f398aa70)

Change-Id: I44ce0d69f3e7364038b00b1ba0f0d27e60132a37

WaE: Prevent uninitialized variable warnings.

(cherry picked from commit b989f4074ea70729d527b307bfbe49e01a0d3646)
2013-11-26 10:24:24 +00:00
Noel Grandin
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
Andrzej J.R. Hunt
2549be5a75 Add namespace to accessbility's TkResMgr.
Previously this conflicted with include/toolkit/helper/tkresmgr.hxx,
breaking the Android build.

Change-Id: I195e18e42a5978fd7d415a8afaa007b3bee33190
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-11-15 10:31:35 +01:00
Michael Stahl
4fc7deb7b0 fix STL assert in accessibility::AccessibleGridControl::commitTableEvent
While running some JunitTest, crashes on an attempt to delete entries
of an empty vector m_pImpl->m_pTable->m_pCellVector.

The entries are created on-demand by
AccessibleGridControlTable::getAccessibleChild(), so presumably that
hadn't been called yet when the rows were deleted.

Also fix bizarre abuse of all applicable variable naming conventions.

(regression from 2095b2e1d4)

Change-Id: Id2d70ca4601a166718629c0fe922f805dd72eec1
2013-10-04 14:46:24 +02:00
Michael Stahl
da21e9de6a require OAccessibleContextHelper to be initialized with SolarMutex
OAccessibleContextHelper methods are locked by OExternalLockGuard
which effectively only locks its ExternalMutex (i.e. SolarMutex);
so ensure that all sub-classes actually pass in a SolarMutex
by removing the default constructor.

(since these classes are in comphelper they can only use the
SolarMutex indirectly)

This uncovers that AccessibleToolPanelDeckTabBarItem and
OAccessibleControlContext did not pass in SolarMutex before.

Change-Id: Ib9085eeee6225f7c74b158e72f04b1bf62622071
2013-10-04 14:46:24 +02:00
Noel Grandin
e6d91ff224 convert ACCESSIBILITY module from String to OUString
Change-Id: Ia4d2e1feef575cb911e981fbb8b6359755ab0dd9
2013-09-17 09:05:40 +02:00
Noel Grandin
c9eb7eefd1 covnert vcl/texteng.hxx from String to OUString
Change-Id: Iaa2dca415b30cae436173df27058c9d3e3755efd
2013-08-12 11:56:39 +02:00
Jan Holesovsky
7cfd340e92 Fix crash & reduce nesting.
Change-Id: Ifbfe401cd69678c278394d190a37cc41a28d5c56
2013-07-17 13:27:46 +02:00
Jelle van der Waa
126827b0fd fdo#43460 framework,i18npool,accessibility: use isEmpty()
Change-Id: I4cd9841127b1d4a294d7f001b646259c61eb1172
Reviewed-on: https://gerrit.libreoffice.org/4443
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-06-24 21:45:42 +00:00
Michael Stahl
35b45e6915 VCLXAccessibleTabPageWindow: unhandled IndexOutOfBoundsException
... due to GetPagePos returning -1, work around that (can be easily
triggered in template manager).

Change-Id: Ic1334b224730d79e533539a24f115dc9aa2e9570
2013-06-20 17:01:32 +02:00
Noel Grandin
95c0d568fd use uno::Reference#clear() method...
...instead of assigning an empty value. Reduces code noise.

Change-Id: Ic95b081a41fb740a738c92b3407a9514ccb8b06e
2013-06-05 08:13:23 +02:00
Michael Meeks
62badf3828 Move to MPLv2 license headers, with ESC decision and author's permission. 2013-04-22 09:37:38 +01:00
Marcos Paulo de Souza
0f200cc30e fdo#63154: Change Min/Max/Abs for std::min/max/abs
Now all these usages were removed from LO.

Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Reviewed-on: https://gerrit.libreoffice.org/3326
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-20 11:09:54 +00:00
Thomas Arnhold
a808497dbb drop prefix from ::css
as css is already ::com::sun::star

Change-Id: I86b43843e4b74f990b6e05dee37184a002072d12
2013-04-02 09:01:37 +02:00
Thomas Arnhold
2b7ee1db28 remove boilerplate comments
Change-Id: I44a476a9843816f70a7a4d84b8c35edeecd5daaf
2013-04-01 22:45:36 +02:00
Eike Rathke
5be14df244 ResMgr with LanguageTag
Change-Id: Ie5ce9157a7ea59db7b0509fbaec61d07f8f9edf0
2013-03-29 14:09:01 +01:00
Borim
a0296296fb fdo#60691 add modelines to *.src and *.hrc files
use solenv/bin/add-modulelines script for the task
and remove all UTF bom from *.src and *.hrc files

svx/source/dialog/hdft.src

Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-08 21:02:26 +00:00
nccuong
a6b9173005 fdo#60148 Clean up warnings from the Clang compiler plugin
Change-Id: I08d755677c46c476710ecbd067ed9f7e2f54a671
loplugin: clean warnings: unused variables, incorrect indentation and log area.
Reviewed-on: https://gerrit.libreoffice.org/2544
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-06 12:59:26 +00:00
Thomas Arnhold
4f4e4e40f5 loplugin: improve indentation
Change-Id: Idb847766d93dc222d6c55889616da21eeac212ee
2013-02-25 17:59:40 +01:00
Tor Lillqvist
616c6924f1 s/the the/the/
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-22 09:58:19 +02:00
Norbert Thiebaud
7f51d6fa0d coverity#707601 Uninitialized pointer field
Change-Id: I1b7c13be91bd2047a4141b6d7d8e4363b0ddcf4f
Reviewed-on: https://gerrit.libreoffice.org/2211
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2013-02-18 15:34:48 +00:00
Norbert Thiebaud
2c570973cc coverity#707602 Uninitialized pointer field
Change-Id: I70fa5899f3bb1eeb22eb18d77f2c816ec60aa97c
Reviewed-on: https://gerrit.libreoffice.org/2212
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-02-18 15:33:52 +00:00
Norbert Thiebaud
de3fc38adf coverity#707600 Uninitialized pointer field
Change-Id: I8894efd7549299903f0ca4c223a3dff60a9db536
Reviewed-on: https://gerrit.libreoffice.org/2210
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-02-18 15:33:12 +00:00
Norbert Thiebaud
51a83689fe coverity#738556 Unitialized scalar field
Change-Id: Iad7ca3d9928e34d0510c85242dc20a6dca6f09bb
Reviewed-on: https://gerrit.libreoffice.org/2209
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-02-18 15:18:58 +00:00
Caolán McNamara
1b13c952f5 Resolves: rhbz#895196 sc filter float a11y parent of itself loop/recurse
Change-Id: I3679e7cfcd32a78b40c6a7b803c92ff0abe6f32c
2013-02-15 17:14:42 +00:00
Stephan Bergmann
f1bca26afc Remove redundant braces around for loops
...that had once been workarounds for compilers that did not yet support the
C++98 scoping rules for declarations in for-init-statements.

Change-Id: I51dc42982b30bf3adea6de1a10a91c0b4b4acfbe
2013-01-26 16:36:09 +01:00
Matteo Casalin
a4c7ded1fd Cleanup: #include <tools/gen.hxx>
Change-Id: Ic547b4a59102afc8bdbc85ec95ac312e32ef2530
Reviewed-on: https://gerrit.libreoffice.org/1484
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-01-07 13:14:57 +00:00
Marcos Paulo de Souza
d204c1a47e Remove last RTL_CONSTASCII_* from accessibility
Change-Id: Icb8f66c9f6ad70828aa55580a1f3aae8b2af1593
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/1500
Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
2012-12-29 15:29:18 +00:00
Julien Nabet
254b11a2c6 Prefer prefix ++/-- operators for non-primitive types
Change-Id: Ib799053921886d1bd524bf4ffe3f586e4c676572
2012-12-24 16:40:57 +01:00
Thorsten Behrens
66a175834c c++ API: use css alias in generated headers, adds global css decl
This changes all generated API headers (.hpp and .hdl) to use a
namespace alias 'css' instead of the pointlessly long com::sun::star

Makes the change in cppumaker & associated tools, adds a global
namespace alias definition in sal/types.h, and removes a kiloton
of local, now pointless-to-harmful versions of that alias from all
over the code.

Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
2012-11-30 14:36:36 +01:00
Thorsten Behrens
70626249cd API CHANGE a11y unpublishing and add/removeListener rename.
The a11y API has never really been picked up by tools vendors, let's
not tie ourselves up here for no good reason.

This unpublishes all css::accessibility, and dependend API.

With that, we can change the rather unfortunately-named add/
removeEventListener to be add/removeAccessibleEventListener, thus
not conflicting with the XComponent methods of the same name.

Change-Id: I595598c3a8e46415f80b2780f333333174865fe4
2012-11-29 16:58:16 +01:00
Noel Grandin
7470cc532f fdo#46808, Adapt reflection::ProxyFactory UNO service to new style
The service is deprecated, but we still have a handful of in-tree
users, and converting it lets me thread XComponentContext through
a bunch of classes.

Change-Id: Iffdfe537ada6b9e4a89f9b3c8dd82ca85f4bfaba
2012-11-28 13:06:18 +01:00
Eike Rathke
9955dbebbd AllSettings with LanguageTag
Change-Id: I710ae66e51139662eb442b681fdf9cc9d158551d
2012-11-22 12:34:59 +01:00
Andras Timar
06ec1c0895 Merge branch 'master' into feature/killsdf
Conflicts:
	Repository.mk
	RepositoryFixes.mk
	connectivity/prj/build.lst
	extensions/prj/build.lst
	filter/prj/build.lst
	fpicker/prj/build.lst
	l10ntools/StaticLibrary_transex.mk
	saxon/build.xml
	shell/prj/build.lst
	solenv/gbuild/AllLangResTarget.mk
	solenv/gbuild/Configuration.mk
	solenv/gbuild/UI.mk
	ucb/source/ucp/webdav/webdavcontent.cxx
2012-11-11 18:24:14 +01:00
Michael Meeks
a73c98a708 Better fix for fdo#56473, Crash when inserting a simple macro
old code used to use XCell->setString, new code uses rDoc.SetString which by default tries to detect number formats. The ScColumn::SetString that eventually
gets called seems to do lots of additional checks ( and apparently even if
an ScSetStringParam instance with mbDetectNumberFormat ( false ) was passed
it seems that it will still try to detect decimal number formats. With that
in mind I restore and un-unoified version of what XCell->setString used do

Change-Id: Ifaef74c78b198f492a390a3d5dc1721622a01ea4
2012-11-09 22:15:23 +01:00
Julien Nabet
465ab1c126 Related: fdo#56473 IDE: Crash when inserting a simple macro
After having discussed with Michael Meeks, a better way would be to be iterator free
Now, should all textwindowaccessibility part be iterator free?

Change-Id: I8079b3ffbc9d37bc2c3b9ede088485dd3a7e410e
2012-11-02 22:58:46 +01:00
David Ostrovsky
9e716494a8 fix some VS 2010 specific issues
Change-Id: Iae27a96c1e2ed72d2744fcbe100d6ada7dc41c82
Reviewed-on: https://gerrit.libreoffice.org/914
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2012-10-28 18:09:02 +00:00