Commit Graph

441522 Commits

Author SHA1 Message Date
Stephan Bergmann
25a23b9b72 loplugin:sallogareas (clang-cl)
Change-Id: I4fd32d006299cfb7ed856e5e8ef8bfd7a680fc6c
Reviewed-on: https://gerrit.libreoffice.org/79940
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01 18:56:53 +02:00
Stephan Bergmann
ff06316fe2 loplugin:unnecessaryparen (clang-cl)
Change-Id: Ief84a2e87bd8bb3cbdb753fdb5bec6e57cf38116
Reviewed-on: https://gerrit.libreoffice.org/79939
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01 18:56:31 +02:00
Stephan Bergmann
6115082b5f loplugin:loopvartoosmall (clang-cl)
Change-Id: I682fccecd94d1d1524fcb12e93f5d53b0c94ea03
Reviewed-on: https://gerrit.libreoffice.org/79935
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01 18:56:15 +02:00
Stephan Bergmann
a2ab2b31b8 loplugin:referencecasting (clang-cl)
Change-Id: Ie534212b09b92a02b377d0bb348e11c96bf61786
Reviewed-on: https://gerrit.libreoffice.org/79934
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01 18:56:06 +02:00
Dennis Francis
46d0afba73 Implement parallel version of super-scalar-sample-sort...
and use it for the pivot table construction routine processBuckets().

The implementation uses ideas from the non-parallel sample sort discussed in the below paper,
but parallelizes the "binning"/"classification" operations and the sorting of the bins
themselves.

Sanders, Peter, and Sebastian Winkel. "Super scalar sample sort."
European Symposium on Algorithms. Springer, Berlin, Heidelberg, 2004.

which can be accessed at :
http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.72.366&rep=rep1&type=pdf

Change-Id: I3723b87e2feb8d7d9ee03f71f6025e26add914ce
Reviewed-on: https://gerrit.libreoffice.org/79486
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-01 18:11:36 +02:00
Dennis Francis
845e1cdca3 Thread a group of formula-groups together if possible
Just before about to thread a FG, look to left and right for
"mutually" independent FG's with some restrictions and thread
this group of FG's together treating it as a single but longer
computation load.

For now the restrictions are :-
All formula-groups in a FG "group" must have :-

1. Same length
2. Same relative position.
3. Same weight.

This is very helpful in cases similar to the below :
There are lots of (say 32) consecutive formula-groups
all with same "small" length (say 8) and same weight.
By conventional formula-group-threading the speed-up is
limited to 8x even if we have a 256 core processor, but
with this threading-multiple-formula-groups patch
(in this case) we can get a speed-up of 256x provided
we have a >= 256 core machine. So effectively with this
patch the speed-up is now only limited to the number of
cells in a range consisting of mutually indepdendent
formula-groups rather than number of cells in each
formula-group.

Change-Id: Ib25b5abbb583fa207e8befff9a908d14313f3d51
Reviewed-on: https://gerrit.libreoffice.org/79485
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-01 18:10:09 +02:00
Stephan Bergmann
1028841feb Silence a supposedly unproblematic loplugin:badstatics (clang-cl)
Change-Id: I9c76fb4aca21757a0bf033103bd6dc2bea740eb5
Reviewed-on: https://gerrit.libreoffice.org/79932
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01 17:36:39 +02:00
Szymon Kłos
44926b4008 jsdialogs: send selection for listbox
Change-Id: Ie5e026da0a4ca95df8fe52a6bf7967dc93b3d869
Reviewed-on: https://gerrit.libreoffice.org/79805
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01 17:23:23 +02:00
Stephan Bergmann
1d07ef46b6 loplugin:redundantcast (clang-cl)
Change-Id: I0682989cdc9528d26925c7770b78fd455c0be396
Reviewed-on: https://gerrit.libreoffice.org/79931
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01 17:15:03 +02:00
Stephan Bergmann
f2bd7857ac loplugin:redundantcast (clang-cl)
Change-Id: I3f66a7850b4604dee576aeb61a39c4e45563d0c1
Reviewed-on: https://gerrit.libreoffice.org/79930
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01 16:51:08 +02:00
Gabor Kelemen
6076335b06 tdf#42949 Fix IWYU warnings in ucb/source/*/*hxx
Note: to build ucb/source/ucp/webdav one needs to use the
--with-webdav=serf
configure option

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I6da50aeeea0c05d49b8b9eadf67ab91d3d250f41
Reviewed-on: https://gerrit.libreoffice.org/79577
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-01 16:49:27 +02:00
László Németh
93ebf6a85f tdf#81100 DOCX: keep "repeat table header" table style setting
during round trip by grab-bagging //tblStylePr/trPr/tblHeader.

Change-Id: Id9d3150ca48031791aeda19c126bc4d4ac16fb8f
Reviewed-on: https://gerrit.libreoffice.org/79597
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
2019-10-01 16:36:33 +02:00
Szymon Kłos
8f5f2ec5d1 jsdialogs: send JSON to the client
Change-Id: If43a774e1e3a4bff4a8ec862f0091d60477090d4
Reviewed-on: https://gerrit.libreoffice.org/79803
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01 16:30:20 +02:00
Noel Grandin
d35840a211 uitest: make child soffice process die when parent dies
using PR_SET_PDEATHSIG.

Note that this can only be called by the child process in question, so
we have to pass a new command line argument down to activate it.

And we have to plumb it through the wrapper oosplash process.

I wonder where else our testing infrastructure could benefit from this

Change-Id: I55e8e9f7f4e6cc415046df04c804e51475b8a4c9
Reviewed-on: https://gerrit.libreoffice.org/79854
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-01 16:21:54 +02:00
Andrea Gelmini
11a1e514db Removed executable permission on file
Change-Id: I6408d8c0d2c7dec30187a147501e19ef6ac86527
Reviewed-on: https://gerrit.libreoffice.org/79969
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-01 16:08:29 +02:00
Stephan Bergmann
e7a1b285df loplugin:indentation (clang-cl)
Change-Id: I19750bd9ac4c77c88097210626fd0c3dfa510a7a
Reviewed-on: https://gerrit.libreoffice.org/79928
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01 16:02:31 +02:00
Jan Holesovsky
1cc241cfb4 lok jsdialogs: Add handling of checked state for checkbox and radiobutton.
Change-Id: Id64833a08c62388220921208cba33a60c178e9ac
Reviewed-on: https://gerrit.libreoffice.org/79797
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01 15:40:40 +02:00
Stephan Bergmann
ede6b3a780 Remove spurious #include <unistd.h>
(which appears to be unused and caused compilation failure on Windows)

Change-Id: Ice6882d98da3bac1f53e869b73ab179df93280fa
Reviewed-on: https://gerrit.libreoffice.org/79925
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01 15:13:43 +02:00
Tünde Tóth
0ddd856af3 tdf#123628 DOCX export: fix color change of unvisited hyperlinks
by exporting the character style name "Hyperlink" requested by Word
instead of the previous "Internet Link" to allow unvisited/visited color
change at opening the link in the document editor.

Change-Id: Ib5e22f8f26a6f3c71543d6e5410d6cc263b83830
Reviewed-on: https://gerrit.libreoffice.org/79855
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
2019-10-01 15:09:08 +02:00
Olivier Hallot
c9dfb6ba71 Update git submodules
* Update helpcontent2 from branch 'master'
  - redmine#2555 replace Help online Google search
    
    This is the helpcontent2/ part of the patch.
    
    Add xapian-omega search to online Help.
    
    The patch replaces Google custom search with xapian-omega search.
    
    A new build key is introduced.
    
    --with-omindex=server : Localizes and adds the xapian result page
    template, adds the xapian form to each Help page.
    
    --with-omindex=noxap : do not localize the result template and
    do not add a form in the Help page.
    
    --with-omindex= will force Online Help build.
    
    Default is noxap
    
    NOTES:
    - xapian-omega databases are built in the server.
    - searches returns results only on localized Help pages, avoiding same
    resulis in many languages.
    
    TODO:
    - Tweak the xapian-omega result page CSS and markup.
    
    Change-Id: I3dc2b79c4111f61fd5fea01b1f8c95bfacab1e8f
    Reviewed-on: https://gerrit.libreoffice.org/79366
    Tested-by: Jenkins
    Reviewed-by: Guilhem Moulin <guilhem@libreoffice.org>
    Tested-by: Guilhem Moulin <guilhem@libreoffice.org>
2019-10-01 15:00:45 +02:00
Olivier Hallot
b2a81fefb1 redmine#2555 replace Help online Google search
This is the core/ part of the patch.

Add xapian-omega search to online Help.

The patch replaces Google custom search with xapian-omega search.

A new build key is introduced.

--with-omindex=server : Localizes and adds the xapian result page,
adds the xapian form to each Help page.

--with-omindex=noxap : do not localize the result template and do
not add a form in the Help page.

--with-omindex will force Online Help build.

Default is noxap

NOTES:
- searches returns resuls only on localized Help pages, avoiding same
resulis in many languages.
-xapian-omega databases must be built in server

TODO:
- Tweak the xapian-omega result page CSS and markup.

Change-Id: I5e3fe4191a3b054e3b6403f7cb5640953d92ba42
Reviewed-on: https://gerrit.libreoffice.org/79368
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-01 15:00:27 +02:00
Szymon Kłos
93d6bef442 jsdialogs: set frame as a separate type
Change-Id: I7f56d49dbe3b403c3716798bb52691748974aaae
Reviewed-on: https://gerrit.libreoffice.org/79801
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01 14:56:30 +02:00
Szymon Kłos
554469c11c jsdialogs: export vertical property for Boxes
Change-Id: I377638b0e9c5575e41ea3f3714541cc94f61a92b
Reviewed-on: https://gerrit.libreoffice.org/79798
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01 14:37:54 +02:00
Szymon Kłos
7d1a5976b3 jsdialogs: set panel as a separate type
Change-Id: I715915ddcaff807ae6a6593dd776dbdb86f2bf4a
Reviewed-on: https://gerrit.libreoffice.org/79802
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01 14:31:23 +02:00
Szymon Kłos
6d46ccc6b5 jsdialogs: send toolitems
Change-Id: I113cd99dbcd8b7a2551271041ae749eaa68af8fc
Reviewed-on: https://gerrit.libreoffice.org/79806
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01 14:05:21 +02:00
Andrea Gelmini
442f421692 Removed one pronoun
Change-Id: I75fe2a1a5846cf31b3036afaec18e4e55d7b0394
Reviewed-on: https://gerrit.libreoffice.org/79949
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-01 13:53:34 +02:00
Stephan Bergmann
2a66221298 loplugin:sequenceloop (clang-cl)
Change-Id: Ie55967043fd6584c8b9a0ad66fad118c70bda8f0
Reviewed-on: https://gerrit.libreoffice.org/79927
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01 13:46:31 +02:00
Stephan Bergmann
6d9203b351 Use loplugin::isSamePathname (as needed on Windows)
Change-Id: I8a1df1c64a93dc3e4a6fb00afd11aaf8521ecea4
Reviewed-on: https://gerrit.libreoffice.org/79926
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01 13:32:00 +02:00
Caolán McNamara
0b6bb03616 Resolves: tdf#127896 fix 'Exchange database' crash
Change-Id: I8278c9e959ab054b5bccf0b33e5885cd4ac7573a
Reviewed-on: https://gerrit.libreoffice.org/79923
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-01 13:23:29 +02:00
Stephan Bergmann
a3e29642b9 loplugin:data (clang-cl)
Change-Id: Ib8b2bc1c5f7b27a646036ce23cae2b6a06edd038
Reviewed-on: https://gerrit.libreoffice.org/79922
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01 13:20:30 +02:00
Stephan Bergmann
720af01132 Avoid loplugin:data (clang-cl)
Change-Id: If10e70b30313509988861ee5200f08f2b83a647b
Reviewed-on: https://gerrit.libreoffice.org/79918
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01 13:20:12 +02:00
Stephan Bergmann
4da2ad58a6 loplugin:nullptr (clang-cl)
Change-Id: I9a9262a236d4257da6f65ee6b0cafbc5522c8a66
Reviewed-on: https://gerrit.libreoffice.org/79917
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01 13:19:37 +02:00
Stephan Bergmann
664de5a816 loplugin:stringconstant (clang-cl)
Change-Id: Id1a82cea4444255fdb693e126b7571a406094624
Reviewed-on: https://gerrit.libreoffice.org/79916
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01 13:19:04 +02:00
Caolán McNamara
f88160d640 don't suggest gtk SAL_USE_VCLPLUGIN env variable
Change-Id: I069fc594c32d2f1ea7fe4cc04be00a9a574054f8
Reviewed-on: https://gerrit.libreoffice.org/79898
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-01 12:12:28 +02:00
Jan Holesovsky
e0a415b13e lok: Enable sidebar also in Impress.
Change-Id: I6c5c7c82a3ad81e590a891f1a8cc76a873823acf
Reviewed-on: https://gerrit.libreoffice.org/79856
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 4ff28e09412d2c0ef73008d3d85dae9b506e4978)
Reviewed-on: https://gerrit.libreoffice.org/79900
Tested-by: Jenkins
2019-10-01 11:38:21 +02:00
Gabor Kelemen
32e781d268 tdf#92845 Save Writer - Comparison settings properly
Options - Writer - Comparison -> 'Compare Documents' and 'Ignore pieces of lenght <value>'
were not retained between runs of Writer.

The type of these settings are defined in
officecfg/registry/schema/org/openoffice/Office/Writer.xcs
as follows:

<prop oor:name="Mode" oor:type="xs:short">
<prop oor:name="IgnoreLength" oor:type="xs:short">

Casting the setting values to sal_Int32 did not work, because sal_Int16 maps to short.

This makes the following warning (2 instances displayed when closing the Options window)
 go away in my local debug build and the values retained:

warn:unotools.config:30387:30387:unotools/source/config/configitem.cxx:483:
Exception from PutProperties com.sun.star.lang.IllegalArgumentException
message: configmgr inappropriate property value context: configmgr::ChildAccess ArgumentPosition: -1

Change-Id: I59fea65378a5dfb2b6f25b9c9eaf08817862587d
Reviewed-on: https://gerrit.libreoffice.org/79807
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
2019-10-01 11:30:27 +02:00
Balazs Varga
6027ec08fd tdf#127777 OOXML chart export: fix X axis position setting "CrossBetween"
Export ShiftedCategoryPosition value into the CrossBetween OOXML tag.

Change-Id: I3d8b298ed47c5326ee4faf0e8663c8c79d5a1d86
Reviewed-on: https://gerrit.libreoffice.org/79502
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
2019-10-01 11:19:18 +02:00
Heiko Tietze
78c6b79f2a Resolves tdf#127756 - Tip of the day not localized
Introduced %LANGUAGENAME token being replaced with
BCP47 for pt, en, zh or ISO otherwise

Change-Id: Iaa7168731e0f6a8e0dd1e906ff0ef646534d9f4b
Reviewed-on: https://gerrit.libreoffice.org/79564
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-01 10:56:36 +02:00
Stephan Bergmann
404a3c806f loplugin:simplifyconstruct (clang-cl)
Change-Id: I08da288a88c2bce1d4250ec77f17bd483e6bc09c
Reviewed-on: https://gerrit.libreoffice.org/79911
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01 10:51:48 +02:00
Noel Grandin
b74c4b7c67 loplugin:stringadd in package..sax
Change-Id: I1f8b626ae99bca6e31e7c4aa9c8a1fc016b76e5c
Reviewed-on: https://gerrit.libreoffice.org/79890
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-01 10:51:39 +02:00
Noel Grandin
46c2a3688c loplugin:stringadd n sfx2..svl
Change-Id: Iaf1bbe37449d4e0cfa817909d56d4bffe1e5a184
Reviewed-on: https://gerrit.libreoffice.org/79893
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-01 10:46:15 +02:00
Juergen Funk
044a683e6c desktop: proper error checking for crashreport ini reading
Change-Id: I1107304a0e3f482b6a7e6110006c2f26b9cb0778
Reviewed-on: https://gerrit.libreoffice.org/79603
Reviewed-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de>
Tested-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de>
2019-10-01 10:35:16 +02:00
Juergen Funk
b5adb2433d crashreport: change addKeyValue to lower-case camel
Change-Id: Ife5775d3a570da1fc2e4dd627456523705b64e1d
Reviewed-on: https://gerrit.libreoffice.org/79601
Reviewed-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de>
Tested-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de>
2019-10-01 10:34:20 +02:00
Szymon Kłos
7388db1b63 jsdialogs: export more properties
Change-Id: Iaabe560867025c30c1478d4b33357231e67b0b57
Reviewed-on: https://gerrit.libreoffice.org/79799
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01 10:22:44 +02:00
Szymon Kłos
7362568a87 jsdialogs: send listbox entries
Change-Id: I00b2260e2ceaffbfbe415633ef5a35c7d147b44a
Reviewed-on: https://gerrit.libreoffice.org/79804
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01 10:21:26 +02:00
Jan Holesovsky
75b8db7fa7 lok jsdialogs: Introduce dumping of widgets hierarchy to vcl::Window.
Change-Id: Ie3267e1f888df371d281e81ead437a150aa8dc1c
Reviewed-on: https://gerrit.libreoffice.org/79796
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-01 10:21:08 +02:00
Marco Cecchetti
9590e8d0a2 lok: handling a single msg for deleting multiple characters
also includes:

	lok: fixing testABI failure
	Change-Id: I4df662a0df49a864c4b307efdd963b857bb77792

	lok: missing removeTextContext implementation for Document class
	Change-Id: I884ad07f330afc19dfe759c08c8a17bdb4f9dcf3

Change-Id: I045d89f9fa478f37fc2917e159e044eee7e1ab31
Reviewed-on: https://gerrit.libreoffice.org/79879
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-01 10:01:57 +02:00
Caolán McNamara
0ff8140676 Resolves: tdf#126781 force comboboxes to take 1/3 avail space
and not their natural size as this dialog is fixed width so we need
to make do. This brings the right border of the entry inside the
scrolled window area as expected

Change-Id: I60d6078436cbfacbbfda55838e4b0584da4bab1e
Reviewed-on: https://gerrit.libreoffice.org/79872
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-01 09:55:16 +02:00
Caolán McNamara
eac301701e add activates_default to GtkEntries in dialogs
activates-default of True means pressing return activates the default
button of the action area, which is typically what vcl Edit did by
default.

Change-Id: I60bc1634b04a486af86526d887d0ada961b08076
Reviewed-on: https://gerrit.libreoffice.org/79860
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-01 09:53:50 +02:00
Caolán McNamara
724cca5d89 weld SafeModeDialog
Change-Id: I079aa278f6f2672534128df7a8739425223c0c74
Reviewed-on: https://gerrit.libreoffice.org/79897
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-01 09:53:34 +02:00