Commit Graph

337 Commits

Author SHA1 Message Date
Tor Lillqvist
aacf715527 <vcl/spin.h> can be private to vcl
Change-Id: If723dd72479ab8d072581e9ffbf7a1462c5fecda
2015-12-12 09:26:29 +02:00
Samuel Mehrbrodt
ac97f32307 Move icon rotation/flip handling from ToolbarManager to vcl's Toolbar
This enables rotatad/flipped icons in the Sidebar and other non-toolbar places (tdf#85767)

Change-Id: I034394ae6f9b8d91ef5a376a43eda587098f064e
Reviewed-on: https://gerrit.libreoffice.org/20403
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-12-08 08:39:44 +00:00
Caolán McNamara
a4e58b5098 silence ReleaseMouse warning
Change-Id: I615b4877ab29075ed45149259260acfb2563cad8
2015-11-30 16:43:30 +00:00
Michael Meeks
ed6aceab08 vcl: reduce pointless timer / scheduler / idle includes.
Change-Id: I8bf7f8d6ba1a54f2969e055956fadc52ff6c8673
2015-11-26 13:48:21 +00:00
Samuel Mehrbrodt
745751e32d Vcl Toolbox: Move Impl and local defines out of header files
This reverts part of 1e82a3e6e3

Change-Id: I683a855727c4a52d3ac6a7c5a1f104a6cf5b9ee2
2015-11-24 13:36:08 +01:00
Samuel Mehrbrodt
1e82a3e6e3 Vcl: Cleanup Toolbox
* Move defines to header file
* Limit line length to 120 chars
* Some other smaller cleanups (unused defines etc)

Change-Id: I14b52579f9b5bae4ea0bc1df434cc3d29c223d4e
Reviewed-on: https://gerrit.libreoffice.org/20133
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-11-24 07:22:01 +00:00
Maxim Monastirsky
78214c982e Revert "ToolBox: Remove unused methods"
The ImplLoadRes method *is* used in
ToolBox::ToolBox( vcl::Window* pParent, const ResId& rResId ).
This change breaks the navigator panel, and therefore the
JunitTest_toolkit_unoapi_1 test.

This reverts commit 9964809501.
2015-11-18 22:26:32 +02:00
Samuel Mehrbrodt
9964809501 ToolBox: Remove unused methods
Change-Id: Ic56cf27c61a904278770f0617d827e574d1eae68
2015-11-18 16:05:44 +01:00
Samuel Mehrbrodt
5328bb57e7 Indentation fixes
Change-Id: Ib508e6f3c89266660e6163bbef2c7f50f5d01806
2015-11-18 12:58:10 +01:00
Stephan Bergmann
d3b6cb7ec2 loplugin:nullptr (automatic rewrite)
Change-Id: I05e89f9896170d4df3d1377549ea074f06b884a0
2015-11-10 10:32:00 +01:00
Stephan Bergmann
666f732412 loplugin:defaultparams
Change-Id: I3e5ee77b51eb8e1207d3f95e6a1d9d8272532ba6
2015-10-20 11:47:18 +02:00
Noel Grandin
0e8a40e8b8 calling IsSet() before Call() on Link<> is unnecessary
the Call() already does a check

Found with:
git grep -A 1 -w 'IsSet()'
    | grep -B 1 '.Call('
    | grep ':'
    | cut -d ':' -f 1

Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-15 12:29:01 +02:00
Andrea Gelmini
835d7774e7 Fix typos
Change-Id: I2cf36eb80068adcf57238a286f09bdc96b4e01f8
Reviewed-on: https://gerrit.libreoffice.org/18994
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-30 10:39:51 +00:00
Noel Grandin
78b124143a convert Link<> to typed
Change-Id: I2f36a123662488ef5534f7bf0845d61e497fb0ec
2015-09-09 10:06:12 +02:00
Maxim Monastirsky
8b8ca054f8 Related: tdf#84277 Hide separator only between two windows
Change-Id: I3176933d20dce9f595fd6a9c0ee434a3709fa560
2015-09-06 22:23:41 +03:00
Maxim Monastirsky
0eda609312 tdf#84277 Use the same logic for native separators
If in some cases we don't want a visible separator, I can't
understand why it shouldn't apply also to platforms that
support native separator drawing.

Change-Id: Ib88bece62cfbb092808f3257a7ba9bd63f4cb1d7
2015-08-23 01:06:32 +03:00
Noel Grandin
8dc5f89346 loplugin: defaultparams
Change-Id: I79a889c68e91712d2abdacc559c78813f730e623
2015-08-11 09:48:18 +02:00
Noel Grandin
9e28cc8ca7 convert WindowAlign to scoped enum
Change-Id: I028d108b3a83bd5541d873c4d03b87339cd3be52
2015-07-24 09:52:08 +02:00
Andrea Gelmini
1a8915ef83 Fix typos
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e
Reviewed-on: https://gerrit.libreoffice.org/16582
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-30 15:57:12 +00:00
Jan Holesovsky
020aecf5d9 tdf#92088: Fix an overlook in the refactor.
This was causing 'if you click in the "default style" combobox in writers
standard bar and press tab and press tab the next two combo boxes go "blue",
happens in gtk2, gtk3 and gen.' reported by Caolan.

Change-Id: I0d97a181a605088a0b8bb8043771eb56280521e0
2015-06-23 15:11:59 +02:00
Jan Holesovsky
5ca1936975 rendercontext: Mass fix of using the wrong size.
In the paints, we must use the size of the Window for the computations, not of
the RenderContext - the RenderContext can be much bigger than the Window in
the double-buffering case.

Fixes for example the list boxes, and many others.

Change-Id: I4c7607569f88b2d097587140858d0862e54b5ea6
2015-06-23 10:32:28 +02:00
Michael Meeks
0aa10c0b3d tdf#92088 - don't invalidate disposed toolbar items.
Change-Id: Ie90906f1ed8dc205850df3a48688f66b7a72a4f4
Reviewed-on: https://gerrit.libreoffice.org/16343
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-18 08:41:08 +00:00
Andrea Gelmini
01532b1ab8 Fix typos
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072
Reviewed-on: https://gerrit.libreoffice.org/16297
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16 11:05:58 +00:00
Caolán McNamara
ff66595adb downgrade this WARN to an INFO
Change-Id: I040a36cc1656c70c7c258e17757745a196c2bf71
2015-06-16 09:30:11 +01:00
Noel Grandin
4729774b24 remove unnecessary check for null when calling delete
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'

Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15 14:46:41 +02:00
László Németh
751d697db6 fix rendercontext rendering of toolbox
Change-Id: I927a7ffdac278384ef102e6619f217daf24879a2
2015-06-02 18:12:03 +02:00
Noel Grandin
f3331f7694 convert PARENTCLIPMODE constants to scoped enum
Change-Id: I36a53112e75fca9208b2f91e224a7c671695509b
2015-05-28 12:47:08 +02:00
Noel Grandin
79db3fc0ee convert STARTTRACK constants to scoped enum
Change-Id: I9b441688eb59ffd3540b014716a9abe7969c9be4
2015-05-28 12:47:07 +02:00
Noel Grandin
4c93c30c79 convert GETFOCUS constants to scoped enum
Change-Id: I7c324bb6358be28c119592850eb7607479279f09
2015-05-28 12:47:05 +02:00
Noel Grandin
c6dfe0545c convert DLGWINDOW constants to scoped enum
Change-Id: Ieda6c5d638c608dd9e7b5d760dfbbfbcc37cc35a
2015-05-27 11:14:24 +02:00
Noel Grandin
bb7ce3137d convert INVALIDATE constants to scoped enum
fixing a bug in Window::ImplMoveAllInvalidateRegions, and improving the
IDL docs for XWindowPeer

Change-Id: Idb774ac913945db2ac7c492c11cf86c370624c3d
2015-05-26 08:30:18 +02:00
Jan Holesovsky
b6b7e34bcc rendercontext: Draw toolbox separators via the rendercontext.
Change-Id: Ie34f9eeb9f706e1a43c31d08869c8b6c610228ec
2015-05-22 15:08:42 +02:00
Markus Mohrhard
929a8f04af fix crash related to VclPtr work
Change-Id: I273658a6edd9787c19cfaac0e1cb4a2c33611b99
2015-05-22 12:25:51 +01:00
Noel Grandin
566922a98d convert WINDOW constants for GetWindow() methods to scoped enum
Change-Id: I0c7c6d095732704eb4ab48f1277a0592b1c7fa33
2015-05-22 10:37:59 +02:00
Noel Grandin
321b344191 convert TITLE_BUTTON constants to scoped enum
Change-Id: Ibfee4c394724570d9f64098d3703a08b7246ad2c
2015-05-22 10:37:59 +02:00
Noel Grandin
e929194317 convert POINTER constants to scoped enum
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19
Reviewed-on: https://gerrit.libreoffice.org/15825
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-22 06:32:35 +00:00
Tomaž Vajngerl
e5b0a647c4 tdf#91404 check if the item position is valid
Change-Id: I963cf83d32bb976095274be913806de19bdf7a86
2015-05-20 20:13:32 +09:00
Noel Grandin
dcefc97c8b convert IMAGE_DRAW_ constants to scoped enum
Change-Id: I75619eeb902af4953a5ac1525605cf3f0f15e2c0
2015-05-20 09:52:08 +02:00
Noel Grandin
25a47c5cd5 convert TEXT_DRAW constants to scoped enum
Change-Id: Ic0f7f8fa236bb478b3598ae3fd3c1b30ebbf1a01
2015-05-20 09:52:08 +02:00
Jan Holesovsky
9c9db85643 rendercontext toolbar: Invalidate instead of direct paint.
Change-Id: Ib4c11d3f1ec793e66cd47c1f7bb4f7d06820d58f
2015-05-19 16:37:10 +02:00
Tomaž Vajngerl
6fa87f3fde use RenderTools variant of DrawSelectionBackground
Change-Id: Ia7a0f0a4d62e478876743c019865e7878bcbf596
2015-05-18 11:22:49 +09:00
Tomaž Vajngerl
b4bbb5e5d7 refactor how font, fg. and bg. are applied in widgets/controls
- Move vcl::RenderContext to outdev.
- Change some methods on vcl::Window to accept RenderContext
  as parameter.
- Add ApplySettings to vcl::Window - This method is called before
  painting. Refactor existing classes that use InitSettings to
  have ApplySettings or mark the classes to be refactored later.
- Add RenderSettings for adding defered settings to rendering.
  This is similar to ApplySettings but for more ad-hoc calls.

Change-Id: I4ea58461f3b6b08ccfa3e0ddd1a4a3e04f8c4f45
2015-05-18 11:22:49 +09:00
Michael Meeks
ecf9f9f869 tdf#91311 - handle toolbox tracking events post dispose safely.
Change-Id: I6284de937cd9daca45f37a780c75beb1585bb2a0
2015-05-15 19:26:56 +01:00
Noel Grandin
741d9990bf convert QUICKHELP constants to scoped enum
Change-Id: Ie7302c909feb2e83b8b5e62a5e6a1f901783fb49
2015-05-14 12:00:40 +02:00
Caolán McNamara
b1a9498a14 Remove EditBoxValue again and just use the native widgets size request
Change-Id: Ib9d0f06bffc9e9d31149a622350145024a9b8a99
2015-05-13 12:49:01 +01:00
Noel Grandin
666f42854e convert FLOATWIN_POPUPMODEEND constants to scoped enum
Change-Id: I36fea4608c744c941bdff401b649fa46302b4dbd
2015-05-13 09:25:51 +02:00
Noel Grandin
670b7ade84 convert BUTTON_DRAW constants to scoped enum
Change-Id: I6ad6558c855736a4a5268593ced9c8300235d4bd
2015-05-13 08:54:36 +02:00
Noel Grandin
82d68f9cbc convert COMMAND_ constants to scoped enum
Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95
Reviewed-on: https://gerrit.libreoffice.org/15671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-11 12:17:42 +00:00
Michael Meeks
8372b3c3d1 PostUserEvent - first cut at keeping a VclPtr for posted UserEvents.
This should eventually enable more certainty that they are still
live by the time we emit the event later.

Change-Id: I7c9eb4c000753d4efe8c59a9e13ef3e11c93b2fa
2015-05-08 22:40:29 +01:00
Tomaž Vajngerl
d8a53d4627 Refactor "SpinField" & "SpinButton" - use RenderContext
Change-Id: I589f49179b446ae24037546075070641de5cb927
2015-05-07 09:57:49 +02:00