Commit Graph

385 Commits

Author SHA1 Message Date
Caolán McNamara
bea8a7ad63 cppcheck: noExplicitConstructor
Change-Id: Ib43e53d5b6c9c130adb765ac9b769f58060ac640
2015-12-29 19:46:23 +00:00
Noel Grandin
a218039d2a loplugin:unusedfields in xmlscript,xmlsecurity
Change-Id: I5239766f2105fb1a7823215a4ffe48891e000c3d
2015-12-21 12:45:49 +02:00
Oliver Specht
ffdd3c6820 tdf#80047: load&save align and valign attributes of NumericField
Change-Id: Iff92f050210c112f355803d4d4bcec6b9d289a84
Reviewed-on: https://gerrit.libreoffice.org/20788
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
2015-12-18 10:42:09 +00:00
Noel Grandin
93ca224721 com::sun::star->css in xmlscript/
Change-Id: I8ead2862ef429a0ac3fc16fe6ca5dfc9e5f549bc
Reviewed-on: https://gerrit.libreoffice.org/20193
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-26 12:21:24 +00:00
Noel Grandin
8e234c5b7d use initialiser syntax for Sequence<OUString>
replaced using the script:

git grep -lP 'Sequence.*OUString.*\(1\)'
  | xargs perl -0777 -pi
    -e "s/Sequence< OUString > (\w+)\(1\);
.*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g"

Change-Id: I23688a91562051a8eed11fc2a85599545c285c34
Reviewed-on: https://gerrit.libreoffice.org/19967
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15 10:13:08 +00:00
Stephan Bergmann
6de82da0c1 loplugin:nullptr (automatic rewrite)
Change-Id: Ie91fbfc9369fe9f2de1cf12c746598a80c2233c1
2015-11-10 10:32:02 +01:00
Noel Grandin
6c80a8fe89 new loplugin: oncevar
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f
Reviewed-on: https://gerrit.libreoffice.org/19815
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-09 08:34:40 +00:00
Stephan Bergmann
28d63935b2 loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)
Change-Id: I8aedb690380d407dcbc290a44d21afa6604b8f95
2015-11-06 09:38:49 +01:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Andrea Gelmini
4678982056 Fix typos
Change-Id: I2cdfc4e9d8ba1acb7c2548f9394d320c6504207e
Reviewed-on: https://gerrit.libreoffice.org/18997
Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org>
Tested-by: Joren De Cuyper <jorendc@libreoffice.org>
2015-09-29 22:13:57 +00:00
Caolán McNamara
31ebd9f475 boost->std
Change-Id: Ic18be8b86727dd1179a7e39c70493d088ed00557
2015-09-16 15:34:23 +01:00
Takeshi Abe
06962719b1 xmlscript: tdf#88206 replace cppu::WeakImplHelper*
with the variadic variants.

Change-Id: Ic05094dea12c0aa66dc97a7e403a3abec9e25785
Reviewed-on: https://gerrit.libreoffice.org/18556
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-14 06:25:52 +00:00
Noel Grandin
a4fd6c4f9e inline some use-once typedefs
Change-Id: I02cbbba56a2ad83e0ac3d806265a7e0d6a29594d
Reviewed-on: https://gerrit.libreoffice.org/17495
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03 12:16:33 +00:00
Andrea Gelmini
1c5f07e60c Fix typos
Change-Id: I98b4dfb0f72f315065693335e2f882bb2eed3afe
Reviewed-on: https://gerrit.libreoffice.org/16713
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-03 09:14:23 +00:00
Noel Grandin
afcf1ecee1 loplugin:loopvartoosmall
Change-Id: I1e9768c08af0bc7caac6a39c13842ee9d8ad962c
2015-05-29 08:48:41 +02:00
Caolán McNamara
dcee23b7f8 cppcheck: noExplicitConstructor
Change-Id: Idcf5460ec59cfb6f13055652c094d460c15da5ed
2015-05-20 20:40:54 +01:00
Caolán McNamara
869e477484 cppcheck: noExplicitConstructor
Change-Id: Iea5bb0504518b380c3fe7c238d376dc26be8a7ef
2015-05-04 20:13:52 +01:00
Stephan Bergmann
6ff2d84ade Various #include <sal/log.hxx> fixups
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx>
(and don't make use of it themselves), but many other files happen to depend on
it.  Cleaned up some, but something like

  grep -FwL sal/log.hxx $(git grep -Elw \
    'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx)

shows lots more files that potentially need fixing before the include can be
removed from rtl/string.hxx and rtl/ustring.hxx.

Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-22 09:57:47 +02:00
Noel Grandin
e4688a3d41 loplugin:staticmethods
Change-Id: Ibaad2adabecb878411fdd66383bca91f034477af
2015-04-07 10:24:54 +02:00
Stephan Bergmann
42c848c506 Replace remaining getCppuType et al with cppu::UnoType
Change-Id: Ida0a4cced7d35be6f9da16447ae4e23ded5e415a
2015-04-01 08:43:42 +02:00
Stephan Bergmann
6485183373 Reduce to static_cast any reinterpret_cast from void pointers
Change-Id: I8af2e7c7bb5e750c13dd9f7ef1fd3033ec9cdf9c
2015-03-31 13:17:59 +02:00
Stephan Bergmann
b51252247e Clean up C-style casts from pointers to void
Change-Id: Id64d800ccebab274e5bb7ad2667c0e270e745bdf
2015-03-28 19:09:29 +01:00
Lionel Elie Mamane
f1ffba8921 constify
Change-Id: Id319c001b399a3105d6c9f87a58168f956ad46c3
2015-02-05 21:45:28 +01:00
Lionel Elie Mamane
e57febdb7f proper indentation
Change-Id: Ifc7577f46625562183ed3ee2273f28b9dcfc13df
2015-02-05 21:45:27 +01:00
Lionel Elie Mamane
87934ed763 destructors are not allowed to throw
so move potentially throwing call to a manually called finish()
additionally don't make it leak something that is not a RuntimeException,
the caller does not expect it.

Change-Id: I8b19585ae197f5ac8625dc85d4c4860a1c11b262
2015-02-05 21:45:26 +01:00
Michael Stahl
ff26f022b3 xmlscript: fix import/export of dialog radio-buttons
The BASIC dialog format is not specified by ODF anyway, so the change
was particularly stupid.

(regression from 2d4b87f0c1)

Change-Id: I5b20d690093b0d2b898f3e45cc0292fb72fbb353
2015-02-05 17:36:48 +01:00
Tor Lillqvist
ad3e0989d1 WaE: implicit conversion of literal of type 'int' to 'bool'
Change-Id: Ie12339760904329d690bbe4863286e005ebde380
2015-01-27 15:03:12 +02:00
Caolán McNamara
199cec3af0 remove spurious xDocStorage temp
Change-Id: Ia47394bcd4d39fca5096413ca7e0fbffbc3d7ac6
2015-01-27 10:46:43 +00:00
Tsutomu Uchino
41146013ad Resolves: #i98734# save/load ScaleMode property of image control on dialogs
Suggested by: Frank Schönheit <frank.schoenheit@gmx.de>
(cherry picked from commit 350c4f9a01b88d4fd1006465151348ac5d459f1a)

Conflicts:
	xmlscript/source/xmldlg_imexp/exp_share.hxx
	xmlscript/source/xmldlg_imexp/xmldlg_expmodels.cxx
	xmlscript/source/xmldlg_imexp/xmldlg_export.cxx
	xmlscript/source/xmldlg_imexp/xmldlg_impmodels.cxx
	xmlscript/source/xmldlg_imexp/xmldlg_import.cxx

Change-Id: I2a11809112c0b1b53349f5b74dca20897d4a6acd
2015-01-27 10:46:43 +00:00
Stephan Bergmann
be06f3433f Some more loplugin:cstylecast: xmlscript
Change-Id: I6c13ff51c32e0fded35d8f9124981fee1cce80ad
2015-01-20 09:06:55 +01:00
Michael Weghorn
bfe79b50bc fdo#39440 reduce scope of local variables
This addresses some cppcheck warnings.

Change-Id: If7ad3584b3124ed0b337836071af1a5bd0451d85
Reviewed-on: https://gerrit.libreoffice.org/13972
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-19 08:39:32 +00:00
Caolán McNamara
fd1372ba8b boost::unordered_map->std::unordered_map
you can get debug stl this way

Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2015-01-02 16:14:36 +00:00
Stephan Bergmann
eabf036cfe xmlscript: Use appropriate OUString functions on string constants
Change-Id: I1fafba17c590d4485f2138e2dda877344c573df1
2014-12-18 14:12:39 +01:00
Michael Stahl
15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18 18:51:49 +01:00
Michael Stahl
6a0fe37dec sal: clean up public headers with include-what-you-use
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
Brij Mohan Lal Srivastava
d32be3ace8 fdo#86023 - O[U]String needs a 'clear' method
Added clear() method to OString and OUString class, Updated appropriate call-sites.

Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14 09:20:38 +01:00
Noel Grandin
705c48d32e fdo#38835 strip out OUString globals
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.

Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-05 08:44:19 +02:00
Andrea Gelmini
0c0e3e7539 Fixed typos. No automatic tools (sed, and so on).
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f
Reviewed-on: https://gerrit.libreoffice.org/12150
Reviewed-by: Bryan Quigley <gquigs@gmail.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-30 17:16:02 +00:00
Noel Grandin
0371a63365 remove unnecessary 'using namespace rtl' declarations
It turns out that almost none of them were necessary.

Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29 11:28:54 +00:00
Stephan Bergmann
389beae2ff xmlscript: std::auto_ptr -> std::unique_ptr
Change-Id: I203b84180d3614a440b37af87223bbf5a6a0f21a
2014-10-01 17:35:15 +02:00
Noel Grandin
fc04f76336 fdo#82577: Handle Time
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01 07:34:23 +00:00
Norbert Thiebaud
0439f66742 xmlscript: avoid accessing [0] of an emptry string
Change-Id: I2ad756b07418d3eb93f48374cd7de3bc3db9ce29
2014-09-12 01:45:29 +02:00
Michael Stahl
2d4b87f0c1 ODF export: don't write invalid "group-name" attribute
Radio buttons are grouped via their "form:name" attribute already.

Change-Id: I9f8b27a2904d947c3d4665495d36961e3e41d2c6
2014-08-20 16:40:14 +02:00
Noel Grandin
e2080e70fe new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
Noel Grandin
dfd44d0b12 xmlscript: remove SAL_THROW macro
Change-Id: Ic830c23d8696fde323dcf67697248a84658be2bf
2014-06-05 08:17:48 +02:00
Jens Carl
626a428367 fdo#68849: Add header guards to all include files
Added header guards to files in directories xml*/*

Change-Id: Ia5dfb9ab494bfbfae7537f2d54ff11331dc8c922
Reviewed-on: https://gerrit.libreoffice.org/9539
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-29 09:02:51 -05:00
Julien Nabet
ac76cc7e60 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-23 22:11:52 +02:00
Noel Grandin
e7bc3cab01 remove boilerplate in UNO Exception constructor calls
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
Thomas Arnhold
debe137b46 xmlscript: remove using namespace from headers
Change-Id: Ic3b355e732bcbecf020720752aadd70e0722b6f0
2014-05-22 12:50:46 +02:00
Thomas Arnhold
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00