mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
375,486 Commits 1 Branch 0 Tags
335df40d28725b224aa8d70dd9b51d2e7bfa86da
Commit Graph

340 Commits

Author SHA1 Message Date
Caolán McNamara
c0fe057827 cppcheck: noExplicitConstructor 
Change-Id: Ic323f07196d8a0d106d9ddf73a06db377c23fb98
 2015-05-25 15:03:43 +01:00
Noel Grandin
e929194317 convert POINTER constants to scoped enum 
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19
Reviewed-on: https://gerrit.libreoffice.org/15825
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-05-22 06:32:35 +00:00
Stephan Bergmann
8cafd08278 Use typed Timer::SetTimeoutHdl Link 
Change-Id: Iaaf0c93e5b28c0f7dbe4f02eda8beeae30708100
 2015-05-05 10:21:54 +02:00
Noel Grandin
cc7af44abd loplugin:staticmethods 
Change-Id: I86e2095bee82a2a6a28b8750e5a328c4d395e2aa
 2015-05-05 09:30:40 +02:00
Noel Grandin
6bb742b9cb convert STR_EVENT constants to scoped enum 
- also add needed infrastructure to o3tl::enumarray so we can use
std::find on it
- move the Impl inside the .cxx file, no need to expose it in the header

Change-Id: I7758a6175849f46723d97b1e657f846524c3b7cd
 2015-04-29 10:41:40 +02:00
Noel Grandin
12ba9e3cad loplugin:staticmethods 
Change-Id: Ib0c0841e48814d1a6e13bcd4575725d86ffa5e5e
 2015-04-23 13:08:48 +02:00
Stephan Bergmann
9222f5d065 A UNO Any can't contain an Any 
...and css::uno::makeAny<css::uno::Any>() was never meant to be used.  Introduce
css::uno::toAny for the (template-code) cases that shall return an Any for both
Any and non-Any inputs.

Change-Id: Ifa977d73f1da71b2fedde7e8140b19497c4a0257
 2015-04-08 17:45:08 +02:00
Noel Grandin
fcaad6576d fix shadow error 
introduced by my commit 216fdcbdb4
"convert RECALCMODE_ constants to scoped enum"

Change-Id: Ie7db053741205faeac70e3d21757774567f43ce0
 2015-04-08 11:40:16 +02:00
Stephan Bergmann
54e87df11f Change INetProtocol enumerators to CamelCase 
...to avoid clashes with macros and poor warnings about hiding global FILE

Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
 2015-04-02 18:33:37 +02:00
Stephan Bergmann
44b3e56bb4 Change INetProtocol to scoped enumeration 
...and fix o3tl::enumarray::operator [] const overload

Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
 2015-04-02 16:30:34 +02:00
Stephan Bergmann
0ca607e067 Replace remaining getCppuType et al with cppu::UnoType 
Change-Id: I5be2bed2203cd3807d3d9659e09e5f60f7a3257c
 2015-04-01 08:43:13 +02:00
Noel Grandin
858e455634 loplugin:constantfunction: various 
Change-Id: I6eddda9f4b31c7ce413c328b6a857a81bd222eed
 2015-03-24 10:51:22 +02:00
Stephan Bergmann
3099c70b11 Fix various XServiceInfo implementations 
...to match what is recorded in the .component files

Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
 2015-03-17 12:25:11 +01:00
Caolán McNamara
567f511924 V801: Decreased performance 
Change-Id: I97c7977fdfea57b5d1c45ce0c5902b74cc719db9
 2015-03-06 17:08:55 +00:00
Caolán McNamara
c622304965 V813: Decreased performance 
Change-Id: Ica2563d9e8da15e19eb38246d4de54a1fcb75655
 2015-03-04 00:51:57 +00:00
Stephan Bergmann
2cebd4d086 loplugin:deletedspecial 
Change-Id: Id3f938a5794e29b14c6adca0065465f3412c5fe2
 2015-02-07 12:36:04 +01:00
Noel Grandin
b44cbb26ef new loplugin: change virtual methods to non-virtual 
Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
 2015-01-26 08:42:28 +02:00
Stephan Bergmann
ea0bb58d98 Drop unused comphelper::service_decl::component_getFactoryHelper params 
Change-Id: Ia47c0bc3539ddf8f925cd053a2431c742c46d337
 2015-01-20 11:06:01 +01:00
Stephan Bergmann
f6cfe99d22 Some more loplugin:cstylecast: vbahelper 
Change-Id: I0b09119d0084ac4eed8d805c4fbca0afc013080d
 2015-01-20 09:06:53 +01:00
Andrea Gelmini
83e8d0166d Fix typo code Resouce->Resource 
Change-Id: I6e68c13e4513c2f8cc38e237646db7dffc88fe3b
Reviewed-on: https://gerrit.libreoffice.org/13986
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-01-19 08:46:05 +00:00
Michael Weghorn
5901827bd4 fdo#39440 reduce scope of local variables 
This addresses some cppcheck warnings.

Change-Id: I1cd8b118e2598b8b18fb445851a3bb41e554267b
Reviewed-on: https://gerrit.libreoffice.org/13967
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-01-19 06:18:37 +00:00
Andrea Gelmini
07e84cae98 Fix typo comments Resouce->Resource 
Change-Id: Ia3195a21ad46b4c9830ee6293135dfe5945986a2
Reviewed-on: https://gerrit.libreoffice.org/13985
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-01-19 06:13:25 +00:00
Caolán McNamara
fd1372ba8b boost::unordered_map->std::unordered_map 
you can get debug stl this way

Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
 2015-01-02 16:14:36 +00:00
Stephan Bergmann
14c1ffe5bd vbahelper: Use appropriate OUString functions on string constants 
Change-Id: Iabe3deccf77a79db03909b8ae6ab70322cf0ffba
 2014-12-15 10:19:57 +01:00
Caolán McNamara
131762b16d coverity#738950 Structurally dead code 
Change-Id: If481c3dfd2c7c9b13bb7fa756156693fd02b8916
 2014-12-11 11:02:06 +00:00
Noel Grandin
2979ff295c fdo#38835 strip out OUString globals 
Change-Id: I1a435214af102461e02217f7d95248dac14e5f1a
 2014-12-08 14:13:17 +02:00
Noel Grandin
705c48d32e fdo#38835 strip out OUString globals 
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.

Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
 2014-11-05 08:44:19 +02:00
Noel Grandin
229eed079c loplugin: cstylecast 
Change-Id: If991c0efe1ded6ef6d32b3a722ee87bbe36bf0bf
 2014-10-23 12:36:16 +02:00
Stephan Bergmann
ad9498f8b8 More -Werror,-Wunused-private-field 
...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
 2014-10-15 15:58:56 +02:00
Noel Grandin
8044acf2db convert SFX_CALLMODE constants to SfxCallMode enum class 
and fix a couple of bugs in SC and SW where the call mode was
being passed to the hints parameter by accident

Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58
Reviewed-on: https://gerrit.libreoffice.org/11916
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-11 15:14:52 +00:00
Noel Grandin
71540e1e47 cid#1244949 Uncaught exception 
Change-Id: Ic33d60a435ee875e8e342420046aae436739c123
 2014-10-10 10:14:17 +02:00
Caolán McNamara
8f436d3de7 use comphelper::rng::uniform_*_distribution everywhere 
and automatically seed from time on first use

coverity#1242393 Don't call rand
coverity#1242404 Don't call rand
coverity#1242410 Don't call rand and additionally allow 0xFF as a value
coverity#1242409 Don't call rand
coverity#1242399 Don't call rand
coverity#1242372 Don't call rand
coverity#1242377 Don't call rand
coverity#1242378 Don't call rand
coverity#1242379 Don't call rand
coverity#1242382 Don't call rand
coverity#1242383 Don't call rand
coverity#1242402 Don't call rand
coverity#1242397 Don't call rand
coverity#1242390 Don't call rand
coverity#1242389 Don't call rand
coverity#1242388 Don't call rand
coverity#1242386 Don't call rand
coverity#1242384 Don't call rand
coverity#1242394 Don't call rand

Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
 2014-10-06 14:13:27 +01:00
Noel Grandin
fc04f76336 fdo#82577: Handle Time 
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-01 07:34:23 +00:00
Stephan Bergmann
0b23ac2c9d vbahelper: std::auto_ptr -> std::unique_ptr 
Change-Id: Ic1b28e7f79cc7dad6a045eb64e5191991533990d
 2014-09-29 18:37:51 +02:00
Noel Grandin
827c46e7d7 fdo#82577: Handle Window 
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
 2014-09-23 14:11:39 +03:00
Stephan Bergmann
82a72bb848 VbaNewFont apparently does not inherit XHelperInterface 
...and thus should simply derive from WeakImplHelper1 instead of
InheritedHelperInterfaceImpl1?

Change-Id: I0cb023a905e93bf9c223676c964f039ac7eee7e0
 2014-09-15 10:06:16 +02:00
Takeshi Abe
ea5ef0a72e Drop unused #includes 
Change-Id: I77ca957204bacee95e32a7f2a54c9311002aeef9
 2014-07-24 01:06:15 +09:00
Caolán McNamara
c1dd91a93c callcatcher: update unused code 
Change-Id: I1dd1b40d807c7c9d9b145aca9f69a67d786ec5ff
 2014-07-22 09:54:38 +01:00
Takeshi Abe
f31a9abfd2 Remove unused #includes 
Change-Id: I96775ac9a8624e12974c78c6abb93ddd80eed567
 2014-07-22 00:13:11 +09:00
Caolán McNamara
7f55c89470 some other coverity foo 
Change-Id: Ide5a10d7f9c45970c3cc5c78213c151c85ff4570
 2014-07-18 15:36:20 +01:00
Caolán McNamara
243e9ab761 fix indent 
Change-Id: I799d7a7989209e9fab03fbc79439b64e6c689499
 2014-07-18 15:36:16 +01:00
Caolán McNamara
e0ec561059 coverity#707480 Uncaught exception 
Change-Id: I27732316c42face6750ffb7eccc238f66519e4e6
 2014-07-10 13:39:18 +01:00
Caolán McNamara
92fe8838f7 coverity#707382 Uncaught exception 
and

coverity#707383 Uncaught exception
coverity#707384 Uncaught exception
coverity#707385 Uncaught exception
coverity#707386 Uncaught exception
coverity#707387 Uncaught exception
coverity#707388 Uncaught exception
coverity#707389 Uncaught exception
coverity#707390 Uncaught exception
coverity#707391 Uncaught exception
coverity#707409 Uncaught exception
coverity#707411 Uncaught exception
coverity#707413 Uncaught exception
coverity#707414 Uncaught exception
coverity#706919 Uncaught exception
coverity#706920 Uncaught exception
coverity#706933 Uncaught exception
coverity#706935 Uncaught exception
coverity#706968 Uncaught exception
coverity#706970 Uncaught exception
coverity#706973 Uncaught exception
coverity#706974 Uncaught exception
coverity#707032 Uncaught exception
coverity#707044 Uncaught exception
coverity#738455 Uncaught exception
coverity#738456 Uncaught exception

Change-Id: Ifd4c0a2b6b4ddcb5df01a951b8d56435ee32d754
 2014-07-09 09:59:02 +01:00
Norbert Thiebaud
d92aa2f445 remove SFX_APP() macro that was a mer wrapper for SfxGetApp() 
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
 2014-06-27 17:08:04 +02:00
Julien Nabet
ac76cc7e60 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20 
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
 2014-05-23 22:11:52 +02:00
Noel Grandin
e7bc3cab01 remove boilerplate in UNO Exception constructor calls 
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
 2014-05-23 15:06:00 +02:00
Julien Nabet
a362f15f85 Typo: shoud -> should 
Change-Id: I44f4fb9682a56af6654e1f7462dc37557d60e735
 2014-05-13 23:26:20 +02:00
Noel Grandin
79cf53cb3b vbahelper: sal_Bool->bool 
Change-Id: I9fd549bd4ad8f67f83db6a864aa86d0c7310d43e
 2014-05-08 11:48:13 +02:00
Noel Grandin
17dcf76ef8 vbahelper: sal_Bool->bool 
Change-Id: Ibf21ce17a8e743701f1011e1620f26b93f952991
 2014-05-02 08:49:23 +02:00
Caolán McNamara
833067c870 coverity#707469 Uncaught exception 
Change-Id: I93bb55b339dcc6a177d7403760703a895cebc805
 2014-04-24 17:16:36 +01:00