Commit Graph

28 Commits

Author SHA1 Message Date
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13 13:19:22 +02:00
Noel Grandin
e7d3fa5804 loplugin:passstuffbyref in chart2
Change-Id: Id14015b1a02047c4d2e9d4ed4a9edfd0cb409c59
2016-04-14 09:21:41 +02:00
Noel Grandin
8353667d35 com::sun::star->css in chart2
Change-Id: I04320d32d6d5c54e461cfabef58645f8b772bc69
2016-03-14 13:43:38 +02:00
Noel Grandin
2afead78b3 tdf#69977: constructing and destructing AccessibleElementInfo...
... is surprisingly expensive
shaves about 5% off the time to build this chart

Change-Id: I8e5d071edba50d264c2ab01c6bc0b2cad0e41ec6
Reviewed-on: https://gerrit.libreoffice.org/20588
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-10 10:32:15 +00:00
Noel Grandin
2f3ea8dfbc refactor out some com::sun::star typedefs
which mostly serve to make the code harder to read

Change-Id: Ia2a83fee9f850ab6f0bea6305ce8600d6b785fe8
2015-10-21 14:17:56 +02:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Caolán McNamara
33cddeea13 boost->std
Change-Id: Iff14f69c200217c5d868978e8ffc06962b99ac09
Reviewed-on: https://gerrit.libreoffice.org/18568
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-14 19:32:42 +00:00
Takeshi Abe
5c420fcdf9 tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants, in chart2.

Change-Id: Ib145860cf757d932fd5710f92c7f9ce33904b619
2015-07-17 09:39:04 +02:00
Stephan Bergmann
da36fc8c95 No more need for PartialWeakComponentImplHelper here
...since 70626249cd "API CHANGE a11y unpublishing
and add/removeListener rename."

Change-Id: I89d81326d97712abcac94c3436a13905954c55cf
2015-04-21 22:48:02 +02:00
Noel Grandin
b44cbb26ef new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-26 08:42:28 +02:00
Michael Stahl
2f69e16c72 override the overloading of "overload" to decrease cognitive (over-)load
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-09 00:00:47 +01:00
Noel Grandin
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
Stephan Bergmann
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Thomas Arnhold
75b7ce9c66 fixincludeguards.sh: chart2
Change-Id: I166e054926fb975949b3021cbc43b25a222f6198
2013-10-23 23:22:34 +02:00
Jelle van der Waa
dd9c97d587 fdo#62475 removed pointless comments
Change-Id: I3f5e86dba2df950aeb12c895f52d99274c0959aa
Reviewed-on: https://gerrit.libreoffice.org/5148
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-07-29 11:34:33 +00:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Thorsten Behrens
70626249cd API CHANGE a11y unpublishing and add/removeListener rename.
The a11y API has never really been picked up by tools vendors, let's
not tie ourselves up here for no good reason.

This unpublishes all css::accessibility, and dependend API.

With that, we can change the rather unfortunately-named add/
removeEventListener to be add/removeAccessibleEventListener, thus
not conflicting with the XComponent methods of the same name.

Change-Id: I595598c3a8e46415f80b2780f333333174865fe4
2012-11-29 16:58:16 +01:00
Michael Meeks
63c508e3e8 re-base on ALv2 code. Includes:
118568: switch to using ucpp
    Patch contributed by Juergen Schmidt
    http://svn.apache.org/viewvc?view=revision&revision=1209396
2012-07-18 09:29:19 +01:00
Takeshi Abe
d221d4e5a7 removed unnecessary forward declarations of class
this also moved necessary ones to right headers

Change-Id: Idda93aeaa1fdfeda602b14e3b233ffd1cf27c0cf
2012-07-02 22:07:55 +09:00
Caolán McNamara
fa6a1107ed use PartialWeakComponentImplHelperX for overloaded-virtual 2011-03-28 14:13:02 +01:00
Caolán McNamara
ad3292e2b3 add modelines to .hxx files as well 2010-10-28 15:47:29 +01:00
Thomas Benisch
568a8725ae chartshapes: merge with DEV300_m72 2010-03-01 12:22:02 +01:00
Jens-Heiner Rechtien
4573ccfffd changefileheader2: #i109125#: change source file copyright notice from Sun Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision) 2010-02-12 15:01:35 +01:00
Thomas Benisch
f246eb7405 #i12587# Inserting/editing arbitrary text objects in chart 2009-07-21 14:09:00 +00:00
Rüdiger Timm
26eff306a1 INTEGRATION: CWS changefileheader (1.3.70); FILE MERGED
2008/04/01 15:04:05 thb 1.3.70.3: #i85898# Stripping all external header guards
2008/04/01 10:50:21 thb 1.3.70.2: #i85898# Stripping all external header guards
2008/03/28 16:43:43 rt 1.3.70.1: #i87441# Change license header to LPGL v3.
2008-04-10 19:29:36 +00:00
Vladimir Glazounov
41bfa2fb2c INTEGRATION: CWS chart11 (1.2.38); FILE MERGED
2007/07/31 22:19:24 bm 1.2.38.1: #i79522# warnings on Solaris removed
2007-09-18 13:55:27 +00:00
Vladimir Glazounov
5c0eae1268 INTEGRATION: CWS chart2mst3 (1.1.2); FILE ADDED
2006/02/20 15:25:58 bm 1.1.2.2: color properties
2006/02/20 09:21:31 bm 1.1.2.1: new base class for accessibility objects that does not implement XAccessibleExtendedComponent
2007-05-22 16:51:41 +00:00