Commit Graph

25 Commits

Author SHA1 Message Date
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13 13:19:22 +02:00
Szymon Kłos
1df394503f GSoC notebookbar: switching tabs depending on context
+ sfx2::sidebar::EnumContext moved to the vcl module
+ TabPage contains vector with context values
+ vcl builder reads control's contexts from the "class" mark
+ ContextTabControl shows tabs depending on context

Change-Id: I661b0d3f35d46ace2a2e8eb1d374148f0c60017d
Reviewed-on: https://gerrit.libreoffice.org/26447
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-27 17:51:56 +00:00
Noel Grandin
c5458af905 loplugin:unusedfields in chart2
Change-Id: I8203f84ad8b138932c990032e17ea5d2daf384bb
2015-12-23 09:38:46 +02:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Noel Grandin
3c99f8500f convert Link<> to typed
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb
Reviewed-on: https://gerrit.libreoffice.org/19305
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12 10:48:13 +00:00
Markus Mohrhard
d7748842e9 hide grid and axes options in chart elements if not supported, tdf#94297
Change-Id: I358340bd1b17f0e2eb5a119a60b623e489044dd3
2015-10-03 16:22:02 +02:00
Markus Mohrhard
85eb1e5148 use localized string for title text, tdf#94294
Change-Id: Id27e5c3794b728ce79d63b6c7d552df0cc1ba239
2015-09-20 21:33:58 +02:00
Markus Mohrhard
e1afea91e9 remove unnecessary base class
Change-Id: Iaa1890d11f9bfba7a8b0996b9adf79b781bcd8bf
2015-09-20 21:33:58 +02:00
Noel Grandin
167bc621ef Convert vcl Button Link<> click handler to typed Link<Button*,void>
Change-Id: Ie80dfb003118d40741549c41ebcc7eda4819f05b
2015-08-26 11:15:35 +02:00
Markus Mohrhard
8b0109f28e avoid crash when chart model is disposed
Change-Id: I70c3a06e2aa9112cd5a47b7d8839c4bd701cfc1e
2015-07-31 17:38:40 +02:00
Katarina Behrens
93d301a287 Some (mostly HIG) tweaks to chart elements panel
As I wanted to represent subsections as frames (it looks kinda
better with bold labels), I tried to emulate grid behaviour by
putting widgets into 2 size groups

Other tweaks include disabling legend position listbox when legend
is not to be shown and missing clear() of that listbox

Change-Id: I0b635fe5aba1580542cf982e2e6be02eb0056352
Reviewed-on: https://gerrit.libreoffice.org/17386
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-07-29 15:40:10 +00:00
Markus Mohrhard
0635208edf handle more than one chart with chart sidebar
Change-Id: I4998904a9273f2c67114a246d7f234843602573c
2015-07-26 00:26:55 +02:00
Markus Mohrhard
c2bd7a7de1 remove unnecessary parts in chart sidebar code
Change-Id: I5adedbb47edd39959220fa7ab3826d586734e943
2015-07-17 10:25:49 +02:00
Markus Mohrhard
0ae9523012 extract the modify listener
Change-Id: Ie191e47b009afc5e3d4655d9b83189540e280dca
2015-07-16 22:19:53 +02:00
Stephan Bergmann
9edaebe651 Remove unused modelInvalid
Change-Id: I18701b367dcca36afb8e6f28645453294881683f
2015-07-16 10:52:54 +02:00
Markus Mohrhard
b1663b86ae handle legend position combobox correctly
Change-Id: Ic19e8cd20d739761975db2b00cb92fd27f8ac4be
2015-07-16 08:15:20 +02:00
Markus Mohrhard
4be80459e5 adapt to UX discussion
Change-Id: I6a7ba1f13cddf20b2751f2ee113427db43978cfa
2015-07-16 08:15:20 +02:00
Markus Mohrhard
a40526eb95 adapt code to last round of discussions
Change-Id: Id0d2bae2a232f80ebe46cb55602c15c57b074e87
2015-07-16 08:15:20 +02:00
Markus Mohrhard
c296eec292 react to changing the checkboxes: axis
Change-Id: Ic1296b9035dce00837b8e8d24cc63e1d9bda0b88
2015-07-16 08:15:18 +02:00
Markus Mohrhard
c03d781e35 sidebar needs to listen to chart modifications
Change-Id: I3dd0ae1c1c7fe14ee08571e96b1804d5d9972e2c
2015-07-16 08:15:18 +02:00
Markus Mohrhard
20f0c633c9 remove unused member variables
Change-Id: I2db9b587eea0569df5225171244cee545d6155df
2015-07-16 08:15:18 +02:00
Markus Mohrhard
6dbb9564f9 wire title and legend checkboxes
Change-Id: I4c6d5e213f44588cf2d53d9c12ed8033307fd863
2015-07-16 08:15:17 +02:00
Markus Mohrhard
1d0696a349 we need access to the chart model in the chart sidebar
Change-Id: I607b5ada047f84cd7a229640772a332702f93f1e
2015-07-16 08:15:17 +02:00
Stephan Bergmann
5b16fff9ac loplugin:staticmethods
Change-Id: I8b57b7ce707438ad3c7c901b03c94d9045585ed8
2015-07-13 09:21:51 +02:00
Markus Mohrhard
5d5667062c add ChartElements panel
Change-Id: I935a0d637a9ea3a1716d6e839e65c4e565a2c840
2015-07-12 18:56:49 +02:00