mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
397,580 Commits 1 Branch 0 Tags
36efdec23b86fe28c79fe672bb6862fb57b6e09a
Commit Graph

95 Commits

Author SHA1 Message Date
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Noel Grandin
6e72f0251b new loplugin unnecessary override 
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb
Reviewed-on: https://gerrit.libreoffice.org/27135
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-07-15 14:05:41 +00:00
Noel Grandin
9fce680e27 loplugin:passstuffbyref in dbaccess 
Change-Id: Ice52ebbfeca45c8587fdcd0d3dea5c02c7de27e3
 2016-04-13 13:27:51 +02:00
Julien Nabet
2b60e64c18 Use const_iterator when possible (whole dbaccess) 
Change-Id: I3d10a7914353b384fc7a2195a70398869f675211
Reviewed-on: https://gerrit.libreoffice.org/23570
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2016-03-28 18:39:16 +00:00
Noel Grandin
f7c23897a3 loplugin:unusedmethods unused return value in dbaccess 
Change-Id: Ia7ec0209a635f8482b6ccbaa7ba48a8c6da79090
 2016-01-11 10:49:24 +02:00
Stephan Bergmann
89c4edc13f loplugin:nullptr (automatic rewrite) 
Change-Id: I2bba104b1bff30910864e45b5b032533099742ff
 2015-11-10 10:31:22 +01:00
Stephan Bergmann
578f267a38 loplugin:defaultparams 
Change-Id: I83d411adf8ef882618bd48ab73602f7cf1531078
 2015-10-19 17:49:41 +02:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Noel Grandin
3c99f8500f convert Link<> to typed 
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb
Reviewed-on: https://gerrit.libreoffice.org/19305
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-12 10:48:13 +00:00
Daniel Robertson
899c21ce5d dbaccess: replace for_each with range-based for 
Replace complex uses of ::std::for_each with a range-based for-loop.

Change-Id: I82331f16cc1994dd9ef36eb80d67b64171cecc74
Reviewed-on: https://gerrit.libreoffice.org/18355
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-09-07 07:18:33 +00:00
Noel Grandin
bd8b93fdff make PostUserEvent Link<> typed 
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
 2015-08-28 09:49:56 +02:00
Caolán McNamara
75938aff38 cppcheck: noExplicitConstructor 
Change-Id: I45f2d96c7bd558405d0b5dfea3beb97ad720a82b
 2015-07-20 14:26:54 +01:00
Andrea Gelmini
799cc41b53 Fix typos 
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0
Reviewed-on: https://gerrit.libreoffice.org/16834
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2015-07-08 05:48:18 +00:00
Andrea Gelmini
87dc6c82d5 Fix typos 
Change-Id: Ideb5688a8c9e7cf10038f2e9d00991e8653b1875
Reviewed-on: https://gerrit.libreoffice.org/16706
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2015-07-03 09:02:48 +00:00
Michael Meeks
e4097762dd Audit all PostUserEvent calls and instrument for VclPtr. 
Hold a reference on the VclPtr while we're waiting for the UserEvent.

Change-Id: I55c2671ca12eb14761c6a7dffd551af71547ecbd
 2015-05-25 21:38:08 +01:00
Michael Meeks
266ce1cd53 tdf#91052 - more macros for 'make' constructors. 
Change-Id: Id05266810760f73db2daba10d1efa14aa9f88dd9
 2015-05-09 21:39:57 +01:00
Stephan Bergmann
3ead3ad52f Gradually typed Link 
Turn the Link class into a template abstracting over the link's argument and
return types, but provide default template arguments that keep the generic,
unsafe "void* in, sal_IntPtr out" behvior.  That way, individual uses of the
Link class can be updated over time.

All the related macros are duplicated with ..._TYPED counterparts, that
additionally take the RetType (except for LINK_TYPED, which manages to infer the
relevant types from the supplied Member).

(It would have been attractive to change the "untyped" LinkStubs from taking a
void* to a properly typed ArgType parameter, too, but that would cause
-fsanitize=function to flag uses of "untyped" Link::Call.)

Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
 2015-04-30 10:20:00 +02:00
Michael Meeks
e8b97a52c9 Merge remote-tracking branch 'origin/feature/vclptr' 
Resolve several thousand lines of conflicts.

Conflicts:
	accessibility/source/extended/accessiblelistbox.cxx
	accessibility/source/standard/vclxaccessiblecombobox.cxx
	accessibility/source/standard/vclxaccessibledropdowncombobox.cxx
	accessibility/source/standard/vclxaccessibledropdownlistbox.cxx
	accessibility/source/standard/vclxaccessiblelistbox.cxx
	accessibility/source/standard/vclxaccessibletextfield.cxx
	basctl/source/basicide/basidesh.cxx
	cui/source/inc/chardlg.hxx
	cui/source/tabpages/tpbitmap.cxx
	dbaccess/source/ui/dlg/UserAdmin.cxx
	dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
	extensions/source/propctrlr/propertyeditor.hxx
	extensions/source/scanner/sanedlg.cxx
	filter/source/pdf/impdialog.cxx
	include/sfx2/mgetempl.hxx
	include/sfx2/sidebar/SidebarToolBox.hxx
	include/sfx2/viewsh.hxx
	include/svtools/brwbox.hxx
	include/svtools/filectrl.hxx
	include/svtools/scrwin.hxx
	include/svx/dlgctrl.hxx
	include/svx/sidebar/Popup.hxx
	include/svx/sidebar/PopupContainer.hxx
	include/svx/sidebar/PopupControl.hxx
	include/svx/sidebar/SidebarDialControl.hxx
	include/svx/sidebar/ValueSetWithTextControl.hxx
	sc/source/ui/condformat/condformatdlgentry.cxx
	sc/source/ui/navipi/navipi.cxx
	sc/source/ui/sidebar/CellBorderStyleControl.hxx
	sd/source/ui/animations/CustomAnimationDialog.cxx
	sd/source/ui/inc/DrawViewShell.hxx
	sd/source/ui/inc/Ruler.hxx
	sd/source/ui/inc/SlideSorter.hxx
	sd/source/ui/inc/ViewTabBar.hxx
	sd/source/ui/inc/Window.hxx
	sd/source/ui/inc/morphdlg.hxx
	sd/source/ui/inc/sdpreslt.hxx
	sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
	sd/source/ui/sidebar/LayoutMenu.hxx
	sd/source/ui/sidebar/MasterPagesSelector.hxx
	sd/source/ui/sidebar/NavigatorWrapper.hxx
	sd/source/ui/sidebar/PanelBase.hxx
	sd/source/ui/sidebar/RecentMasterPagesSelector.cxx
	sd/source/ui/sidebar/RecentMasterPagesSelector.hxx
	sd/source/ui/slideshow/showwindow.hxx
	sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx
	sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
	sd/source/ui/view/ViewShellBase.cxx
	sd/source/ui/view/drviewsa.cxx
	sfx2/source/appl/fileobj.hxx
	sfx2/source/appl/opengrf.cxx
	sfx2/source/control/thumbnailviewacc.hxx
	sfx2/source/dialog/securitypage.cxx
	sfx2/source/dialog/templdlg.cxx
	sfx2/source/doc/docinsert.cxx
	sfx2/source/doc/guisaveas.cxx
	sfx2/source/inc/alienwarn.hxx
	sfx2/source/sidebar/Deck.cxx
	sfx2/source/sidebar/Deck.hxx
	sfx2/source/sidebar/DeckTitleBar.cxx
	sfx2/source/sidebar/DeckTitleBar.hxx
	sfx2/source/sidebar/MenuButton.cxx
	sfx2/source/sidebar/MenuButton.hxx
	sfx2/source/sidebar/Panel.cxx
	sfx2/source/sidebar/Panel.hxx
	sfx2/source/sidebar/PanelTitleBar.hxx
	sfx2/source/sidebar/SidebarDockingWindow.hxx
	sfx2/source/sidebar/SidebarToolBox.cxx
	sfx2/source/sidebar/TabBar.hxx
	sfx2/source/sidebar/TabItem.cxx
	sfx2/source/sidebar/TabItem.hxx
	sfx2/source/sidebar/TitleBar.hxx
	sfx2/source/toolbox/imgmgr.cxx
	starmath/inc/edit.hxx
	starmath/inc/smmod.hxx
	starmath/qa/cppunit/test_starmath.cxx
	starmath/source/edit.cxx
	starmath/source/smmod.cxx
	svtools/source/brwbox/brwbox1.cxx
	svtools/source/brwbox/datwin.hxx
	svtools/source/contnr/fileview.cxx
	svtools/source/contnr/simptabl.cxx
	svtools/source/control/filectrl.cxx
	svtools/source/control/valueimp.hxx
	svx/inc/GalleryControl.hxx
	svx/source/dialog/dlgctrl.cxx
	svx/source/dialog/swframeexample.cxx
	svx/source/fmcomp/fmgridif.cxx
	svx/source/gallery2/GalleryControl.cxx
	svx/source/sidebar/EmptyPanel.hxx
	svx/source/sidebar/area/AreaPropertyPanel.hxx
	svx/source/sidebar/area/AreaTransparencyGradientControl.hxx
	svx/source/sidebar/graphic/GraphicPropertyPanel.hxx
	svx/source/sidebar/insert/InsertPropertyPanel.cxx
	svx/source/sidebar/insert/InsertPropertyPanel.hxx
	svx/source/sidebar/line/LinePropertyPanel.hxx
	svx/source/sidebar/line/LineWidthControl.cxx
	svx/source/sidebar/line/LineWidthControl.hxx
	svx/source/sidebar/line/LineWidthValueSet.hxx
	svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
	svx/source/sidebar/possize/SidebarDialControl.cxx
	svx/source/sidebar/text/TextCharacterSpacingPopup.hxx
	svx/source/sidebar/text/TextPropertyPanel.hxx
	svx/source/sidebar/tools/PopupContainer.cxx
	svx/source/sidebar/tools/PopupControl.cxx
	svx/source/sidebar/tools/ValueSetWithTextControl.cxx
	svx/source/svdraw/svdfmtf.hxx
	svx/source/svdraw/svdibrow.cxx
	svx/source/tbxctrls/colrctrl.cxx
	svx/source/tbxctrls/tbcontrl.cxx
	sw/source/ui/dbui/mmaddressblockpage.cxx
	sw/source/ui/dialog/uiregionsw.cxx
	sw/source/ui/index/cnttab.cxx
	sw/source/uibase/inc/drpcps.hxx
	sw/source/uibase/sidebar/PageColumnControl.hxx
	sw/source/uibase/sidebar/PageMarginControl.hxx
	sw/source/uibase/sidebar/PageOrientationControl.hxx
	sw/source/uibase/sidebar/PagePropertyPanel.hxx
	sw/source/uibase/sidebar/PageSizeControl.hxx
	sw/source/uibase/uiview/view2.cxx
	sw/source/uibase/utlui/navipi.cxx
	vcl/inc/svdata.hxx
	vcl/source/control/combobox.cxx
	vcl/source/control/lstbox.cxx
	vcl/source/window/dockwin.cxx
	vcl/source/window/winproc.cxx

Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
 2015-04-28 15:08:48 +01:00
Noel Grandin
ed54799117 convert EBBF_ constants to scoped enum 
Change-Id: I6f281001a96ebfbca20f3e8dd3423945e119eef0
 2015-04-22 10:28:39 +02:00
Noel Grandin
0578aa4de2 convert BROWSER_ constants to scoped enum 
and fix a couple of places where it was mixing these flags up with the
WinBits flags and calling the wrong constructor.

Change-Id: I65c66bdd5a263e2f1db179c853f3f00e9ac7659e
 2015-04-22 10:28:39 +02:00
Michael Meeks
f12488405c dbaccess: convert new to ::Create. 
Also convert svtools' WizardShell::createPage.

Change-Id: I09bd40ef4748aa2de7b49eeefc95be06b545ea05
 2015-04-20 15:13:23 +01:00
Noel Grandin
c72fac2696 vclwidget: convert lots more sites to use VclPtr 
seems there was a lot of shared_ptr usage floating around...

Change-Id: Icd05243170eb8493709275fc36bf986fc194b781
 2015-04-10 11:20:46 +01:00
Noel Grandin
97eacd1d55 vcl: VclPtr conversion in dbaccess 
Change-Id: I85fce0403121ffe55204d78445e4809960ec404a
 2015-04-09 21:34:32 +01:00
Stephan Bergmann
3b3c52ae87 const_cast: convert some C-style casts and remove some redundant ones 
Change-Id: I2b69af91ad6dac306f626bdd5a434c75be574617
 2015-03-26 15:33:29 +01:00
Noel Grandin
b44cbb26ef new loplugin: change virtual methods to non-virtual 
Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
 2015-01-26 08:42:28 +02:00
Tobias Madl
14596452e7 fdo#84938: replace EVENT_ constants with enum 
Change-Id: I8275832d8dae43b374bddd48520d11592e9a6a1f
Reviewed-on: https://gerrit.libreoffice.org/13134
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2014-12-01 07:43:31 +00:00
David Tardon
3e6f70a39c I think this should be Left() 
Change-Id: Ifd83a4a28414ffa5d8cc3cec3def4361737a333e
 2014-11-03 18:48:36 +01:00
David Tardon
074cbe02ee coverity#1242510 arguments in wrong order 
Change-Id: I898f3e383f5ff3451860e49b0ea00111ed1b52c2
 2014-11-03 18:48:36 +01:00
Noel Grandin
8dbde0845a fdo#82577: Handle Region 
Put the VCL Region class in the vcl namespace. Avoids clash with the X11
Region typedef.

Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
 2014-09-30 09:58:23 +02:00
Stephan Bergmann
d54a72a408 dbaccess: std::auto_ptr -> std::unique_ptr 
Change-Id: I2b27aaf589fcbe4da1680f624a57be7ae62b0dc5
 2014-09-25 08:40:12 +02:00
Noel Grandin
827c46e7d7 fdo#82577: Handle Window 
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
 2014-09-23 14:11:39 +03:00
Noel Grandin
e2080e70fe new compilerplugin returnbyref 
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
 2014-06-24 11:34:21 +02:00
Thomas Arnhold
40064f479b clean up hrc files 
and remove some unused stuff

Change-Id: Iea6177c3d2f9d0668187e66155b62688ae2ecb04
 2014-04-22 13:03:17 +02:00
Noel Grandin
fee4efcb54 dbaccess: sal_Bool->bool 
Change-Id: Ieb52470f9638b74898954db3890aaf2cf202290a
 2014-04-17 11:17:21 +02:00
Stephan Bergmann
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
 2014-03-27 18:12:18 +01:00
Noel Grandin
f661ac03e0 svtools: sal_Bool->bool 
Change-Id: I22d8869551f46d2a0607f670f937853f394b6acf
 2014-03-24 08:12:09 +02:00
Noel Grandin
1a1fe47731 svtools: sal_Bool->bool 
Change-Id: I0c2e9314d85860831b29db76c89c8776c1b071b9
 2014-03-24 08:12:08 +02:00
Caolán McNamara
07579ec100 convert query join dialog to .ui format 
Change-Id: I1de2bb1d171e23a42834e20040ade92822901876
 2014-03-13 16:24:15 +00:00
Caolán McNamara
649bb48e2a coverity#738613 Uninitialized scalar field 
Change-Id: If6166e4b22afcc0afc5f552652ab76f5e21c52de
 2014-02-21 12:40:30 +00:00
Arnaud Versini
5b2ba8ed5d DBACCESS : Remove usage of DBG_CTOR and DBG_DTOR. 
Valgrind is capable of detecting such bugs. No need for extra macros.

Conflicts:
	dbaccess/source/ui/dlg/tablespage.cxx

Change-Id: I25ea9174a042050efdb371246417ee7f2edae997
Reviewed-on: https://gerrit.libreoffice.org/7532
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-01-21 16:20:10 +00:00
Stephan Bergmann
602c87b425 Window::PreNotify should return bool 
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
 2014-01-18 00:37:49 +01:00
Noel Grandin
d11ed5a57e convert dbaccess module from String to OUString 
Change-Id: I110c925f8d955dfd841cdd1092c13df4d8205393
 2013-10-01 10:08:43 +02:00
Jelle van der Waa
2ec606730b fdo#62475 removed pointless comments 
Conflicts:
	dbaccess/source/filter/xml/xmlfilter.cxx
	dbaccess/source/ui/dlg/ConnectionPage.cxx
	dbaccess/source/ui/dlg/detailpages.cxx
	dbaccess/source/ui/dlg/odbcconfig.cxx
	dbaccess/source/ui/querydesign/querycontroller.cxx

Change-Id: I3a05649efa3a43dd8d8fb069fc1bce14ca0a6338
Reviewed-on: https://gerrit.libreoffice.org/5484
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
 2013-08-27 16:11:09 +00:00
Caolán McNamara
cf6a74af53 XubString->OUString 
Change-Id: I1049249741f445ad7bd9c070f99812c4404597c9
 2013-07-11 14:31:44 +01:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String* 
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
 2013-04-07 14:23:11 +02:00
Michael Stahl
38d3e115c1 vcl: make Region ctors explicit to prevent overloading desasters 
Change-Id: Id36d125b4940418833bec31a4710d6cd545629e0
 2013-03-13 22:29:46 +01:00
Lionel Elie Mamane
058deb4a4c fdo#32958 join editor: remove empty lines 
Change-Id: If150261bae55cf91c8a344f34c79194ad29db903
 2012-12-12 16:37:26 +01:00
Lionel Elie Mamane
9503a458f9 query design / edit join: valid only iif column names everywhere 
Change-Id: Idfb0e16c4cc2581a46e26fe97948897dc4b11dc0
 2012-12-12 16:37:23 +01:00
Lionel Elie Mamane
84bcb75ee0 be more cautious in debug mode 
Change-Id: I46b89b10287ac755e2b727b46d6fdd19f44bcdd3
 2012-12-12 16:37:21 +01:00
Stephan Bergmann
4a69252e2c -Werror,-Wunused-private-field (Clang towards 3.2) 
Change-Id: I55ad905bef36b54fadc245bfb22f687e47d20c3a
 2012-08-31 09:04:17 +02:00